configure | 8 + default-configs/rx-softmmu.mak | 3 + qapi/common.json | 3 +- include/disas/dis-asm.h | 5 + include/exec/poison.h | 1 + include/hw/char/renesas_sci.h | 45 + include/hw/intc/rx_icu.h | 56 + include/hw/registerfields.h | 32 +- include/hw/rx/rx.h | 7 + include/hw/rx/rx62n.h | 91 ++ include/hw/timer/renesas_cmt.h | 38 + include/hw/timer/renesas_tmr.h | 53 + include/qemu/bitops.h | 38 + include/sysemu/arch_init.h | 1 + target/rx/cpu-param.h | 31 + target/rx/cpu-qom.h | 42 + target/rx/cpu.h | 182 +++ target/rx/helper.h | 31 + arch_init.c | 2 + hw/char/renesas_sci.c | 340 +++++ hw/intc/rx_icu.c | 376 +++++ hw/rx/rx-virt.c | 135 ++ hw/rx/rx62n.c | 246 ++++ hw/timer/renesas_cmt.c | 275 ++++ hw/timer/renesas_tmr.c | 455 ++++++ target/rx/cpu.c | 217 +++ target/rx/disas.c | 1446 +++++++++++++++++++ target/rx/gdbstub.c | 112 ++ target/rx/helper.c | 148 ++ target/rx/op_helper.c | 470 ++++++ target/rx/translate.c | 2432 ++++++++++++++++++++++++++++++++ tests/machine-none-test.c | 1 + MAINTAINERS | 19 + hw/Kconfig | 1 + hw/char/Kconfig | 3 + hw/char/Makefile.objs | 1 + hw/intc/Kconfig | 3 + hw/intc/Makefile.objs | 1 + hw/rx/Kconfig | 14 + hw/rx/Makefile.objs | 2 + hw/timer/Kconfig | 6 + hw/timer/Makefile.objs | 3 + target/rx/Makefile.objs | 11 + target/rx/insns.decode | 621 ++++++++ tests/acceptance/boot_linux_console.py | 46 + 45 files changed, 8051 insertions(+), 2 deletions(-) create mode 100644 default-configs/rx-softmmu.mak create mode 100644 include/hw/char/renesas_sci.h create mode 100644 include/hw/intc/rx_icu.h create mode 100644 include/hw/rx/rx.h create mode 100644 include/hw/rx/rx62n.h create mode 100644 include/hw/timer/renesas_cmt.h create mode 100644 include/hw/timer/renesas_tmr.h create mode 100644 target/rx/cpu-param.h create mode 100644 target/rx/cpu-qom.h create mode 100644 target/rx/cpu.h create mode 100644 target/rx/helper.h create mode 100644 hw/char/renesas_sci.c create mode 100644 hw/intc/rx_icu.c create mode 100644 hw/rx/rx-virt.c create mode 100644 hw/rx/rx62n.c create mode 100644 hw/timer/renesas_cmt.c create mode 100644 hw/timer/renesas_tmr.c create mode 100644 target/rx/cpu.c create mode 100644 target/rx/disas.c create mode 100644 target/rx/gdbstub.c create mode 100644 target/rx/helper.c create mode 100644 target/rx/op_helper.c create mode 100644 target/rx/translate.c create mode 100644 hw/rx/Kconfig create mode 100644 hw/rx/Makefile.objs create mode 100644 target/rx/Makefile.objs create mode 100644 target/rx/insns.decode
Hello. This patch series is added Renesas RX target emulation. Changes for v21. rebase latest master. Remove unneeded hmp_info_tlb. Chanegs for v20. Reorderd patches. Squashed v19 changes. Changes for v19. Follow tcg changes. Cleanup cpu.c. simplify rx_cpu_class_by_name and rx_load_image move to rx-virt. My git repository is bellow. git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20190618 Testing binaries bellow. u-boot Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz starting $ gzip -d u-boot.bin.gz $ qemu-system-rx -bios u-boot.bin linux and pico-root (only sash) Download - https://osdn.net/users/ysato/pf/qemu/dl/zImage (kernel) https://osdn.net/users/ysato/pf/qemu/dl/rx-qemu.dtb (DeviceTree) starting $ qemu-system-rx -kernel zImage -dtb rx-qemu.dtb -append "earlycon" Philippe Mathieu-Daudé (3): hw/registerfields.h: Add 8bit and 16bit register macros hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core BootLinuxConsoleTest: Test the RX-Virt machine Richard Henderson (7): target/rx: Disassemble rx_index_addr into a string target/rx: Replace operand with prt_ldmi in disassembler target/rx: Use prt_ldmi for XCHG_mr disassembly target/rx: Emit all disassembly in one prt() target/rx: Collect all bytes during disassembly target/rx: Dump bytes for each insn during disassembly hw/rx: Honor -accel qtest Yoshinori Sato (12): MAINTAINERS: Add RX qemu/bitops.h: Add extract8 and extract16 target/rx: TCG translation target/rx: TCG helper target/rx: CPU definition target/rx: RX disassembler hw/intc: RX62N interrupt controller (ICUa) hw/timer: RX62N internal timer modules hw/char: RX62N serial communication interface (SCI) hw/rx: RX Target hardware definition Add rx-softmmu target/rx: remove unused functions. configure | 8 + default-configs/rx-softmmu.mak | 3 + qapi/common.json | 3 +- include/disas/dis-asm.h | 5 + include/exec/poison.h | 1 + include/hw/char/renesas_sci.h | 45 + include/hw/intc/rx_icu.h | 56 + include/hw/registerfields.h | 32 +- include/hw/rx/rx.h | 7 + include/hw/rx/rx62n.h | 91 ++ include/hw/timer/renesas_cmt.h | 38 + include/hw/timer/renesas_tmr.h | 53 + include/qemu/bitops.h | 38 + include/sysemu/arch_init.h | 1 + target/rx/cpu-param.h | 31 + target/rx/cpu-qom.h | 42 + target/rx/cpu.h | 182 +++ target/rx/helper.h | 31 + arch_init.c | 2 + hw/char/renesas_sci.c | 340 +++++ hw/intc/rx_icu.c | 376 +++++ hw/rx/rx-virt.c | 135 ++ hw/rx/rx62n.c | 246 ++++ hw/timer/renesas_cmt.c | 275 ++++ hw/timer/renesas_tmr.c | 455 ++++++ target/rx/cpu.c | 217 +++ target/rx/disas.c | 1446 +++++++++++++++++++ target/rx/gdbstub.c | 112 ++ target/rx/helper.c | 148 ++ target/rx/op_helper.c | 470 ++++++ target/rx/translate.c | 2432 ++++++++++++++++++++++++++++++++ tests/machine-none-test.c | 1 + MAINTAINERS | 19 + hw/Kconfig | 1 + hw/char/Kconfig | 3 + hw/char/Makefile.objs | 1 + hw/intc/Kconfig | 3 + hw/intc/Makefile.objs | 1 + hw/rx/Kconfig | 14 + hw/rx/Makefile.objs | 2 + hw/timer/Kconfig | 6 + hw/timer/Makefile.objs | 3 + target/rx/Makefile.objs | 11 + target/rx/insns.decode | 621 ++++++++ tests/acceptance/boot_linux_console.py | 46 + 45 files changed, 8051 insertions(+), 2 deletions(-) create mode 100644 default-configs/rx-softmmu.mak create mode 100644 include/hw/char/renesas_sci.h create mode 100644 include/hw/intc/rx_icu.h create mode 100644 include/hw/rx/rx.h create mode 100644 include/hw/rx/rx62n.h create mode 100644 include/hw/timer/renesas_cmt.h create mode 100644 include/hw/timer/renesas_tmr.h create mode 100644 target/rx/cpu-param.h create mode 100644 target/rx/cpu-qom.h create mode 100644 target/rx/cpu.h create mode 100644 target/rx/helper.h create mode 100644 hw/char/renesas_sci.c create mode 100644 hw/intc/rx_icu.c create mode 100644 hw/rx/rx-virt.c create mode 100644 hw/rx/rx62n.c create mode 100644 hw/timer/renesas_cmt.c create mode 100644 hw/timer/renesas_tmr.c create mode 100644 target/rx/cpu.c create mode 100644 target/rx/disas.c create mode 100644 target/rx/gdbstub.c create mode 100644 target/rx/helper.c create mode 100644 target/rx/op_helper.c create mode 100644 target/rx/translate.c create mode 100644 hw/rx/Kconfig create mode 100644 hw/rx/Makefile.objs create mode 100644 target/rx/Makefile.objs create mode 100644 target/rx/insns.decode -- 2.11.0
Patchew URL: https://patchew.org/QEMU/20190705083141.106254-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support Message-id: 20190705083141.106254-1-ysato@users.sourceforge.jp === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 5c31c30 target/rx: remove unused functions. 308fe3f BootLinuxConsoleTest: Test the RX-Virt machine aad3fbb Add rx-softmmu 75e7452 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core fbdf7ad hw/rx: Honor -accel qtest 6332318 hw/rx: RX Target hardware definition 4fb12bc hw/char: RX62N serial communication interface (SCI) ff11a0d hw/timer: RX62N internal timer modules b40f5b0 hw/intc: RX62N interrupt controller (ICUa) d89af76 target/rx: Dump bytes for each insn during disassembly 1986f48 target/rx: Collect all bytes during disassembly 1c5a800 target/rx: Emit all disassembly in one prt() 5ee3296 target/rx: Use prt_ldmi for XCHG_mr disassembly 2970dd5 target/rx: Replace operand with prt_ldmi in disassembler f685d62 target/rx: Disassemble rx_index_addr into a string 14f4a89 target/rx: RX disassembler 48090c8 target/rx: CPU definition ab6ad65 target/rx: TCG helper a8ffda1 target/rx: TCG translation 4f57e38 hw/registerfields.h: Add 8bit and 16bit register macros ad6d108 qemu/bitops.h: Add extract8 and extract16 da0b865 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit da0b865da945 (MAINTAINERS: Add RX) 2/22 Checking commit ad6d1082803e (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 4f57e3834e2d (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit a8ffda140514 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit ab6ad652a680 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 48090c8d253d (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 622 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 14f4a8973e07 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit f685d6247c8f (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 2970dd537949 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 5ee3296eff91 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 1c5a80035379 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 1986f486e83a (target/rx: Collect all bytes during disassembly) 13/22 Checking commit d89af7691926 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit b40f5b0cbd9a (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit ff11a0d1ac3e (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 4fb12bc99962 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 6332318fd7d5 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 479 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit fbdf7ad2b118 (hw/rx: Honor -accel qtest) 19/22 Checking commit 75e74524c726 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit aad3fbbe2c3e (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit 308fe3f8510b (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 5c31c30565ff (target/rx: remove unused functions.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: deleted file mode 100644 total: 0 errors, 1 warnings, 5 lines checked Patch 22/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190705083141.106254-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190705083141.106254-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support Message-id: 20190705083141.106254-1-ysato@users.sourceforge.jp === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu 57dfc2c..c35d17c master -> master Switched to a new branch 'test' 7dc94c9 target/rx: remove unused functions. a1dcbc2 BootLinuxConsoleTest: Test the RX-Virt machine c9b115b Add rx-softmmu 29d1e47 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 37d323b hw/rx: Honor -accel qtest 2e9f24e hw/rx: RX Target hardware definition c69c355 hw/char: RX62N serial communication interface (SCI) e1086fe hw/timer: RX62N internal timer modules d8646fd hw/intc: RX62N interrupt controller (ICUa) e858f68 target/rx: Dump bytes for each insn during disassembly 3a608c5 target/rx: Collect all bytes during disassembly 77d00da target/rx: Emit all disassembly in one prt() 101ed53 target/rx: Use prt_ldmi for XCHG_mr disassembly 6740c34 target/rx: Replace operand with prt_ldmi in disassembler 21b7801 target/rx: Disassemble rx_index_addr into a string c398a2a target/rx: RX disassembler e6c645d target/rx: CPU definition fa682af target/rx: TCG helper 7d10a82 target/rx: TCG translation 9fd4faa hw/registerfields.h: Add 8bit and 16bit register macros c77a02f qemu/bitops.h: Add extract8 and extract16 915fcf5 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 915fcf5daaad (MAINTAINERS: Add RX) 2/22 Checking commit c77a02f0d111 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 9fd4faa3b6a2 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 7d10a824502b (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit fa682afe030b (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit e6c645d92353 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 622 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit c398a2afb28c (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 21b7801324f8 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 6740c34a87e3 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 101ed537cf26 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 77d00da68ec6 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 3a608c5b0661 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit e858f6823e1e (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit d8646fde162d (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit e1086fe9b69d (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit c69c355e0e1d (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 2e9f24e0f82b (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 479 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 37d323b91eef (hw/rx: Honor -accel qtest) 19/22 Checking commit 29d1e47b7769 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit c9b115bd4c24 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit a1dcbc2f2c44 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 7dc94c9438c2 (target/rx: remove unused functions.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: deleted file mode 100644 total: 0 errors, 1 warnings, 5 lines checked Patch 22/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190705083141.106254-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190705083141.106254-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support Message-id: 20190705083141.106254-1-ysato@users.sourceforge.jp === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 7b6c672 target/rx: remove unused functions. f631f26 BootLinuxConsoleTest: Test the RX-Virt machine ae956c0 Add rx-softmmu f32fa6f hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 2e4b3a7 hw/rx: Honor -accel qtest 33132af hw/rx: RX Target hardware definition 037b5f7 hw/char: RX62N serial communication interface (SCI) af608ff hw/timer: RX62N internal timer modules 61c2a93 hw/intc: RX62N interrupt controller (ICUa) 17dfb71 target/rx: Dump bytes for each insn during disassembly 464b24d target/rx: Collect all bytes during disassembly b60817a target/rx: Emit all disassembly in one prt() a6852a9 target/rx: Use prt_ldmi for XCHG_mr disassembly 85bd9b8 target/rx: Replace operand with prt_ldmi in disassembler 1e8f6a8 target/rx: Disassemble rx_index_addr into a string 7cc9c8a target/rx: RX disassembler 4601333 target/rx: CPU definition 288586d target/rx: TCG helper f6e6413 target/rx: TCG translation ca8f38f hw/registerfields.h: Add 8bit and 16bit register macros 2b91785 qemu/bitops.h: Add extract8 and extract16 de03b2e MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit de03b2eadbbb (MAINTAINERS: Add RX) 2/22 Checking commit 2b9178589b66 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit ca8f38f84b15 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit f6e6413f5d9c (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 288586d1dedb (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 46013335befe (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 622 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 7cc9c8a1242f (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 1e8f6a89b733 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 85bd9b87bdcf (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit a6852a9b457d (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit b60817aca52a (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 464b24d782c6 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit 17dfb715770c (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit 61c2a933c0d2 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit af608ff329e7 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 037b5f7c0476 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 33132afa04d0 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 479 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 2e4b3a7c42c3 (hw/rx: Honor -accel qtest) 19/22 Checking commit f32fa6fe3667 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit ae956c0ae588 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit f631f2648e7a (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 7b6c672a33ee (target/rx: remove unused functions.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: deleted file mode 100644 total: 0 errors, 1 warnings, 5 lines checked Patch 22/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190705083141.106254-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190705083141.106254-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support Message-id: 20190705083141.106254-1-ysato@users.sourceforge.jp === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20190705083141.106254-1-ysato@users.sourceforge.jp -> patchew/20190705083141.106254-1-ysato@users.sourceforge.jp Switched to a new branch 'test' 768db26 target/rx: remove unused functions. ed8a99e BootLinuxConsoleTest: Test the RX-Virt machine ce60411 Add rx-softmmu c5fdb33 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 42ed9fc hw/rx: Honor -accel qtest 0af198e hw/rx: RX Target hardware definition 9dba70d hw/char: RX62N serial communication interface (SCI) bb02bef hw/timer: RX62N internal timer modules 84a988c hw/intc: RX62N interrupt controller (ICUa) 214861a target/rx: Dump bytes for each insn during disassembly bc5426a target/rx: Collect all bytes during disassembly be621d1 target/rx: Emit all disassembly in one prt() c033e57 target/rx: Use prt_ldmi for XCHG_mr disassembly 8c061e4 target/rx: Replace operand with prt_ldmi in disassembler 5fd1d69 target/rx: Disassemble rx_index_addr into a string 4b360ac target/rx: RX disassembler 5900729 target/rx: CPU definition a2a8f4d target/rx: TCG helper 4bafc3d target/rx: TCG translation cba7819 hw/registerfields.h: Add 8bit and 16bit register macros 9a9de6e qemu/bitops.h: Add extract8 and extract16 8ca7f4f MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 8ca7f4ffdd07 (MAINTAINERS: Add RX) 2/22 Checking commit 9a9de6ed241d (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit cba7819b1f0a (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 4bafc3dd09d7 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit a2a8f4dcb738 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 5900729079cb (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 622 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 4b360ac5c2a1 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 5fd1d69a85e3 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 8c061e412fe5 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit c033e579b386 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit be621d169e8f (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit bc5426af2c01 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit 214861ad93dd (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit 84a988cacd5a (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit bb02bef98a66 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 9dba70d97cc3 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 0af198e5a81a (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 479 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 42ed9fca92ce (hw/rx: Honor -accel qtest) 19/22 Checking commit c5fdb334b58d (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit ce6041163bda (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit ed8a99eab0f7 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 768db267f825 (target/rx: remove unused functions.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: deleted file mode 100644 total: 0 errors, 1 warnings, 5 lines checked Patch 22/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190705083141.106254-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190705083141.106254-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support Message-id: 20190705083141.106254-1-ysato@users.sourceforge.jp === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20190705083141.106254-1-ysato@users.sourceforge.jp -> patchew/20190705083141.106254-1-ysato@users.sourceforge.jp Switched to a new branch 'test' 43520aa target/rx: remove unused functions. 8c4fa37 BootLinuxConsoleTest: Test the RX-Virt machine 04564e4 Add rx-softmmu 9378055 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 623d106 hw/rx: Honor -accel qtest ce90108 hw/rx: RX Target hardware definition 5e1fd91 hw/char: RX62N serial communication interface (SCI) ed12e4f hw/timer: RX62N internal timer modules 4ee171f hw/intc: RX62N interrupt controller (ICUa) 3e99d3a target/rx: Dump bytes for each insn during disassembly 8ab5e5a target/rx: Collect all bytes during disassembly bfc0549 target/rx: Emit all disassembly in one prt() 8bc54a1 target/rx: Use prt_ldmi for XCHG_mr disassembly c337f3e target/rx: Replace operand with prt_ldmi in disassembler 06f56ef target/rx: Disassemble rx_index_addr into a string 29174101 target/rx: RX disassembler c693655 target/rx: CPU definition 439bd90 target/rx: TCG helper 83dfefb target/rx: TCG translation 3f7fb72 hw/registerfields.h: Add 8bit and 16bit register macros 260aa39 qemu/bitops.h: Add extract8 and extract16 7059b8f MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 7059b8fb4490 (MAINTAINERS: Add RX) 2/22 Checking commit 260aa39095f4 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 3f7fb72b73e5 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 83dfefba5ed1 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 439bd90293d1 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit c69365510576 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 622 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 29174101dd66 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 06f56ef1f68d (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit c337f3e82978 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 8bc54a18e392 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit bfc054910893 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 8ab5e5a64531 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit 3e99d3a17590 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit 4ee171f1b30c (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit ed12e4f78ded (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 5e1fd91ae9ec (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit ce90108ec40b (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 479 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 623d1066205d (hw/rx: Honor -accel qtest) 19/22 Checking commit 9378055ee6b5 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit 04564e411abc (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit 8c4fa379bd21 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 43520aa2a410 (target/rx: remove unused functions.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: deleted file mode 100644 total: 0 errors, 1 warnings, 5 lines checked Patch 22/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190705083141.106254-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
© 2016 - 2024 Red Hat, Inc.