tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

[Qemu-devel] [PATCH] tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

Posted by Eric Auger 4 years, 9 months ago

PCDIMM hotplug addition updated the DSDT. Update the reference table.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
 tests/data/acpi/virt/DSDT | Bin 18476 -> 18493 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)

diff --git a/tests/data/acpi/virt/DSDT b/tests/data/acpi/virt/DSDT
index 20e85c7f89f645c69935c615c07084e221419960..1a5c3e5243c78eb25345fdf7ffa442afec3c5c28 100644
GIT binary patch
delta 172
zcmZ28fpPByMlP3Nmk?VI1_q{Y6S<_BIvO{s=eSSi^^mWRZt~=a(Tfjuig$N)iRXy-
z@O0sIbPn(|FfcS`;D`?ea)A;+mUB?BARiZZCmRDZqb36bLnT9WgKLnhI|B~`0|zG;
zOLQYQi0kYc?CPT+ViNBf7Q$Ho;v_5(n_Qj1$iNt*&kVB1*CW8$H`v*4fdEjLhl`1U
Ni>WOjJjjWw0RY`tDw+TQ

delta 134
zcmdlxfpN_QMlP3Nmk=Ef1_q{ziCof5?F}2%bKIpo*xdvC4LIUGJY9GlgM2*<49pA}
zIN}{$f+og`c`$P_2rw{ovN13+sxvS!RDxt&Jq4Ay6ndl?7@-g-A<n=c$sh-0Ff)LR
Z11c2ZjdwLLW@rlt4|3vam^{&45den68LI#Q

-- 
2.20.1

Re: [Qemu-devel] [PATCH] tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

Posted by Igor Mammedov 4 years, 9 months ago

On Mon,  1 Jul 2019 21:08:19 +0200
Eric Auger <eric.auger@redhat.com> wrote:

> PCDIMM hotplug addition updated the DSDT. Update the reference table.
> 
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
checked ASL after applying it.
Modulo minor issue with generated ASL (reference to non existing method when running without memory hotplug enabled) which lax linux AML interpreter happily ignores if method is not actually accessed.
(could be fixed later on top of Shameer's series as trivial bugfix)

Reviewed-by: Igor Mammedov <imammedo@redhat.com>


> ---
>  tests/data/acpi/virt/DSDT | Bin 18476 -> 18493 bytes
>  1 file changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/tests/data/acpi/virt/DSDT b/tests/data/acpi/virt/DSDT
> index 20e85c7f89f645c69935c615c07084e221419960..1a5c3e5243c78eb25345fdf7ffa442afec3c5c28 100644
> GIT binary patch
> delta 172
> zcmZ28fpPByMlP3Nmk?VI1_q{Y6S<_BIvO{s=eSSi^^mWRZt~=a(Tfjuig$N)iRXy-
> z@O0sIbPn(|FfcS`;D`?ea)A;+mUB?BARiZZCmRDZqb36bLnT9WgKLnhI|B~`0|zG;
> zOLQYQi0kYc?CPT+ViNBf7Q$Ho;v_5(n_Qj1$iNt*&kVB1*CW8$H`v*4fdEjLhl`1U
> Ni>WOjJjjWw0RY`tDw+TQ  
> 
> delta 134
> zcmdlxfpN_QMlP3Nmk=Ef1_q{ziCof5?F}2%bKIpo*xdvC4LIUGJY9GlgM2*<49pA}
> zIN}{$f+og`c`$P_2rw{ovN13+sxvS!RDxt&Jq4Ay6ndl?7@-g-A<n=c$sh-0Ff)LR
> Z11c2ZjdwLLW@rlt4|3vam^{&45den68LI#Q
>

Re: [Qemu-devel] [PATCH] tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

Posted by Philippe Mathieu-Daudé 4 years, 9 months ago

Hi Eric,

On 7/1/19 9:08 PM, Eric Auger wrote:
> PCDIMM hotplug addition updated the DSDT. Update the reference table.

Can you point the commit sha1 please?

> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> ---
>  tests/data/acpi/virt/DSDT | Bin 18476 -> 18493 bytes
>  1 file changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/tests/data/acpi/virt/DSDT b/tests/data/acpi/virt/DSDT
> index 20e85c7f89f645c69935c615c07084e221419960..1a5c3e5243c78eb25345fdf7ffa442afec3c5c28 100644
> GIT binary patch
> delta 172
> zcmZ28fpPByMlP3Nmk?VI1_q{Y6S<_BIvO{s=eSSi^^mWRZt~=a(Tfjuig$N)iRXy-
> z@O0sIbPn(|FfcS`;D`?ea)A;+mUB?BARiZZCmRDZqb36bLnT9WgKLnhI|B~`0|zG;
> zOLQYQi0kYc?CPT+ViNBf7Q$Ho;v_5(n_Qj1$iNt*&kVB1*CW8$H`v*4fdEjLhl`1U
> Ni>WOjJjjWw0RY`tDw+TQ
> 
> delta 134
> zcmdlxfpN_QMlP3Nmk=Ef1_q{ziCof5?F}2%bKIpo*xdvC4LIUGJY9GlgM2*<49pA}
> zIN}{$f+og`c`$P_2rw{ovN13+sxvS!RDxt&Jq4Ay6ndl?7@-g-A<n=c$sh-0Ff)LR
> Z11c2ZjdwLLW@rlt4|3vam^{&45den68LI#Q
>

Re: [Qemu-devel] [PATCH] tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

Posted by Auger Eric 4 years, 9 months ago

Hi Philippe,
On 7/2/19 10:56 AM, Philippe Mathieu-Daudé wrote:
> Hi Eric,
> 
> On 7/1/19 9:08 PM, Eric Auger wrote:
>> PCDIMM hotplug addition updated the DSDT. Update the reference table.
> 
> Can you point the commit sha1 please?

this follows Peter's make check failure report sent yesterday and
follow-up discussion on IRC. The series is not yet upstream so I cannot
point to any SHA1 yet.

https://www.mail-archive.com/qemu-devel@nongnu.org/msg627971.html

Thanks

Eric

> 
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>> ---
>>  tests/data/acpi/virt/DSDT | Bin 18476 -> 18493 bytes
>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>
>> diff --git a/tests/data/acpi/virt/DSDT b/tests/data/acpi/virt/DSDT
>> index 20e85c7f89f645c69935c615c07084e221419960..1a5c3e5243c78eb25345fdf7ffa442afec3c5c28 100644
>> GIT binary patch
>> delta 172
>> zcmZ28fpPByMlP3Nmk?VI1_q{Y6S<_BIvO{s=eSSi^^mWRZt~=a(Tfjuig$N)iRXy-
>> z@O0sIbPn(|FfcS`;D`?ea)A;+mUB?BARiZZCmRDZqb36bLnT9WgKLnhI|B~`0|zG;
>> zOLQYQi0kYc?CPT+ViNBf7Q$Ho;v_5(n_Qj1$iNt*&kVB1*CW8$H`v*4fdEjLhl`1U
>> Ni>WOjJjjWw0RY`tDw+TQ
>>
>> delta 134
>> zcmdlxfpN_QMlP3Nmk=Ef1_q{ziCof5?F}2%bKIpo*xdvC4LIUGJY9GlgM2*<49pA}
>> zIN}{$f+og`c`$P_2rw{ovN13+sxvS!RDxt&Jq4Ay6ndl?7@-g-A<n=c$sh-0Ff)LR
>> Z11c2ZjdwLLW@rlt4|3vam^{&45den68LI#Q
>>

Re: [Qemu-devel] [PATCH] tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

Posted by Philippe Mathieu-Daudé 4 years, 9 months ago

On 7/2/19 11:01 AM, Auger Eric wrote:
> Hi Philippe,
> On 7/2/19 10:56 AM, Philippe Mathieu-Daudé wrote:
>> Hi Eric,
>>
>> On 7/1/19 9:08 PM, Eric Auger wrote:
>>> PCDIMM hotplug addition updated the DSDT. Update the reference table.
>>
>> Can you point the commit sha1 please?
> 
> this follows Peter's make check failure report sent yesterday and
> follow-up discussion on IRC. The series is not yet upstream so I cannot
> point to any SHA1 yet.
> 
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg627971.html

I hadn't review this series, so this patch was making no sense at all to
me, now it does.

I think it has to be squashed with:
"hw/arm/virt: Enable device memory cold/hot plug with ACPI boot"
in the series you mentioned.

Regards,

Phil.

>>
>>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>>> ---
>>>  tests/data/acpi/virt/DSDT | Bin 18476 -> 18493 bytes
>>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/tests/data/acpi/virt/DSDT b/tests/data/acpi/virt/DSDT
>>> index 20e85c7f89f645c69935c615c07084e221419960..1a5c3e5243c78eb25345fdf7ffa442afec3c5c28 100644
>>> GIT binary patch
>>> delta 172
>>> zcmZ28fpPByMlP3Nmk?VI1_q{Y6S<_BIvO{s=eSSi^^mWRZt~=a(Tfjuig$N)iRXy-
>>> z@O0sIbPn(|FfcS`;D`?ea)A;+mUB?BARiZZCmRDZqb36bLnT9WgKLnhI|B~`0|zG;
>>> zOLQYQi0kYc?CPT+ViNBf7Q$Ho;v_5(n_Qj1$iNt*&kVB1*CW8$H`v*4fdEjLhl`1U
>>> Ni>WOjJjjWw0RY`tDw+TQ
>>>
>>> delta 134
>>> zcmdlxfpN_QMlP3Nmk=Ef1_q{ziCof5?F}2%bKIpo*xdvC4LIUGJY9GlgM2*<49pA}
>>> zIN}{$f+og`c`$P_2rw{ovN13+sxvS!RDxt&Jq4Ay6ndl?7@-g-A<n=c$sh-0Ff)LR
>>> Z11c2ZjdwLLW@rlt4|3vam^{&45den68LI#Q
>>>

Re: [Qemu-devel] [PATCH] tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

Posted by Auger Eric 4 years, 9 months ago

Hi Philippe,
On 7/2/19 11:43 AM, Philippe Mathieu-Daudé wrote:
> On 7/2/19 11:01 AM, Auger Eric wrote:
>> Hi Philippe,
>> On 7/2/19 10:56 AM, Philippe Mathieu-Daudé wrote:
>>> Hi Eric,
>>>
>>> On 7/1/19 9:08 PM, Eric Auger wrote:
>>>> PCDIMM hotplug addition updated the DSDT. Update the reference table.
>>>
>>> Can you point the commit sha1 please?
>>
>> this follows Peter's make check failure report sent yesterday and
>> follow-up discussion on IRC. The series is not yet upstream so I cannot
>> point to any SHA1 yet.
>>
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg627971.html
> 
> I hadn't review this series, so this patch was making no sense at all to
> me, now it does.
> 
> I think it has to be squashed with:
> "hw/arm/virt: Enable device memory cold/hot plug with ACPI boot"
> in the series you mentioned.
Yep sorry for that. I was trying to fix the issue quickly for unblocking
the series for 4.1.

Actually it looks really weird as the test is passing on some hosts
(Igor is currently experiencing it). At the beginning I was not able to
reproduce Peter's issue and eventually after many various tweaks in the
environment I was able to. I used the script to regenerate the DSDT and
this definitively fixes the issue for me. Now we are not sure this isn't
an issue in the test itself.

Thanks

Eric
> 
> Regards,
> 
> Phil.
> 
>>>
>>>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>>>> ---
>>>>  tests/data/acpi/virt/DSDT | Bin 18476 -> 18493 bytes
>>>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/tests/data/acpi/virt/DSDT b/tests/data/acpi/virt/DSDT
>>>> index 20e85c7f89f645c69935c615c07084e221419960..1a5c3e5243c78eb25345fdf7ffa442afec3c5c28 100644
>>>> GIT binary patch
>>>> delta 172
>>>> zcmZ28fpPByMlP3Nmk?VI1_q{Y6S<_BIvO{s=eSSi^^mWRZt~=a(Tfjuig$N)iRXy-
>>>> z@O0sIbPn(|FfcS`;D`?ea)A;+mUB?BARiZZCmRDZqb36bLnT9WgKLnhI|B~`0|zG;
>>>> zOLQYQi0kYc?CPT+ViNBf7Q$Ho;v_5(n_Qj1$iNt*&kVB1*CW8$H`v*4fdEjLhl`1U
>>>> Ni>WOjJjjWw0RY`tDw+TQ
>>>>
>>>> delta 134
>>>> zcmdlxfpN_QMlP3Nmk=Ef1_q{ziCof5?F}2%bKIpo*xdvC4LIUGJY9GlgM2*<49pA}
>>>> zIN}{$f+og`c`$P_2rw{ovN13+sxvS!RDxt&Jq4Ay6ndl?7@-g-A<n=c$sh-0Ff)LR
>>>> Z11c2ZjdwLLW@rlt4|3vam^{&45den68LI#Q
>>>>