[Qemu-devel] [PULL 00/29] Machine next patches

Eduardo Habkost posted 29 patches 6 years, 3 months ago
Test checkpatch passed
Test s390x failed
Test asan passed
Test docker-mingw@fedora passed
Test FreeBSD passed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190628015606.32107-1-ehabkost@redhat.com
Maintainers: Paul Burton <pburton@wavecomp.com>, Paul Durrant <paul.durrant@citrix.com>, Anthony Perard <anthony.perard@citrix.com>, Juan Quintela <quintela@redhat.com>, Rob Herring <robh@kernel.org>, Cornelia Huck <cohuck@redhat.com>, Richard Henderson <rth@twiddle.net>, Jia Liu <proljc@gmail.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Aleksandar Markovic <amarkovic@wavecomp.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, David Gibson <david@gibson.dropbear.id.au>, Igor Mammedov <imammedo@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, Andrey Smirnov <andrew.smirnov@gmail.com>, Andrew Baumann <Andrew.Baumann@microsoft.com>, Jean-Christophe Dubois <jcd@tribudubois.net>, Stefano Stabellini <sstabellini@kernel.org>, Aleksandar Rikalo <arikalo@wavecomp.com>, Sagar Karandikar <sagark@eecs.berkeley.edu>, Aurelien Jarno <aurelien@aurel32.net>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Halil Pasic <pasic@linux.ibm.com>, Stafford Horne <shorne@gmail.com>, Artyom Tarasenko <atar4qemu@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Helge Deller <deller@gmx.de>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Hervé Poussineau" <hpoussin@reactos.org>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Palmer Dabbelt <palmer@sifive.com>, Eric Blake <eblake@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, Alistair Francis <alistair@alistair23.me>, "Cédric Le Goater" <clg@kaod.org>, "Alex Bennée" <alex.bennee@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Max Filippov <jcmvbkbc@gmail.com>, Markus Armbruster <armbru@redhat.com>, Alistair Francis <Alistair.Francis@wdc.com>, David Hildenbrand <david@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
qapi/misc.json               |  11 ++-
include/hw/boards.h          |  27 +++++-
include/hw/firmware/smbios.h |   5 +-
include/hw/i386/pc.h         |   5 +-
include/hw/i386/topology.h   |  76 +++++++++++----
target/hppa/cpu.h            |   2 -
target/i386/cpu.h            |   8 +-
accel/kvm/kvm-all.c          |   4 +-
backends/hostmem.c           |   6 +-
cpus.c                       |   6 +-
exec.c                       |   3 +-
gdbstub.c                    |   4 +
hw/alpha/dp264.c             |   1 +
hw/arm/fsl-imx6.c            |   6 +-
hw/arm/fsl-imx6ul.c          |   6 +-
hw/arm/fsl-imx7.c            |   7 +-
hw/arm/highbank.c            |   1 +
hw/arm/mcimx6ul-evk.c        |   2 +-
hw/arm/mcimx7d-sabre.c       |   2 +-
hw/arm/raspi.c               |   4 +-
hw/arm/realview.c            |   1 +
hw/arm/sabrelite.c           |   2 +-
hw/arm/vexpress.c            |  16 +--
hw/arm/virt.c                |  11 ++-
hw/arm/xlnx-zynqmp.c         |  16 +--
hw/core/machine.c            |  88 +++++++++++++++++
hw/cpu/core.c                |   4 +-
hw/hppa/machine.c            |   4 +-
hw/i386/acpi-build.c         |  13 ++-
hw/i386/kvmvapic.c           |   7 +-
hw/i386/pc.c                 | 183 +++++++++++++++++++++++++++++------
hw/i386/xen/xen-hvm.c        |   4 +
hw/mips/boston.c             |   2 +-
hw/mips/mips_malta.c         |  24 ++---
hw/openrisc/openrisc_sim.c   |   1 +
hw/ppc/e500.c                |   3 +
hw/ppc/mac_newworld.c        |   3 +-
hw/ppc/mac_oldworld.c        |   3 +-
hw/ppc/pnv.c                 |   9 +-
hw/ppc/prep.c                |   4 +-
hw/ppc/spapr.c               |  38 ++++++--
hw/ppc/spapr_rtas.c          |   4 +-
hw/riscv/sifive_e.c          |   6 +-
hw/riscv/sifive_plic.c       |   3 +
hw/riscv/sifive_u.c          |   6 +-
hw/riscv/spike.c             |   3 +
hw/riscv/virt.c              |   1 +
hw/s390x/s390-virtio-ccw.c   |   9 +-
hw/s390x/sclp.c              |   2 +-
hw/smbios/smbios.c           |  26 ++---
hw/sparc/sun4m.c             |   2 +
hw/sparc64/sun4u.c           |   4 +-
hw/xtensa/sim.c              |   2 +-
hw/xtensa/xtfpga.c           |   1 +
migration/postcopy-ram.c     |   8 +-
monitor/hmp-cmds.c           |   3 +
monitor/qmp-cmds.c           |   2 +-
numa.c                       |  12 ++-
target/arm/cpu.c             |   8 +-
target/hppa/cpu.c            |  17 ----
target/i386/cpu.c            | 130 +++++++++++++------------
target/i386/hyperv-stub.c    |   2 +-
target/i386/kvm.c            |  12 +++
target/openrisc/sys_helper.c |   6 +-
target/s390x/cpu.c           |   3 +
target/s390x/excp_helper.c   |   5 +
tcg/tcg.c                    |  13 ++-
tests/test-x86-cpuid.c       |  84 ++++++++--------
vl.c                         |  97 ++++---------------
qemu-deprecated.texi         |  33 +++++++
qemu-options.hx              |  17 ++--
71 files changed, 773 insertions(+), 370 deletions(-)
[Qemu-devel] [PULL 00/29] Machine next patches
Posted by Eduardo Habkost 6 years, 3 months ago
The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde:

  Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 15:40:50 +0100)

are available in the Git repository at:

  git://github.com/ehabkost/qemu.git tags/machine-next-pull-request

for you to fetch changes up to 99e5945a1e7369737c2ad65dfafc86cb63df9e7a:

  vl.c: Add -smp, dies=* command line support and update doc (2019-06-26 14:38:13 -0300)

----------------------------------------------------------------
Machine and x86 queue, 2019-06-27

* CPU die topology support (Like Xu)
* Deprecation of features (Igor Mammedov):
  * 'mem' parameter of '-numa node' option
  * implict memory distribution between NUMA nodes
  * deprecate -mem-path fallback to anonymous RAM
* Other i386 fixes

----------------------------------------------------------------

Queue for Machine Core patches


Alex Bennée (1):
  target/i386: fix feature check in hyperv-stub.c

Eduardo Habkost (4):
  hppa: Delete unused hppa_cpu_list() function
  i386: Don't print warning if phys-bits was set automatically
  i386: Fix signedness of hyperv_spinlock_attempts
  i386: Remove unused host_cpudef variable

Igor Mammedov (5):
  pc: fix possible NULL pointer dereference in
    pc_machine_get_device_memory_region_size()
  machine: show if CLI option '-numa node,mem' is supported in QAPI
    schema
  numa: deprecate 'mem' parameter of '-numa node' option
  numa: deprecate implict memory distribution between nodes
  deprecate -mem-path fallback to anonymous RAM

Like Xu (17):
  hw/boards: Add struct CpuTopology to MachineState
  machine: Refactor smp-related call chains to pass MachineState
  general: Replace global smp variables with smp machine properties
  hw/ppc: Replace global smp variables with machine smp properties
  hw/riscv: Replace global smp variables with machine smp properties
  hw/s390x: Replace global smp variables with machine smp properties
  hw/i386: Replace global smp variables with machine smp properties
  hw/arm: Replace global smp variables with machine smp properties
  hw: Replace global smp variables with MachineState for all remaining
    archs
  vl.c: Replace smp global variables with smp machine properties
  i386: Add die-level cpu topology to x86CPU on PCMachine
  hw/i386: Adjust nr_dies with configured smp_dies for PCMachine
  i386/cpu: Consolidate die-id validity in smp context
  i386: Update new x86_apicid parsing rules with die_offset support
  target/i386: Add CPUID.1F generation support for multi-dies PCMachine
  machine: Refactor smp_parse() in vl.c as MachineClass::smp_parse()
  vl.c: Add -smp, dies=* command line support and update doc

Roman Kagan (1):
  i386: make 'hv-spinlocks' a regular uint32 property

Wei Yang (1):
  x86/cpu: use FeatureWordArray to define filtered_features

 qapi/misc.json               |  11 ++-
 include/hw/boards.h          |  27 +++++-
 include/hw/firmware/smbios.h |   5 +-
 include/hw/i386/pc.h         |   5 +-
 include/hw/i386/topology.h   |  76 +++++++++++----
 target/hppa/cpu.h            |   2 -
 target/i386/cpu.h            |   8 +-
 accel/kvm/kvm-all.c          |   4 +-
 backends/hostmem.c           |   6 +-
 cpus.c                       |   6 +-
 exec.c                       |   3 +-
 gdbstub.c                    |   4 +
 hw/alpha/dp264.c             |   1 +
 hw/arm/fsl-imx6.c            |   6 +-
 hw/arm/fsl-imx6ul.c          |   6 +-
 hw/arm/fsl-imx7.c            |   7 +-
 hw/arm/highbank.c            |   1 +
 hw/arm/mcimx6ul-evk.c        |   2 +-
 hw/arm/mcimx7d-sabre.c       |   2 +-
 hw/arm/raspi.c               |   4 +-
 hw/arm/realview.c            |   1 +
 hw/arm/sabrelite.c           |   2 +-
 hw/arm/vexpress.c            |  16 +--
 hw/arm/virt.c                |  11 ++-
 hw/arm/xlnx-zynqmp.c         |  16 +--
 hw/core/machine.c            |  88 +++++++++++++++++
 hw/cpu/core.c                |   4 +-
 hw/hppa/machine.c            |   4 +-
 hw/i386/acpi-build.c         |  13 ++-
 hw/i386/kvmvapic.c           |   7 +-
 hw/i386/pc.c                 | 183 +++++++++++++++++++++++++++++------
 hw/i386/xen/xen-hvm.c        |   4 +
 hw/mips/boston.c             |   2 +-
 hw/mips/mips_malta.c         |  24 ++---
 hw/openrisc/openrisc_sim.c   |   1 +
 hw/ppc/e500.c                |   3 +
 hw/ppc/mac_newworld.c        |   3 +-
 hw/ppc/mac_oldworld.c        |   3 +-
 hw/ppc/pnv.c                 |   9 +-
 hw/ppc/prep.c                |   4 +-
 hw/ppc/spapr.c               |  38 ++++++--
 hw/ppc/spapr_rtas.c          |   4 +-
 hw/riscv/sifive_e.c          |   6 +-
 hw/riscv/sifive_plic.c       |   3 +
 hw/riscv/sifive_u.c          |   6 +-
 hw/riscv/spike.c             |   3 +
 hw/riscv/virt.c              |   1 +
 hw/s390x/s390-virtio-ccw.c   |   9 +-
 hw/s390x/sclp.c              |   2 +-
 hw/smbios/smbios.c           |  26 ++---
 hw/sparc/sun4m.c             |   2 +
 hw/sparc64/sun4u.c           |   4 +-
 hw/xtensa/sim.c              |   2 +-
 hw/xtensa/xtfpga.c           |   1 +
 migration/postcopy-ram.c     |   8 +-
 monitor/hmp-cmds.c           |   3 +
 monitor/qmp-cmds.c           |   2 +-
 numa.c                       |  12 ++-
 target/arm/cpu.c             |   8 +-
 target/hppa/cpu.c            |  17 ----
 target/i386/cpu.c            | 130 +++++++++++++------------
 target/i386/hyperv-stub.c    |   2 +-
 target/i386/kvm.c            |  12 +++
 target/openrisc/sys_helper.c |   6 +-
 target/s390x/cpu.c           |   3 +
 target/s390x/excp_helper.c   |   5 +
 tcg/tcg.c                    |  13 ++-
 tests/test-x86-cpuid.c       |  84 ++++++++--------
 vl.c                         |  97 ++++---------------
 qemu-deprecated.texi         |  33 +++++++
 qemu-options.hx              |  17 ++--
 71 files changed, 773 insertions(+), 370 deletions(-)

-- 
2.18.0.rc1.1.g3f1ff2140


Re: [Qemu-devel] [PULL 00/29] Machine next patches
Posted by no-reply@patchew.org 6 years, 3 months ago
Patchew URL: https://patchew.org/QEMU/20190628015606.32107-1-ehabkost@redhat.com/



Hi,

This series failed build test on s390x host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e
CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install

echo
echo "=== ENV ==="
env

echo
echo "=== PACKAGES ==="
rpm -qa
=== TEST SCRIPT END ===

/var/tmp/patchew-tester-tmp-vfw4sa78/src/target/s390x/kvm.c:367: undefined reference to `max_cpus'
/usr/bin/ld: target/s390x/kvm.o: in function `kvm_s390_vcpu_interrupt_pre_save':
/var/tmp/patchew-tester-tmp-vfw4sa78/src/target/s390x/kvm.c:1953: undefined reference to `max_cpus'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:205: qemu-system-s390x] Error 1
make: *** [Makefile:472: subdir-s390x-softmmu] Error 2
make: *** Waiting for unfinished jobs....


The full log is available at
http://patchew.org/logs/20190628015606.32107-1-ehabkost@redhat.com/testing.s390x/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PULL 00/29] Machine next patches
Posted by Eduardo Habkost 6 years, 3 months ago
On Thu, Jun 27, 2019 at 07:49:47PM -0700, no-reply@patchew.org wrote:
> === TEST SCRIPT END ===
> 
> /var/tmp/patchew-tester-tmp-vfw4sa78/src/target/s390x/kvm.c:367: undefined reference to `max_cpus'
> /usr/bin/ld: target/s390x/kvm.o: in function `kvm_s390_vcpu_interrupt_pre_save':
> /var/tmp/patchew-tester-tmp-vfw4sa78/src/target/s390x/kvm.c:1953: undefined reference to `max_cpus'

I've fixed this and I'm sending v2 of the pull request right now.

-- 
Eduardo