Hi,
These are some rather selfish iotests patches. The first patch helps me
personally because I tend to run the tests over SSH and forget to set
$DISPLAY. That makes test 139 skip the tests annotated with
skip_if_unsupprted(), because iotests.py can no longer determine the
list of whitelisted formats.
Patches 2 through 5 are specifically for RHEL. We have not whitelisted
null-aio, so it would be nice if tests didn’t require it. Sorry, I
don’t have a better reason to give.
In all seriousness, null-co is used widely in many tests, it basically
is our standard null driver. Tests should prefer it over null-aio, just
for consistency alone. It is not completely unreasonable to treat
null-aio as optional. I guess.
v2:
- Allow tests to use the unittest module’s skipTest() so it is possible
to skip a test case in the setUp() method (new patch 3). Then use
this in patches 4 and 5 to skip all null-aio cases instead of falling
back to null-co and thus running tests twice.
- Patch 1 needed to be rebased on
4a715461c8eab628e79b1e6889d650455e043b88
(“tests/qemu-iotests/check: Pick a default machine if necessary”)
git backport-diff against v1:
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/5:[0008] [FC] 'iotests: Add -display none to the qemu options'
002/5:[----] [--] 'iotests: Prefer null-co over null-aio'
003/5:[down] 'iotests: Allow skipping test cases'
004/5:[0007] [FC] 'iotests: Test driver whitelisting in 093'
005/5:[0007] [FC] 'iotests: Test driver whitelisting in 136'
Max Reitz (5):
iotests: Add -display none to the qemu options
iotests: Prefer null-co over null-aio
iotests: Allow skipping test cases
iotests: Test driver whitelisting in 093
iotests: Test driver whitelisting in 136
tests/qemu-iotests/093 | 21 ++++++++++++++-------
tests/qemu-iotests/136 | 16 ++++++++++++----
tests/qemu-iotests/245 | 2 +-
tests/qemu-iotests/check | 6 +++---
tests/qemu-iotests/iotests.py | 20 ++++++++++++++++++--
5 files changed, 48 insertions(+), 17 deletions(-)
--
2.21.0