vfio-common.h: Remove inaccurate comment

[Qemu-devel] [PATCH] vfio-common.h: Remove inaccurate comment

Fabiano Rosas posted 1 patch 4 years, 10 months ago

Download mbox

Test s390x passed

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190621220120.15567-1-farosas@linux.ibm.com

Maintainers: Alex Williamson <alex.williamson@redhat.com>

include/hw/vfio/vfio-common.h | 5 -----
1 file changed, 5 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] vfio-common.h: Remove inaccurate comment

Posted by Fabiano Rosas 4 years, 10 months ago

This is a left-over from "f4ec5e26ed vfio: Add host side DMA window
capabilities", which added support to more than one DMA window.

Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
---
 include/hw/vfio/vfio-common.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
index a88b69b675..9107bd41c0 100644
--- a/include/hw/vfio/vfio-common.h
+++ b/include/hw/vfio/vfio-common.h
@@ -74,11 +74,6 @@ typedef struct VFIOContainer {
     int error;
     bool initialized;
     unsigned long pgsizes;
-    /*
-     * This assumes the host IOMMU can support only a single
-     * contiguous IOVA window.  We may need to generalize that in
-     * future
-     */
     QLIST_HEAD(, VFIOGuestIOMMU) giommu_list;
     QLIST_HEAD(, VFIOHostDMAWindow) hostwin_list;
     QLIST_HEAD(, VFIOGroup) group_list;
-- 
2.20.1

Re: [Qemu-devel] [PATCH] vfio-common.h: Remove inaccurate comment

Posted by David Gibson 4 years, 10 months ago

On Fri, Jun 21, 2019 at 07:01:20PM -0300, Fabiano Rosas wrote:
> This is a left-over from "f4ec5e26ed vfio: Add host side DMA window
> capabilities", which added support to more than one DMA window.
> 
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>

Acked-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  include/hw/vfio/vfio-common.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
> index a88b69b675..9107bd41c0 100644
> --- a/include/hw/vfio/vfio-common.h
> +++ b/include/hw/vfio/vfio-common.h
> @@ -74,11 +74,6 @@ typedef struct VFIOContainer {
>      int error;
>      bool initialized;
>      unsigned long pgsizes;
> -    /*
> -     * This assumes the host IOMMU can support only a single
> -     * contiguous IOVA window.  We may need to generalize that in
> -     * future
> -     */
>      QLIST_HEAD(, VFIOGuestIOMMU) giommu_list;
>      QLIST_HEAD(, VFIOHostDMAWindow) hostwin_list;
>      QLIST_HEAD(, VFIOGroup) group_list;

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson