[v3] vmdk: Add read-only support for the new seSparse format

[Qemu-devel] [PATCH v3 0/3] vmdk: Add read-only support for the new seSparse format

Sam Eiderman posted 3 patches 4 years, 10 months ago

Diff against v2
Download series mbox

Test s390x passed

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190620091057.47441-1-shmuel.eiderman@oracle.com

Maintainers: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>

block/vmdk.c               | 372 ++++++++++++++++++++++++++++++++++++++++++---
tests/qemu-iotests/059.out |   2 +-
2 files changed, 353 insertions(+), 21 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v3 0/3] vmdk: Add read-only support for the new seSparse format

Posted by Sam Eiderman 4 years, 10 months ago

v1:

VMware introduced a new snapshot format in VMFS6 - seSparse (Space
Efficient Sparse) which is the default format available in ESXi 6.7.
Add read-only support for the new snapshot format.

v2:

Fixed after Max's review:

* Removed strict sesparse checks
* Reduced maximal L1 table size
* Added non-write mode check in vmdk_open() on sesparse

v3:

Change non-write mode check in vmdk_open() to bdrv_apply_auto_read_only().

Sam Eiderman (3):
  vmdk: Fix comment regarding max l1_size coverage
  vmdk: Reduce the max bound for L1 table size
  vmdk: Add read-only support for seSparse snapshots

 block/vmdk.c               | 372 ++++++++++++++++++++++++++++++++++++++++++---
 tests/qemu-iotests/059.out |   2 +-
 2 files changed, 353 insertions(+), 21 deletions(-)

-- 
2.13.3

Re: [Qemu-devel] [PATCH v3 0/3] vmdk: Add read-only support for the new seSparse format

Posted by Max Reitz 4 years, 10 months ago

On 20.06.19 11:10, Sam Eiderman wrote:
> v1:
> 
> VMware introduced a new snapshot format in VMFS6 - seSparse (Space
> Efficient Sparse) which is the default format available in ESXi 6.7.
> Add read-only support for the new snapshot format.
> 
> v2:
> 
> Fixed after Max's review:
> 
> * Removed strict sesparse checks
> * Reduced maximal L1 table size
> * Added non-write mode check in vmdk_open() on sesparse
> 
> v3:
> 
> Change non-write mode check in vmdk_open() to bdrv_apply_auto_read_only().
> 
> Sam Eiderman (3):
>   vmdk: Fix comment regarding max l1_size coverage
>   vmdk: Reduce the max bound for L1 table size
>   vmdk: Add read-only support for seSparse snapshots
> 
>  block/vmdk.c               | 372 ++++++++++++++++++++++++++++++++++++++++++---
>  tests/qemu-iotests/059.out |   2 +-
>  2 files changed, 353 insertions(+), 21 deletions(-)

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max