Move QOM, qdev, machine core and dump code

[Qemu-devel] [PATCH 02/17] Makefile: Don't add monitor/ twice to common-obj-y

Markus Armbruster posted 17 patches 6 years, 4 months ago

Download mbox

Maintainers: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Aleksandar Markovic <amarkovic@wavecomp.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Aleksandar Rikalo <arikalo@wavecomp.com>, Anthony Perard <anthony.perard@citrix.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, Kevin Wolf <kwolf@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Peter Maydell <peter.maydell@linaro.org>, Max Filippov <jcmvbkbc@gmail.com>, Cornelia Huck <cohuck@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, David Hildenbrand <david@redhat.com>, Richard Henderson <rth@twiddle.net>, Paul Durrant <paul.durrant@citrix.com>, Max Reitz <mreitz@redhat.com>, Marek Vasut <marex@denx.de>, David Gibson <david@gibson.dropbear.id.au>, Eduardo Habkost <ehabkost@redhat.com>, Igor Mammedov <imammedo@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Stefano Stabellini <sstabellini@kernel.org>, Chris Wulff <crwulff@gmail.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>

Expand all Fold all

[Qemu-devel] [PATCH 02/17] Makefile: Don't add monitor/ twice to common-obj-y

Posted by Markus Armbruster 6 years, 4 months ago

Both commit f1b3ccfaa68 "monitor: Move {hmp, qmp}.c to monitor/{hmp,
qmp}-cmds.c" and commit 7e3c0deab1b "monitor: Split out monitor/qmp.c"
added monitor/ to common-obj-y ifeq ($(CONFIG_SOFTMMU),y).  Revert the
second addition.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 Makefile.objs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Makefile.objs b/Makefile.objs
index 658cfc9d9f..7494d6143b 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -85,7 +85,6 @@ common-obj-$(CONFIG_FDT) += device_tree.o
 # qapi
 
 common-obj-y += qapi/
-common-obj-y += monitor/
 endif
 
 #######################################################################
-- 
2.21.0

Re: [Qemu-devel] [PATCH 02/17] Makefile: Don't add monitor/ twice to common-obj-y

Posted by Daniel P. Berrangé 6 years, 4 months ago

On Wed, Jun 19, 2019 at 10:10:35PM +0200, Markus Armbruster wrote:
> Both commit f1b3ccfaa68 "monitor: Move {hmp, qmp}.c to monitor/{hmp,
> qmp}-cmds.c" and commit 7e3c0deab1b "monitor: Split out monitor/qmp.c"
> added monitor/ to common-obj-y ifeq ($(CONFIG_SOFTMMU),y).  Revert the
> second addition.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  Makefile.objs | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|