gdbstub: print message on startup as gdbserver

[Qemu-devel] [PATCH] gdbstub: print message on startup as gdbserver

lukas.durfina@gmail.com posted 1 patch 6 years, 4 months ago

Download mbox

Test s390x passed

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190619145654.118068-1-ldurfina@tachyum.com

Maintainers: "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>

gdbstub.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[Qemu-devel] [PATCH] gdbstub: print message on startup as gdbserver

Posted by lukas.durfina@gmail.com 6 years, 4 months ago

From: Lukas Durfina <ldurfina@tachyum.com>

It helps to test gdb running qemu instead of a gdbserver.
It prints the same message as the gdbserver on startup.

Signed-off-by: Lukas Durfina <ldurfina@tachyum.com>
---
 gdbstub.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdbstub.c b/gdbstub.c
index 8618e34311..9ad9929968 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -3109,6 +3109,7 @@ int gdbserver_start(int port)
     gdbserver_fd = gdbserver_open(port);
     if (gdbserver_fd < 0)
         return -1;
+    printf("Listening on port %d\n", port);
     /* accept connections */
     if (!gdb_accept()) {
         close(gdbserver_fd);
-- 
2.17.1

Re: [Qemu-devel] [PATCH] gdbstub: print message on startup as gdbserver

Posted by Alex Bennée 6 years, 4 months ago

lukas.durfina@gmail.com writes:

> From: Lukas Durfina <ldurfina@tachyum.com>
>
> It helps to test gdb running qemu instead of a gdbserver.
> It prints the same message as the gdbserver on startup.
>
> Signed-off-by: Lukas Durfina <ldurfina@tachyum.com>
> ---
>  gdbstub.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 8618e34311..9ad9929968 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -3109,6 +3109,7 @@ int gdbserver_start(int port)
>      gdbserver_fd = gdbserver_open(port);
>      if (gdbserver_fd < 0)
>          return -1;
> +    printf("Listening on port %d\n", port);

Not really - we don't arbitrarily output stuff on stdout. In fact the
best way to track what gdbserver is doing is to use the built-in trace
points:

  $QEMU -d trace:gdb\* $QEMU_ARGS

For system emulation from the console you can run:

  (qemu) info chardev

which will report the state of the gdb connection:

  gdb: filename=disconnected:tcp:0.0.0.0:1234,server

>      /* accept connections */
>      if (!gdb_accept()) {
>          close(gdbserver_fd);


--
Alex Bennée