[Qemu-devel] [PATCH v2 0/5] tricore: adding new instructions and fixing issues

David Brenken posted 5 patches 4 years, 10 months ago
Test s390x passed
Test checkpatch failed
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190619075643.10048-1-david.brenken@efs-auto.org
Maintainers: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
target/tricore/fpu_helper.c | 126 ++++++++++++++++++++++++++++++++++++
target/tricore/helper.h     |   3 +
target/tricore/translate.c  |  14 +++-
3 files changed, 141 insertions(+), 2 deletions(-)
[Qemu-devel] [PATCH v2 0/5] tricore: adding new instructions and fixing issues
Posted by David Brenken 4 years, 10 months ago
From: David Brenken <david.brenken@efs-auto.de>

Hello everyone,

as discussed here is the second version of the patchset.
- We changed the implementation of the RRPW_INSERT to make use of 
tcg_gen_deposit_tl.
- We added more information of the implementation of QSEED in the code
and changed parts of the implementation.
- We do only sync ctx.hflags with tb->flags.

Best regards

David

Andreas Konopik (1):
  tricore: add QSEED instruction

David Brenken (3):
  tricore: add FTOIZ instruction
  tricore: add UTOF instruction
  tricore: fix RRPW_INSERT instruction

Georg Hofstetter (1):
  tricore: reset DisasContext before generating code

 target/tricore/fpu_helper.c | 126 ++++++++++++++++++++++++++++++++++++
 target/tricore/helper.h     |   3 +
 target/tricore/translate.c  |  14 +++-
 3 files changed, 141 insertions(+), 2 deletions(-)

-- 
2.22.0.windows.1

Re: [Qemu-devel] [PATCH v2 0/5] tricore: adding new instructions and fixing issues
Posted by no-reply@patchew.org 4 years, 10 months ago
Patchew URL: https://patchew.org/QEMU/20190619075643.10048-1-david.brenken@efs-auto.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v2 0/5] tricore: adding new instructions and fixing issues
Type: series
Message-id: 20190619075643.10048-1-david.brenken@efs-auto.org

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190619075643.10048-1-david.brenken@efs-auto.org -> patchew/20190619075643.10048-1-david.brenken@efs-auto.org
Switched to a new branch 'test'
b4315e0b64 tricore: reset DisasContext before generating code
915f96578d tricore: add QSEED instruction
cf97b82189 tricore: fix RRPW_INSERT instruction
a3170a6c41 tricore: add UTOF instruction
7366542cc6 tricore: add FTOIZ instruction

=== OUTPUT BEGIN ===
1/5 Checking commit 7366542cc639 (tricore: add FTOIZ instruction)
2/5 Checking commit a3170a6c41b8 (tricore: add UTOF instruction)
3/5 Checking commit cf97b8218918 (tricore: fix RRPW_INSERT instruction)
4/5 Checking commit 915f96578db6 (tricore: add QSEED instruction)
ERROR: trailing whitespace
#146: FILE: target/tricore/translate.c:6755:
+        break;^I^I^I^I$

ERROR: code indent should never use tabs
#146: FILE: target/tricore/translate.c:6755:
+        break;^I^I^I^I$

total: 2 errors, 0 warnings, 119 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/5 Checking commit b4315e0b64ed (tricore: reset DisasContext before generating code)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190619075643.10048-1-david.brenken@efs-auto.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH v2 0/5] tricore: adding new instructions and fixing issues
Posted by no-reply@patchew.org 4 years, 10 months ago
Patchew URL: https://patchew.org/QEMU/20190619075643.10048-1-david.brenken@efs-auto.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v2 0/5] tricore: adding new instructions and fixing issues
Type: series
Message-id: 20190619075643.10048-1-david.brenken@efs-auto.org

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190619075643.10048-1-david.brenken@efs-auto.org -> patchew/20190619075643.10048-1-david.brenken@efs-auto.org
Switched to a new branch 'test'
cef0cc9a23 tricore: reset DisasContext before generating code
7961721b61 tricore: add QSEED instruction
c1173a9492 tricore: fix RRPW_INSERT instruction
29d6aeb64c tricore: add UTOF instruction
f0b753a6c2 tricore: add FTOIZ instruction

=== OUTPUT BEGIN ===
1/5 Checking commit f0b753a6c2da (tricore: add FTOIZ instruction)
2/5 Checking commit 29d6aeb64c9b (tricore: add UTOF instruction)
3/5 Checking commit c1173a949230 (tricore: fix RRPW_INSERT instruction)
4/5 Checking commit 7961721b6133 (tricore: add QSEED instruction)
ERROR: trailing whitespace
#146: FILE: target/tricore/translate.c:6755:
+        break;^I^I^I^I$

ERROR: code indent should never use tabs
#146: FILE: target/tricore/translate.c:6755:
+        break;^I^I^I^I$

total: 2 errors, 0 warnings, 119 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/5 Checking commit cef0cc9a2327 (tricore: reset DisasContext before generating code)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190619075643.10048-1-david.brenken@efs-auto.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com