[Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition

David Hildenbrand posted 2 patches 13 weeks ago
Test s390x passed
Test checkpatch failed
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190612132526.8905-1-david@redhat.com
Maintainers: Richard Henderson <rth@twiddle.net>, David Hildenbrand <david@redhat.com>, Cornelia Huck <cohuck@redhat.com>
target/s390x/cpu_features.c         | 352 +-------------------------
target/s390x/cpu_features_def.h     | 352 +-------------------------
target/s390x/cpu_features_def.inc.h | 369 ++++++++++++++++++++++++++++
target/s390x/gen-features.c         |  30 +--
4 files changed, 401 insertions(+), 702 deletions(-)
create mode 100644 target/s390x/cpu_features_def.inc.h

[Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition

Posted by David Hildenbrand 13 weeks ago
Rework the feature initialization, making it harder to make mistakes.
While at it, rename the enum names of the KDSA features.

David Hildenbrand (2):
  s390x/cpumodel: Rework CPU feature definition
  s390x/cpumodel: Prepend KDSA features with "KDSA"

 target/s390x/cpu_features.c         | 352 +-------------------------
 target/s390x/cpu_features_def.h     | 352 +-------------------------
 target/s390x/cpu_features_def.inc.h | 369 ++++++++++++++++++++++++++++
 target/s390x/gen-features.c         |  30 +--
 4 files changed, 401 insertions(+), 702 deletions(-)
 create mode 100644 target/s390x/cpu_features_def.inc.h

-- 
2.21.0


Re: [Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition

Posted by David Hildenbrand 13 weeks ago
On 12.06.19 15:25, David Hildenbrand wrote:
> Rework the feature initialization, making it harder to make mistakes.
> While at it, rename the enum names of the KDSA features.
> 
> David Hildenbrand (2):
>   s390x/cpumodel: Rework CPU feature definition
>   s390x/cpumodel: Prepend KDSA features with "KDSA"
> 
>  target/s390x/cpu_features.c         | 352 +-------------------------
>  target/s390x/cpu_features_def.h     | 352 +-------------------------
>  target/s390x/cpu_features_def.inc.h | 369 ++++++++++++++++++++++++++++
>  target/s390x/gen-features.c         |  30 +--
>  4 files changed, 401 insertions(+), 702 deletions(-)
>  create mode 100644 target/s390x/cpu_features_def.inc.h
> 

Queued to

https://github.com/davidhildenbrand/qemu.git s390-tcg-next

Thanks to Janosch and Conny.

-- 

Thanks,

David / dhildenb

Re: [Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition

Posted by Cornelia Huck 13 weeks ago
On Wed, 12 Jun 2019 15:25:24 +0200
David Hildenbrand <david@redhat.com> wrote:

> Rework the feature initialization, making it harder to make mistakes.
> While at it, rename the enum names of the KDSA features.
> 
> David Hildenbrand (2):
>   s390x/cpumodel: Rework CPU feature definition
>   s390x/cpumodel: Prepend KDSA features with "KDSA"
> 
>  target/s390x/cpu_features.c         | 352 +-------------------------
>  target/s390x/cpu_features_def.h     | 352 +-------------------------
>  target/s390x/cpu_features_def.inc.h | 369 ++++++++++++++++++++++++++++
>  target/s390x/gen-features.c         |  30 +--
>  4 files changed, 401 insertions(+), 702 deletions(-)
>  create mode 100644 target/s390x/cpu_features_def.inc.h
> 

Looks good to me. Do you want to take it via your tree?

Re: [Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition

Posted by David Hildenbrand 13 weeks ago
On 14.06.19 13:49, Cornelia Huck wrote:
> On Wed, 12 Jun 2019 15:25:24 +0200
> David Hildenbrand <david@redhat.com> wrote:
> 
>> Rework the feature initialization, making it harder to make mistakes.
>> While at it, rename the enum names of the KDSA features.
>>
>> David Hildenbrand (2):
>>   s390x/cpumodel: Rework CPU feature definition
>>   s390x/cpumodel: Prepend KDSA features with "KDSA"
>>
>>  target/s390x/cpu_features.c         | 352 +-------------------------
>>  target/s390x/cpu_features_def.h     | 352 +-------------------------
>>  target/s390x/cpu_features_def.inc.h | 369 ++++++++++++++++++++++++++++
>>  target/s390x/gen-features.c         |  30 +--
>>  4 files changed, 401 insertions(+), 702 deletions(-)
>>  create mode 100644 target/s390x/cpu_features_def.inc.h
>>
> 
> Looks good to me. Do you want to take it via your tree?
> 

Yep, will do. Thanks!

-- 

Thanks,

David / dhildenb

Re: [Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition

Posted by no-reply@patchew.org 13 weeks ago
Patchew URL: https://patchew.org/QEMU/20190612132526.8905-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v1 0/2] s390x/cpumodel: Rework CPU feature definition
Type: series
Message-id: 20190612132526.8905-1-david@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190612132526.8905-1-david@redhat.com -> patchew/20190612132526.8905-1-david@redhat.com
Switched to a new branch 'test'
52497e176f s390x/cpumodel: Prepend KDSA features with "KDSA"
29938d0aed s390x/cpumodel: Rework CPU feature definition

=== OUTPUT BEGIN ===
1/2 Checking commit 29938d0aed77 (s390x/cpumodel: Rework CPU feature definition)
ERROR: Macros with complex values should be enclosed in parenthesis
#405: FILE: target/s390x/cpu_features_def.h:18:
+#define DEF_FEAT(_FEAT, ...) S390_FEAT_##_FEAT,

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#760: 
new file mode 100644

WARNING: line over 80 characters
#790: FILE: target/s390x/cpu_features_def.inc.h:26:
+DEF_FEAT(IDTE_SEGMENT, "idtes", STFL, 4, "IDTE selective TLB segment-table clearing")

WARNING: line over 80 characters
#791: FILE: target/s390x/cpu_features_def.inc.h:27:
+DEF_FEAT(IDTE_REGION, "idter", STFL, 5, "IDTE selective TLB region-table clearing")

WARNING: line over 80 characters
#797: FILE: target/s390x/cpu_features_def.inc.h:33:
+DEF_FEAT(CONFIGURATION_TOPOLOGY, "ctop", STFL, 11, "Configuration-topology facility")

ERROR: line over 90 characters
#798: FILE: target/s390x/cpu_features_def.inc.h:34:
+DEF_FEAT(AP_QUERY_CONFIG_INFO, "apqci", STFL, 12, "Query AP Configuration Information facility")

WARNING: line over 80 characters
#800: FILE: target/s390x/cpu_features_def.inc.h:36:
+DEF_FEAT(NONQ_KEY_SETTING, "nonqks", STFL, 14, "Nonquiescing key-setting facility")

WARNING: line over 80 characters
#802: FILE: target/s390x/cpu_features_def.inc.h:38:
+DEF_FEAT(EXTENDED_TRANSLATION_2, "etf2", STFL, 16, "Extended-translation facility 2")

ERROR: line over 90 characters
#803: FILE: target/s390x/cpu_features_def.inc.h:39:
+DEF_FEAT(MSA, "msa-base", STFL, 17, "Message-security-assist facility (excluding subfunctions)")

ERROR: line over 90 characters
#805: FILE: target/s390x/cpu_features_def.inc.h:41:
+DEF_FEAT(LONG_DISPLACEMENT_FAST, "ldisphp", STFL, 19, "Long-displacement facility has high performance")

WARNING: line over 80 characters
#808: FILE: target/s390x/cpu_features_def.inc.h:44:
+DEF_FEAT(EXTENDED_TRANSLATION_3, "etf3", STFL, 22, "Extended-translation facility 3")

WARNING: line over 80 characters
#809: FILE: target/s390x/cpu_features_def.inc.h:45:
+DEF_FEAT(HFP_UNNORMALIZED_EXT, "hfpue", STFL, 23, "HFP-unnormalized-extension facility")

ERROR: line over 90 characters
#813: FILE: target/s390x/cpu_features_def.inc.h:49:
+DEF_FEAT(MOVE_WITH_OPTIONAL_SPEC, "mvcos", STFL, 27, "Move-with-optional-specification facility")

ERROR: line over 90 characters
#814: FILE: target/s390x/cpu_features_def.inc.h:50:
+DEF_FEAT(TOD_CLOCK_STEERING, "tods-base", STFL, 28, "TOD-clock-steering facility (excluding subfunctions)")

ERROR: line over 90 characters
#817: FILE: target/s390x/cpu_features_def.inc.h:53:
+DEF_FEAT(COMPARE_AND_SWAP_AND_STORE, "csst", STFL, 32, "Compare-and-swap-and-store facility")

ERROR: line over 90 characters
#818: FILE: target/s390x/cpu_features_def.inc.h:54:
+DEF_FEAT(COMPARE_AND_SWAP_AND_STORE_2, "csst2", STFL, 33, "Compare-and-swap-and-store facility 2")

ERROR: line over 90 characters
#819: FILE: target/s390x/cpu_features_def.inc.h:55:
+DEF_FEAT(GENERAL_INSTRUCTIONS_EXT, "ginste", STFL, 34, "General-instructions-extension facility")

WARNING: line over 80 characters
#822: FILE: target/s390x/cpu_features_def.inc.h:58:
+DEF_FEAT(FLOATING_POINT_EXT, "fpe", STFL, 37, "Floating-point extension facility")

ERROR: line over 90 characters
#823: FILE: target/s390x/cpu_features_def.inc.h:59:
+DEF_FEAT(ORDER_PRESERVING_COMPRESSION, "opc", STFL, 38, "Order Preserving Compression facility")

WARNING: line over 80 characters
#824: FILE: target/s390x/cpu_features_def.inc.h:60:
+DEF_FEAT(SET_PROGRAM_PARAMETERS, "sprogp", STFL, 40, "Set-program-parameters facility")

ERROR: line over 90 characters
#825: FILE: target/s390x/cpu_features_def.inc.h:61:
+DEF_FEAT(FLOATING_POINT_SUPPPORT_ENH, "fpseh", STFL, 41, "Floating-point-support-enhancement facilities")

ERROR: line over 90 characters
#827: FILE: target/s390x/cpu_features_def.inc.h:63:
+DEF_FEAT(DFP_FAST, "dfphp", STFL, 43, "DFP (decimal-floating-point) facility has high performance")

WARNING: line over 80 characters
#829: FILE: target/s390x/cpu_features_def.inc.h:65:
+DEF_FEAT(STFLE_45, "stfle45", STFL, 45, "Various facilities introduced with z196")

ERROR: line over 90 characters
#831: FILE: target/s390x/cpu_features_def.inc.h:67:
+DEF_FEAT(DFP_ZONED_CONVERSION, "dfpzc", STFL, 48, "Decimal-floating-point zoned-conversion facility")

WARNING: line over 80 characters
#832: FILE: target/s390x/cpu_features_def.inc.h:68:
+DEF_FEAT(STFLE_49, "stfle49", STFL, 49, "Various facilities introduced with zEC12")

ERROR: line over 90 characters
#833: FILE: target/s390x/cpu_features_def.inc.h:69:
+DEF_FEAT(CONSTRAINT_TRANSACTIONAL_EXE, "cte", STFL, 50, "Constrained transactional-execution facility")

WARNING: line over 80 characters
#835: FILE: target/s390x/cpu_features_def.inc.h:71:
+DEF_FEAT(INTERLOCKED_ACCESS_2, "iacc2", STFL, 52, "Interlocked-access facility 2")

WARNING: line over 80 characters
#836: FILE: target/s390x/cpu_features_def.inc.h:72:
+DEF_FEAT(STFLE_53, "stfle53", STFL, 53, "Various facilities introduced with z13")

WARNING: line over 80 characters
#837: FILE: target/s390x/cpu_features_def.inc.h:73:
+DEF_FEAT(ENTROPY_ENC_COMP, "eec", STFL, 54, "Entropy encoding compression facility")

ERROR: line over 90 characters
#838: FILE: target/s390x/cpu_features_def.inc.h:74:
+DEF_FEAT(MSA_EXT_5, "msa5-base", STFL, 57, "Message-security-assist-extension-5 facility (excluding subfunctions)")

ERROR: line over 90 characters
#839: FILE: target/s390x/cpu_features_def.inc.h:75:
+DEF_FEAT(MISC_INSTRUCTION_EXT, "minste2", STFL, 58, "Miscellaneous-instruction-extensions facility 2")

ERROR: line over 90 characters
#841: FILE: target/s390x/cpu_features_def.inc.h:77:
+DEF_FEAT(TIME_SLICE_INSTRUMENTATION, "tsi", STFL, 60, "Time-slice Instrumentation facility")

ERROR: line over 90 characters
#842: FILE: target/s390x/cpu_features_def.inc.h:78:
+DEF_FEAT(MISC_INSTRUCTION_EXT3, "minste3", STFL, 61, "Miscellaneous-Instruction-Extensions Facility 3")

WARNING: line over 80 characters
#843: FILE: target/s390x/cpu_features_def.inc.h:79:
+DEF_FEAT(RUNTIME_INSTRUMENTATION, "ri", STFL, 64, "CPU runtime-instrumentation facility")

ERROR: line over 90 characters
#845: FILE: target/s390x/cpu_features_def.inc.h:81:
+DEF_FEAT(ADAPTER_EVENT_NOTIFICATION, "aen", STFL, 71, "General-purpose-adapter-event-notification facility")

ERROR: line over 90 characters
#846: FILE: target/s390x/cpu_features_def.inc.h:82:
+DEF_FEAT(ADAPTER_INT_SUPPRESSION, "ais", STFL, 72, "General-purpose-adapter-interruption-suppression facility")

ERROR: line over 90 characters
#848: FILE: target/s390x/cpu_features_def.inc.h:84:
+DEF_FEAT(STORE_HYPERVISOR_INFO, "sthyi", STFL, 74, "Store-hypervisor-information facility")

ERROR: line over 90 characters
#849: FILE: target/s390x/cpu_features_def.inc.h:85:
+DEF_FEAT(ACCESS_EXCEPTION_FS_INDICATION, "aefsi", STFL, 75, "Access-exception-fetch/store-indication facility")

ERROR: line over 90 characters
#850: FILE: target/s390x/cpu_features_def.inc.h:86:
+DEF_FEAT(MSA_EXT_3, "msa3-base", STFL, 76, "Message-security-assist-extension-3 facility (excluding subfunctions)")

ERROR: line over 90 characters
#851: FILE: target/s390x/cpu_features_def.inc.h:87:
+DEF_FEAT(MSA_EXT_4, "msa4-base", STFL, 77, "Message-security-assist-extension-4 facility (excluding subfunctions)")

ERROR: line over 90 characters
#853: FILE: target/s390x/cpu_features_def.inc.h:89:
+DEF_FEAT(DFP_PACKED_CONVERSION, "dfppc", STFL, 80, "Decimal-floating-point packed-conversion facility")

ERROR: line over 90 characters
#857: FILE: target/s390x/cpu_features_def.inc.h:93:
+DEF_FEAT(INSTRUCTION_EXEC_PROT, "iep", STFL, 130, "Instruction-execution-protection facility")

ERROR: line over 90 characters
#858: FILE: target/s390x/cpu_features_def.inc.h:94:
+DEF_FEAT(SIDE_EFFECT_ACCESS_ESOP2, "sea_esop2", STFL, 131, "Side-effect-access facility and Enhanced-suppression-on-protection facility 2")

WARNING: line over 80 characters
#860: FILE: target/s390x/cpu_features_def.inc.h:96:
+DEF_FEAT(VECTOR_PACKED_DECIMAL, "vxpd", STFL, 134, "Vector packed decimal facility")

ERROR: line over 90 characters
#863: FILE: target/s390x/cpu_features_def.inc.h:99:
+DEF_FEAT(TEST_PENDING_EXT_INTERRUPTION, "tpei", STFL, 144, "Test-pending-external-interruption facility")

ERROR: line over 90 characters
#864: FILE: target/s390x/cpu_features_def.inc.h:100:
+DEF_FEAT(INSERT_REFERENCE_BITS_MULT, "irbm", STFL, 145, "Insert-reference-bits-multiple facility")

ERROR: line over 90 characters
#865: FILE: target/s390x/cpu_features_def.inc.h:101:
+DEF_FEAT(MSA_EXT_8, "msa8-base", STFL, 146, "Message-security-assist-extension-8 facility (excluding subfunctions)")

WARNING: line over 80 characters
#866: FILE: target/s390x/cpu_features_def.inc.h:102:
+DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facility")

ERROR: line over 90 characters
#868: FILE: target/s390x/cpu_features_def.inc.h:104:
+DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")

ERROR: line over 90 characters
#869: FILE: target/s390x/cpu_features_def.inc.h:105:
+DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")

WARNING: line over 80 characters
#870: FILE: target/s390x/cpu_features_def.inc.h:106:
+DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, "Vector BCD enhancements facility 1")

ERROR: line over 90 characters
#871: FILE: target/s390x/cpu_features_def.inc.h:107:
+DEF_FEAT(MSA_EXT_9, "msa9-base", STFL, 155, "Message-security-assist-extension-9 facility (excluding subfunctions)")

WARNING: line over 80 characters
#874: FILE: target/s390x/cpu_features_def.inc.h:110:
+/* Features exposed via SCLP SCCB Byte 80 - 98  (bit numbers relative to byte-80) */

ERROR: line over 90 characters
#875: FILE: target/s390x/cpu_features_def.inc.h:111:
+DEF_FEAT(SIE_GSLS, "gsls", SCLP_CONF_CHAR, 40, "SIE: Guest-storage-limit-suppression facility")

WARNING: line over 80 characters
#876: FILE: target/s390x/cpu_features_def.inc.h:112:
+DEF_FEAT(ESOP, "esop", SCLP_CONF_CHAR, 46, "Enhanced-suppression-on-protection facility")

ERROR: line over 90 characters
#877: FILE: target/s390x/cpu_features_def.inc.h:113:
+DEF_FEAT(HPMA2, "hpma2", SCLP_CONF_CHAR, 90, "Host page management assist 2 Facility") /* 91-2 */

WARNING: line over 80 characters
#878: FILE: target/s390x/cpu_features_def.inc.h:114:
+DEF_FEAT(SIE_KSS, "kss", SCLP_CONF_CHAR, 151, "SIE: Keyless-subset facility")  /* 98-7 */

WARNING: line over 80 characters
#880: FILE: target/s390x/cpu_features_def.inc.h:116:
+/* Features exposed via SCLP SCCB Byte 116 - 119 (bit numbers relative to byte-116) */

WARNING: line over 80 characters
#881: FILE: target/s390x/cpu_features_def.inc.h:117:
+DEF_FEAT(SIE_64BSCAO, "64bscao", SCLP_CONF_CHAR_EXT, 0, "SIE: 64-bit-SCAO facility")

ERROR: line over 90 characters
#882: FILE: target/s390x/cpu_features_def.inc.h:118:
+DEF_FEAT(SIE_CMMA, "cmma", SCLP_CONF_CHAR_EXT, 1, "SIE: Collaborative-memory-management assist")

WARNING: line over 80 characters
#883: FILE: target/s390x/cpu_features_def.inc.h:119:
+DEF_FEAT(SIE_PFMFI, "pfmfi", SCLP_CONF_CHAR_EXT, 9, "SIE: PFMF interpretation facility")

ERROR: line over 90 characters
#884: FILE: target/s390x/cpu_features_def.inc.h:120:
+DEF_FEAT(SIE_IBS, "ibs", SCLP_CONF_CHAR_EXT, 10, "SIE: Interlock-and-broadcast-suppression facility")

WARNING: line over 80 characters
#887: FILE: target/s390x/cpu_features_def.inc.h:123:
+DEF_FEAT(SIE_F2, "sief2", SCLP_CPU, 4, "SIE: interception format 2 (Virtual SIE)")

WARNING: line over 80 characters
#889: FILE: target/s390x/cpu_features_def.inc.h:125:
+DEF_FEAT(SIE_GPERE, "gpereh", SCLP_CPU, 10, "SIE: Guest-PER enhancement facility")

WARNING: line over 80 characters
#891: FILE: target/s390x/cpu_features_def.inc.h:127:
+DEF_FEAT(SIE_SIGPIF, "sigpif", SCLP_CPU, 12, "SIE: SIGP interpretation facility")

WARNING: line over 80 characters
#893: FILE: target/s390x/cpu_features_def.inc.h:129:
+DEF_FEAT(SIE_CEI, "cei", SCLP_CPU, 43, "SIE: Conditional-external-interception facility")

WARNING: line over 80 characters
#904: FILE: target/s390x/cpu_features_def.inc.h:140:
+DEF_FEAT(PLO_CL, "plo-cl", PLO, 0, "PLO Compare and load (32 bit in general registers)")

WARNING: line over 80 characters
#905: FILE: target/s390x/cpu_features_def.inc.h:141:
+DEF_FEAT(PLO_CLG, "plo-clg", PLO, 1, "PLO Compare and load (64 bit in parameter list)")

ERROR: line over 90 characters
#906: FILE: target/s390x/cpu_features_def.inc.h:142:
+DEF_FEAT(PLO_CLGR, "plo-clgr", PLO, 2, "PLO Compare and load (32 bit in general registers)")

WARNING: line over 80 characters
#907: FILE: target/s390x/cpu_features_def.inc.h:143:
+DEF_FEAT(PLO_CLX, "plo-clx", PLO, 3, "PLO Compare and load (128 bit in parameter list)")

WARNING: line over 80 characters
#908: FILE: target/s390x/cpu_features_def.inc.h:144:
+DEF_FEAT(PLO_CS, "plo-cs", PLO, 4, "PLO Compare and swap (32 bit in general registers)")

WARNING: line over 80 characters
#909: FILE: target/s390x/cpu_features_def.inc.h:145:
+DEF_FEAT(PLO_CSG, "plo-csg", PLO, 5, "PLO Compare and swap (64 bit in parameter list)")

ERROR: line over 90 characters
#910: FILE: target/s390x/cpu_features_def.inc.h:146:
+DEF_FEAT(PLO_CSGR, "plo-csgr", PLO, 6, "PLO Compare and swap (32 bit in general registers)")

WARNING: line over 80 characters
#911: FILE: target/s390x/cpu_features_def.inc.h:147:
+DEF_FEAT(PLO_CSX, "plo-csx", PLO, 7, "PLO Compare and swap (128 bit in parameter list)")

ERROR: line over 90 characters
#912: FILE: target/s390x/cpu_features_def.inc.h:148:
+DEF_FEAT(PLO_DCS, "plo-dcs", PLO, 8, "PLO Double compare and swap (32 bit in general registers)")

ERROR: line over 90 characters
#913: FILE: target/s390x/cpu_features_def.inc.h:149:
+DEF_FEAT(PLO_DCSG, "plo-dcsg", PLO, 9, "PLO Double compare and swap (64 bit in parameter list)")

ERROR: line over 90 characters
#914: FILE: target/s390x/cpu_features_def.inc.h:150:
+DEF_FEAT(PLO_DCSGR, "plo-dcsgr", PLO, 10, "PLO Double compare and swap (32 bit in general registers)")

ERROR: line over 90 characters
#915: FILE: target/s390x/cpu_features_def.inc.h:151:
+DEF_FEAT(PLO_DCSX, "plo-dcsx", PLO, 11, "PLO Double compare and swap (128 bit in parameter list)")

ERROR: line over 90 characters
#916: FILE: target/s390x/cpu_features_def.inc.h:152:
+DEF_FEAT(PLO_CSST, "plo-csst", PLO, 12, "PLO Compare and swap and store (32 bit in general registers)")

ERROR: line over 90 characters
#917: FILE: target/s390x/cpu_features_def.inc.h:153:
+DEF_FEAT(PLO_CSSTG, "plo-csstg", PLO, 13, "PLO Compare and swap and store (64 bit in parameter list)")

ERROR: line over 90 characters
#918: FILE: target/s390x/cpu_features_def.inc.h:154:
+DEF_FEAT(PLO_CSSTGR, "plo-csstgr", PLO, 14, "PLO Compare and swap and store (32 bit in general registers)")

ERROR: line over 90 characters
#919: FILE: target/s390x/cpu_features_def.inc.h:155:
+DEF_FEAT(PLO_CSSTX, "plo-csstx", PLO, 15, "PLO Compare and swap and store (128 bit in parameter list)")

ERROR: line over 90 characters
#920: FILE: target/s390x/cpu_features_def.inc.h:156:
+DEF_FEAT(PLO_CSDST, "plo-csdst", PLO, 16, "PLO Compare and swap and double store (32 bit in general registers)")

ERROR: line over 90 characters
#921: FILE: target/s390x/cpu_features_def.inc.h:157:
+DEF_FEAT(PLO_CSDSTG, "plo-csdstg", PLO, 17, "PLO Compare and swap and double store (64 bit in parameter list)")

ERROR: line over 90 characters
#922: FILE: target/s390x/cpu_features_def.inc.h:158:
+DEF_FEAT(PLO_CSDSTGR, "plo-csdstgr", PLO, 18, "PLO Compare and swap and double store (32 bit in general registers)")

ERROR: line over 90 characters
#923: FILE: target/s390x/cpu_features_def.inc.h:159:
+DEF_FEAT(PLO_CSDSTX, "plo-csdstx", PLO, 19, "PLO Compare and swap and double store (128 bit in parameter list)")

ERROR: line over 90 characters
#924: FILE: target/s390x/cpu_features_def.inc.h:160:
+DEF_FEAT(PLO_CSTST, "plo-cstst", PLO, 20, "PLO Compare and swap and triple store (32 bit in general registers)")

ERROR: line over 90 characters
#925: FILE: target/s390x/cpu_features_def.inc.h:161:
+DEF_FEAT(PLO_CSTSTG, "plo-cststg", PLO, 21, "PLO Compare and swap and triple store (64 bit in parameter list)")

ERROR: line over 90 characters
#926: FILE: target/s390x/cpu_features_def.inc.h:162:
+DEF_FEAT(PLO_CSTSTGR, "plo-cststgr", PLO, 22, "PLO Compare and swap and triple store (32 bit in general registers)")

ERROR: line over 90 characters
#927: FILE: target/s390x/cpu_features_def.inc.h:163:
+DEF_FEAT(PLO_CSTSTX, "plo-cststx", PLO, 23, "PLO Compare and swap and triple store (128 bit in parameter list)")

WARNING: line over 80 characters
#935: FILE: target/s390x/cpu_features_def.inc.h:171:
+DEF_FEAT(PTFF_QSIE, "ptff-qsie", PTFF, 10, "PTFF Query Steering Information Extended")

WARNING: line over 80 characters
#936: FILE: target/s390x/cpu_features_def.inc.h:172:
+DEF_FEAT(PTFF_QTOUE, "ptff-qtoue", PTFF, 13, "PTFF Query TOD Offset User Extended")

WARNING: line over 80 characters
#940: FILE: target/s390x/cpu_features_def.inc.h:176:
+DEF_FEAT(PTFF_STOUE, "ptff-stoue", PTFF, 77, "PTFF Set TOD Offset User Extended")

WARNING: line over 80 characters
#1014: FILE: target/s390x/cpu_features_def.inc.h:250:
+DEF_FEAT(PCKMO_ETDEA_128, "pckmo-etdea-128", PCKMO, 2, "PCKMO Encrypted-TDEA-128-Key")

WARNING: line over 80 characters
#1015: FILE: target/s390x/cpu_features_def.inc.h:251:
+DEF_FEAT(PCKMO_ETDEA_256, "pckmo-etdea-192", PCKMO, 3, "PCKMO Encrypted-TDEA-192-Key")

WARNING: line over 80 characters
#1016: FILE: target/s390x/cpu_features_def.inc.h:252:
+DEF_FEAT(PCKMO_AES_128, "pckmo-aes-128", PCKMO, 18, "PCKMO Encrypted-AES-128-Key")

WARNING: line over 80 characters
#1017: FILE: target/s390x/cpu_features_def.inc.h:253:
+DEF_FEAT(PCKMO_AES_192, "pckmo-aes-192", PCKMO, 19, "PCKMO Encrypted-AES-192-Key")

WARNING: line over 80 characters
#1018: FILE: target/s390x/cpu_features_def.inc.h:254:
+DEF_FEAT(PCKMO_AES_256, "pckmo-aes-256", PCKMO, 20, "PCKMO Encrypted-AES-256-Key")

WARNING: line over 80 characters
#1019: FILE: target/s390x/cpu_features_def.inc.h:255:
+DEF_FEAT(PCKMO_ECC_P256, "pckmo-ecc-p256", PCKMO, 32, "PCKMO Encrypt-ECC-P256-Key")

WARNING: line over 80 characters
#1020: FILE: target/s390x/cpu_features_def.inc.h:256:
+DEF_FEAT(PCKMO_ECC_P384, "pckmo-ecc-p384", PCKMO, 33, "PCKMO Encrypt-ECC-P384-Key")

WARNING: line over 80 characters
#1021: FILE: target/s390x/cpu_features_def.inc.h:257:
+DEF_FEAT(PCKMO_ECC_P521, "pckmo-ecc-p521", PCKMO, 34, "PCKMO Encrypt-ECC-P521-Key")

ERROR: line over 90 characters
#1022: FILE: target/s390x/cpu_features_def.inc.h:258:
+DEF_FEAT(PCKMO_ECC_ED25519, "pckmo-ecc-ed25519", PCKMO, 40 , "PCKMO Encrypt-ECC-Ed25519-Key")

WARNING: line over 80 characters
#1023: FILE: target/s390x/cpu_features_def.inc.h:259:
+DEF_FEAT(PCKMO_ECC_ED448, "pckmo-ecc-ed448", PCKMO, 41 , "PCKMO Encrypt-ECC-Ed448-Key")

WARNING: line over 80 characters
#1030: FILE: target/s390x/cpu_features_def.inc.h:266:
+DEF_FEAT(KMCTR_ETDEA_128, "kmctr-etdea-128", KMCTR, 10, "KMCTR Encrypted-TDEA-128")

WARNING: line over 80 characters
#1031: FILE: target/s390x/cpu_features_def.inc.h:267:
+DEF_FEAT(KMCTR_ETDEA_192, "kmctr-etdea-192", KMCTR, 11, "KMCTR Encrypted-TDEA-192")

WARNING: line over 80 characters
#1068: FILE: target/s390x/cpu_features_def.inc.h:304:
+DEF_FEAT(PCC_CMAC_DEA, "pcc-cmac-dea", PCC, 1, "PCC Compute-Last-Block-CMAC-Using-DEA")

ERROR: line over 90 characters
#1069: FILE: target/s390x/cpu_features_def.inc.h:305:
+DEF_FEAT(PCC_CMAC_TDEA_128, "pcc-cmac-tdea-128", PCC, 2, "PCC Compute-Last-Block-CMAC-Using-TDEA-128")

ERROR: line over 90 characters
#1070: FILE: target/s390x/cpu_features_def.inc.h:306:
+DEF_FEAT(PCC_CMAC_TDEA_192, "pcc-cmac-tdea-192", PCC, 3, "PCC Compute-Last-Block-CMAC-Using-TDEA-192")

ERROR: line over 90 characters
#1071: FILE: target/s390x/cpu_features_def.inc.h:307:
+DEF_FEAT(PCC_CMAC_ETDEA_128, "pcc-cmac-edea", PCC, 9, "PCC Compute-Last-Block-CMAC-Using-Encrypted-DEA")

ERROR: line over 90 characters
#1072: FILE: target/s390x/cpu_features_def.inc.h:308:
+DEF_FEAT(PCC_CMAC_ETDEA_192, "pcc-cmac-etdea-128", PCC, 10, "PCC Compute-Last-Block-CMAC-Using-Encrypted-TDEA-128")

ERROR: line over 90 characters
#1073: FILE: target/s390x/cpu_features_def.inc.h:309:
+DEF_FEAT(PCC_CMAC_TDEA, "pcc-cmac-etdea-192", PCC, 11, "PCC Compute-Last-Block-CMAC-Using-EncryptedTDEA-192")

ERROR: line over 90 characters
#1074: FILE: target/s390x/cpu_features_def.inc.h:310:
+DEF_FEAT(PCC_CMAC_AES_128, "pcc-cmac-aes-128", PCC, 18, "PCC Compute-Last-Block-CMAC-Using-AES-128")

ERROR: line over 90 characters
#1075: FILE: target/s390x/cpu_features_def.inc.h:311:
+DEF_FEAT(PCC_CMAC_AES_192, "pcc-cmac-aes-192", PCC, 19, "PCC Compute-Last-Block-CMAC-Using-AES-192")

ERROR: line over 90 characters
#1076: FILE: target/s390x/cpu_features_def.inc.h:312:
+DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-eaes-256", PCC, 20, "PCC Compute-Last-Block-CMAC-Using-AES-256")

ERROR: line over 90 characters
#1077: FILE: target/s390x/cpu_features_def.inc.h:313:
+DEF_FEAT(PCC_CMAC_EAES_128, "pcc-cmac-eaes-128", PCC, 26, "PCC Compute-Last-Block-CMAC-Using-Encrypted-AES-128")

ERROR: line over 90 characters
#1078: FILE: target/s390x/cpu_features_def.inc.h:314:
+DEF_FEAT(PCC_CMAC_EAES_192, "pcc-cmac-eaes-192", PCC, 27, "PCC Compute-Last-Block-CMAC-Using-Encrypted-AES-192")

ERROR: line over 90 characters
#1079: FILE: target/s390x/cpu_features_def.inc.h:315:
+DEF_FEAT(PCC_CMAC_EAES_256, "pcc-cmac-eaes-256", PCC, 28, "PCC Compute-Last-Block-CMAC-Using-Encrypted-AES-256")

ERROR: line over 90 characters
#1080: FILE: target/s390x/cpu_features_def.inc.h:316:
+DEF_FEAT(PCC_XTS_AES_128, "pcc-xts-aes-128", PCC, 50, "PCC Compute-XTS-Parameter-Using-AES-128")

ERROR: line over 90 characters
#1081: FILE: target/s390x/cpu_features_def.inc.h:317:
+DEF_FEAT(PCC_XTS_AES_256, "pcc-xts-aes-256", PCC, 52, "PCC Compute-XTS-Parameter-Using-AES-256")

ERROR: line over 90 characters
#1082: FILE: target/s390x/cpu_features_def.inc.h:318:
+DEF_FEAT(PCC_XTS_EAES_128, "pcc-xts-eaes-128", PCC, 58, "PCC Compute-XTS-Parameter-Using-Encrypted-AES-128")

ERROR: line over 90 characters
#1083: FILE: target/s390x/cpu_features_def.inc.h:319:
+DEF_FEAT(PCC_XTS_EAES_256, "pcc-xts-eaes-256", PCC, 60, "PCC Compute-XTS-Parameter-Using-Encrypted-AES-256")

ERROR: line over 90 characters
#1084: FILE: target/s390x/cpu_features_def.inc.h:320:
+DEF_FEAT(PCC_SCALAR_MULT_P256, "pcc-scalar-mult-p256", PCC, 64, "PCC Scalar-Multiply-P256")

ERROR: line over 90 characters
#1085: FILE: target/s390x/cpu_features_def.inc.h:321:
+DEF_FEAT(PCC_SCALAR_MULT_P384, "pcc-scalar-mult-p384", PCC, 65, "PCC Scalar-Multiply-P384")

ERROR: line over 90 characters
#1086: FILE: target/s390x/cpu_features_def.inc.h:322:
+DEF_FEAT(PCC_SCALAR_MULT_P512, "pcc-scalar-mult-p521", PCC, 66, "PCC Scalar-Multiply-P521")

ERROR: line over 90 characters
#1087: FILE: target/s390x/cpu_features_def.inc.h:323:
+DEF_FEAT(PCC_SCALAR_MULT_ED25519, "pcc-scalar-mult-ed25519", PCC, 72, "PCC Scalar-Multiply-Ed25519")

ERROR: line over 90 characters
#1088: FILE: target/s390x/cpu_features_def.inc.h:324:
+DEF_FEAT(PCC_SCALAR_MULT_ED448, "pcc-scalar-mult-ed448", PCC, 73, "PCC Scalar-Multiply-Ed448")

ERROR: line over 90 characters
#1089: FILE: target/s390x/cpu_features_def.inc.h:325:
+DEF_FEAT(PCC_SCALAR_MULT_X25519, "pcc-scalar-mult-x25519", PCC, 80, "PCC Scalar-Multiply-X25519")

ERROR: line over 90 characters
#1090: FILE: target/s390x/cpu_features_def.inc.h:326:
+DEF_FEAT(PCC_SCALAR_MULT_X448, "pcc-scalar-mult-x448", PCC, 81, "PCC Scalar-Multiply-X448")

ERROR: line over 90 characters
#1094: FILE: target/s390x/cpu_features_def.inc.h:330:
+DEF_FEAT(PRNO_TRNG_QRTCR, "prno-trng-qrtcr", PPNO, 112, "PRNO TRNG-Query-Raw-to-Conditioned-Ratio")

WARNING: line over 80 characters
#1101: FILE: target/s390x/cpu_features_def.inc.h:337:
+DEF_FEAT(KMA_GCM_EAES_128, "kma-gcm-eaes-128", KMA, 26, "KMA GCM-Encrypted-AES-128")

WARNING: line over 80 characters
#1102: FILE: target/s390x/cpu_features_def.inc.h:338:
+DEF_FEAT(KMA_GCM_EAES_192, "kma-gcm-eaes-192", KMA, 27, "KMA GCM-Encrypted-AES-192")

WARNING: line over 80 characters
#1103: FILE: target/s390x/cpu_features_def.inc.h:339:
+DEF_FEAT(KMA_GCM_EAES_256, "kma-gcm-eaes-256", KMA, 28, "KMA GCM-Encrypted-AES-256")

WARNING: line over 80 characters
#1106: FILE: target/s390x/cpu_features_def.inc.h:342:
+DEF_FEAT(ECDSA_VERIFY_P256, "kdsa-ecdsa-verify-p256", KDSA, 1, "KDSA ECDSA-Verify-P256")

WARNING: line over 80 characters
#1107: FILE: target/s390x/cpu_features_def.inc.h:343:
+DEF_FEAT(ECDSA_VERIFY_P384, "kdsa-ecdsa-verify-p384", KDSA, 2, "KDSA ECDSA-Verify-P384")

WARNING: line over 80 characters
#1108: FILE: target/s390x/cpu_features_def.inc.h:344:
+DEF_FEAT(ECDSA_VERIFY_P512, "kdsa-ecdsa-verify-p521", KDSA, 3, "KDSA ECDSA-Verify-P521")

WARNING: line over 80 characters
#1109: FILE: target/s390x/cpu_features_def.inc.h:345:
+DEF_FEAT(ECDSA_SIGN_P256, "kdsa-ecdsa-sign-p256", KDSA, 9, "KDSA ECDSA-Sign-P256")

WARNING: line over 80 characters
#1110: FILE: target/s390x/cpu_features_def.inc.h:346:
+DEF_FEAT(ECDSA_SIGN_P384, "kdsa-ecdsa-sign-p384", KDSA, 10, "KDSA ECDSA-Sign-P384")

WARNING: line over 80 characters
#1111: FILE: target/s390x/cpu_features_def.inc.h:347:
+DEF_FEAT(ECDSA_SIGN_P512, "kdsa-ecdsa-sign-p521", KDSA, 11, "KDSA ECDSA-Sign-P521")

ERROR: line over 90 characters
#1112: FILE: target/s390x/cpu_features_def.inc.h:348:
+DEF_FEAT(EECDSA_SIGN_P256, "kdsa-eecdsa-sign-p256", KDSA, 17, "KDSA Encrypted-ECDSA-Sign-P256")

ERROR: line over 90 characters
#1113: FILE: target/s390x/cpu_features_def.inc.h:349:
+DEF_FEAT(EECDSA_SIGN_P384, "kdsa-eecdsa-sign-p384", KDSA, 18, "KDSA Encrypted-ECDSA-Sign-P384")

ERROR: line over 90 characters
#1114: FILE: target/s390x/cpu_features_def.inc.h:350:
+DEF_FEAT(EECDSA_SIGN_P512, "kdsa-eecdsa-sign-p521", KDSA, 19, "KDSA Encrypted-ECDSA-Sign-P521")

ERROR: line over 90 characters
#1115: FILE: target/s390x/cpu_features_def.inc.h:351:
+DEF_FEAT(EDDSA_VERIFY_ED25519, "kdsa-eddsa-verify-ed25519", KDSA, 32, "KDSA EdDSA-Verify-Ed25519")

ERROR: line over 90 characters
#1116: FILE: target/s390x/cpu_features_def.inc.h:352:
+DEF_FEAT(EDDSA_VERIFY_ED448, "kdsa-eddsa-verify-ed448", KDSA, 36, "KDSA EdDSA-Verify-Ed448")

ERROR: line over 90 characters
#1117: FILE: target/s390x/cpu_features_def.inc.h:353:
+DEF_FEAT(EDDSA_SIGN_ED25519, "kdsa-eddsa-sign-ed25519", KDSA, 40, "KDSA EdDSA-Sign-Ed25519")

WARNING: line over 80 characters
#1118: FILE: target/s390x/cpu_features_def.inc.h:354:
+DEF_FEAT(EDDSA_SIGN_ED448, "kdsa-eddsa-sign-ed448", KDSA, 44, "KDSA EdDSA-Sign-Ed448")

ERROR: line over 90 characters
#1119: FILE: target/s390x/cpu_features_def.inc.h:355:
+DEF_FEAT(EEDDSA_SIGN_ED25519, "kdsa-eeddsa-sign-ed25519", KDSA, 48, "KDSA Encrypted-EdDSA-Sign-Ed25519")

ERROR: line over 90 characters
#1120: FILE: target/s390x/cpu_features_def.inc.h:356:
+DEF_FEAT(EEDDSA_SIGN_ED448, "kdsa-eeddsa-sign-ed448", KDSA, 52, "KDSA Encrypted-EdDSA-Sign-Ed448")

WARNING: line over 80 characters
#1133: FILE: target/s390x/cpu_features_def.inc.h:369:
+DEF_FEAT(DEFLATE_F0, "dfltcc-f0", DFLTCC, 192, "DFLTCC format 0 parameter-block")

total: 87 errors, 61 warnings, 1103 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit 52497e176fe9 (s390x/cpumodel: Prepend KDSA features with "KDSA")
ERROR: line over 90 characters
#35: FILE: target/s390x/cpu_features_def.inc.h:342:
+DEF_FEAT(KDSA_ECDSA_VERIFY_P256, "kdsa-ecdsa-verify-p256", KDSA, 1, "KDSA ECDSA-Verify-P256")

ERROR: line over 90 characters
#36: FILE: target/s390x/cpu_features_def.inc.h:343:
+DEF_FEAT(KDSA_ECDSA_VERIFY_P384, "kdsa-ecdsa-verify-p384", KDSA, 2, "KDSA ECDSA-Verify-P384")

ERROR: line over 90 characters
#37: FILE: target/s390x/cpu_features_def.inc.h:344:
+DEF_FEAT(KDSA_ECDSA_VERIFY_P512, "kdsa-ecdsa-verify-p521", KDSA, 3, "KDSA ECDSA-Verify-P521")

WARNING: line over 80 characters
#38: FILE: target/s390x/cpu_features_def.inc.h:345:
+DEF_FEAT(KDSA_ECDSA_SIGN_P256, "kdsa-ecdsa-sign-p256", KDSA, 9, "KDSA ECDSA-Sign-P256")

WARNING: line over 80 characters
#39: FILE: target/s390x/cpu_features_def.inc.h:346:
+DEF_FEAT(KDSA_ECDSA_SIGN_P384, "kdsa-ecdsa-sign-p384", KDSA, 10, "KDSA ECDSA-Sign-P384")

WARNING: line over 80 characters
#40: FILE: target/s390x/cpu_features_def.inc.h:347:
+DEF_FEAT(KDSA_ECDSA_SIGN_P512, "kdsa-ecdsa-sign-p521", KDSA, 11, "KDSA ECDSA-Sign-P521")

ERROR: line over 90 characters
#41: FILE: target/s390x/cpu_features_def.inc.h:348:
+DEF_FEAT(KDSA_EECDSA_SIGN_P256, "kdsa-eecdsa-sign-p256", KDSA, 17, "KDSA Encrypted-ECDSA-Sign-P256")

ERROR: line over 90 characters
#42: FILE: target/s390x/cpu_features_def.inc.h:349:
+DEF_FEAT(KDSA_EECDSA_SIGN_P384, "kdsa-eecdsa-sign-p384", KDSA, 18, "KDSA Encrypted-ECDSA-Sign-P384")

ERROR: line over 90 characters
#43: FILE: target/s390x/cpu_features_def.inc.h:350:
+DEF_FEAT(KDSA_EECDSA_SIGN_P512, "kdsa-eecdsa-sign-p521", KDSA, 19, "KDSA Encrypted-ECDSA-Sign-P521")

ERROR: line over 90 characters
#44: FILE: target/s390x/cpu_features_def.inc.h:351:
+DEF_FEAT(KDSA_EDDSA_VERIFY_ED25519, "kdsa-eddsa-verify-ed25519", KDSA, 32, "KDSA EdDSA-Verify-Ed25519")

ERROR: line over 90 characters
#45: FILE: target/s390x/cpu_features_def.inc.h:352:
+DEF_FEAT(KDSA_EDDSA_VERIFY_ED448, "kdsa-eddsa-verify-ed448", KDSA, 36, "KDSA EdDSA-Verify-Ed448")

ERROR: line over 90 characters
#46: FILE: target/s390x/cpu_features_def.inc.h:353:
+DEF_FEAT(KDSA_EDDSA_SIGN_ED25519, "kdsa-eddsa-sign-ed25519", KDSA, 40, "KDSA EdDSA-Sign-Ed25519")

ERROR: line over 90 characters
#47: FILE: target/s390x/cpu_features_def.inc.h:354:
+DEF_FEAT(KDSA_EDDSA_SIGN_ED448, "kdsa-eddsa-sign-ed448", KDSA, 44, "KDSA EdDSA-Sign-Ed448")

ERROR: line over 90 characters
#48: FILE: target/s390x/cpu_features_def.inc.h:355:
+DEF_FEAT(KDSA_EEDDSA_SIGN_ED25519, "kdsa-eeddsa-sign-ed25519", KDSA, 48, "KDSA Encrypted-EdDSA-Sign-Ed25519")

ERROR: line over 90 characters
#49: FILE: target/s390x/cpu_features_def.inc.h:356:
+DEF_FEAT(KDSA_EEDDSA_SIGN_ED448, "kdsa-eeddsa-sign-ed448", KDSA, 52, "KDSA Encrypted-EdDSA-Sign-Ed448")

total: 12 errors, 3 warnings, 72 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190612132526.8905-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com