tests/tcg/s390x: Fix alignment of csst parameter list

[Qemu-devel] [PATCH] tests/tcg/s390x: Fix alignment of csst parameter list

Richard Henderson posted 1 patch 4 years, 11 months ago

Download mbox

Test s390x passed

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190610014249.7346-1-richard.henderson@linaro.org

Maintainers: David Hildenbrand <david@redhat.com>, Richard Henderson <rth@twiddle.net>, Cornelia Huck <cohuck@redhat.com>

tests/tcg/s390x/csst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] tests/tcg/s390x: Fix alignment of csst parameter list

Posted by Richard Henderson 4 years, 11 months ago

The parameter list given in general register 1 shall be aligned
on a quadword boundary.  This test currently succeeds or fails
depending on the compiler version used and the accidential layout
of the function's stack frame.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tests/tcg/s390x/csst.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/tcg/s390x/csst.c b/tests/tcg/s390x/csst.c
index 1dae9071fb..084d80af49 100644
--- a/tests/tcg/s390x/csst.c
+++ b/tests/tcg/s390x/csst.c
@@ -3,7 +3,7 @@
 
 int main(void)
 {
-    uint64_t parmlist[] = {
+    uint64_t parmlist[] __attribute__((aligned(16))) = {
         0xfedcba9876543210ull,
         0,
         0x7777777777777777ull,
-- 
2.17.1

Re: [Qemu-devel] [PATCH] tests/tcg/s390x: Fix alignment of csst parameter list

Posted by David Hildenbrand 4 years, 11 months ago

On 10.06.19 03:42, Richard Henderson wrote:
> The parameter list given in general register 1 shall be aligned
> on a quadword boundary.  This test currently succeeds or fails
> depending on the compiler version used and the accidential layout
> of the function's stack frame.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tests/tcg/s390x/csst.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/tcg/s390x/csst.c b/tests/tcg/s390x/csst.c
> index 1dae9071fb..084d80af49 100644
> --- a/tests/tcg/s390x/csst.c
> +++ b/tests/tcg/s390x/csst.c
> @@ -3,7 +3,7 @@
>  
>  int main(void)
>  {
> -    uint64_t parmlist[] = {
> +    uint64_t parmlist[] __attribute__((aligned(16))) = {
>          0xfedcba9876543210ull,
>          0,
>          0x7777777777777777ull,
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

Queuing it to

https://github.com/davidhildenbrand/qemu.git s390-tcg-next

for now. Let me know if you want to send this via a different PULL
request yourself.

-- 

Thanks,

David / dhildenb

Re: [Qemu-devel] [PATCH] tests/tcg/s390x: Fix alignment of csst parameter list

Posted by Richard Henderson 4 years, 11 months ago

On 6/11/19 6:06 AM, David Hildenbrand wrote:
> Queuing it to
> 
> https://github.com/davidhildenbrand/qemu.git s390-tcg-next
> 
> for now. Let me know if you want to send this via a different PULL
> request yourself.

No, that's perfect, thanks.


r~