[v18] Add RX archtecture support

[Qemu-devel] [PATCH v18 28/29] hw/rx: Fix comments

Posted by Philippe Mathieu-Daudé 6 years, 8 months ago

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/rx/rx-virt.c | 2 +-
 hw/rx/rx62n.c   | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/rx/rx-virt.c b/hw/rx/rx-virt.c
index 49d04d22ea..53f43f62bd 100644
--- a/hw/rx/rx-virt.c
+++ b/hw/rx/rx-virt.c
@@ -55,7 +55,7 @@ static void rxvirt_init(MachineState *machine)
                            &error_fatal);
     memory_region_add_subregion(sysmem, SDRAM_BASE, sdram);
 
-    /* Initalize CPU */
+    /* Initalize MCU */
     object_initialize_child(OBJECT(machine), "mcu", s,
                             sizeof(RX62NState), TYPE_RX62N,
                             &error_fatal, NULL);
diff --git a/hw/rx/rx62n.c b/hw/rx/rx62n.c
index e55257c622..a8ed88ef27 100644
--- a/hw/rx/rx62n.c
+++ b/hw/rx/rx62n.c
@@ -1,5 +1,5 @@
 /*
- * RX62N device
+ * RX62N Microcontroller
  *
  * Datasheet: RX62N Group, RX621 Group User's Manual: Hardware
  * (Rev.1.40 R01UH0033EJ0140)
@@ -202,6 +202,7 @@ static void rx62n_realize(DeviceState *dev, Error **errp)
         }
     }
 
+    /* Initalize CPU */
     object_initialize_child(OBJECT(s), "cpu", &s->cpu,
                             sizeof(RXCPU), RX_CPU_TYPE_NAME("rx62n"),
                             errp, NULL);
-- 
2.20.1

Re: [Qemu-devel] [PATCH v18 28/29] hw/rx: Fix comments

Posted by Peter Maydell 6 years, 8 months ago

On Fri, 7 Jun 2019 at 17:52, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/rx/rx-virt.c | 2 +-
>  hw/rx/rx62n.c   | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/rx/rx-virt.c b/hw/rx/rx-virt.c
> index 49d04d22ea..53f43f62bd 100644
> --- a/hw/rx/rx-virt.c
> +++ b/hw/rx/rx-virt.c
> @@ -55,7 +55,7 @@ static void rxvirt_init(MachineState *machine)
>                             &error_fatal);
>      memory_region_add_subregion(sysmem, SDRAM_BASE, sdram);
>
> -    /* Initalize CPU */
> +    /* Initalize MCU */

typo: "Initialize" (extra 'i').

>
> +    /* Initalize CPU */
>      object_initialize_child(OBJECT(s), "cpu", &s->cpu,
>                              sizeof(RXCPU), RX_CPU_TYPE_NAME("rx62n"),
>                              errp, NULL);

ditto.

thanks
-- PMM