kvm-all: Add/update fprintf's for kvm_*_ioeventfd_del

[Qemu-devel] [PATCH] kvm-all: Add/update fprintf's for kvm_*_ioeventfd_del

Posted by Yury Kotov 6 years, 5 months ago

Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>
---
 accel/kvm/kvm-all.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 524c4ddfbd..e4ac3386cb 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -864,8 +864,8 @@ static void kvm_mem_ioeventfd_add(MemoryListener *listener,
                                data, true, int128_get64(section->size),
                                match_data);
     if (r < 0) {
-        fprintf(stderr, "%s: error adding ioeventfd: %s\n",
-                __func__, strerror(-r));
+        fprintf(stderr, "%s: error adding ioeventfd: %s (%d)\n",
+                __func__, strerror(-r), -r);
         abort();
     }
 }
@@ -882,6 +882,8 @@ static void kvm_mem_ioeventfd_del(MemoryListener *listener,
                                data, false, int128_get64(section->size),
                                match_data);
     if (r < 0) {
+        fprintf(stderr, "%s: error deleting ioeventfd: %s (%d)\n",
+                __func__, strerror(-r), -r);
         abort();
     }
 }
@@ -898,8 +900,8 @@ static void kvm_io_ioeventfd_add(MemoryListener *listener,
                               data, true, int128_get64(section->size),
                               match_data);
     if (r < 0) {
-        fprintf(stderr, "%s: error adding ioeventfd: %s\n",
-                __func__, strerror(-r));
+        fprintf(stderr, "%s: error adding ioeventfd: %s (%d)\n",
+                __func__, strerror(-r), -r);
         abort();
     }
 }
@@ -917,6 +919,8 @@ static void kvm_io_ioeventfd_del(MemoryListener *listener,
                               data, false, int128_get64(section->size),
                               match_data);
     if (r < 0) {
+        fprintf(stderr, "%s: error deleting ioeventfd: %s (%d)\n",
+                __func__, strerror(-r), -r);
         abort();
     }
 }
-- 
2.21.0

Re: [Qemu-devel] [PATCH] kvm-all: Add/update fprintf's for kvm_*_ioeventfd_del

Posted by Paolo Bonzini 6 years, 5 months ago

On 07/06/19 11:08, Yury Kotov wrote:
> Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>
> ---
>  accel/kvm/kvm-all.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index 524c4ddfbd..e4ac3386cb 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -864,8 +864,8 @@ static void kvm_mem_ioeventfd_add(MemoryListener *listener,
>                                 data, true, int128_get64(section->size),
>                                 match_data);
>      if (r < 0) {
> -        fprintf(stderr, "%s: error adding ioeventfd: %s\n",
> -                __func__, strerror(-r));
> +        fprintf(stderr, "%s: error adding ioeventfd: %s (%d)\n",
> +                __func__, strerror(-r), -r);
>          abort();
>      }
>  }
> @@ -882,6 +882,8 @@ static void kvm_mem_ioeventfd_del(MemoryListener *listener,
>                                 data, false, int128_get64(section->size),
>                                 match_data);
>      if (r < 0) {
> +        fprintf(stderr, "%s: error deleting ioeventfd: %s (%d)\n",
> +                __func__, strerror(-r), -r);
>          abort();
>      }
>  }
> @@ -898,8 +900,8 @@ static void kvm_io_ioeventfd_add(MemoryListener *listener,
>                                data, true, int128_get64(section->size),
>                                match_data);
>      if (r < 0) {
> -        fprintf(stderr, "%s: error adding ioeventfd: %s\n",
> -                __func__, strerror(-r));
> +        fprintf(stderr, "%s: error adding ioeventfd: %s (%d)\n",
> +                __func__, strerror(-r), -r);
>          abort();
>      }
>  }
> @@ -917,6 +919,8 @@ static void kvm_io_ioeventfd_del(MemoryListener *listener,
>                                data, false, int128_get64(section->size),
>                                match_data);
>      if (r < 0) {
> +        fprintf(stderr, "%s: error deleting ioeventfd: %s (%d)\n",
> +                __func__, strerror(-r), -r);
>          abort();
>      }
>  }
> 

Queued, thanks.

Paolo