ppc/pnv: activate the "dumpdtb" option on the powernv machine

[Qemu-devel] [PATCH] ppc/pnv: activate the "dumpdtb" option on the powernv machine

Cédric Le Goater posted 1 patch 6 years, 5 months ago

Download mbox

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test FreeBSD passed

Test s390x passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190606174732.13051-1-clg@kaod.org

Maintainers: David Gibson <david@gibson.dropbear.id.au>, "Cédric Le Goater" <clg@kaod.org>

hw/ppc/pnv.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[Qemu-devel] [PATCH] ppc/pnv: activate the "dumpdtb" option on the powernv machine

Posted by Cédric Le Goater 6 years, 5 months ago

This is a good way to debug the DT creation for current PowerNV
machines and new ones to come.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/ppc/pnv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 046f0a83c8e5..ed6892466793 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -23,6 +23,7 @@
 #include "sysemu/sysemu.h"
 #include "sysemu/numa.h"
 #include "sysemu/cpus.h"
+#include "sysemu/device_tree.h"
 #include "hw/hw.h"
 #include "target/ppc/cpu.h"
 #include "qemu/log.h"
@@ -554,6 +555,7 @@ static void pnv_reset(void)
     /* Pack resulting tree */
     _FDT((fdt_pack(fdt)));
 
+    qemu_fdt_dumpdtb(fdt, fdt_totalsize(fdt));
     cpu_physical_memory_write(PNV_FDT_ADDR, fdt, fdt_totalsize(fdt));
 }
 
-- 
2.21.0

Re: [Qemu-devel] [PATCH] ppc/pnv: activate the "dumpdtb" option on the powernv machine

Posted by David Gibson 6 years, 5 months ago

On Thu, Jun 06, 2019 at 07:47:32PM +0200, Cédric Le Goater wrote:
> This is a good way to debug the DT creation for current PowerNV
> machines and new ones to come.
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>

Applied, thanks.

> ---
>  hw/ppc/pnv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 046f0a83c8e5..ed6892466793 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -23,6 +23,7 @@
>  #include "sysemu/sysemu.h"
>  #include "sysemu/numa.h"
>  #include "sysemu/cpus.h"
> +#include "sysemu/device_tree.h"
>  #include "hw/hw.h"
>  #include "target/ppc/cpu.h"
>  #include "qemu/log.h"
> @@ -554,6 +555,7 @@ static void pnv_reset(void)
>      /* Pack resulting tree */
>      _FDT((fdt_pack(fdt)));
>  
> +    qemu_fdt_dumpdtb(fdt, fdt_totalsize(fdt));
>      cpu_physical_memory_write(PNV_FDT_ADDR, fdt, fdt_totalsize(fdt));
>  }
>  

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [Qemu-devel] [PATCH] ppc/pnv: activate the "dumpdtb" option on the powernv machine

Posted by Greg Kurz 6 years, 5 months ago

On Thu,  6 Jun 2019 19:47:32 +0200
Cédric Le Goater <clg@kaod.org> wrote:

> This is a good way to debug the DT creation for current PowerNV
> machines and new ones to come.
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---

Reviewed-by: Greg Kurz <groug@kaod.org>

>  hw/ppc/pnv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 046f0a83c8e5..ed6892466793 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -23,6 +23,7 @@
>  #include "sysemu/sysemu.h"
>  #include "sysemu/numa.h"
>  #include "sysemu/cpus.h"
> +#include "sysemu/device_tree.h"
>  #include "hw/hw.h"
>  #include "target/ppc/cpu.h"
>  #include "qemu/log.h"
> @@ -554,6 +555,7 @@ static void pnv_reset(void)
>      /* Pack resulting tree */
>      _FDT((fdt_pack(fdt)));
>  
> +    qemu_fdt_dumpdtb(fdt, fdt_totalsize(fdt));
>      cpu_physical_memory_write(PNV_FDT_ADDR, fdt, fdt_totalsize(fdt));
>  }
>