[Qemu-devel] [PATCH v2 0/2] Deferred incoming migration through fd

Yury Kotov posted 2 patches 4 years, 11 months ago
Test s390x failed
Test checkpatch passed
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190528091633.12246-1-yury-kotov@yandex-team.ru
Maintainers: Juan Quintela <quintela@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
migration/fd.c         |   8 ++--
migration/fd.h         |   2 +-
tests/libqtest.c       |  80 ++++++++++++++++++++++++++++++--
tests/libqtest.h       |  51 ++++++++++++++++++++-
tests/migration-test.c | 101 +++++++++++++++++++++++++++++++++++++++++
5 files changed, 233 insertions(+), 9 deletions(-)
[Qemu-devel] [PATCH v2 0/2] Deferred incoming migration through fd
Posted by Yury Kotov 4 years, 11 months ago
Hi,

V2:
* Revert odd changes in migrate()
* Add short description for socket_send_fds()
  and remove ifdef WIN32 as it's not needed

This series is a continuation of the previous two:
* migration: Fix handling fd protocol
* Add 'inline-fd:' protocol for migration

It's about such use case:
1. Target VM: exec ...,-incoming defer
2. Target VM: getfd("fd-mig")
3. Target VM: migrate-incoming("fd:"fd-mig")
4. Source VM: getfd("fd-mig")
5. Source VM: migrate("fd-mig")

Currently, it's not possible to do the step 3, because for incoming migration
"fd:" protocol expects an integer, not the name of fd.

Yury Kotov (2):
  migration: Fix fd protocol for incoming defer
  migration-test: Add a test for fd protocol

 migration/fd.c         |   8 ++--
 migration/fd.h         |   2 +-
 tests/libqtest.c       |  80 ++++++++++++++++++++++++++++++--
 tests/libqtest.h       |  51 ++++++++++++++++++++-
 tests/migration-test.c | 101 +++++++++++++++++++++++++++++++++++++++++
 5 files changed, 233 insertions(+), 9 deletions(-)

-- 
2.21.0


Re: [Qemu-devel] [PATCH v2 0/2] Deferred incoming migration through fd
Posted by Peter Xu 4 years, 11 months ago
On Tue, May 28, 2019 at 12:16:31PM +0300, Yury Kotov wrote:
> Hi,
> 
> V2:
> * Revert odd changes in migrate()
> * Add short description for socket_send_fds()
>   and remove ifdef WIN32 as it's not needed
> 
> This series is a continuation of the previous two:
> * migration: Fix handling fd protocol
> * Add 'inline-fd:' protocol for migration
> 
> It's about such use case:
> 1. Target VM: exec ...,-incoming defer
> 2. Target VM: getfd("fd-mig")
> 3. Target VM: migrate-incoming("fd:"fd-mig")
> 4. Source VM: getfd("fd-mig")
> 5. Source VM: migrate("fd-mig")
> 
> Currently, it's not possible to do the step 3, because for incoming migration
> "fd:" protocol expects an integer, not the name of fd.

Reviewed-by: Peter Xu <peterx@redhat.com>

I gave a quick shot on the new test - it runs well.

-- 
Peter Xu