[v2] Update documentation and help related to the preallocation parameter

[Qemu-devel] [PATCH v2 0/3] Update documentation and help related to the preallocation parameter

Stefano Garzarella posted 3 patches 4 years, 11 months ago

Diff against v1
Download series mbox

Test FreeBSD passed

Test docker-clang@ubuntu passed

Test s390x passed

Test docker-mingw@fedora passed

Test checkpatch passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190524075848.23781-1-sgarzare@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>, Max Reitz <mreitz@redhat.com>

qapi/block-core.json | 20 ++++++++++++++------
block/file-posix.c   |  6 +++++-
block/gluster.c      |  9 ++++++++-
3 files changed, 27 insertions(+), 8 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/3] Update documentation and help related to the preallocation parameter

Posted by Stefano Garzarella 4 years, 11 months ago

Following Markus' advice, I updated the documentation of preallocation
parameter in qapi/block-core.json adding default and allowed values (patch 1).
I also updated the help related to BLOCK_OPT_PREALLOC in the QemuOptsList of
file-posix (patch 2) and gluster (patch 3).

v2:
 - Patch 1: removed references to "file-win32" and "file-posix" in the
            block comment [Markus]
 - Patch 3: reworded commit message [Markus]

Stefano Garzarella (3):
  qapi/block-core: update documentation of preallocation parameter
  block/file-posix: update .help of BLOCK_OPT_PREALLOC option
  block/gluster: update .help of BLOCK_OPT_PREALLOC option

 qapi/block-core.json | 20 ++++++++++++++------
 block/file-posix.c   |  6 +++++-
 block/gluster.c      |  9 ++++++++-
 3 files changed, 27 insertions(+), 8 deletions(-)

-- 
2.20.1

Re: [Qemu-devel] [PATCH v2 0/3] Update documentation and help related to the preallocation parameter

Posted by Markus Armbruster 4 years, 11 months ago

Kevin, Max, this series looks ready to me.  Feel free to ask me to take
it through my tree.

Re: [Qemu-devel] [PATCH v2 0/3] Update documentation and help related to the preallocation parameter

Posted by Max Reitz 4 years, 11 months ago

On 28.05.19 08:15, Markus Armbruster wrote:
> Kevin, Max, this series looks ready to me.  Feel free to ask me to take
> it through my tree.

*ask*

:-)

Re: [Qemu-devel] [PATCH v2 0/3] Update documentation and help related to the preallocation parameter

Posted by Markus Armbruster 4 years, 11 months ago

Stefano Garzarella <sgarzare@redhat.com> writes:

> Following Markus' advice, I updated the documentation of preallocation
> parameter in qapi/block-core.json adding default and allowed values (patch 1).
> I also updated the help related to BLOCK_OPT_PREALLOC in the QemuOptsList of
> file-posix (patch 2) and gluster (patch 3).

Queued.  Thanks!