[v5] qemu-img: rebase: Improve/optimize rebase operation

[Qemu-devel] [PATCH v5 0/3] qemu-img: rebase: Improve/optimize rebase operation

Sam Eiderman posted 3 patches 4 years, 11 months ago

Diff against v1 v2 v3 v4
Download series mbox

Test FreeBSD passed

Test docker-clang@ubuntu passed

Test s390x passed

Test docker-mingw@fedora passed

Test checkpatch passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190523163337.4497-1-shmuel.eiderman@oracle.com

Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>

qemu-img.c | 85 ++++++++++++++++++++++++++++++++++++++++----------------------
1 file changed, 55 insertions(+), 30 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v5 0/3] qemu-img: rebase: Improve/optimize rebase operation

Posted by Sam Eiderman 4 years, 11 months ago

This patch series aims to improve the speed of qemu-img rebase.

  1. Mainly by removing unnecessary reads when rebasing on the same
     chain.
  2. But also by minimizing the number of bdrv_open calls rebase
     requires.

v2:

* Added missing g_free in
  "qemu-img: rebase: Reuse in-chain BlockDriverState"

v3:

* Rebased on top of "Allow rebase with no input base" series

v4 & v5:

* Using backing_bs(bs) when a prefix was detected since bs was
  already checked for allocation.

Sam Eiderman (3):
  qemu-img: rebase: Reuse parent BlockDriverState
  qemu-img: rebase: Reduce reads on in-chain rebase
  qemu-img: rebase: Reuse in-chain BlockDriverState

 qemu-img.c | 85 ++++++++++++++++++++++++++++++++++++++++----------------------
 1 file changed, 55 insertions(+), 30 deletions(-)

-- 
2.13.3

Re: [Qemu-devel] [PATCH v5 0/3] qemu-img: rebase: Improve/optimize rebase operation

Posted by Max Reitz 4 years, 11 months ago

On 23.05.19 18:33, Sam Eiderman wrote:
> This patch series aims to improve the speed of qemu-img rebase.
> 
>   1. Mainly by removing unnecessary reads when rebasing on the same
>      chain.
>   2. But also by minimizing the number of bdrv_open calls rebase
>      requires.
> 
> v2:
> 
> * Added missing g_free in
>   "qemu-img: rebase: Reuse in-chain BlockDriverState"
> 
> v3:
> 
> * Rebased on top of "Allow rebase with no input base" series
> 
> v4 & v5:
> 
> * Using backing_bs(bs) when a prefix was detected since bs was
>   already checked for allocation.
> 
> Sam Eiderman (3):
>   qemu-img: rebase: Reuse parent BlockDriverState
>   qemu-img: rebase: Reduce reads on in-chain rebase
>   qemu-img: rebase: Reuse in-chain BlockDriverState
> 
>  qemu-img.c | 85 ++++++++++++++++++++++++++++++++++++++++----------------------
>  1 file changed, 55 insertions(+), 30 deletions(-)

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max