[v1] qcow2-bitmaps: rewrite reopening logic

[Qemu-devel] [PATCH 0/3] qcow2-bitmaps: rewrite reopening logic

Vladimir Sementsov-Ogievskiy posted 3 patches 4 years, 11 months ago

Diff against v2 v3 v4 v5
Download series mbox

Test FreeBSD passed

Test docker-clang@ubuntu passed

Test s390x passed

Test docker-mingw@fedora passed

Test checkpatch passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190523154733.54944-1-vsementsov@virtuozzo.com

Maintainers: John Snow <jsnow@redhat.com>, Fam Zheng <fam@euphon.net>, Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>

There is a newer version of this series

block/qcow2.h                |   5 +-
include/block/block_int.h    |   2 +-
include/block/dirty-bitmap.h |   1 -
block.c                      |  29 ++---
block/dirty-bitmap.c         |  12 --
block/qcow2-bitmap.c         | 220 ++++++++++++++++++++++++-----------
block/qcow2.c                |   2 +-
python/qemu/__init__.py      |   4 +-
tests/qemu-iotests/255       |  83 +++++++++++++
tests/qemu-iotests/255.out   |  52 +++++++++
tests/qemu-iotests/group     |   1 +
11 files changed, 308 insertions(+), 103 deletions(-)
create mode 100755 tests/qemu-iotests/255
create mode 100644 tests/qemu-iotests/255.out

Expand all Fold all

[Qemu-devel] [PATCH 0/3] qcow2-bitmaps: rewrite reopening logic

Posted by Vladimir Sementsov-Ogievskiy 4 years, 11 months ago

Hi all!

Bitmaps reopening is buggy, we may easily produce broken incremental
backup if we do temporary snaphost. Let's fix it! The main patch is 03
and it has full description of the problem and solution.

Vladimir Sementsov-Ogievskiy (3):
  iotests: add test 255 to check bitmap life after snapshot + commit
  block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps
  block/qcow2-bitmap: rewrite bitmap reopening logic

 block/qcow2.h                |   5 +-
 include/block/block_int.h    |   2 +-
 include/block/dirty-bitmap.h |   1 -
 block.c                      |  29 ++---
 block/dirty-bitmap.c         |  12 --
 block/qcow2-bitmap.c         | 220 ++++++++++++++++++++++++-----------
 block/qcow2.c                |   2 +-
 python/qemu/__init__.py      |   4 +-
 tests/qemu-iotests/255       |  83 +++++++++++++
 tests/qemu-iotests/255.out   |  52 +++++++++
 tests/qemu-iotests/group     |   1 +
 11 files changed, 308 insertions(+), 103 deletions(-)
 create mode 100755 tests/qemu-iotests/255
 create mode 100644 tests/qemu-iotests/255.out

-- 
2.18.0