[v1] Linux user for 4.1 patches

[Qemu-devel] [PULL 00/10] Linux user for 4.1 patches

Posted by Laurent Vivier 4 years, 11 months ago

The following changes since commit a4f667b6714916683408b983cfe0a615a725775f:

  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into staging (2019-05-21 16:30:13 +0100)

are available in the Git repository at:

  git://github.com/vivier/qemu.git tags/linux-user-for-4.1-pull-request

for you to fetch changes up to 069a1504ee1e2943964d0357d798e11b66afd351:

  linux-user: Pass through nanosecond timestamp components for stat syscalls (2019-05-22 20:50:55 +0200)

----------------------------------------------------------------
Add /proc/hardware and /proc/cpuinfo,
update SIOCXXX ioctls,
update IPV6 options,
fix shmat emulation,
add nanoseconds in stat,
init field fp_abi on mips

----------------------------------------------------------------

Aleksandar Markovic (2):
  linux-user: Fix support for SIOCATMARK and SIOCGPGRP ioctls for xtensa
  linux-user: Add support for SIOCSPGRP ioctl for all targets

Chen-Yu Tsai (1):
  linux-user: Pass through nanosecond timestamp components for stat
    syscalls

Daniel Santos (1):
  linux-user: Sanitize interp_info and, for mips only, init field fp_abi

Laurent Vivier (2):
  linux-user: add pseudo /proc/cpuinfo for sparc
  linux-user: add pseudo /proc/hardware for m68k

Neng Chen (2):
  linux-user: Add support for SIOC<G|S>IFPFLAGS ioctls for all targets
  linux-user: Add support for setsockopt() options
    IPV6_<ADD|DROP>_MEMBERSHIP

Richard Henderson (2):
  linux-user: Fix shmat emulation by honoring host SHMLBA
  linux-user: Align mmap_find_vma to host page size

 linux-user/elfload.c      | 22 ++++++++----
 linux-user/ioctls.h       |  3 ++
 linux-user/mmap.c         | 72 +++++++++++++++++++++------------------
 linux-user/qemu.h         |  2 +-
 linux-user/syscall.c      | 72 +++++++++++++++++++++++++++++++++++++--
 linux-user/syscall_defs.h | 57 ++++++++++++++++++++-----------
 6 files changed, 166 insertions(+), 62 deletions(-)

-- 
2.20.1

Re: [Qemu-devel] [PULL 00/10] Linux user for 4.1 patches

Posted by no-reply@patchew.org 4 years, 11 months ago

Patchew URL: https://patchew.org/QEMU/20190523144336.13960-1-laurent@vivier.eu/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190523144336.13960-1-laurent@vivier.eu
Type: series
Subject: [Qemu-devel] [PULL 00/10] Linux user for 4.1 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
   d418238dca..8dc7fd56dd  master     -> master
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190523144336.13960-1-laurent@vivier.eu -> patchew/20190523144336.13960-1-laurent@vivier.eu
Switched to a new branch 'test'
4770ccf734 linux-user: Pass through nanosecond timestamp components for stat syscalls
1b5b9faa88 linux-user: Align mmap_find_vma to host page size
874caa8bfb linux-user: Fix shmat emulation by honoring host SHMLBA
d907278358 linux-user: Add support for setsockopt() options IPV6_<ADD|DROP>_MEMBERSHIP
57d45df330 linux-user: Sanitize interp_info and, for mips only, init field fp_abi
7267248384 linux-user: Add support for SIOC<G|S>IFPFLAGS ioctls for all targets
0eac2d71cc linux-user: Add support for SIOCSPGRP ioctl for all targets
f0e6b29b94 linux-user: Fix support for SIOCATMARK and SIOCGPGRP ioctls for xtensa
bd5d878a8c linux-user: add pseudo /proc/hardware for m68k
1384b0eeee linux-user: add pseudo /proc/cpuinfo for sparc

=== OUTPUT BEGIN ===
1/10 Checking commit 1384b0eeeeb5 (linux-user: add pseudo /proc/cpuinfo for sparc)
2/10 Checking commit bd5d878a8cee (linux-user: add pseudo /proc/hardware for m68k)
3/10 Checking commit f0e6b29b94d6 (linux-user: Fix support for SIOCATMARK and SIOCGPGRP ioctls for xtensa)
4/10 Checking commit 0eac2d71ccfa (linux-user: Add support for SIOCSPGRP ioctl for all targets)
5/10 Checking commit 72672483844f (linux-user: Add support for SIOC<G|S>IFPFLAGS ioctls for all targets)
6/10 Checking commit 57d45df3304f (linux-user: Sanitize interp_info and, for mips only, init field fp_abi)
7/10 Checking commit d907278358c4 (linux-user: Add support for setsockopt() options IPV6_<ADD|DROP>_MEMBERSHIP)
WARNING: architecture specific defines should be avoided
#70: FILE: linux-user/syscall.c:1929:
+#if __UAPI_DEF_IPV6_MREQ

total: 0 errors, 1 warnings, 29 lines checked

Patch 7/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/10 Checking commit 874caa8bfb4f (linux-user: Fix shmat emulation by honoring host SHMLBA)
WARNING: Block comments use a leading /* on a separate line
#54: FILE: linux-user/elfload.c:2070:
+            /* The same thing again, but with extra

total: 0 errors, 1 warnings, 221 lines checked

Patch 8/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/10 Checking commit 1b5b9faa88bd (linux-user: Align mmap_find_vma to host page size)
10/10 Checking commit 4770ccf73400 (linux-user: Pass through nanosecond timestamp components for stat syscalls)
ERROR: code indent should never use tabs
#105: FILE: linux-user/syscall_defs.h:1203:
+^Iabi_ulong  target_st_atime_nsec;$

ERROR: code indent should never use tabs
#108: FILE: linux-user/syscall_defs.h:1205:
+^Iabi_ulong  target_st_mtime_nsec;$

ERROR: code indent should never use tabs
#111: FILE: linux-user/syscall_defs.h:1207:
+^Iabi_ulong  target_st_ctime_nsec;$

ERROR: code indent should never use tabs
#120: FILE: linux-user/syscall_defs.h:1239:
+^Iabi_ulong^Itarget_st_atime_nsec;$

ERROR: code indent should never use tabs
#124: FILE: linux-user/syscall_defs.h:1242:
+^Iabi_ulong^Itarget_st_mtime_nsec;$

ERROR: code indent should never use tabs
#128: FILE: linux-user/syscall_defs.h:1245:
+^Iabi_ulong^Itarget_st_ctime_nsec;$

ERROR: code indent should never use tabs
#137: FILE: linux-user/syscall_defs.h:1324:
+^Iabi_ulong^Itarget_st_atime_nsec;$

ERROR: code indent should never use tabs
#141: FILE: linux-user/syscall_defs.h:1327:
+^Iabi_ulong^Itarget_st_mtime_nsec;$

ERROR: code indent should never use tabs
#145: FILE: linux-user/syscall_defs.h:1330:
+^Iabi_ulong^Itarget_st_ctime_nsec;$

ERROR: code indent should never use tabs
#161: FILE: linux-user/syscall_defs.h:1348:
+^Iabi_ulong^Itarget_st_atime_nsec;$

ERROR: code indent should never use tabs
#164: FILE: linux-user/syscall_defs.h:1350:
+^Iabi_ulong^Itarget_st_mtime_nsec;$

ERROR: code indent should never use tabs
#167: FILE: linux-user/syscall_defs.h:1352:
+^Iabi_ulong^Itarget_st_ctime_nsec;$

ERROR: code indent should never use tabs
#171: FILE: linux-user/syscall_defs.h:1355:
+^Iabi_ulong^I__unused1[2];$

ERROR: code indent should never use tabs
#180: FILE: linux-user/syscall_defs.h:1383:
+^Iunsigned int^Itarget_st_atime_nsec;$

ERROR: code indent should never use tabs
#184: FILE: linux-user/syscall_defs.h:1386:
+^Iunsigned int^Itarget_st_mtime_nsec;$

ERROR: code indent should never use tabs
#188: FILE: linux-user/syscall_defs.h:1389:
+^Iunsigned int^Itarget_st_ctime_nsec;$

ERROR: code indent should never use tabs
#192: FILE: linux-user/syscall_defs.h:1391:
+^Iunsigned int^I__unused1;$

ERROR: code indent should never use tabs
#193: FILE: linux-user/syscall_defs.h:1392:
+^Iunsigned int^I__unused2;$

total: 18 errors, 0 warnings, 211 lines checked

Patch 10/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190523144336.13960-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PULL 00/10] Linux user for 4.1 patches

Posted by Aleksandar Markovic 4 years, 11 months ago

On May 23, 2019 6:51 PM, <no-reply@patchew.org> wrote:
>
> Patchew URL:
https://patchew.org/QEMU/20190523144336.13960-1-laurent@vivier.eu/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Message-id: 20190523144336.13960-1-laurent@vivier.eu
> Type: series
> Subject: [Qemu-devel] [PULL 00/10] Linux user for 4.1 patches
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
>
> From https://github.com/patchew-project/qemu
>    d418238dca..8dc7fd56dd  master     -> master
> From https://github.com/patchew-project/qemu
>  * [new tag]               patchew/
20190523144336.13960-1-laurent@vivier.eu -> patchew/
20190523144336.13960-1-laurent@vivier.eu
> Switched to a new branch 'test'
> 4770ccf734 linux-user: Pass through nanosecond timestamp components for
stat syscalls
> 1b5b9faa88 linux-user: Align mmap_find_vma to host page size
> 874caa8bfb linux-user: Fix shmat emulation by honoring host SHMLBA
> d907278358 linux-user: Add support for setsockopt() options
IPV6_<ADD|DROP>_MEMBERSHIP
> 57d45df330 linux-user: Sanitize interp_info and, for mips only, init
field fp_abi
> 7267248384 linux-user: Add support for SIOC<G|S>IFPFLAGS ioctls for all
targets
> 0eac2d71cc linux-user: Add support for SIOCSPGRP ioctl for all targets
> f0e6b29b94 linux-user: Fix support for SIOCATMARK and SIOCGPGRP ioctls
for xtensa
> bd5d878a8c linux-user: add pseudo /proc/hardware for m68k
> 1384b0eeee linux-user: add pseudo /proc/cpuinfo for sparc
>
> === OUTPUT BEGIN ===
> 1/10 Checking commit 1384b0eeeeb5 (linux-user: add pseudo /proc/cpuinfo
for sparc)
> 2/10 Checking commit bd5d878a8cee (linux-user: add pseudo /proc/hardware
for m68k)
> 3/10 Checking commit f0e6b29b94d6 (linux-user: Fix support for SIOCATMARK
and SIOCGPGRP ioctls for xtensa)
> 4/10 Checking commit 0eac2d71ccfa (linux-user: Add support for SIOCSPGRP
ioctl for all targets)
> 5/10 Checking commit 72672483844f (linux-user: Add support for
SIOC<G|S>IFPFLAGS ioctls for all targets)
> 6/10 Checking commit 57d45df3304f (linux-user: Sanitize interp_info and,
for mips only, init field fp_abi)
> 7/10 Checking commit d907278358c4 (linux-user: Add support for
setsockopt() options IPV6_<ADD|DROP>_MEMBERSHIP)
> WARNING: architecture specific defines should be avoided
> #70: FILE: linux-user/syscall.c:1929:
> +#if __UAPI_DEF_IPV6_MREQ
>
> total: 0 errors, 1 warnings, 29 lines checked
>

This warning was known to us, but we can't do anything about it, the line
in question is a “necessary evil” .

> Patch 7/10 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 8/10 Checking commit 874caa8bfb4f (linux-user: Fix shmat emulation by
honoring host SHMLBA)
> WARNING: Block comments use a leading /* on a separate line
> #54: FILE: linux-user/elfload.c:2070:
> +            /* The same thing again, but with extra
>
> total: 0 errors, 1 warnings, 221 lines checked
>
> Patch 8/10 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 9/10 Checking commit 1b5b9faa88bd (linux-user: Align mmap_find_vma to
host page size)
> 10/10 Checking commit 4770ccf73400 (linux-user: Pass through nanosecond
timestamp components for stat syscalls)
> ERROR: code indent should never use tabs
> #105: FILE: linux-user/syscall_defs.h:1203:
> +^Iabi_ulong  target_st_atime_nsec;$
>
> ERROR: code indent should never use tabs
> #108: FILE: linux-user/syscall_defs.h:1205:
> +^Iabi_ulong  target_st_mtime_nsec;$
>
> ERROR: code indent should never use tabs
> #111: FILE: linux-user/syscall_defs.h:1207:
> +^Iabi_ulong  target_st_ctime_nsec;$
>
> ERROR: code indent should never use tabs
> #120: FILE: linux-user/syscall_defs.h:1239:
> +^Iabi_ulong^Itarget_st_atime_nsec;$
>
> ERROR: code indent should never use tabs
> #124: FILE: linux-user/syscall_defs.h:1242:
> +^Iabi_ulong^Itarget_st_mtime_nsec;$
>
> ERROR: code indent should never use tabs
> #128: FILE: linux-user/syscall_defs.h:1245:
> +^Iabi_ulong^Itarget_st_ctime_nsec;$
>
> ERROR: code indent should never use tabs
> #137: FILE: linux-user/syscall_defs.h:1324:
> +^Iabi_ulong^Itarget_st_atime_nsec;$
>
> ERROR: code indent should never use tabs
> #141: FILE: linux-user/syscall_defs.h:1327:
> +^Iabi_ulong^Itarget_st_mtime_nsec;$
>
> ERROR: code indent should never use tabs
> #145: FILE: linux-user/syscall_defs.h:1330:
> +^Iabi_ulong^Itarget_st_ctime_nsec;$
>
> ERROR: code indent should never use tabs
> #161: FILE: linux-user/syscall_defs.h:1348:
> +^Iabi_ulong^Itarget_st_atime_nsec;$
>
> ERROR: code indent should never use tabs
> #164: FILE: linux-user/syscall_defs.h:1350:
> +^Iabi_ulong^Itarget_st_mtime_nsec;$
>
> ERROR: code indent should never use tabs
> #167: FILE: linux-user/syscall_defs.h:1352:
> +^Iabi_ulong^Itarget_st_ctime_nsec;$
>
> ERROR: code indent should never use tabs
> #171: FILE: linux-user/syscall_defs.h:1355:
> +^Iabi_ulong^I__unused1[2];$
>
> ERROR: code indent should never use tabs
> #180: FILE: linux-user/syscall_defs.h:1383:
> +^Iunsigned int^Itarget_st_atime_nsec;$
>
> ERROR: code indent should never use tabs
> #184: FILE: linux-user/syscall_defs.h:1386:
> +^Iunsigned int^Itarget_st_mtime_nsec;$
>
> ERROR: code indent should never use tabs
> #188: FILE: linux-user/syscall_defs.h:1389:
> +^Iunsigned int^Itarget_st_ctime_nsec;$
>
> ERROR: code indent should never use tabs
> #192: FILE: linux-user/syscall_defs.h:1391:
> +^Iunsigned int^I__unused1;$
>
> ERROR: code indent should never use tabs
> #193: FILE: linux-user/syscall_defs.h:1392:
> +^Iunsigned int^I__unused2;$
>
> total: 18 errors, 0 warnings, 211 lines checked
>
> Patch 10/10 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> The full log is available at
>
http://patchew.org/logs/20190523144336.13960-1-laurent@vivier.eu/testing.checkpatch/?type=message
.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PULL 00/10] Linux user for 4.1 patches

Posted by Peter Maydell 4 years, 11 months ago

On Thu, 23 May 2019 at 15:47, Laurent Vivier <laurent@vivier.eu> wrote:
>
> The following changes since commit a4f667b6714916683408b983cfe0a615a725775f:
>
>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into staging (2019-05-21 16:30:13 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/vivier/qemu.git tags/linux-user-for-4.1-pull-request
>
> for you to fetch changes up to 069a1504ee1e2943964d0357d798e11b66afd351:
>
>   linux-user: Pass through nanosecond timestamp components for stat syscalls (2019-05-22 20:50:55 +0200)
>
> ----------------------------------------------------------------
> Add /proc/hardware and /proc/cpuinfo,
> update SIOCXXX ioctls,
> update IPV6 options,
> fix shmat emulation,
> add nanoseconds in stat,
> init field fp_abi on mips
>
> ----------------------------------------------------------------

Hi; I'm afraid this fails to build on a couple of the hosts
I test on:

/home/pm215/qemu/linux-user/syscall.c: In function ‘do_setsockopt’:
/home/pm215/qemu/linux-user/syscall.c:1929:5: error:
"__UAPI_DEF_IPV6_MREQ" is not defined [-Werror=undef]
 #if __UAPI_DEF_IPV6_MREQ
     ^

(these were the ppc64 and aarch64 machines in the gcc compile farm, but
I suspect this is just "older kernel headers" rather than arch-specific.)


thanks
-- PMM

Re: [Qemu-devel] [PULL 00/10] Linux user for 4.1 patches

Posted by Laurent Vivier 4 years, 11 months ago

On 24/05/2019 13:07, Peter Maydell wrote:
> On Thu, 23 May 2019 at 15:47, Laurent Vivier <laurent@vivier.eu> wrote:
>>
>> The following changes since commit a4f667b6714916683408b983cfe0a615a725775f:
>>
>>    Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into staging (2019-05-21 16:30:13 +0100)
>>
>> are available in the Git repository at:
>>
>>    git://github.com/vivier/qemu.git tags/linux-user-for-4.1-pull-request
>>
>> for you to fetch changes up to 069a1504ee1e2943964d0357d798e11b66afd351:
>>
>>    linux-user: Pass through nanosecond timestamp components for stat syscalls (2019-05-22 20:50:55 +0200)
>>
>> ----------------------------------------------------------------
>> Add /proc/hardware and /proc/cpuinfo,
>> update SIOCXXX ioctls,
>> update IPV6 options,
>> fix shmat emulation,
>> add nanoseconds in stat,
>> init field fp_abi on mips
>>
>> ----------------------------------------------------------------
> 
> Hi; I'm afraid this fails to build on a couple of the hosts
> I test on:
> 
> /home/pm215/qemu/linux-user/syscall.c: In function ‘do_setsockopt’:
> /home/pm215/qemu/linux-user/syscall.c:1929:5: error:
> "__UAPI_DEF_IPV6_MREQ" is not defined [-Werror=undef]
>   #if __UAPI_DEF_IPV6_MREQ
>       ^
> 
> (these were the ppc64 and aarch64 machines in the gcc compile farm, but
> I suspect this is just "older kernel headers" rather than arch-specific.)
> 

Thank you,

I'm going to remove the patch from the PR and we will rework it later.

Thanks,
Laurent