1 | Not very much here, but several people have fallen over | 1 | The following changes since commit 64ada298b98a51eb2512607f6e6180cb330c47b1: |
---|---|---|---|
2 | the vector operation segfault bug, so let's get the fix | ||
3 | into master. | ||
4 | 2 | ||
5 | thanks | 3 | Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220302' into staging (2022-03-02 12:38:46 +0000) |
6 | -- PMM | ||
7 | |||
8 | The following changes since commit d418238dca7b4e0b124135827ead3076233052b1: | ||
9 | |||
10 | Merge remote-tracking branch 'remotes/rth/tags/pull-rng-20190522' into staging (2019-05-23 12:57:17 +0100) | ||
11 | 4 | ||
12 | are available in the Git repository at: | 5 | are available in the Git repository at: |
13 | 6 | ||
14 | https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20190523 | 7 | https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20220302 |
15 | 8 | ||
16 | for you to fetch changes up to 98e4f4fdb8ea05d840f51f47125924c2bb9df2df: | 9 | for you to fetch changes up to 268c11984e67867c22f53beb3c7f8b98900d66b2: |
17 | 10 | ||
18 | hw/arm/exynos4210: QOM'ify the Exynos4210 SoC (2019-05-23 14:47:44 +0100) | 11 | ui/cocoa.m: Remove unnecessary NSAutoreleasePools (2022-03-02 19:27:37 +0000) |
19 | 12 | ||
20 | ---------------------------------------------------------------- | 13 | ---------------------------------------------------------------- |
21 | target-arm queue: | 14 | target-arm queue: |
22 | * exynos4210: QOM'ify the Exynos4210 SoC | 15 | * mps3-an547: Add missing user ahb interfaces |
23 | * exynos4210: Add DMA support for the Exynos4210 | 16 | * hw/arm/mps2-tz.c: Update AN547 documentation URL |
24 | * arm_gicv3: Fix writes to ICC_CTLR_EL3 | 17 | * hw/input/tsc210x: Don't abort on bad SPI word widths |
25 | * arm_gicv3: Fix write of ICH_VMCR_EL2.{VBPR0, VBPR1} | 18 | * hw/i2c: flatten pca954x mux device |
26 | * target/arm: Fix vector operation segfault | 19 | * target/arm: Support PSCI 1.1 and SMCCC 1.0 |
27 | * target/arm: Minor improvements to BFXIL, EXTR | 20 | * target/arm: Fix early free of TCG temp in handle_simd_shift_fpint_conv() |
21 | * tests/qtest: add qtests for npcm7xx sdhci | ||
22 | * Implement FEAT_LVA | ||
23 | * Implement FEAT_LPA | ||
24 | * Implement FEAT_LPA2 (but do not enable it yet) | ||
25 | * Report KVM's actual PSCI version to guest in dtb | ||
26 | * ui/cocoa.m: Fix updateUIInfo threading issues | ||
27 | * ui/cocoa.m: Remove unnecessary NSAutoreleasePools | ||
28 | 28 | ||
29 | ---------------------------------------------------------------- | 29 | ---------------------------------------------------------------- |
30 | Alistair Francis (1): | 30 | Akihiko Odaki (1): |
31 | target/arm: Fix vector operation segfault | 31 | target/arm: Support PSCI 1.1 and SMCCC 1.0 |
32 | 32 | ||
33 | Guenter Roeck (1): | 33 | Jimmy Brisson (1): |
34 | hw/arm/exynos4210: Add DMA support for the Exynos4210 | 34 | mps3-an547: Add missing user ahb interfaces |
35 | |||
36 | Patrick Venture (1): | ||
37 | hw/i2c: flatten pca954x mux device | ||
35 | 38 | ||
36 | Peter Maydell (5): | 39 | Peter Maydell (5): |
37 | arm: Move system_clock_scale to armv7m_systick.h | 40 | hw/arm/mps2-tz.c: Update AN547 documentation URL |
38 | arm: Remove unnecessary includes of hw/arm/arm.h | 41 | hw/input/tsc210x: Don't abort on bad SPI word widths |
39 | arm: Rename hw/arm/arm.h to hw/arm/boot.h | 42 | target/arm: Report KVM's actual PSCI version to guest in dtb |
40 | hw/intc/arm_gicv3: Fix write of ICH_VMCR_EL2.{VBPR0, VBPR1} | 43 | ui/cocoa.m: Fix updateUIInfo threading issues |
41 | hw/intc/arm_gicv3: Fix writes to ICC_CTLR_EL3 | 44 | ui/cocoa.m: Remove unnecessary NSAutoreleasePools |
42 | 45 | ||
43 | Philippe Mathieu-Daudé (3): | 46 | Richard Henderson (16): |
44 | hw/arm/exynos4: Remove unuseful debug code | 47 | hw/registerfields: Add FIELD_SEX<N> and FIELD_SDP<N> |
45 | hw/arm/exynos4: Use the IEC binary prefix definitions | 48 | target/arm: Set TCR_EL1.TSZ for user-only |
46 | hw/arm/exynos4210: QOM'ify the Exynos4210 SoC | 49 | target/arm: Fault on invalid TCR_ELx.TxSZ |
50 | target/arm: Move arm_pamax out of line | ||
51 | target/arm: Pass outputsize down to check_s2_mmu_setup | ||
52 | target/arm: Use MAKE_64BIT_MASK to compute indexmask | ||
53 | target/arm: Honor TCR_ELx.{I}PS | ||
54 | target/arm: Prepare DBGBVR and DBGWVR for FEAT_LVA | ||
55 | target/arm: Implement FEAT_LVA | ||
56 | target/arm: Implement FEAT_LPA | ||
57 | target/arm: Extend arm_fi_to_lfsc to level -1 | ||
58 | target/arm: Introduce tlbi_aa64_get_range | ||
59 | target/arm: Fix TLBIRange.base for 16k and 64k pages | ||
60 | target/arm: Validate tlbi TG matches translation granule in use | ||
61 | target/arm: Advertise all page sizes for -cpu max | ||
62 | target/arm: Implement FEAT_LPA2 | ||
47 | 63 | ||
48 | Richard Henderson (2): | 64 | Shengtan Mao (1): |
49 | target/arm: Use extract2 for EXTR | 65 | tests/qtest: add qtests for npcm7xx sdhci |
50 | target/arm: Simplify BFXIL expansion | ||
51 | 66 | ||
52 | include/hw/arm/allwinner-a10.h | 2 +- | 67 | Wentao_Liang (1): |
53 | include/hw/arm/aspeed_soc.h | 1 - | 68 | target/arm: Fix early free of TCG temp in handle_simd_shift_fpint_conv() |
54 | include/hw/arm/bcm2836.h | 1 - | ||
55 | include/hw/arm/{arm.h => boot.h} | 12 +++------ | ||
56 | include/hw/arm/exynos4210.h | 9 +++++-- | ||
57 | include/hw/arm/fsl-imx25.h | 2 +- | ||
58 | include/hw/arm/fsl-imx31.h | 2 +- | ||
59 | include/hw/arm/fsl-imx6.h | 2 +- | ||
60 | include/hw/arm/fsl-imx6ul.h | 2 +- | ||
61 | include/hw/arm/fsl-imx7.h | 2 +- | ||
62 | include/hw/arm/virt.h | 2 +- | ||
63 | include/hw/arm/xlnx-versal.h | 2 +- | ||
64 | include/hw/arm/xlnx-zynqmp.h | 2 +- | ||
65 | include/hw/timer/armv7m_systick.h | 22 ++++++++++++++++ | ||
66 | hw/arm/armsse.c | 2 +- | ||
67 | hw/arm/armv7m.c | 2 +- | ||
68 | hw/arm/aspeed.c | 2 +- | ||
69 | hw/arm/boot.c | 2 +- | ||
70 | hw/arm/collie.c | 2 +- | ||
71 | hw/arm/exynos4210.c | 54 ++++++++++++++++++++++++++++++++++++--- | ||
72 | hw/arm/exynos4_boards.c | 40 ++++++++--------------------- | ||
73 | hw/arm/highbank.c | 2 +- | ||
74 | hw/arm/integratorcp.c | 2 +- | ||
75 | hw/arm/mainstone.c | 2 +- | ||
76 | hw/arm/microbit.c | 2 +- | ||
77 | hw/arm/mps2-tz.c | 2 +- | ||
78 | hw/arm/mps2.c | 2 +- | ||
79 | hw/arm/msf2-soc.c | 1 - | ||
80 | hw/arm/msf2-som.c | 2 +- | ||
81 | hw/arm/musca.c | 2 +- | ||
82 | hw/arm/musicpal.c | 2 +- | ||
83 | hw/arm/netduino2.c | 2 +- | ||
84 | hw/arm/nrf51_soc.c | 2 +- | ||
85 | hw/arm/nseries.c | 2 +- | ||
86 | hw/arm/omap1.c | 2 +- | ||
87 | hw/arm/omap2.c | 2 +- | ||
88 | hw/arm/omap_sx1.c | 2 +- | ||
89 | hw/arm/palm.c | 2 +- | ||
90 | hw/arm/raspi.c | 2 +- | ||
91 | hw/arm/realview.c | 2 +- | ||
92 | hw/arm/spitz.c | 2 +- | ||
93 | hw/arm/stellaris.c | 2 +- | ||
94 | hw/arm/stm32f205_soc.c | 2 +- | ||
95 | hw/arm/strongarm.c | 2 +- | ||
96 | hw/arm/tosa.c | 2 +- | ||
97 | hw/arm/versatilepb.c | 2 +- | ||
98 | hw/arm/vexpress.c | 2 +- | ||
99 | hw/arm/virt.c | 2 +- | ||
100 | hw/arm/xilinx_zynq.c | 2 +- | ||
101 | hw/arm/xlnx-versal.c | 2 +- | ||
102 | hw/arm/z2.c | 2 +- | ||
103 | hw/intc/arm_gicv3_cpuif.c | 6 ++--- | ||
104 | hw/intc/armv7m_nvic.c | 1 - | ||
105 | target/arm/arm-semi.c | 1 - | ||
106 | target/arm/cpu.c | 1 - | ||
107 | target/arm/cpu64.c | 1 - | ||
108 | target/arm/kvm.c | 1 - | ||
109 | target/arm/kvm32.c | 1 - | ||
110 | target/arm/kvm64.c | 1 - | ||
111 | target/arm/translate-a64.c | 44 ++++++++++++++++--------------- | ||
112 | target/arm/translate.c | 4 +-- | ||
113 | 61 files changed, 164 insertions(+), 123 deletions(-) | ||
114 | rename include/hw/arm/{arm.h => boot.h} (96%) | ||
115 | 69 | ||
70 | docs/system/arm/emulation.rst | 3 + | ||
71 | include/hw/registerfields.h | 48 +++++- | ||
72 | target/arm/cpu-param.h | 4 +- | ||
73 | target/arm/cpu.h | 27 ++++ | ||
74 | target/arm/internals.h | 58 ++++--- | ||
75 | target/arm/kvm-consts.h | 14 +- | ||
76 | hw/arm/boot.c | 11 +- | ||
77 | hw/arm/mps2-tz.c | 6 +- | ||
78 | hw/i2c/i2c_mux_pca954x.c | 77 ++------- | ||
79 | hw/input/tsc210x.c | 8 +- | ||
80 | target/arm/cpu.c | 8 +- | ||
81 | target/arm/cpu64.c | 7 +- | ||
82 | target/arm/helper.c | 332 ++++++++++++++++++++++++++++++--------- | ||
83 | target/arm/hvf/hvf.c | 27 +++- | ||
84 | target/arm/kvm64.c | 14 +- | ||
85 | target/arm/psci.c | 35 ++++- | ||
86 | target/arm/translate-a64.c | 2 +- | ||
87 | tests/qtest/npcm7xx_sdhci-test.c | 215 +++++++++++++++++++++++++ | ||
88 | tests/qtest/meson.build | 1 + | ||
89 | ui/cocoa.m | 31 ++-- | ||
90 | 20 files changed, 736 insertions(+), 192 deletions(-) | ||
91 | create mode 100644 tests/qtest/npcm7xx_sdhci-test.c | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Jimmy Brisson <jimmy.brisson@linaro.org> | ||
1 | 2 | ||
3 | With these interfaces missing, TFM would delegate peripherals 0, 1, | ||
4 | 2, 3 and 8, and qemu would ignore the delegation of interface 8, as | ||
5 | it thought interface 4 was eth & USB. | ||
6 | |||
7 | This patch corrects this behavior and allows TFM to delegate the | ||
8 | eth & USB peripheral to NS mode. | ||
9 | |||
10 | (The old QEMU behaviour was based on revision B of the AN547 | ||
11 | appnote; revision C corrects this error in the documentation, | ||
12 | and this commit brings QEMU in to line with how the FPGA | ||
13 | image really behaves.) | ||
14 | |||
15 | Signed-off-by: Jimmy Brisson <jimmy.brisson@linaro.org> | ||
16 | Message-id: 20220210210227.3203883-1-jimmy.brisson@linaro.org | ||
17 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
18 | [PMM: added commit message note clarifying that the old behaviour | ||
19 | was a docs issue, not because there were two different versions | ||
20 | of the FPGA image] | ||
21 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
22 | --- | ||
23 | hw/arm/mps2-tz.c | 4 ++++ | ||
24 | 1 file changed, 4 insertions(+) | ||
25 | |||
26 | diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c | ||
27 | index XXXXXXX..XXXXXXX 100644 | ||
28 | --- a/hw/arm/mps2-tz.c | ||
29 | +++ b/hw/arm/mps2-tz.c | ||
30 | @@ -XXX,XX +XXX,XX @@ static void mps2tz_common_init(MachineState *machine) | ||
31 | { "gpio1", make_unimp_dev, &mms->gpio[1], 0x41101000, 0x1000 }, | ||
32 | { "gpio2", make_unimp_dev, &mms->gpio[2], 0x41102000, 0x1000 }, | ||
33 | { "gpio3", make_unimp_dev, &mms->gpio[3], 0x41103000, 0x1000 }, | ||
34 | + { /* port 4 USER AHB interface 0 */ }, | ||
35 | + { /* port 5 USER AHB interface 1 */ }, | ||
36 | + { /* port 6 USER AHB interface 2 */ }, | ||
37 | + { /* port 7 USER AHB interface 3 */ }, | ||
38 | { "eth-usb", make_eth_usb, NULL, 0x41400000, 0x200000, { 49 } }, | ||
39 | }, | ||
40 | }, | ||
41 | -- | ||
42 | 2.25.1 | diff view generated by jsdifflib |
1 | The header file hw/arm/arm.h now includes only declarations | 1 | The AN547 application note URL has changed: update our comment |
---|---|---|---|
2 | relating to hw/arm/boot.c functionality. Rename it accordingly, | 2 | accordingly. (Rev B is still downloadable from the old URL, |
3 | and adjust its header comment. | 3 | but there is a new Rev C of the document now.) |
4 | |||
5 | The bulk of this commit was created via | ||
6 | perl -pi -e 's|hw/arm/arm.h|hw/arm/boot.h|' hw/arm/*.c include/hw/arm/*.h | ||
7 | |||
8 | In a few cases we can just delete the #include: | ||
9 | hw/arm/msf2-soc.c, include/hw/arm/aspeed_soc.h and | ||
10 | include/hw/arm/bcm2836.h did not require it. | ||
11 | 4 | ||
12 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 5 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
13 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | 6 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> |
14 | Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> | 7 | Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> |
15 | Message-id: 20190516163857.6430-4-peter.maydell@linaro.org | 8 | Message-id: 20220221094144.426191-1-peter.maydell@linaro.org |
16 | --- | 9 | --- |
17 | include/hw/arm/allwinner-a10.h | 2 +- | 10 | hw/arm/mps2-tz.c | 2 +- |
18 | include/hw/arm/aspeed_soc.h | 1 - | 11 | 1 file changed, 1 insertion(+), 1 deletion(-) |
19 | include/hw/arm/bcm2836.h | 1 - | ||
20 | include/hw/arm/{arm.h => boot.h} | 8 ++++---- | ||
21 | include/hw/arm/fsl-imx25.h | 2 +- | ||
22 | include/hw/arm/fsl-imx31.h | 2 +- | ||
23 | include/hw/arm/fsl-imx6.h | 2 +- | ||
24 | include/hw/arm/fsl-imx6ul.h | 2 +- | ||
25 | include/hw/arm/fsl-imx7.h | 2 +- | ||
26 | include/hw/arm/virt.h | 2 +- | ||
27 | include/hw/arm/xlnx-versal.h | 2 +- | ||
28 | include/hw/arm/xlnx-zynqmp.h | 2 +- | ||
29 | hw/arm/armsse.c | 2 +- | ||
30 | hw/arm/armv7m.c | 2 +- | ||
31 | hw/arm/aspeed.c | 2 +- | ||
32 | hw/arm/boot.c | 2 +- | ||
33 | hw/arm/collie.c | 2 +- | ||
34 | hw/arm/exynos4210.c | 2 +- | ||
35 | hw/arm/exynos4_boards.c | 2 +- | ||
36 | hw/arm/highbank.c | 2 +- | ||
37 | hw/arm/integratorcp.c | 2 +- | ||
38 | hw/arm/mainstone.c | 2 +- | ||
39 | hw/arm/microbit.c | 2 +- | ||
40 | hw/arm/mps2-tz.c | 2 +- | ||
41 | hw/arm/mps2.c | 2 +- | ||
42 | hw/arm/msf2-soc.c | 1 - | ||
43 | hw/arm/msf2-som.c | 2 +- | ||
44 | hw/arm/musca.c | 2 +- | ||
45 | hw/arm/musicpal.c | 2 +- | ||
46 | hw/arm/netduino2.c | 2 +- | ||
47 | hw/arm/nrf51_soc.c | 2 +- | ||
48 | hw/arm/nseries.c | 2 +- | ||
49 | hw/arm/omap1.c | 2 +- | ||
50 | hw/arm/omap2.c | 2 +- | ||
51 | hw/arm/omap_sx1.c | 2 +- | ||
52 | hw/arm/palm.c | 2 +- | ||
53 | hw/arm/raspi.c | 2 +- | ||
54 | hw/arm/realview.c | 2 +- | ||
55 | hw/arm/spitz.c | 2 +- | ||
56 | hw/arm/stellaris.c | 2 +- | ||
57 | hw/arm/stm32f205_soc.c | 2 +- | ||
58 | hw/arm/strongarm.c | 2 +- | ||
59 | hw/arm/tosa.c | 2 +- | ||
60 | hw/arm/versatilepb.c | 2 +- | ||
61 | hw/arm/vexpress.c | 2 +- | ||
62 | hw/arm/virt.c | 2 +- | ||
63 | hw/arm/xilinx_zynq.c | 2 +- | ||
64 | hw/arm/xlnx-versal.c | 2 +- | ||
65 | hw/arm/z2.c | 2 +- | ||
66 | 49 files changed, 49 insertions(+), 52 deletions(-) | ||
67 | rename include/hw/arm/{arm.h => boot.h} (98%) | ||
68 | 12 | ||
69 | diff --git a/include/hw/arm/allwinner-a10.h b/include/hw/arm/allwinner-a10.h | ||
70 | index XXXXXXX..XXXXXXX 100644 | ||
71 | --- a/include/hw/arm/allwinner-a10.h | ||
72 | +++ b/include/hw/arm/allwinner-a10.h | ||
73 | @@ -XXX,XX +XXX,XX @@ | ||
74 | #include "qemu-common.h" | ||
75 | #include "qemu/error-report.h" | ||
76 | #include "hw/char/serial.h" | ||
77 | -#include "hw/arm/arm.h" | ||
78 | +#include "hw/arm/boot.h" | ||
79 | #include "hw/timer/allwinner-a10-pit.h" | ||
80 | #include "hw/intc/allwinner-a10-pic.h" | ||
81 | #include "hw/net/allwinner_emac.h" | ||
82 | diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h | ||
83 | index XXXXXXX..XXXXXXX 100644 | ||
84 | --- a/include/hw/arm/aspeed_soc.h | ||
85 | +++ b/include/hw/arm/aspeed_soc.h | ||
86 | @@ -XXX,XX +XXX,XX @@ | ||
87 | #ifndef ASPEED_SOC_H | ||
88 | #define ASPEED_SOC_H | ||
89 | |||
90 | -#include "hw/arm/arm.h" | ||
91 | #include "hw/intc/aspeed_vic.h" | ||
92 | #include "hw/misc/aspeed_scu.h" | ||
93 | #include "hw/misc/aspeed_sdmc.h" | ||
94 | diff --git a/include/hw/arm/bcm2836.h b/include/hw/arm/bcm2836.h | ||
95 | index XXXXXXX..XXXXXXX 100644 | ||
96 | --- a/include/hw/arm/bcm2836.h | ||
97 | +++ b/include/hw/arm/bcm2836.h | ||
98 | @@ -XXX,XX +XXX,XX @@ | ||
99 | #ifndef BCM2836_H | ||
100 | #define BCM2836_H | ||
101 | |||
102 | -#include "hw/arm/arm.h" | ||
103 | #include "hw/arm/bcm2835_peripherals.h" | ||
104 | #include "hw/intc/bcm2836_control.h" | ||
105 | |||
106 | diff --git a/include/hw/arm/arm.h b/include/hw/arm/boot.h | ||
107 | similarity index 98% | ||
108 | rename from include/hw/arm/arm.h | ||
109 | rename to include/hw/arm/boot.h | ||
110 | index XXXXXXX..XXXXXXX 100644 | ||
111 | --- a/include/hw/arm/arm.h | ||
112 | +++ b/include/hw/arm/boot.h | ||
113 | @@ -XXX,XX +XXX,XX @@ | ||
114 | /* | ||
115 | - * Misc ARM declarations | ||
116 | + * ARM kernel loader. | ||
117 | * | ||
118 | * Copyright (c) 2006 CodeSourcery. | ||
119 | * Written by Paul Brook | ||
120 | @@ -XXX,XX +XXX,XX @@ | ||
121 | * | ||
122 | */ | ||
123 | |||
124 | -#ifndef HW_ARM_H | ||
125 | -#define HW_ARM_H | ||
126 | +#ifndef HW_ARM_BOOT_H | ||
127 | +#define HW_ARM_BOOT_H | ||
128 | |||
129 | #include "exec/memory.h" | ||
130 | #include "target/arm/cpu-qom.h" | ||
131 | @@ -XXX,XX +XXX,XX @@ void arm_write_secure_board_setup_dummy_smc(ARMCPU *cpu, | ||
132 | const struct arm_boot_info *info, | ||
133 | hwaddr mvbar_addr); | ||
134 | |||
135 | -#endif /* HW_ARM_H */ | ||
136 | +#endif /* HW_ARM_BOOT_H */ | ||
137 | diff --git a/include/hw/arm/fsl-imx25.h b/include/hw/arm/fsl-imx25.h | ||
138 | index XXXXXXX..XXXXXXX 100644 | ||
139 | --- a/include/hw/arm/fsl-imx25.h | ||
140 | +++ b/include/hw/arm/fsl-imx25.h | ||
141 | @@ -XXX,XX +XXX,XX @@ | ||
142 | #ifndef FSL_IMX25_H | ||
143 | #define FSL_IMX25_H | ||
144 | |||
145 | -#include "hw/arm/arm.h" | ||
146 | +#include "hw/arm/boot.h" | ||
147 | #include "hw/intc/imx_avic.h" | ||
148 | #include "hw/misc/imx25_ccm.h" | ||
149 | #include "hw/char/imx_serial.h" | ||
150 | diff --git a/include/hw/arm/fsl-imx31.h b/include/hw/arm/fsl-imx31.h | ||
151 | index XXXXXXX..XXXXXXX 100644 | ||
152 | --- a/include/hw/arm/fsl-imx31.h | ||
153 | +++ b/include/hw/arm/fsl-imx31.h | ||
154 | @@ -XXX,XX +XXX,XX @@ | ||
155 | #ifndef FSL_IMX31_H | ||
156 | #define FSL_IMX31_H | ||
157 | |||
158 | -#include "hw/arm/arm.h" | ||
159 | +#include "hw/arm/boot.h" | ||
160 | #include "hw/intc/imx_avic.h" | ||
161 | #include "hw/misc/imx31_ccm.h" | ||
162 | #include "hw/char/imx_serial.h" | ||
163 | diff --git a/include/hw/arm/fsl-imx6.h b/include/hw/arm/fsl-imx6.h | ||
164 | index XXXXXXX..XXXXXXX 100644 | ||
165 | --- a/include/hw/arm/fsl-imx6.h | ||
166 | +++ b/include/hw/arm/fsl-imx6.h | ||
167 | @@ -XXX,XX +XXX,XX @@ | ||
168 | #ifndef FSL_IMX6_H | ||
169 | #define FSL_IMX6_H | ||
170 | |||
171 | -#include "hw/arm/arm.h" | ||
172 | +#include "hw/arm/boot.h" | ||
173 | #include "hw/cpu/a9mpcore.h" | ||
174 | #include "hw/misc/imx6_ccm.h" | ||
175 | #include "hw/misc/imx6_src.h" | ||
176 | diff --git a/include/hw/arm/fsl-imx6ul.h b/include/hw/arm/fsl-imx6ul.h | ||
177 | index XXXXXXX..XXXXXXX 100644 | ||
178 | --- a/include/hw/arm/fsl-imx6ul.h | ||
179 | +++ b/include/hw/arm/fsl-imx6ul.h | ||
180 | @@ -XXX,XX +XXX,XX @@ | ||
181 | #ifndef FSL_IMX6UL_H | ||
182 | #define FSL_IMX6UL_H | ||
183 | |||
184 | -#include "hw/arm/arm.h" | ||
185 | +#include "hw/arm/boot.h" | ||
186 | #include "hw/cpu/a15mpcore.h" | ||
187 | #include "hw/misc/imx6ul_ccm.h" | ||
188 | #include "hw/misc/imx6_src.h" | ||
189 | diff --git a/include/hw/arm/fsl-imx7.h b/include/hw/arm/fsl-imx7.h | ||
190 | index XXXXXXX..XXXXXXX 100644 | ||
191 | --- a/include/hw/arm/fsl-imx7.h | ||
192 | +++ b/include/hw/arm/fsl-imx7.h | ||
193 | @@ -XXX,XX +XXX,XX @@ | ||
194 | #ifndef FSL_IMX7_H | ||
195 | #define FSL_IMX7_H | ||
196 | |||
197 | -#include "hw/arm/arm.h" | ||
198 | +#include "hw/arm/boot.h" | ||
199 | #include "hw/cpu/a15mpcore.h" | ||
200 | #include "hw/intc/imx_gpcv2.h" | ||
201 | #include "hw/misc/imx7_ccm.h" | ||
202 | diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h | ||
203 | index XXXXXXX..XXXXXXX 100644 | ||
204 | --- a/include/hw/arm/virt.h | ||
205 | +++ b/include/hw/arm/virt.h | ||
206 | @@ -XXX,XX +XXX,XX @@ | ||
207 | #include "exec/hwaddr.h" | ||
208 | #include "qemu/notify.h" | ||
209 | #include "hw/boards.h" | ||
210 | -#include "hw/arm/arm.h" | ||
211 | +#include "hw/arm/boot.h" | ||
212 | #include "hw/block/flash.h" | ||
213 | #include "sysemu/kvm.h" | ||
214 | #include "hw/intc/arm_gicv3_common.h" | ||
215 | diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h | ||
216 | index XXXXXXX..XXXXXXX 100644 | ||
217 | --- a/include/hw/arm/xlnx-versal.h | ||
218 | +++ b/include/hw/arm/xlnx-versal.h | ||
219 | @@ -XXX,XX +XXX,XX @@ | ||
220 | #define XLNX_VERSAL_H | ||
221 | |||
222 | #include "hw/sysbus.h" | ||
223 | -#include "hw/arm/arm.h" | ||
224 | +#include "hw/arm/boot.h" | ||
225 | #include "hw/intc/arm_gicv3.h" | ||
226 | |||
227 | #define TYPE_XLNX_VERSAL "xlnx-versal" | ||
228 | diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h | ||
229 | index XXXXXXX..XXXXXXX 100644 | ||
230 | --- a/include/hw/arm/xlnx-zynqmp.h | ||
231 | +++ b/include/hw/arm/xlnx-zynqmp.h | ||
232 | @@ -XXX,XX +XXX,XX @@ | ||
233 | #ifndef XLNX_ZYNQMP_H | ||
234 | |||
235 | #include "qemu-common.h" | ||
236 | -#include "hw/arm/arm.h" | ||
237 | +#include "hw/arm/boot.h" | ||
238 | #include "hw/intc/arm_gic.h" | ||
239 | #include "hw/net/cadence_gem.h" | ||
240 | #include "hw/char/cadence_uart.h" | ||
241 | diff --git a/hw/arm/armsse.c b/hw/arm/armsse.c | ||
242 | index XXXXXXX..XXXXXXX 100644 | ||
243 | --- a/hw/arm/armsse.c | ||
244 | +++ b/hw/arm/armsse.c | ||
245 | @@ -XXX,XX +XXX,XX @@ | ||
246 | #include "hw/sysbus.h" | ||
247 | #include "hw/registerfields.h" | ||
248 | #include "hw/arm/armsse.h" | ||
249 | -#include "hw/arm/arm.h" | ||
250 | +#include "hw/arm/boot.h" | ||
251 | |||
252 | /* Format of the System Information block SYS_CONFIG register */ | ||
253 | typedef enum SysConfigFormat { | ||
254 | diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c | ||
255 | index XXXXXXX..XXXXXXX 100644 | ||
256 | --- a/hw/arm/armv7m.c | ||
257 | +++ b/hw/arm/armv7m.c | ||
258 | @@ -XXX,XX +XXX,XX @@ | ||
259 | #include "qemu-common.h" | ||
260 | #include "cpu.h" | ||
261 | #include "hw/sysbus.h" | ||
262 | -#include "hw/arm/arm.h" | ||
263 | +#include "hw/arm/boot.h" | ||
264 | #include "hw/loader.h" | ||
265 | #include "elf.h" | ||
266 | #include "sysemu/qtest.h" | ||
267 | diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c | ||
268 | index XXXXXXX..XXXXXXX 100644 | ||
269 | --- a/hw/arm/aspeed.c | ||
270 | +++ b/hw/arm/aspeed.c | ||
271 | @@ -XXX,XX +XXX,XX @@ | ||
272 | #include "qemu-common.h" | ||
273 | #include "cpu.h" | ||
274 | #include "exec/address-spaces.h" | ||
275 | -#include "hw/arm/arm.h" | ||
276 | +#include "hw/arm/boot.h" | ||
277 | #include "hw/arm/aspeed.h" | ||
278 | #include "hw/arm/aspeed_soc.h" | ||
279 | #include "hw/boards.h" | ||
280 | diff --git a/hw/arm/boot.c b/hw/arm/boot.c | ||
281 | index XXXXXXX..XXXXXXX 100644 | ||
282 | --- a/hw/arm/boot.c | ||
283 | +++ b/hw/arm/boot.c | ||
284 | @@ -XXX,XX +XXX,XX @@ | ||
285 | #include "qapi/error.h" | ||
286 | #include <libfdt.h> | ||
287 | #include "hw/hw.h" | ||
288 | -#include "hw/arm/arm.h" | ||
289 | +#include "hw/arm/boot.h" | ||
290 | #include "hw/arm/linux-boot-if.h" | ||
291 | #include "sysemu/kvm.h" | ||
292 | #include "sysemu/sysemu.h" | ||
293 | diff --git a/hw/arm/collie.c b/hw/arm/collie.c | ||
294 | index XXXXXXX..XXXXXXX 100644 | ||
295 | --- a/hw/arm/collie.c | ||
296 | +++ b/hw/arm/collie.c | ||
297 | @@ -XXX,XX +XXX,XX @@ | ||
298 | #include "hw/sysbus.h" | ||
299 | #include "hw/boards.h" | ||
300 | #include "strongarm.h" | ||
301 | -#include "hw/arm/arm.h" | ||
302 | +#include "hw/arm/boot.h" | ||
303 | #include "hw/block/flash.h" | ||
304 | #include "exec/address-spaces.h" | ||
305 | #include "cpu.h" | ||
306 | diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c | ||
307 | index XXXXXXX..XXXXXXX 100644 | ||
308 | --- a/hw/arm/exynos4210.c | ||
309 | +++ b/hw/arm/exynos4210.c | ||
310 | @@ -XXX,XX +XXX,XX @@ | ||
311 | #include "hw/boards.h" | ||
312 | #include "sysemu/sysemu.h" | ||
313 | #include "hw/sysbus.h" | ||
314 | -#include "hw/arm/arm.h" | ||
315 | +#include "hw/arm/boot.h" | ||
316 | #include "hw/loader.h" | ||
317 | #include "hw/arm/exynos4210.h" | ||
318 | #include "hw/sd/sdhci.h" | ||
319 | diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c | ||
320 | index XXXXXXX..XXXXXXX 100644 | ||
321 | --- a/hw/arm/exynos4_boards.c | ||
322 | +++ b/hw/arm/exynos4_boards.c | ||
323 | @@ -XXX,XX +XXX,XX @@ | ||
324 | #include "sysemu/sysemu.h" | ||
325 | #include "hw/sysbus.h" | ||
326 | #include "net/net.h" | ||
327 | -#include "hw/arm/arm.h" | ||
328 | +#include "hw/arm/boot.h" | ||
329 | #include "exec/address-spaces.h" | ||
330 | #include "hw/arm/exynos4210.h" | ||
331 | #include "hw/net/lan9118.h" | ||
332 | diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c | ||
333 | index XXXXXXX..XXXXXXX 100644 | ||
334 | --- a/hw/arm/highbank.c | ||
335 | +++ b/hw/arm/highbank.c | ||
336 | @@ -XXX,XX +XXX,XX @@ | ||
337 | #include "qemu/osdep.h" | ||
338 | #include "qapi/error.h" | ||
339 | #include "hw/sysbus.h" | ||
340 | -#include "hw/arm/arm.h" | ||
341 | +#include "hw/arm/boot.h" | ||
342 | #include "hw/loader.h" | ||
343 | #include "net/net.h" | ||
344 | #include "sysemu/kvm.h" | ||
345 | diff --git a/hw/arm/integratorcp.c b/hw/arm/integratorcp.c | ||
346 | index XXXXXXX..XXXXXXX 100644 | ||
347 | --- a/hw/arm/integratorcp.c | ||
348 | +++ b/hw/arm/integratorcp.c | ||
349 | @@ -XXX,XX +XXX,XX @@ | ||
350 | #include "cpu.h" | ||
351 | #include "hw/sysbus.h" | ||
352 | #include "hw/boards.h" | ||
353 | -#include "hw/arm/arm.h" | ||
354 | +#include "hw/arm/boot.h" | ||
355 | #include "hw/misc/arm_integrator_debug.h" | ||
356 | #include "hw/net/smc91c111.h" | ||
357 | #include "net/net.h" | ||
358 | diff --git a/hw/arm/mainstone.c b/hw/arm/mainstone.c | ||
359 | index XXXXXXX..XXXXXXX 100644 | ||
360 | --- a/hw/arm/mainstone.c | ||
361 | +++ b/hw/arm/mainstone.c | ||
362 | @@ -XXX,XX +XXX,XX @@ | ||
363 | #include "qapi/error.h" | ||
364 | #include "hw/hw.h" | ||
365 | #include "hw/arm/pxa.h" | ||
366 | -#include "hw/arm/arm.h" | ||
367 | +#include "hw/arm/boot.h" | ||
368 | #include "net/net.h" | ||
369 | #include "hw/net/smc91c111.h" | ||
370 | #include "hw/boards.h" | ||
371 | diff --git a/hw/arm/microbit.c b/hw/arm/microbit.c | ||
372 | index XXXXXXX..XXXXXXX 100644 | ||
373 | --- a/hw/arm/microbit.c | ||
374 | +++ b/hw/arm/microbit.c | ||
375 | @@ -XXX,XX +XXX,XX @@ | ||
376 | #include "qemu/osdep.h" | ||
377 | #include "qapi/error.h" | ||
378 | #include "hw/boards.h" | ||
379 | -#include "hw/arm/arm.h" | ||
380 | +#include "hw/arm/boot.h" | ||
381 | #include "sysemu/sysemu.h" | ||
382 | #include "exec/address-spaces.h" | ||
383 | |||
384 | diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c | 13 | diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c |
385 | index XXXXXXX..XXXXXXX 100644 | 14 | index XXXXXXX..XXXXXXX 100644 |
386 | --- a/hw/arm/mps2-tz.c | 15 | --- a/hw/arm/mps2-tz.c |
387 | +++ b/hw/arm/mps2-tz.c | 16 | +++ b/hw/arm/mps2-tz.c |
388 | @@ -XXX,XX +XXX,XX @@ | 17 | @@ -XXX,XX +XXX,XX @@ |
389 | #include "qemu/osdep.h" | 18 | * Application Note AN524: |
390 | #include "qapi/error.h" | 19 | * https://developer.arm.com/documentation/dai0524/latest/ |
391 | #include "qemu/error-report.h" | 20 | * Application Note AN547: |
392 | -#include "hw/arm/arm.h" | 21 | - * https://developer.arm.com/-/media/Arm%20Developer%20Community/PDF/DAI0547B_SSE300_PLUS_U55_FPGA_for_mps3.pdf |
393 | +#include "hw/arm/boot.h" | 22 | + * https://developer.arm.com/documentation/dai0547/latest/ |
394 | #include "hw/arm/armv7m.h" | 23 | * |
395 | #include "hw/or-irq.h" | 24 | * The AN505 defers to the Cortex-M33 processor ARMv8M IoT Kit FVP User Guide |
396 | #include "hw/boards.h" | 25 | * (ARM ECM0601256) for the details of some of the device layout: |
397 | diff --git a/hw/arm/mps2.c b/hw/arm/mps2.c | ||
398 | index XXXXXXX..XXXXXXX 100644 | ||
399 | --- a/hw/arm/mps2.c | ||
400 | +++ b/hw/arm/mps2.c | ||
401 | @@ -XXX,XX +XXX,XX @@ | ||
402 | #include "qemu/osdep.h" | ||
403 | #include "qapi/error.h" | ||
404 | #include "qemu/error-report.h" | ||
405 | -#include "hw/arm/arm.h" | ||
406 | +#include "hw/arm/boot.h" | ||
407 | #include "hw/arm/armv7m.h" | ||
408 | #include "hw/or-irq.h" | ||
409 | #include "hw/boards.h" | ||
410 | diff --git a/hw/arm/msf2-soc.c b/hw/arm/msf2-soc.c | ||
411 | index XXXXXXX..XXXXXXX 100644 | ||
412 | --- a/hw/arm/msf2-soc.c | ||
413 | +++ b/hw/arm/msf2-soc.c | ||
414 | @@ -XXX,XX +XXX,XX @@ | ||
415 | #include "qemu/units.h" | ||
416 | #include "qapi/error.h" | ||
417 | #include "qemu-common.h" | ||
418 | -#include "hw/arm/arm.h" | ||
419 | #include "exec/address-spaces.h" | ||
420 | #include "hw/char/serial.h" | ||
421 | #include "hw/boards.h" | ||
422 | diff --git a/hw/arm/msf2-som.c b/hw/arm/msf2-som.c | ||
423 | index XXXXXXX..XXXXXXX 100644 | ||
424 | --- a/hw/arm/msf2-som.c | ||
425 | +++ b/hw/arm/msf2-som.c | ||
426 | @@ -XXX,XX +XXX,XX @@ | ||
427 | #include "qapi/error.h" | ||
428 | #include "qemu/error-report.h" | ||
429 | #include "hw/boards.h" | ||
430 | -#include "hw/arm/arm.h" | ||
431 | +#include "hw/arm/boot.h" | ||
432 | #include "exec/address-spaces.h" | ||
433 | #include "hw/arm/msf2-soc.h" | ||
434 | #include "cpu.h" | ||
435 | diff --git a/hw/arm/musca.c b/hw/arm/musca.c | ||
436 | index XXXXXXX..XXXXXXX 100644 | ||
437 | --- a/hw/arm/musca.c | ||
438 | +++ b/hw/arm/musca.c | ||
439 | @@ -XXX,XX +XXX,XX @@ | ||
440 | #include "qapi/error.h" | ||
441 | #include "exec/address-spaces.h" | ||
442 | #include "sysemu/sysemu.h" | ||
443 | -#include "hw/arm/arm.h" | ||
444 | +#include "hw/arm/boot.h" | ||
445 | #include "hw/arm/armsse.h" | ||
446 | #include "hw/boards.h" | ||
447 | #include "hw/char/pl011.h" | ||
448 | diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c | ||
449 | index XXXXXXX..XXXXXXX 100644 | ||
450 | --- a/hw/arm/musicpal.c | ||
451 | +++ b/hw/arm/musicpal.c | ||
452 | @@ -XXX,XX +XXX,XX @@ | ||
453 | #include "qemu-common.h" | ||
454 | #include "cpu.h" | ||
455 | #include "hw/sysbus.h" | ||
456 | -#include "hw/arm/arm.h" | ||
457 | +#include "hw/arm/boot.h" | ||
458 | #include "net/net.h" | ||
459 | #include "sysemu/sysemu.h" | ||
460 | #include "hw/boards.h" | ||
461 | diff --git a/hw/arm/netduino2.c b/hw/arm/netduino2.c | ||
462 | index XXXXXXX..XXXXXXX 100644 | ||
463 | --- a/hw/arm/netduino2.c | ||
464 | +++ b/hw/arm/netduino2.c | ||
465 | @@ -XXX,XX +XXX,XX @@ | ||
466 | #include "hw/boards.h" | ||
467 | #include "qemu/error-report.h" | ||
468 | #include "hw/arm/stm32f205_soc.h" | ||
469 | -#include "hw/arm/arm.h" | ||
470 | +#include "hw/arm/boot.h" | ||
471 | |||
472 | static void netduino2_init(MachineState *machine) | ||
473 | { | ||
474 | diff --git a/hw/arm/nrf51_soc.c b/hw/arm/nrf51_soc.c | ||
475 | index XXXXXXX..XXXXXXX 100644 | ||
476 | --- a/hw/arm/nrf51_soc.c | ||
477 | +++ b/hw/arm/nrf51_soc.c | ||
478 | @@ -XXX,XX +XXX,XX @@ | ||
479 | #include "qemu/osdep.h" | ||
480 | #include "qapi/error.h" | ||
481 | #include "qemu-common.h" | ||
482 | -#include "hw/arm/arm.h" | ||
483 | +#include "hw/arm/boot.h" | ||
484 | #include "hw/sysbus.h" | ||
485 | #include "hw/boards.h" | ||
486 | #include "hw/misc/unimp.h" | ||
487 | diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c | ||
488 | index XXXXXXX..XXXXXXX 100644 | ||
489 | --- a/hw/arm/nseries.c | ||
490 | +++ b/hw/arm/nseries.c | ||
491 | @@ -XXX,XX +XXX,XX @@ | ||
492 | #include "qemu/bswap.h" | ||
493 | #include "sysemu/sysemu.h" | ||
494 | #include "hw/arm/omap.h" | ||
495 | -#include "hw/arm/arm.h" | ||
496 | +#include "hw/arm/boot.h" | ||
497 | #include "hw/irq.h" | ||
498 | #include "ui/console.h" | ||
499 | #include "hw/boards.h" | ||
500 | diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c | ||
501 | index XXXXXXX..XXXXXXX 100644 | ||
502 | --- a/hw/arm/omap1.c | ||
503 | +++ b/hw/arm/omap1.c | ||
504 | @@ -XXX,XX +XXX,XX @@ | ||
505 | #include "cpu.h" | ||
506 | #include "hw/boards.h" | ||
507 | #include "hw/hw.h" | ||
508 | -#include "hw/arm/arm.h" | ||
509 | +#include "hw/arm/boot.h" | ||
510 | #include "hw/arm/omap.h" | ||
511 | #include "sysemu/sysemu.h" | ||
512 | #include "hw/arm/soc_dma.h" | ||
513 | diff --git a/hw/arm/omap2.c b/hw/arm/omap2.c | ||
514 | index XXXXXXX..XXXXXXX 100644 | ||
515 | --- a/hw/arm/omap2.c | ||
516 | +++ b/hw/arm/omap2.c | ||
517 | @@ -XXX,XX +XXX,XX @@ | ||
518 | #include "sysemu/qtest.h" | ||
519 | #include "hw/boards.h" | ||
520 | #include "hw/hw.h" | ||
521 | -#include "hw/arm/arm.h" | ||
522 | +#include "hw/arm/boot.h" | ||
523 | #include "hw/arm/omap.h" | ||
524 | #include "sysemu/sysemu.h" | ||
525 | #include "qemu/timer.h" | ||
526 | diff --git a/hw/arm/omap_sx1.c b/hw/arm/omap_sx1.c | ||
527 | index XXXXXXX..XXXXXXX 100644 | ||
528 | --- a/hw/arm/omap_sx1.c | ||
529 | +++ b/hw/arm/omap_sx1.c | ||
530 | @@ -XXX,XX +XXX,XX @@ | ||
531 | #include "ui/console.h" | ||
532 | #include "hw/arm/omap.h" | ||
533 | #include "hw/boards.h" | ||
534 | -#include "hw/arm/arm.h" | ||
535 | +#include "hw/arm/boot.h" | ||
536 | #include "hw/block/flash.h" | ||
537 | #include "sysemu/qtest.h" | ||
538 | #include "exec/address-spaces.h" | ||
539 | diff --git a/hw/arm/palm.c b/hw/arm/palm.c | ||
540 | index XXXXXXX..XXXXXXX 100644 | ||
541 | --- a/hw/arm/palm.c | ||
542 | +++ b/hw/arm/palm.c | ||
543 | @@ -XXX,XX +XXX,XX @@ | ||
544 | #include "ui/console.h" | ||
545 | #include "hw/arm/omap.h" | ||
546 | #include "hw/boards.h" | ||
547 | -#include "hw/arm/arm.h" | ||
548 | +#include "hw/arm/boot.h" | ||
549 | #include "hw/input/tsc2xxx.h" | ||
550 | #include "hw/loader.h" | ||
551 | #include "exec/address-spaces.h" | ||
552 | diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c | ||
553 | index XXXXXXX..XXXXXXX 100644 | ||
554 | --- a/hw/arm/raspi.c | ||
555 | +++ b/hw/arm/raspi.c | ||
556 | @@ -XXX,XX +XXX,XX @@ | ||
557 | #include "qemu/error-report.h" | ||
558 | #include "hw/boards.h" | ||
559 | #include "hw/loader.h" | ||
560 | -#include "hw/arm/arm.h" | ||
561 | +#include "hw/arm/boot.h" | ||
562 | #include "sysemu/sysemu.h" | ||
563 | |||
564 | #define SMPBOOT_ADDR 0x300 /* this should leave enough space for ATAGS */ | ||
565 | diff --git a/hw/arm/realview.c b/hw/arm/realview.c | ||
566 | index XXXXXXX..XXXXXXX 100644 | ||
567 | --- a/hw/arm/realview.c | ||
568 | +++ b/hw/arm/realview.c | ||
569 | @@ -XXX,XX +XXX,XX @@ | ||
570 | #include "qemu-common.h" | ||
571 | #include "cpu.h" | ||
572 | #include "hw/sysbus.h" | ||
573 | -#include "hw/arm/arm.h" | ||
574 | +#include "hw/arm/boot.h" | ||
575 | #include "hw/arm/primecell.h" | ||
576 | #include "hw/net/lan9118.h" | ||
577 | #include "hw/net/smc91c111.h" | ||
578 | diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c | ||
579 | index XXXXXXX..XXXXXXX 100644 | ||
580 | --- a/hw/arm/spitz.c | ||
581 | +++ b/hw/arm/spitz.c | ||
582 | @@ -XXX,XX +XXX,XX @@ | ||
583 | #include "qapi/error.h" | ||
584 | #include "hw/hw.h" | ||
585 | #include "hw/arm/pxa.h" | ||
586 | -#include "hw/arm/arm.h" | ||
587 | +#include "hw/arm/boot.h" | ||
588 | #include "sysemu/sysemu.h" | ||
589 | #include "hw/pcmcia.h" | ||
590 | #include "hw/i2c/i2c.h" | ||
591 | diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c | ||
592 | index XXXXXXX..XXXXXXX 100644 | ||
593 | --- a/hw/arm/stellaris.c | ||
594 | +++ b/hw/arm/stellaris.c | ||
595 | @@ -XXX,XX +XXX,XX @@ | ||
596 | #include "qapi/error.h" | ||
597 | #include "hw/sysbus.h" | ||
598 | #include "hw/ssi/ssi.h" | ||
599 | -#include "hw/arm/arm.h" | ||
600 | +#include "hw/arm/boot.h" | ||
601 | #include "qemu/timer.h" | ||
602 | #include "hw/i2c/i2c.h" | ||
603 | #include "net/net.h" | ||
604 | diff --git a/hw/arm/stm32f205_soc.c b/hw/arm/stm32f205_soc.c | ||
605 | index XXXXXXX..XXXXXXX 100644 | ||
606 | --- a/hw/arm/stm32f205_soc.c | ||
607 | +++ b/hw/arm/stm32f205_soc.c | ||
608 | @@ -XXX,XX +XXX,XX @@ | ||
609 | #include "qemu/osdep.h" | ||
610 | #include "qapi/error.h" | ||
611 | #include "qemu-common.h" | ||
612 | -#include "hw/arm/arm.h" | ||
613 | +#include "hw/arm/boot.h" | ||
614 | #include "exec/address-spaces.h" | ||
615 | #include "hw/arm/stm32f205_soc.h" | ||
616 | |||
617 | diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c | ||
618 | index XXXXXXX..XXXXXXX 100644 | ||
619 | --- a/hw/arm/strongarm.c | ||
620 | +++ b/hw/arm/strongarm.c | ||
621 | @@ -XXX,XX +XXX,XX @@ | ||
622 | #include "hw/sysbus.h" | ||
623 | #include "strongarm.h" | ||
624 | #include "qemu/error-report.h" | ||
625 | -#include "hw/arm/arm.h" | ||
626 | +#include "hw/arm/boot.h" | ||
627 | #include "chardev/char-fe.h" | ||
628 | #include "chardev/char-serial.h" | ||
629 | #include "sysemu/sysemu.h" | ||
630 | diff --git a/hw/arm/tosa.c b/hw/arm/tosa.c | ||
631 | index XXXXXXX..XXXXXXX 100644 | ||
632 | --- a/hw/arm/tosa.c | ||
633 | +++ b/hw/arm/tosa.c | ||
634 | @@ -XXX,XX +XXX,XX @@ | ||
635 | #include "qapi/error.h" | ||
636 | #include "hw/hw.h" | ||
637 | #include "hw/arm/pxa.h" | ||
638 | -#include "hw/arm/arm.h" | ||
639 | +#include "hw/arm/boot.h" | ||
640 | #include "hw/arm/sharpsl.h" | ||
641 | #include "hw/pcmcia.h" | ||
642 | #include "hw/boards.h" | ||
643 | diff --git a/hw/arm/versatilepb.c b/hw/arm/versatilepb.c | ||
644 | index XXXXXXX..XXXXXXX 100644 | ||
645 | --- a/hw/arm/versatilepb.c | ||
646 | +++ b/hw/arm/versatilepb.c | ||
647 | @@ -XXX,XX +XXX,XX @@ | ||
648 | #include "qemu-common.h" | ||
649 | #include "cpu.h" | ||
650 | #include "hw/sysbus.h" | ||
651 | -#include "hw/arm/arm.h" | ||
652 | +#include "hw/arm/boot.h" | ||
653 | #include "hw/net/smc91c111.h" | ||
654 | #include "net/net.h" | ||
655 | #include "sysemu/sysemu.h" | ||
656 | diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c | ||
657 | index XXXXXXX..XXXXXXX 100644 | ||
658 | --- a/hw/arm/vexpress.c | ||
659 | +++ b/hw/arm/vexpress.c | ||
660 | @@ -XXX,XX +XXX,XX @@ | ||
661 | #include "qemu-common.h" | ||
662 | #include "cpu.h" | ||
663 | #include "hw/sysbus.h" | ||
664 | -#include "hw/arm/arm.h" | ||
665 | +#include "hw/arm/boot.h" | ||
666 | #include "hw/arm/primecell.h" | ||
667 | #include "hw/net/lan9118.h" | ||
668 | #include "hw/i2c/i2c.h" | ||
669 | diff --git a/hw/arm/virt.c b/hw/arm/virt.c | ||
670 | index XXXXXXX..XXXXXXX 100644 | ||
671 | --- a/hw/arm/virt.c | ||
672 | +++ b/hw/arm/virt.c | ||
673 | @@ -XXX,XX +XXX,XX @@ | ||
674 | #include "qemu/option.h" | ||
675 | #include "qapi/error.h" | ||
676 | #include "hw/sysbus.h" | ||
677 | -#include "hw/arm/arm.h" | ||
678 | +#include "hw/arm/boot.h" | ||
679 | #include "hw/arm/primecell.h" | ||
680 | #include "hw/arm/virt.h" | ||
681 | #include "hw/block/flash.h" | ||
682 | diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c | ||
683 | index XXXXXXX..XXXXXXX 100644 | ||
684 | --- a/hw/arm/xilinx_zynq.c | ||
685 | +++ b/hw/arm/xilinx_zynq.c | ||
686 | @@ -XXX,XX +XXX,XX @@ | ||
687 | #include "qemu-common.h" | ||
688 | #include "cpu.h" | ||
689 | #include "hw/sysbus.h" | ||
690 | -#include "hw/arm/arm.h" | ||
691 | +#include "hw/arm/boot.h" | ||
692 | #include "net/net.h" | ||
693 | #include "exec/address-spaces.h" | ||
694 | #include "sysemu/sysemu.h" | ||
695 | diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c | ||
696 | index XXXXXXX..XXXXXXX 100644 | ||
697 | --- a/hw/arm/xlnx-versal.c | ||
698 | +++ b/hw/arm/xlnx-versal.c | ||
699 | @@ -XXX,XX +XXX,XX @@ | ||
700 | #include "net/net.h" | ||
701 | #include "sysemu/sysemu.h" | ||
702 | #include "sysemu/kvm.h" | ||
703 | -#include "hw/arm/arm.h" | ||
704 | +#include "hw/arm/boot.h" | ||
705 | #include "kvm_arm.h" | ||
706 | #include "hw/misc/unimp.h" | ||
707 | #include "hw/intc/arm_gicv3_common.h" | ||
708 | diff --git a/hw/arm/z2.c b/hw/arm/z2.c | ||
709 | index XXXXXXX..XXXXXXX 100644 | ||
710 | --- a/hw/arm/z2.c | ||
711 | +++ b/hw/arm/z2.c | ||
712 | @@ -XXX,XX +XXX,XX @@ | ||
713 | #include "qemu/osdep.h" | ||
714 | #include "hw/hw.h" | ||
715 | #include "hw/arm/pxa.h" | ||
716 | -#include "hw/arm/arm.h" | ||
717 | +#include "hw/arm/boot.h" | ||
718 | #include "hw/i2c/i2c.h" | ||
719 | #include "hw/ssi/ssi.h" | ||
720 | #include "hw/boards.h" | ||
721 | -- | 26 | -- |
722 | 2.20.1 | 27 | 2.25.1 |
723 | 28 | ||
724 | 29 | diff view generated by jsdifflib |
1 | In ich_vmcr_write() we enforce "writes of BPR fields to less than | 1 | The tsc210x doesn't support anything other than 16-bit reads on the |
---|---|---|---|
2 | their minimum sets them to the minimum" by doing a "read vbpr and | 2 | SPI bus, but the guest can program the SPI controller to attempt |
3 | write it back" operation. A typo here meant that we weren't handling | 3 | them anyway. If this happens, don't abort QEMU, just log this as |
4 | writes to these fields correctly, because we were reading from VBPR0 | 4 | a guest error. |
5 | but writing to VBPR1. | ||
6 | 5 | ||
6 | This fixes our machine_arm_n8x0.py:N8x0Machine.test_n800 | ||
7 | acceptance test, which hits this assertion. | ||
8 | |||
9 | The reason we hit the assertion is because the guest kernel thinks | ||
10 | there is a TSC2005 on this SPI bus address, not a TSC210x. (The n810 | ||
11 | *does* have a TSC2005 at this address.) The TSC2005 supports the | ||
12 | 24-bit accesses which the guest driver makes, and the TSC210x does | ||
13 | not (that is, our TSC210x emulation is not missing support for a word | ||
14 | width the hardware can handle). It's not clear whether the problem | ||
15 | here is that the guest kernel incorrectly thinks the n800 has the | ||
16 | same device at this SPI bus address as the n810, or that QEMU's n810 | ||
17 | board model doesn't get the SPI devices right. At this late date | ||
18 | there no longer appears to be any reliable information on the web | ||
19 | about the hardware behaviour, but I am inclined to think this is a | ||
20 | guest kernel bug. In any case, we prefer not to abort QEMU for | ||
21 | guest-triggerable conditions, so logging the error is the right thing | ||
22 | to do. | ||
23 | |||
24 | Resolves: https://gitlab.com/qemu-project/qemu/-/issues/736 | ||
7 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 25 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
8 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | 26 | Reviewed-by: Alex Bennée <alex.bennee@linaro.org> |
9 | Message-id: 20190520162809.2677-4-peter.maydell@linaro.org | 27 | Message-id: 20220221140750.514557-1-peter.maydell@linaro.org |
10 | --- | 28 | --- |
11 | hw/intc/arm_gicv3_cpuif.c | 2 +- | 29 | hw/input/tsc210x.c | 8 ++++++-- |
12 | 1 file changed, 1 insertion(+), 1 deletion(-) | 30 | 1 file changed, 6 insertions(+), 2 deletions(-) |
13 | 31 | ||
14 | diff --git a/hw/intc/arm_gicv3_cpuif.c b/hw/intc/arm_gicv3_cpuif.c | 32 | diff --git a/hw/input/tsc210x.c b/hw/input/tsc210x.c |
15 | index XXXXXXX..XXXXXXX 100644 | 33 | index XXXXXXX..XXXXXXX 100644 |
16 | --- a/hw/intc/arm_gicv3_cpuif.c | 34 | --- a/hw/input/tsc210x.c |
17 | +++ b/hw/intc/arm_gicv3_cpuif.c | 35 | +++ b/hw/input/tsc210x.c |
18 | @@ -XXX,XX +XXX,XX @@ static void ich_vmcr_write(CPUARMState *env, const ARMCPRegInfo *ri, | 36 | @@ -XXX,XX +XXX,XX @@ |
19 | /* Enforce "writing BPRs to less than minimum sets them to the minimum" | 37 | #include "hw/hw.h" |
20 | * by reading and writing back the fields. | 38 | #include "audio/audio.h" |
21 | */ | 39 | #include "qemu/timer.h" |
22 | - write_vbpr(cs, GICV3_G1, read_vbpr(cs, GICV3_G0)); | 40 | +#include "qemu/log.h" |
23 | + write_vbpr(cs, GICV3_G0, read_vbpr(cs, GICV3_G0)); | 41 | #include "sysemu/reset.h" |
24 | write_vbpr(cs, GICV3_G1, read_vbpr(cs, GICV3_G1)); | 42 | #include "ui/console.h" |
25 | 43 | #include "hw/arm/omap.h" /* For I2SCodec */ | |
26 | gicv3_cpuif_virt_update(cs); | 44 | @@ -XXX,XX +XXX,XX @@ uint32_t tsc210x_txrx(void *opaque, uint32_t value, int len) |
45 | TSC210xState *s = opaque; | ||
46 | uint32_t ret = 0; | ||
47 | |||
48 | - if (len != 16) | ||
49 | - hw_error("%s: FIXME: bad SPI word width %i\n", __func__, len); | ||
50 | + if (len != 16) { | ||
51 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
52 | + "%s: bad SPI word width %i\n", __func__, len); | ||
53 | + return 0; | ||
54 | + } | ||
55 | |||
56 | /* TODO: sequential reads etc - how do we make sure the host doesn't | ||
57 | * unintentionally read out a conversion result from a register while | ||
27 | -- | 58 | -- |
28 | 2.20.1 | 59 | 2.25.1 |
29 | 60 | ||
30 | 61 | diff view generated by jsdifflib |
1 | From: Philippe Mathieu-Daudé <philmd@redhat.com> | 1 | From: Patrick Venture <venture@google.com> |
---|---|---|---|
2 | 2 | ||
3 | It eases code review, unit is explicit. | 3 | Previously this device created N subdevices which each owned an i2c bus. |
4 | Now this device simply owns the N i2c busses directly. | ||
4 | 5 | ||
5 | Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> | 6 | Tested: Verified devices behind mux are still accessible via qmp and i2c |
6 | Reviewed-by: Alistair Francis <alistair.francis@wdc.com> | 7 | from within an arm32 SoC. |
7 | Message-id: 20190520214342.13709-3-philmd@redhat.com | 8 | |
9 | Reviewed-by: Hao Wu <wuhaotsh@google.com> | ||
10 | Signed-off-by: Patrick Venture <venture@google.com> | ||
11 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
12 | Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
13 | Message-id: 20220202164533.1283668-1-venture@google.com | ||
8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 14 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
9 | --- | 15 | --- |
10 | hw/arm/exynos4_boards.c | 5 +++-- | 16 | hw/i2c/i2c_mux_pca954x.c | 77 +++++++--------------------------------- |
11 | 1 file changed, 3 insertions(+), 2 deletions(-) | 17 | 1 file changed, 13 insertions(+), 64 deletions(-) |
12 | 18 | ||
13 | diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c | 19 | diff --git a/hw/i2c/i2c_mux_pca954x.c b/hw/i2c/i2c_mux_pca954x.c |
14 | index XXXXXXX..XXXXXXX 100644 | 20 | index XXXXXXX..XXXXXXX 100644 |
15 | --- a/hw/arm/exynos4_boards.c | 21 | --- a/hw/i2c/i2c_mux_pca954x.c |
16 | +++ b/hw/arm/exynos4_boards.c | 22 | +++ b/hw/i2c/i2c_mux_pca954x.c |
17 | @@ -XXX,XX +XXX,XX @@ | 23 | @@ -XXX,XX +XXX,XX @@ |
18 | */ | 24 | #define PCA9548_CHANNEL_COUNT 8 |
19 | 25 | #define PCA9546_CHANNEL_COUNT 4 | |
20 | #include "qemu/osdep.h" | 26 | |
21 | +#include "qemu/units.h" | 27 | -/* |
22 | #include "qapi/error.h" | 28 | - * struct Pca954xChannel - The i2c mux device will have N of these states |
23 | #include "qemu/error-report.h" | 29 | - * that own the i2c channel bus. |
24 | #include "qemu-common.h" | 30 | - * @bus: The owned channel bus. |
25 | @@ -XXX,XX +XXX,XX @@ static int exynos4_board_smp_bootreg_addr[EXYNOS4_NUM_OF_BOARDS] = { | 31 | - * @enabled: Is this channel active? |
32 | - */ | ||
33 | -typedef struct Pca954xChannel { | ||
34 | - SysBusDevice parent; | ||
35 | - | ||
36 | - I2CBus *bus; | ||
37 | - | ||
38 | - bool enabled; | ||
39 | -} Pca954xChannel; | ||
40 | - | ||
41 | -#define TYPE_PCA954X_CHANNEL "pca954x-channel" | ||
42 | -#define PCA954X_CHANNEL(obj) \ | ||
43 | - OBJECT_CHECK(Pca954xChannel, (obj), TYPE_PCA954X_CHANNEL) | ||
44 | - | ||
45 | /* | ||
46 | * struct Pca954xState - The pca954x state object. | ||
47 | * @control: The value written to the mux control. | ||
48 | @@ -XXX,XX +XXX,XX @@ typedef struct Pca954xState { | ||
49 | |||
50 | uint8_t control; | ||
51 | |||
52 | - /* The channel i2c buses. */ | ||
53 | - Pca954xChannel channel[PCA9548_CHANNEL_COUNT]; | ||
54 | + bool enabled[PCA9548_CHANNEL_COUNT]; | ||
55 | + I2CBus *bus[PCA9548_CHANNEL_COUNT]; | ||
56 | } Pca954xState; | ||
57 | |||
58 | /* | ||
59 | @@ -XXX,XX +XXX,XX @@ static bool pca954x_match(I2CSlave *candidate, uint8_t address, | ||
60 | } | ||
61 | |||
62 | for (i = 0; i < mc->nchans; i++) { | ||
63 | - if (!mux->channel[i].enabled) { | ||
64 | + if (!mux->enabled[i]) { | ||
65 | continue; | ||
66 | } | ||
67 | |||
68 | - if (i2c_scan_bus(mux->channel[i].bus, address, broadcast, | ||
69 | + if (i2c_scan_bus(mux->bus[i], address, broadcast, | ||
70 | current_devs)) { | ||
71 | if (!broadcast) { | ||
72 | return true; | ||
73 | @@ -XXX,XX +XXX,XX @@ static void pca954x_enable_channel(Pca954xState *s, uint8_t enable_mask) | ||
74 | */ | ||
75 | for (i = 0; i < mc->nchans; i++) { | ||
76 | if (enable_mask & (1 << i)) { | ||
77 | - s->channel[i].enabled = true; | ||
78 | + s->enabled[i] = true; | ||
79 | } else { | ||
80 | - s->channel[i].enabled = false; | ||
81 | + s->enabled[i] = false; | ||
82 | } | ||
83 | } | ||
84 | } | ||
85 | @@ -XXX,XX +XXX,XX @@ I2CBus *pca954x_i2c_get_bus(I2CSlave *mux, uint8_t channel) | ||
86 | Pca954xState *pca954x = PCA954X(mux); | ||
87 | |||
88 | g_assert(channel < pc->nchans); | ||
89 | - return I2C_BUS(qdev_get_child_bus(DEVICE(&pca954x->channel[channel]), | ||
90 | - "i2c-bus")); | ||
91 | -} | ||
92 | - | ||
93 | -static void pca954x_channel_init(Object *obj) | ||
94 | -{ | ||
95 | - Pca954xChannel *s = PCA954X_CHANNEL(obj); | ||
96 | - s->bus = i2c_init_bus(DEVICE(s), "i2c-bus"); | ||
97 | - | ||
98 | - /* Start all channels as disabled. */ | ||
99 | - s->enabled = false; | ||
100 | -} | ||
101 | - | ||
102 | -static void pca954x_channel_class_init(ObjectClass *klass, void *data) | ||
103 | -{ | ||
104 | - DeviceClass *dc = DEVICE_CLASS(klass); | ||
105 | - dc->desc = "Pca954x Channel"; | ||
106 | + return pca954x->bus[channel]; | ||
107 | } | ||
108 | |||
109 | static void pca9546_class_init(ObjectClass *klass, void *data) | ||
110 | @@ -XXX,XX +XXX,XX @@ static void pca9548_class_init(ObjectClass *klass, void *data) | ||
111 | s->nchans = PCA9548_CHANNEL_COUNT; | ||
112 | } | ||
113 | |||
114 | -static void pca954x_realize(DeviceState *dev, Error **errp) | ||
115 | -{ | ||
116 | - Pca954xState *s = PCA954X(dev); | ||
117 | - Pca954xClass *c = PCA954X_GET_CLASS(s); | ||
118 | - int i; | ||
119 | - | ||
120 | - /* SMBus modules. Cannot fail. */ | ||
121 | - for (i = 0; i < c->nchans; i++) { | ||
122 | - sysbus_realize(SYS_BUS_DEVICE(&s->channel[i]), &error_abort); | ||
123 | - } | ||
124 | -} | ||
125 | - | ||
126 | static void pca954x_init(Object *obj) | ||
127 | { | ||
128 | Pca954xState *s = PCA954X(obj); | ||
129 | Pca954xClass *c = PCA954X_GET_CLASS(obj); | ||
130 | int i; | ||
131 | |||
132 | - /* Only initialize the children we expect. */ | ||
133 | + /* SMBus modules. Cannot fail. */ | ||
134 | for (i = 0; i < c->nchans; i++) { | ||
135 | - object_initialize_child(obj, "channel[*]", &s->channel[i], | ||
136 | - TYPE_PCA954X_CHANNEL); | ||
137 | + g_autofree gchar *bus_name = g_strdup_printf("i2c.%d", i); | ||
138 | + | ||
139 | + /* start all channels as disabled. */ | ||
140 | + s->enabled[i] = false; | ||
141 | + s->bus[i] = i2c_init_bus(DEVICE(s), bus_name); | ||
142 | } | ||
143 | } | ||
144 | |||
145 | @@ -XXX,XX +XXX,XX @@ static void pca954x_class_init(ObjectClass *klass, void *data) | ||
146 | rc->phases.enter = pca954x_enter_reset; | ||
147 | |||
148 | dc->desc = "Pca954x i2c-mux"; | ||
149 | - dc->realize = pca954x_realize; | ||
150 | |||
151 | k->write_data = pca954x_write_data; | ||
152 | k->receive_byte = pca954x_read_byte; | ||
153 | @@ -XXX,XX +XXX,XX @@ static const TypeInfo pca954x_info[] = { | ||
154 | .parent = TYPE_PCA954X, | ||
155 | .class_init = pca9548_class_init, | ||
156 | }, | ||
157 | - { | ||
158 | - .name = TYPE_PCA954X_CHANNEL, | ||
159 | - .parent = TYPE_SYS_BUS_DEVICE, | ||
160 | - .class_init = pca954x_channel_class_init, | ||
161 | - .instance_size = sizeof(Pca954xChannel), | ||
162 | - .instance_init = pca954x_channel_init, | ||
163 | - } | ||
26 | }; | 164 | }; |
27 | 165 | ||
28 | static unsigned long exynos4_board_ram_size[EXYNOS4_NUM_OF_BOARDS] = { | 166 | DEFINE_TYPES(pca954x_info) |
29 | - [EXYNOS4_BOARD_NURI] = 0x40000000, | ||
30 | - [EXYNOS4_BOARD_SMDKC210] = 0x40000000, | ||
31 | + [EXYNOS4_BOARD_NURI] = 1 * GiB, | ||
32 | + [EXYNOS4_BOARD_SMDKC210] = 1 * GiB, | ||
33 | }; | ||
34 | |||
35 | static struct arm_boot_info exynos4_board_binfo = { | ||
36 | -- | 167 | -- |
37 | 2.20.1 | 168 | 2.25.1 |
38 | 169 | ||
39 | 170 | diff view generated by jsdifflib |
1 | The hw/arm/arm.h header now only includes declarations relating | 1 | From: Akihiko Odaki <akihiko.odaki@gmail.com> |
---|---|---|---|
2 | to boot.c code, so it is only needed by Arm board or SoC code. | ||
3 | Remove some unnecessary inclusions of it from target/arm files | ||
4 | and from hw/intc/armv7m_nvic.c. | ||
5 | 2 | ||
3 | Support the latest PSCI on TCG and HVF. A 64-bit function called from | ||
4 | AArch32 now returns NOT_SUPPORTED, which is necessary to adhere to SMC | ||
5 | Calling Convention 1.0. It is still not compliant with SMCCC 1.3 since | ||
6 | they do not implement mandatory functions. | ||
7 | |||
8 | Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com> | ||
9 | Message-id: 20220213035753.34577-1-akihiko.odaki@gmail.com | ||
10 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
11 | [PMM: update MISMATCH_CHECK checks on PSCI_VERSION macros to match] | ||
6 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 12 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
7 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
8 | Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
9 | Message-id: 20190516163857.6430-3-peter.maydell@linaro.org | ||
10 | --- | 13 | --- |
11 | hw/intc/armv7m_nvic.c | 1 - | 14 | target/arm/kvm-consts.h | 13 +++++++++---- |
12 | target/arm/arm-semi.c | 1 - | 15 | hw/arm/boot.c | 12 +++++++++--- |
13 | target/arm/cpu.c | 1 - | 16 | target/arm/cpu.c | 5 +++-- |
14 | target/arm/cpu64.c | 1 - | 17 | target/arm/hvf/hvf.c | 27 ++++++++++++++++++++++++++- |
15 | target/arm/kvm.c | 1 - | 18 | target/arm/kvm64.c | 2 +- |
16 | target/arm/kvm32.c | 1 - | 19 | target/arm/psci.c | 35 ++++++++++++++++++++++++++++++++--- |
17 | target/arm/kvm64.c | 1 - | 20 | 6 files changed, 80 insertions(+), 14 deletions(-) |
18 | 7 files changed, 7 deletions(-) | ||
19 | 21 | ||
20 | diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c | 22 | diff --git a/target/arm/kvm-consts.h b/target/arm/kvm-consts.h |
21 | index XXXXXXX..XXXXXXX 100644 | 23 | index XXXXXXX..XXXXXXX 100644 |
22 | --- a/hw/intc/armv7m_nvic.c | 24 | --- a/target/arm/kvm-consts.h |
23 | +++ b/hw/intc/armv7m_nvic.c | 25 | +++ b/target/arm/kvm-consts.h |
24 | @@ -XXX,XX +XXX,XX @@ | 26 | @@ -XXX,XX +XXX,XX @@ MISMATCH_CHECK(QEMU_PSCI_0_1_FN_MIGRATE, KVM_PSCI_FN_MIGRATE); |
25 | #include "cpu.h" | 27 | #define QEMU_PSCI_0_2_FN64_AFFINITY_INFO QEMU_PSCI_0_2_FN64(4) |
26 | #include "hw/sysbus.h" | 28 | #define QEMU_PSCI_0_2_FN64_MIGRATE QEMU_PSCI_0_2_FN64(5) |
27 | #include "qemu/timer.h" | 29 | |
28 | -#include "hw/arm/arm.h" | 30 | +#define QEMU_PSCI_1_0_FN_PSCI_FEATURES QEMU_PSCI_0_2_FN(10) |
29 | #include "hw/intc/armv7m_nvic.h" | 31 | + |
30 | #include "target/arm/cpu.h" | 32 | MISMATCH_CHECK(QEMU_PSCI_0_2_FN_CPU_SUSPEND, PSCI_0_2_FN_CPU_SUSPEND); |
31 | #include "exec/exec-all.h" | 33 | MISMATCH_CHECK(QEMU_PSCI_0_2_FN_CPU_OFF, PSCI_0_2_FN_CPU_OFF); |
32 | diff --git a/target/arm/arm-semi.c b/target/arm/arm-semi.c | 34 | MISMATCH_CHECK(QEMU_PSCI_0_2_FN_CPU_ON, PSCI_0_2_FN_CPU_ON); |
33 | index XXXXXXX..XXXXXXX 100644 | 35 | @@ -XXX,XX +XXX,XX @@ MISMATCH_CHECK(QEMU_PSCI_0_2_FN_MIGRATE, PSCI_0_2_FN_MIGRATE); |
34 | --- a/target/arm/arm-semi.c | 36 | MISMATCH_CHECK(QEMU_PSCI_0_2_FN64_CPU_SUSPEND, PSCI_0_2_FN64_CPU_SUSPEND); |
35 | +++ b/target/arm/arm-semi.c | 37 | MISMATCH_CHECK(QEMU_PSCI_0_2_FN64_CPU_ON, PSCI_0_2_FN64_CPU_ON); |
36 | @@ -XXX,XX +XXX,XX @@ | 38 | MISMATCH_CHECK(QEMU_PSCI_0_2_FN64_MIGRATE, PSCI_0_2_FN64_MIGRATE); |
37 | #else | 39 | +MISMATCH_CHECK(QEMU_PSCI_1_0_FN_PSCI_FEATURES, PSCI_1_0_FN_PSCI_FEATURES); |
38 | #include "qemu-common.h" | 40 | |
39 | #include "exec/gdbstub.h" | 41 | /* PSCI v0.2 return values used by TCG emulation of PSCI */ |
40 | -#include "hw/arm/arm.h" | 42 | |
41 | #include "qemu/cutils.h" | 43 | /* No Trusted OS migration to worry about when offlining CPUs */ |
42 | #endif | 44 | #define QEMU_PSCI_0_2_RET_TOS_MIGRATION_NOT_REQUIRED 2 |
43 | 45 | ||
46 | -/* We implement version 0.2 only */ | ||
47 | -#define QEMU_PSCI_0_2_RET_VERSION_0_2 2 | ||
48 | +#define QEMU_PSCI_VERSION_0_1 0x00001 | ||
49 | +#define QEMU_PSCI_VERSION_0_2 0x00002 | ||
50 | +#define QEMU_PSCI_VERSION_1_1 0x10001 | ||
51 | |||
52 | MISMATCH_CHECK(QEMU_PSCI_0_2_RET_TOS_MIGRATION_NOT_REQUIRED, PSCI_0_2_TOS_MP); | ||
53 | -MISMATCH_CHECK(QEMU_PSCI_0_2_RET_VERSION_0_2, | ||
54 | - (PSCI_VERSION_MAJOR(0) | PSCI_VERSION_MINOR(2))); | ||
55 | +/* We don't bother to check every possible version value */ | ||
56 | +MISMATCH_CHECK(QEMU_PSCI_VERSION_0_2, PSCI_VERSION(0, 2)); | ||
57 | +MISMATCH_CHECK(QEMU_PSCI_VERSION_1_1, PSCI_VERSION(1, 1)); | ||
58 | |||
59 | /* PSCI return values (inclusive of all PSCI versions) */ | ||
60 | #define QEMU_PSCI_RET_SUCCESS 0 | ||
61 | diff --git a/hw/arm/boot.c b/hw/arm/boot.c | ||
62 | index XXXXXXX..XXXXXXX 100644 | ||
63 | --- a/hw/arm/boot.c | ||
64 | +++ b/hw/arm/boot.c | ||
65 | @@ -XXX,XX +XXX,XX @@ static void fdt_add_psci_node(void *fdt) | ||
66 | } | ||
67 | |||
68 | qemu_fdt_add_subnode(fdt, "/psci"); | ||
69 | - if (armcpu->psci_version == 2) { | ||
70 | - const char comp[] = "arm,psci-0.2\0arm,psci"; | ||
71 | - qemu_fdt_setprop(fdt, "/psci", "compatible", comp, sizeof(comp)); | ||
72 | + if (armcpu->psci_version == QEMU_PSCI_VERSION_0_2 || | ||
73 | + armcpu->psci_version == QEMU_PSCI_VERSION_1_1) { | ||
74 | + if (armcpu->psci_version == QEMU_PSCI_VERSION_0_2) { | ||
75 | + const char comp[] = "arm,psci-0.2\0arm,psci"; | ||
76 | + qemu_fdt_setprop(fdt, "/psci", "compatible", comp, sizeof(comp)); | ||
77 | + } else { | ||
78 | + const char comp[] = "arm,psci-1.0\0arm,psci-0.2\0arm,psci"; | ||
79 | + qemu_fdt_setprop(fdt, "/psci", "compatible", comp, sizeof(comp)); | ||
80 | + } | ||
81 | |||
82 | cpu_off_fn = QEMU_PSCI_0_2_FN_CPU_OFF; | ||
83 | if (arm_feature(&armcpu->env, ARM_FEATURE_AARCH64)) { | ||
44 | diff --git a/target/arm/cpu.c b/target/arm/cpu.c | 84 | diff --git a/target/arm/cpu.c b/target/arm/cpu.c |
45 | index XXXXXXX..XXXXXXX 100644 | 85 | index XXXXXXX..XXXXXXX 100644 |
46 | --- a/target/arm/cpu.c | 86 | --- a/target/arm/cpu.c |
47 | +++ b/target/arm/cpu.c | 87 | +++ b/target/arm/cpu.c |
48 | @@ -XXX,XX +XXX,XX @@ | 88 | @@ -XXX,XX +XXX,XX @@ static void arm_cpu_initfn(Object *obj) |
49 | #if !defined(CONFIG_USER_ONLY) | 89 | * picky DTB consumer will also provide a helpful error message. |
50 | #include "hw/loader.h" | 90 | */ |
51 | #endif | 91 | cpu->dtb_compatible = "qemu,unknown"; |
52 | -#include "hw/arm/arm.h" | 92 | - cpu->psci_version = 1; /* By default assume PSCI v0.1 */ |
53 | #include "sysemu/sysemu.h" | 93 | + cpu->psci_version = QEMU_PSCI_VERSION_0_1; /* By default assume PSCI v0.1 */ |
54 | #include "sysemu/hw_accel.h" | 94 | cpu->kvm_target = QEMU_KVM_ARM_TARGET_NONE; |
55 | #include "kvm_arm.h" | 95 | |
56 | diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c | 96 | if (tcg_enabled() || hvf_enabled()) { |
57 | index XXXXXXX..XXXXXXX 100644 | 97 | - cpu->psci_version = 2; /* TCG and HVF implement PSCI 0.2 */ |
58 | --- a/target/arm/cpu64.c | 98 | + /* TCG and HVF implement PSCI 1.1 */ |
59 | +++ b/target/arm/cpu64.c | 99 | + cpu->psci_version = QEMU_PSCI_VERSION_1_1; |
60 | @@ -XXX,XX +XXX,XX @@ | 100 | } |
61 | #if !defined(CONFIG_USER_ONLY) | 101 | } |
62 | #include "hw/loader.h" | 102 | |
63 | #endif | 103 | diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c |
64 | -#include "hw/arm/arm.h" | 104 | index XXXXXXX..XXXXXXX 100644 |
65 | #include "sysemu/sysemu.h" | 105 | --- a/target/arm/hvf/hvf.c |
66 | #include "sysemu/kvm.h" | 106 | +++ b/target/arm/hvf/hvf.c |
67 | #include "kvm_arm.h" | 107 | @@ -XXX,XX +XXX,XX @@ static bool hvf_handle_psci_call(CPUState *cpu) |
68 | diff --git a/target/arm/kvm.c b/target/arm/kvm.c | 108 | |
69 | index XXXXXXX..XXXXXXX 100644 | 109 | switch (param[0]) { |
70 | --- a/target/arm/kvm.c | 110 | case QEMU_PSCI_0_2_FN_PSCI_VERSION: |
71 | +++ b/target/arm/kvm.c | 111 | - ret = QEMU_PSCI_0_2_RET_VERSION_0_2; |
72 | @@ -XXX,XX +XXX,XX @@ | 112 | + ret = QEMU_PSCI_VERSION_1_1; |
73 | #include "cpu.h" | 113 | break; |
74 | #include "trace.h" | 114 | case QEMU_PSCI_0_2_FN_MIGRATE_INFO_TYPE: |
75 | #include "internals.h" | 115 | ret = QEMU_PSCI_0_2_RET_TOS_MIGRATION_NOT_REQUIRED; /* No trusted OS */ |
76 | -#include "hw/arm/arm.h" | 116 | @@ -XXX,XX +XXX,XX @@ static bool hvf_handle_psci_call(CPUState *cpu) |
77 | #include "hw/pci/pci.h" | 117 | case QEMU_PSCI_0_2_FN_MIGRATE: |
78 | #include "exec/memattrs.h" | 118 | ret = QEMU_PSCI_RET_NOT_SUPPORTED; |
79 | #include "exec/address-spaces.h" | 119 | break; |
80 | diff --git a/target/arm/kvm32.c b/target/arm/kvm32.c | 120 | + case QEMU_PSCI_1_0_FN_PSCI_FEATURES: |
81 | index XXXXXXX..XXXXXXX 100644 | 121 | + switch (param[1]) { |
82 | --- a/target/arm/kvm32.c | 122 | + case QEMU_PSCI_0_2_FN_PSCI_VERSION: |
83 | +++ b/target/arm/kvm32.c | 123 | + case QEMU_PSCI_0_2_FN_MIGRATE_INFO_TYPE: |
84 | @@ -XXX,XX +XXX,XX @@ | 124 | + case QEMU_PSCI_0_2_FN_AFFINITY_INFO: |
85 | #include "sysemu/kvm.h" | 125 | + case QEMU_PSCI_0_2_FN64_AFFINITY_INFO: |
86 | #include "kvm_arm.h" | 126 | + case QEMU_PSCI_0_2_FN_SYSTEM_RESET: |
87 | #include "internals.h" | 127 | + case QEMU_PSCI_0_2_FN_SYSTEM_OFF: |
88 | -#include "hw/arm/arm.h" | 128 | + case QEMU_PSCI_0_1_FN_CPU_ON: |
89 | #include "qemu/log.h" | 129 | + case QEMU_PSCI_0_2_FN_CPU_ON: |
90 | 130 | + case QEMU_PSCI_0_2_FN64_CPU_ON: | |
91 | static inline void set_feature(uint64_t *features, int feature) | 131 | + case QEMU_PSCI_0_1_FN_CPU_OFF: |
132 | + case QEMU_PSCI_0_2_FN_CPU_OFF: | ||
133 | + case QEMU_PSCI_0_1_FN_CPU_SUSPEND: | ||
134 | + case QEMU_PSCI_0_2_FN_CPU_SUSPEND: | ||
135 | + case QEMU_PSCI_0_2_FN64_CPU_SUSPEND: | ||
136 | + case QEMU_PSCI_1_0_FN_PSCI_FEATURES: | ||
137 | + ret = 0; | ||
138 | + break; | ||
139 | + case QEMU_PSCI_0_1_FN_MIGRATE: | ||
140 | + case QEMU_PSCI_0_2_FN_MIGRATE: | ||
141 | + default: | ||
142 | + ret = QEMU_PSCI_RET_NOT_SUPPORTED; | ||
143 | + } | ||
144 | + break; | ||
145 | default: | ||
146 | return false; | ||
147 | } | ||
92 | diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c | 148 | diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c |
93 | index XXXXXXX..XXXXXXX 100644 | 149 | index XXXXXXX..XXXXXXX 100644 |
94 | --- a/target/arm/kvm64.c | 150 | --- a/target/arm/kvm64.c |
95 | +++ b/target/arm/kvm64.c | 151 | +++ b/target/arm/kvm64.c |
96 | @@ -XXX,XX +XXX,XX @@ | 152 | @@ -XXX,XX +XXX,XX @@ int kvm_arch_init_vcpu(CPUState *cs) |
97 | #include "sysemu/kvm.h" | 153 | cpu->kvm_init_features[0] |= 1 << KVM_ARM_VCPU_POWER_OFF; |
98 | #include "kvm_arm.h" | 154 | } |
99 | #include "internals.h" | 155 | if (kvm_check_extension(cs->kvm_state, KVM_CAP_ARM_PSCI_0_2)) { |
100 | -#include "hw/arm/arm.h" | 156 | - cpu->psci_version = 2; |
101 | 157 | + cpu->psci_version = QEMU_PSCI_VERSION_0_2; | |
102 | static bool have_guest_debug; | 158 | cpu->kvm_init_features[0] |= 1 << KVM_ARM_VCPU_PSCI_0_2; |
103 | 159 | } | |
160 | if (!arm_feature(&cpu->env, ARM_FEATURE_AARCH64)) { | ||
161 | diff --git a/target/arm/psci.c b/target/arm/psci.c | ||
162 | index XXXXXXX..XXXXXXX 100644 | ||
163 | --- a/target/arm/psci.c | ||
164 | +++ b/target/arm/psci.c | ||
165 | @@ -XXX,XX +XXX,XX @@ void arm_handle_psci_call(ARMCPU *cpu) | ||
166 | { | ||
167 | /* | ||
168 | * This function partially implements the logic for dispatching Power State | ||
169 | - * Coordination Interface (PSCI) calls (as described in ARM DEN 0022B.b), | ||
170 | + * Coordination Interface (PSCI) calls (as described in ARM DEN 0022D.b), | ||
171 | * to the extent required for bringing up and taking down secondary cores, | ||
172 | * and for handling reset and poweroff requests. | ||
173 | * Additional information about the calling convention used is available in | ||
174 | @@ -XXX,XX +XXX,XX @@ void arm_handle_psci_call(ARMCPU *cpu) | ||
175 | } | ||
176 | |||
177 | if ((param[0] & QEMU_PSCI_0_2_64BIT) && !is_a64(env)) { | ||
178 | - ret = QEMU_PSCI_RET_INVALID_PARAMS; | ||
179 | + ret = QEMU_PSCI_RET_NOT_SUPPORTED; | ||
180 | goto err; | ||
181 | } | ||
182 | |||
183 | @@ -XXX,XX +XXX,XX @@ void arm_handle_psci_call(ARMCPU *cpu) | ||
184 | ARMCPU *target_cpu; | ||
185 | |||
186 | case QEMU_PSCI_0_2_FN_PSCI_VERSION: | ||
187 | - ret = QEMU_PSCI_0_2_RET_VERSION_0_2; | ||
188 | + ret = QEMU_PSCI_VERSION_1_1; | ||
189 | break; | ||
190 | case QEMU_PSCI_0_2_FN_MIGRATE_INFO_TYPE: | ||
191 | ret = QEMU_PSCI_0_2_RET_TOS_MIGRATION_NOT_REQUIRED; /* No trusted OS */ | ||
192 | @@ -XXX,XX +XXX,XX @@ void arm_handle_psci_call(ARMCPU *cpu) | ||
193 | } | ||
194 | helper_wfi(env, 4); | ||
195 | break; | ||
196 | + case QEMU_PSCI_1_0_FN_PSCI_FEATURES: | ||
197 | + switch (param[1]) { | ||
198 | + case QEMU_PSCI_0_2_FN_PSCI_VERSION: | ||
199 | + case QEMU_PSCI_0_2_FN_MIGRATE_INFO_TYPE: | ||
200 | + case QEMU_PSCI_0_2_FN_AFFINITY_INFO: | ||
201 | + case QEMU_PSCI_0_2_FN64_AFFINITY_INFO: | ||
202 | + case QEMU_PSCI_0_2_FN_SYSTEM_RESET: | ||
203 | + case QEMU_PSCI_0_2_FN_SYSTEM_OFF: | ||
204 | + case QEMU_PSCI_0_1_FN_CPU_ON: | ||
205 | + case QEMU_PSCI_0_2_FN_CPU_ON: | ||
206 | + case QEMU_PSCI_0_2_FN64_CPU_ON: | ||
207 | + case QEMU_PSCI_0_1_FN_CPU_OFF: | ||
208 | + case QEMU_PSCI_0_2_FN_CPU_OFF: | ||
209 | + case QEMU_PSCI_0_1_FN_CPU_SUSPEND: | ||
210 | + case QEMU_PSCI_0_2_FN_CPU_SUSPEND: | ||
211 | + case QEMU_PSCI_0_2_FN64_CPU_SUSPEND: | ||
212 | + case QEMU_PSCI_1_0_FN_PSCI_FEATURES: | ||
213 | + if (!(param[1] & QEMU_PSCI_0_2_64BIT) || is_a64(env)) { | ||
214 | + ret = 0; | ||
215 | + break; | ||
216 | + } | ||
217 | + /* fallthrough */ | ||
218 | + case QEMU_PSCI_0_1_FN_MIGRATE: | ||
219 | + case QEMU_PSCI_0_2_FN_MIGRATE: | ||
220 | + default: | ||
221 | + ret = QEMU_PSCI_RET_NOT_SUPPORTED; | ||
222 | + break; | ||
223 | + } | ||
224 | + break; | ||
225 | case QEMU_PSCI_0_1_FN_MIGRATE: | ||
226 | case QEMU_PSCI_0_2_FN_MIGRATE: | ||
227 | default: | ||
104 | -- | 228 | -- |
105 | 2.20.1 | 229 | 2.25.1 |
106 | |||
107 | diff view generated by jsdifflib |
1 | From: Richard Henderson <richard.henderson@linaro.org> | 1 | From: Wentao_Liang <Wentao_Liang_g@163.com> |
---|---|---|---|
2 | 2 | ||
3 | The mask implied by the extract is redundant with the one | 3 | handle_simd_shift_fpint_conv() was accidentally freeing the TCG |
4 | implied by the deposit. Also, fix spelling of BFXIL. | 4 | temporary tcg_fpstatus too early, before the last use of it. Move |
5 | the free down to where it belongs. | ||
5 | 6 | ||
6 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | 7 | Signed-off-by: Wentao_Liang <Wentao_Liang_g@163.com> |
7 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | 8 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> |
8 | Message-id: 20190514011129.11330-3-richard.henderson@linaro.org | 9 | [PMM: cleaned up commit message] |
9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
10 | --- | 11 | --- |
11 | target/arm/translate-a64.c | 6 +++--- | 12 | target/arm/translate-a64.c | 2 +- |
12 | 1 file changed, 3 insertions(+), 3 deletions(-) | 13 | 1 file changed, 1 insertion(+), 1 deletion(-) |
13 | 14 | ||
14 | diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c | 15 | diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c |
15 | index XXXXXXX..XXXXXXX 100644 | 16 | index XXXXXXX..XXXXXXX 100644 |
16 | --- a/target/arm/translate-a64.c | 17 | --- a/target/arm/translate-a64.c |
17 | +++ b/target/arm/translate-a64.c | 18 | +++ b/target/arm/translate-a64.c |
18 | @@ -XXX,XX +XXX,XX @@ static void disas_bitfield(DisasContext *s, uint32_t insn) | 19 | @@ -XXX,XX +XXX,XX @@ static void handle_simd_shift_fpint_conv(DisasContext *s, bool is_scalar, |
19 | tcg_gen_extract_i64(tcg_rd, tcg_tmp, ri, len); | ||
20 | return; | ||
21 | } | 20 | } |
22 | - /* opc == 1, BXFIL fall through to deposit */ | ||
23 | - tcg_gen_extract_i64(tcg_tmp, tcg_tmp, ri, len); | ||
24 | + /* opc == 1, BFXIL fall through to deposit */ | ||
25 | + tcg_gen_shri_i64(tcg_tmp, tcg_tmp, ri); | ||
26 | pos = 0; | ||
27 | } else { | ||
28 | /* Handle the ri > si case with a deposit | ||
29 | @@ -XXX,XX +XXX,XX @@ static void disas_bitfield(DisasContext *s, uint32_t insn) | ||
30 | len = ri; | ||
31 | } | 21 | } |
32 | 22 | ||
33 | - if (opc == 1) { /* BFM, BXFIL */ | 23 | - tcg_temp_free_ptr(tcg_fpstatus); |
34 | + if (opc == 1) { /* BFM, BFXIL */ | 24 | tcg_temp_free_i32(tcg_shift); |
35 | tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, pos, len); | 25 | gen_helper_set_rmode(tcg_rmode, tcg_rmode, tcg_fpstatus); |
36 | } else { | 26 | + tcg_temp_free_ptr(tcg_fpstatus); |
37 | /* SBFM or UBFM: We start with zero, and we haven't modified | 27 | tcg_temp_free_i32(tcg_rmode); |
28 | } | ||
29 | |||
38 | -- | 30 | -- |
39 | 2.20.1 | 31 | 2.25.1 |
40 | |||
41 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Shengtan Mao <stmao@google.com> | ||
1 | 2 | ||
3 | Reviewed-by: Hao Wu <wuhaotsh@google.com> | ||
4 | Reviewed-by: Chris Rauer <crauer@google.com> | ||
5 | Signed-off-by: Shengtan Mao <stmao@google.com> | ||
6 | Signed-off-by: Patrick Venture <venture@google.com> | ||
7 | Message-id: 20220225174451.192304-1-wuhaotsh@google.com | ||
8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
9 | --- | ||
10 | tests/qtest/npcm7xx_sdhci-test.c | 215 +++++++++++++++++++++++++++++++ | ||
11 | tests/qtest/meson.build | 1 + | ||
12 | 2 files changed, 216 insertions(+) | ||
13 | create mode 100644 tests/qtest/npcm7xx_sdhci-test.c | ||
14 | |||
15 | diff --git a/tests/qtest/npcm7xx_sdhci-test.c b/tests/qtest/npcm7xx_sdhci-test.c | ||
16 | new file mode 100644 | ||
17 | index XXXXXXX..XXXXXXX | ||
18 | --- /dev/null | ||
19 | +++ b/tests/qtest/npcm7xx_sdhci-test.c | ||
20 | @@ -XXX,XX +XXX,XX @@ | ||
21 | +/* | ||
22 | + * QTests for NPCM7xx SD-3.0 / MMC-4.51 Host Controller | ||
23 | + * | ||
24 | + * Copyright (c) 2022 Google LLC | ||
25 | + * | ||
26 | + * This program is free software; you can redistribute it and/or modify it | ||
27 | + * under the terms of the GNU General Public License as published by the | ||
28 | + * Free Software Foundation; either version 2 of the License, or | ||
29 | + * (at your option) any later version. | ||
30 | + * | ||
31 | + * This program is distributed in the hope that it will be useful, but WITHOUT | ||
32 | + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
33 | + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
34 | + * for more details. | ||
35 | + */ | ||
36 | + | ||
37 | +#include "qemu/osdep.h" | ||
38 | +#include "hw/sd/npcm7xx_sdhci.h" | ||
39 | + | ||
40 | +#include "libqos/libqtest.h" | ||
41 | +#include "libqtest-single.h" | ||
42 | +#include "libqos/sdhci-cmd.h" | ||
43 | + | ||
44 | +#define NPCM7XX_REG_SIZE 0x100 | ||
45 | +#define NPCM7XX_MMC_BA 0xF0842000 | ||
46 | +#define NPCM7XX_BLK_SIZE 512 | ||
47 | +#define NPCM7XX_TEST_IMAGE_SIZE (1 << 30) | ||
48 | + | ||
49 | +char *sd_path; | ||
50 | + | ||
51 | +static QTestState *setup_sd_card(void) | ||
52 | +{ | ||
53 | + QTestState *qts = qtest_initf( | ||
54 | + "-machine kudo-bmc " | ||
55 | + "-device sd-card,drive=drive0 " | ||
56 | + "-drive id=drive0,if=none,file=%s,format=raw,auto-read-only=off", | ||
57 | + sd_path); | ||
58 | + | ||
59 | + qtest_writew(qts, NPCM7XX_MMC_BA + SDHC_SWRST, SDHC_RESET_ALL); | ||
60 | + qtest_writew(qts, NPCM7XX_MMC_BA + SDHC_CLKCON, | ||
61 | + SDHC_CLOCK_SDCLK_EN | SDHC_CLOCK_INT_STABLE | | ||
62 | + SDHC_CLOCK_INT_EN); | ||
63 | + sdhci_cmd_regs(qts, NPCM7XX_MMC_BA, 0, 0, 0, 0, SDHC_APP_CMD); | ||
64 | + sdhci_cmd_regs(qts, NPCM7XX_MMC_BA, 0, 0, 0x41200000, 0, (41 << 8)); | ||
65 | + sdhci_cmd_regs(qts, NPCM7XX_MMC_BA, 0, 0, 0, 0, SDHC_ALL_SEND_CID); | ||
66 | + sdhci_cmd_regs(qts, NPCM7XX_MMC_BA, 0, 0, 0, 0, SDHC_SEND_RELATIVE_ADDR); | ||
67 | + sdhci_cmd_regs(qts, NPCM7XX_MMC_BA, 0, 0, 0x45670000, 0, | ||
68 | + SDHC_SELECT_DESELECT_CARD); | ||
69 | + | ||
70 | + return qts; | ||
71 | +} | ||
72 | + | ||
73 | +static void write_sdread(QTestState *qts, const char *msg) | ||
74 | +{ | ||
75 | + int fd, ret; | ||
76 | + size_t len = strlen(msg); | ||
77 | + char *rmsg = g_malloc(len); | ||
78 | + | ||
79 | + /* write message to sd */ | ||
80 | + fd = open(sd_path, O_WRONLY); | ||
81 | + g_assert(fd >= 0); | ||
82 | + ret = write(fd, msg, len); | ||
83 | + close(fd); | ||
84 | + g_assert(ret == len); | ||
85 | + | ||
86 | + /* read message using sdhci */ | ||
87 | + ret = sdhci_read_cmd(qts, NPCM7XX_MMC_BA, rmsg, len); | ||
88 | + g_assert(ret == len); | ||
89 | + g_assert(!memcmp(rmsg, msg, len)); | ||
90 | + | ||
91 | + g_free(rmsg); | ||
92 | +} | ||
93 | + | ||
94 | +/* Check MMC can read values from sd */ | ||
95 | +static void test_read_sd(void) | ||
96 | +{ | ||
97 | + QTestState *qts = setup_sd_card(); | ||
98 | + | ||
99 | + write_sdread(qts, "hello world"); | ||
100 | + write_sdread(qts, "goodbye"); | ||
101 | + | ||
102 | + qtest_quit(qts); | ||
103 | +} | ||
104 | + | ||
105 | +static void sdwrite_read(QTestState *qts, const char *msg) | ||
106 | +{ | ||
107 | + int fd, ret; | ||
108 | + size_t len = strlen(msg); | ||
109 | + char *rmsg = g_malloc(len); | ||
110 | + | ||
111 | + /* write message using sdhci */ | ||
112 | + sdhci_write_cmd(qts, NPCM7XX_MMC_BA, msg, len, NPCM7XX_BLK_SIZE); | ||
113 | + | ||
114 | + /* read message from sd */ | ||
115 | + fd = open(sd_path, O_RDONLY); | ||
116 | + g_assert(fd >= 0); | ||
117 | + ret = read(fd, rmsg, len); | ||
118 | + close(fd); | ||
119 | + g_assert(ret == len); | ||
120 | + | ||
121 | + g_assert(!memcmp(rmsg, msg, len)); | ||
122 | + | ||
123 | + g_free(rmsg); | ||
124 | +} | ||
125 | + | ||
126 | +/* Check MMC can write values to sd */ | ||
127 | +static void test_write_sd(void) | ||
128 | +{ | ||
129 | + QTestState *qts = setup_sd_card(); | ||
130 | + | ||
131 | + sdwrite_read(qts, "hello world"); | ||
132 | + sdwrite_read(qts, "goodbye"); | ||
133 | + | ||
134 | + qtest_quit(qts); | ||
135 | +} | ||
136 | + | ||
137 | +/* Check SDHCI has correct default values. */ | ||
138 | +static void test_reset(void) | ||
139 | +{ | ||
140 | + QTestState *qts = qtest_init("-machine kudo-bmc"); | ||
141 | + uint64_t addr = NPCM7XX_MMC_BA; | ||
142 | + uint64_t end_addr = addr + NPCM7XX_REG_SIZE; | ||
143 | + uint16_t prstvals_resets[] = {NPCM7XX_PRSTVALS_0_RESET, | ||
144 | + NPCM7XX_PRSTVALS_1_RESET, | ||
145 | + 0, | ||
146 | + NPCM7XX_PRSTVALS_3_RESET, | ||
147 | + 0, | ||
148 | + 0}; | ||
149 | + int i; | ||
150 | + uint32_t mask; | ||
151 | + | ||
152 | + while (addr < end_addr) { | ||
153 | + switch (addr - NPCM7XX_MMC_BA) { | ||
154 | + case SDHC_PRNSTS: | ||
155 | + /* | ||
156 | + * ignores bits 20 to 24: they are changed when reading registers | ||
157 | + */ | ||
158 | + mask = 0x1f00000; | ||
159 | + g_assert_cmphex(qtest_readl(qts, addr) | mask, ==, | ||
160 | + NPCM7XX_PRSNTS_RESET | mask); | ||
161 | + addr += 4; | ||
162 | + break; | ||
163 | + case SDHC_BLKGAP: | ||
164 | + g_assert_cmphex(qtest_readb(qts, addr), ==, NPCM7XX_BLKGAP_RESET); | ||
165 | + addr += 1; | ||
166 | + break; | ||
167 | + case SDHC_CAPAB: | ||
168 | + g_assert_cmphex(qtest_readq(qts, addr), ==, NPCM7XX_CAPAB_RESET); | ||
169 | + addr += 8; | ||
170 | + break; | ||
171 | + case SDHC_MAXCURR: | ||
172 | + g_assert_cmphex(qtest_readq(qts, addr), ==, NPCM7XX_MAXCURR_RESET); | ||
173 | + addr += 8; | ||
174 | + break; | ||
175 | + case SDHC_HCVER: | ||
176 | + g_assert_cmphex(qtest_readw(qts, addr), ==, NPCM7XX_HCVER_RESET); | ||
177 | + addr += 2; | ||
178 | + break; | ||
179 | + case NPCM7XX_PRSTVALS: | ||
180 | + for (i = 0; i < NPCM7XX_PRSTVALS_SIZE; ++i) { | ||
181 | + g_assert_cmphex(qtest_readw(qts, addr + 2 * i), ==, | ||
182 | + prstvals_resets[i]); | ||
183 | + } | ||
184 | + addr += NPCM7XX_PRSTVALS_SIZE * 2; | ||
185 | + break; | ||
186 | + default: | ||
187 | + g_assert_cmphex(qtest_readb(qts, addr), ==, 0); | ||
188 | + addr += 1; | ||
189 | + } | ||
190 | + } | ||
191 | + | ||
192 | + qtest_quit(qts); | ||
193 | +} | ||
194 | + | ||
195 | +static void drive_destroy(void) | ||
196 | +{ | ||
197 | + unlink(sd_path); | ||
198 | + g_free(sd_path); | ||
199 | +} | ||
200 | + | ||
201 | +static void drive_create(void) | ||
202 | +{ | ||
203 | + int fd, ret; | ||
204 | + GError *error = NULL; | ||
205 | + | ||
206 | + /* Create a temporary raw image */ | ||
207 | + fd = g_file_open_tmp("sdhci_XXXXXX", &sd_path, &error); | ||
208 | + if (fd == -1) { | ||
209 | + fprintf(stderr, "unable to create sdhci file: %s\n", error->message); | ||
210 | + g_error_free(error); | ||
211 | + } | ||
212 | + g_assert(sd_path != NULL); | ||
213 | + | ||
214 | + ret = ftruncate(fd, NPCM7XX_TEST_IMAGE_SIZE); | ||
215 | + g_assert_cmpint(ret, ==, 0); | ||
216 | + g_message("%s", sd_path); | ||
217 | + close(fd); | ||
218 | +} | ||
219 | + | ||
220 | +int main(int argc, char **argv) | ||
221 | +{ | ||
222 | + int ret; | ||
223 | + | ||
224 | + drive_create(); | ||
225 | + | ||
226 | + g_test_init(&argc, &argv, NULL); | ||
227 | + | ||
228 | + qtest_add_func("npcm7xx_sdhci/reset", test_reset); | ||
229 | + qtest_add_func("npcm7xx_sdhci/write_sd", test_write_sd); | ||
230 | + qtest_add_func("npcm7xx_sdhci/read_sd", test_read_sd); | ||
231 | + | ||
232 | + ret = g_test_run(); | ||
233 | + drive_destroy(); | ||
234 | + return ret; | ||
235 | +} | ||
236 | diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build | ||
237 | index XXXXXXX..XXXXXXX 100644 | ||
238 | --- a/tests/qtest/meson.build | ||
239 | +++ b/tests/qtest/meson.build | ||
240 | @@ -XXX,XX +XXX,XX @@ qtests_npcm7xx = \ | ||
241 | 'npcm7xx_gpio-test', | ||
242 | 'npcm7xx_pwm-test', | ||
243 | 'npcm7xx_rng-test', | ||
244 | + 'npcm7xx_sdhci-test', | ||
245 | 'npcm7xx_smbus-test', | ||
246 | 'npcm7xx_timer-test', | ||
247 | 'npcm7xx_watchdog_timer-test'] + \ | ||
248 | -- | ||
249 | 2.25.1 | diff view generated by jsdifflib |
1 | The system_clock_scale global is used only by the armv7m systick | 1 | From: Richard Henderson <richard.henderson@linaro.org> |
---|---|---|---|
2 | device; move the extern declaration to the armv7m_systick.h header, | ||
3 | and expand the comment to explain what it is and that it should | ||
4 | ideally be replaced with a different approach. | ||
5 | 2 | ||
3 | Add new macros to manipulate signed fields within the register. | ||
4 | |||
5 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
6 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
7 | Message-id: 20220301215958.157011-2-richard.henderson@linaro.org | ||
8 | Suggested-by: Peter Maydell <peter.maydell@linaro.org> | ||
9 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
6 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
7 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
8 | Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
9 | Message-id: 20190516163857.6430-2-peter.maydell@linaro.org | ||
10 | --- | 11 | --- |
11 | include/hw/arm/arm.h | 4 ---- | 12 | include/hw/registerfields.h | 48 ++++++++++++++++++++++++++++++++++++- |
12 | include/hw/timer/armv7m_systick.h | 22 ++++++++++++++++++++++ | 13 | 1 file changed, 47 insertions(+), 1 deletion(-) |
13 | 2 files changed, 22 insertions(+), 4 deletions(-) | ||
14 | 14 | ||
15 | diff --git a/include/hw/arm/arm.h b/include/hw/arm/arm.h | 15 | diff --git a/include/hw/registerfields.h b/include/hw/registerfields.h |
16 | index XXXXXXX..XXXXXXX 100644 | 16 | index XXXXXXX..XXXXXXX 100644 |
17 | --- a/include/hw/arm/arm.h | 17 | --- a/include/hw/registerfields.h |
18 | +++ b/include/hw/arm/arm.h | 18 | +++ b/include/hw/registerfields.h |
19 | @@ -XXX,XX +XXX,XX @@ void arm_write_secure_board_setup_dummy_smc(ARMCPU *cpu, | 19 | @@ -XXX,XX +XXX,XX @@ |
20 | const struct arm_boot_info *info, | 20 | extract64((storage), R_ ## reg ## _ ## field ## _SHIFT, \ |
21 | hwaddr mvbar_addr); | 21 | R_ ## reg ## _ ## field ## _LENGTH) |
22 | 22 | ||
23 | -/* Multiplication factor to convert from system clock ticks to qemu timer | 23 | +#define FIELD_SEX8(storage, reg, field) \ |
24 | - ticks. */ | 24 | + sextract8((storage), R_ ## reg ## _ ## field ## _SHIFT, \ |
25 | -extern int system_clock_scale; | 25 | + R_ ## reg ## _ ## field ## _LENGTH) |
26 | - | 26 | +#define FIELD_SEX16(storage, reg, field) \ |
27 | #endif /* HW_ARM_H */ | 27 | + sextract16((storage), R_ ## reg ## _ ## field ## _SHIFT, \ |
28 | diff --git a/include/hw/timer/armv7m_systick.h b/include/hw/timer/armv7m_systick.h | 28 | + R_ ## reg ## _ ## field ## _LENGTH) |
29 | index XXXXXXX..XXXXXXX 100644 | 29 | +#define FIELD_SEX32(storage, reg, field) \ |
30 | --- a/include/hw/timer/armv7m_systick.h | 30 | + sextract32((storage), R_ ## reg ## _ ## field ## _SHIFT, \ |
31 | +++ b/include/hw/timer/armv7m_systick.h | 31 | + R_ ## reg ## _ ## field ## _LENGTH) |
32 | @@ -XXX,XX +XXX,XX @@ typedef struct SysTickState { | 32 | +#define FIELD_SEX64(storage, reg, field) \ |
33 | qemu_irq irq; | 33 | + sextract64((storage), R_ ## reg ## _ ## field ## _SHIFT, \ |
34 | } SysTickState; | 34 | + R_ ## reg ## _ ## field ## _LENGTH) |
35 | |||
36 | +/* | ||
37 | + * Multiplication factor to convert from system clock ticks to qemu timer | ||
38 | + * ticks. This should be set (by board code, usually) to a value | ||
39 | + * equal to NANOSECONDS_PER_SECOND / frq, where frq is the clock frequency | ||
40 | + * in Hz of the CPU. | ||
41 | + * | ||
42 | + * This value is used by the systick device when it is running in | ||
43 | + * its "use the CPU clock" mode (ie when SYST_CSR.CLKSOURCE == 1) to | ||
44 | + * set how fast the timer should tick. | ||
45 | + * | ||
46 | + * TODO: we should refactor this so that rather than using a global | ||
47 | + * we use a device property or something similar. This is complicated | ||
48 | + * because (a) the property would need to be plumbed through from the | ||
49 | + * board code down through various layers to the systick device | ||
50 | + * and (b) the property needs to be modifiable after realize, because | ||
51 | + * the stellaris board uses this to implement the behaviour where the | ||
52 | + * guest can reprogram the PLL registers to downclock the CPU, and the | ||
53 | + * systick device needs to react accordingly. Possibly this should | ||
54 | + * be deferred until we have a good API for modelling clock trees. | ||
55 | + */ | ||
56 | +extern int system_clock_scale; | ||
57 | + | 35 | + |
58 | #endif | 36 | /* Extract a field from an array of registers */ |
37 | #define ARRAY_FIELD_EX32(regs, reg, field) \ | ||
38 | FIELD_EX32((regs)[R_ ## reg], reg, field) | ||
39 | @@ -XXX,XX +XXX,XX @@ | ||
40 | _d; }) | ||
41 | #define FIELD_DP64(storage, reg, field, val) ({ \ | ||
42 | struct { \ | ||
43 | - uint64_t v:R_ ## reg ## _ ## field ## _LENGTH; \ | ||
44 | + uint64_t v:R_ ## reg ## _ ## field ## _LENGTH; \ | ||
45 | + } _v = { .v = val }; \ | ||
46 | + uint64_t _d; \ | ||
47 | + _d = deposit64((storage), R_ ## reg ## _ ## field ## _SHIFT, \ | ||
48 | + R_ ## reg ## _ ## field ## _LENGTH, _v.v); \ | ||
49 | + _d; }) | ||
50 | + | ||
51 | +#define FIELD_SDP8(storage, reg, field, val) ({ \ | ||
52 | + struct { \ | ||
53 | + signed int v:R_ ## reg ## _ ## field ## _LENGTH; \ | ||
54 | + } _v = { .v = val }; \ | ||
55 | + uint8_t _d; \ | ||
56 | + _d = deposit32((storage), R_ ## reg ## _ ## field ## _SHIFT, \ | ||
57 | + R_ ## reg ## _ ## field ## _LENGTH, _v.v); \ | ||
58 | + _d; }) | ||
59 | +#define FIELD_SDP16(storage, reg, field, val) ({ \ | ||
60 | + struct { \ | ||
61 | + signed int v:R_ ## reg ## _ ## field ## _LENGTH; \ | ||
62 | + } _v = { .v = val }; \ | ||
63 | + uint16_t _d; \ | ||
64 | + _d = deposit32((storage), R_ ## reg ## _ ## field ## _SHIFT, \ | ||
65 | + R_ ## reg ## _ ## field ## _LENGTH, _v.v); \ | ||
66 | + _d; }) | ||
67 | +#define FIELD_SDP32(storage, reg, field, val) ({ \ | ||
68 | + struct { \ | ||
69 | + signed int v:R_ ## reg ## _ ## field ## _LENGTH; \ | ||
70 | + } _v = { .v = val }; \ | ||
71 | + uint32_t _d; \ | ||
72 | + _d = deposit32((storage), R_ ## reg ## _ ## field ## _SHIFT, \ | ||
73 | + R_ ## reg ## _ ## field ## _LENGTH, _v.v); \ | ||
74 | + _d; }) | ||
75 | +#define FIELD_SDP64(storage, reg, field, val) ({ \ | ||
76 | + struct { \ | ||
77 | + int64_t v:R_ ## reg ## _ ## field ## _LENGTH; \ | ||
78 | } _v = { .v = val }; \ | ||
79 | uint64_t _d; \ | ||
80 | _d = deposit64((storage), R_ ## reg ## _ ## field ## _SHIFT, \ | ||
59 | -- | 81 | -- |
60 | 2.20.1 | 82 | 2.25.1 |
61 | 83 | ||
62 | 84 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
1 | 2 | ||
3 | Set this as the kernel would, to 48 bits, to keep the computation | ||
4 | of the address space correct for PAuth. | ||
5 | |||
6 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
7 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
8 | Message-id: 20220301215958.157011-3-richard.henderson@linaro.org | ||
9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | --- | ||
11 | target/arm/cpu.c | 3 ++- | ||
12 | 1 file changed, 2 insertions(+), 1 deletion(-) | ||
13 | |||
14 | diff --git a/target/arm/cpu.c b/target/arm/cpu.c | ||
15 | index XXXXXXX..XXXXXXX 100644 | ||
16 | --- a/target/arm/cpu.c | ||
17 | +++ b/target/arm/cpu.c | ||
18 | @@ -XXX,XX +XXX,XX @@ static void arm_cpu_reset(DeviceState *dev) | ||
19 | aarch64_sve_zcr_get_valid_len(cpu, cpu->sve_default_vq - 1); | ||
20 | } | ||
21 | /* | ||
22 | + * Enable 48-bit address space (TODO: take reserved_va into account). | ||
23 | * Enable TBI0 but not TBI1. | ||
24 | * Note that this must match useronly_clean_ptr. | ||
25 | */ | ||
26 | - env->cp15.tcr_el[1].raw_tcr = (1ULL << 37); | ||
27 | + env->cp15.tcr_el[1].raw_tcr = 5 | (1ULL << 37); | ||
28 | |||
29 | /* Enable MTE */ | ||
30 | if (cpu_isar_feature(aa64_mte, cpu)) { | ||
31 | -- | ||
32 | 2.25.1 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
1 | 2 | ||
3 | Without FEAT_LVA, the behaviour of programming an invalid value | ||
4 | is IMPLEMENTATION DEFINED. With FEAT_LVA, programming an invalid | ||
5 | minimum value requires a Translation fault. | ||
6 | |||
7 | It is most self-consistent to choose to generate the fault always. | ||
8 | |||
9 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
11 | Message-id: 20220301215958.157011-4-richard.henderson@linaro.org | ||
12 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
13 | --- | ||
14 | target/arm/internals.h | 1 + | ||
15 | target/arm/helper.c | 32 ++++++++++++++++++++++++++++---- | ||
16 | 2 files changed, 29 insertions(+), 4 deletions(-) | ||
17 | |||
18 | diff --git a/target/arm/internals.h b/target/arm/internals.h | ||
19 | index XXXXXXX..XXXXXXX 100644 | ||
20 | --- a/target/arm/internals.h | ||
21 | +++ b/target/arm/internals.h | ||
22 | @@ -XXX,XX +XXX,XX @@ typedef struct ARMVAParameters { | ||
23 | bool hpd : 1; | ||
24 | bool using16k : 1; | ||
25 | bool using64k : 1; | ||
26 | + bool tsz_oob : 1; /* tsz has been clamped to legal range */ | ||
27 | } ARMVAParameters; | ||
28 | |||
29 | ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
30 | diff --git a/target/arm/helper.c b/target/arm/helper.c | ||
31 | index XXXXXXX..XXXXXXX 100644 | ||
32 | --- a/target/arm/helper.c | ||
33 | +++ b/target/arm/helper.c | ||
34 | @@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
35 | ARMMMUIdx mmu_idx, bool data) | ||
36 | { | ||
37 | uint64_t tcr = regime_tcr(env, mmu_idx)->raw_tcr; | ||
38 | - bool epd, hpd, using16k, using64k; | ||
39 | - int select, tsz, tbi, max_tsz; | ||
40 | + bool epd, hpd, using16k, using64k, tsz_oob; | ||
41 | + int select, tsz, tbi, max_tsz, min_tsz; | ||
42 | |||
43 | if (!regime_has_2_ranges(mmu_idx)) { | ||
44 | select = 0; | ||
45 | @@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
46 | } else { | ||
47 | max_tsz = 39; | ||
48 | } | ||
49 | + min_tsz = 16; /* TODO: ARMv8.2-LVA */ | ||
50 | |||
51 | - tsz = MIN(tsz, max_tsz); | ||
52 | - tsz = MAX(tsz, 16); /* TODO: ARMv8.2-LVA */ | ||
53 | + if (tsz > max_tsz) { | ||
54 | + tsz = max_tsz; | ||
55 | + tsz_oob = true; | ||
56 | + } else if (tsz < min_tsz) { | ||
57 | + tsz = min_tsz; | ||
58 | + tsz_oob = true; | ||
59 | + } else { | ||
60 | + tsz_oob = false; | ||
61 | + } | ||
62 | |||
63 | /* Present TBI as a composite with TBID. */ | ||
64 | tbi = aa64_va_parameter_tbi(tcr, mmu_idx); | ||
65 | @@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
66 | .hpd = hpd, | ||
67 | .using16k = using16k, | ||
68 | .using64k = using64k, | ||
69 | + .tsz_oob = tsz_oob, | ||
70 | }; | ||
71 | } | ||
72 | |||
73 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, | ||
74 | param = aa64_va_parameters(env, address, mmu_idx, | ||
75 | access_type != MMU_INST_FETCH); | ||
76 | level = 0; | ||
77 | + | ||
78 | + /* | ||
79 | + * If TxSZ is programmed to a value larger than the maximum, | ||
80 | + * or smaller than the effective minimum, it is IMPLEMENTATION | ||
81 | + * DEFINED whether we behave as if the field were programmed | ||
82 | + * within bounds, or if a level 0 Translation fault is generated. | ||
83 | + * | ||
84 | + * With FEAT_LVA, fault on less than minimum becomes required, | ||
85 | + * so our choice is to always raise the fault. | ||
86 | + */ | ||
87 | + if (param.tsz_oob) { | ||
88 | + fault_type = ARMFault_Translation; | ||
89 | + goto do_fault; | ||
90 | + } | ||
91 | + | ||
92 | addrsize = 64 - 8 * param.tbi; | ||
93 | inputsize = 64 - param.tsz; | ||
94 | } else { | ||
95 | -- | ||
96 | 2.25.1 | diff view generated by jsdifflib |
1 | From: Guenter Roeck <linux@roeck-us.net> | 1 | From: Richard Henderson <richard.henderson@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | QEMU already supports pl330. Instantiate it for Exynos4210. | 3 | We will shortly share parts of this function with other portions |
4 | of address translation. | ||
4 | 5 | ||
5 | Relevant part of Linux arch/arm/boot/dts/exynos4.dtsi: | ||
6 | |||
7 | / { | ||
8 | soc: soc { | ||
9 | amba { | ||
10 | pdma0: pdma@12680000 { | ||
11 | compatible = "arm,pl330", "arm,primecell"; | ||
12 | reg = <0x12680000 0x1000>; | ||
13 | interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>; | ||
14 | clocks = <&clock CLK_PDMA0>; | ||
15 | clock-names = "apb_pclk"; | ||
16 | #dma-cells = <1>; | ||
17 | #dma-channels = <8>; | ||
18 | #dma-requests = <32>; | ||
19 | }; | ||
20 | pdma1: pdma@12690000 { | ||
21 | compatible = "arm,pl330", "arm,primecell"; | ||
22 | reg = <0x12690000 0x1000>; | ||
23 | interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>; | ||
24 | clocks = <&clock CLK_PDMA1>; | ||
25 | clock-names = "apb_pclk"; | ||
26 | #dma-cells = <1>; | ||
27 | #dma-channels = <8>; | ||
28 | #dma-requests = <32>; | ||
29 | }; | ||
30 | mdma1: mdma@12850000 { | ||
31 | compatible = "arm,pl330", "arm,primecell"; | ||
32 | reg = <0x12850000 0x1000>; | ||
33 | interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>; | ||
34 | clocks = <&clock CLK_MDMA>; | ||
35 | clock-names = "apb_pclk"; | ||
36 | #dma-cells = <1>; | ||
37 | #dma-channels = <8>; | ||
38 | #dma-requests = <1>; | ||
39 | }; | ||
40 | }; | ||
41 | }; | ||
42 | }; | ||
43 | |||
44 | Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ||
45 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
46 | Reviewed-by: Alistair Francis <alistair.francis@wdc.com> | ||
47 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 6 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
48 | Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> | 7 | Reviewed-by: Alex Bennée <alex.bennee@linaro.org> |
49 | Message-id: 20190520214342.13709-4-philmd@redhat.com | 8 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> |
50 | [PMD: Do not set default qdev properties, create the controllers in the SoC | 9 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> |
51 | rather than the board (Peter Maydell), add dtsi in commit message] | 10 | Message-id: 20220301215958.157011-5-richard.henderson@linaro.org |
52 | Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
53 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
54 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
55 | --- | 12 | --- |
56 | hw/arm/exynos4210.c | 26 ++++++++++++++++++++++++++ | 13 | target/arm/internals.h | 19 +------------------ |
57 | 1 file changed, 26 insertions(+) | 14 | target/arm/helper.c | 22 ++++++++++++++++++++++ |
15 | 2 files changed, 23 insertions(+), 18 deletions(-) | ||
58 | 16 | ||
59 | diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c | 17 | diff --git a/target/arm/internals.h b/target/arm/internals.h |
60 | index XXXXXXX..XXXXXXX 100644 | 18 | index XXXXXXX..XXXXXXX 100644 |
61 | --- a/hw/arm/exynos4210.c | 19 | --- a/target/arm/internals.h |
62 | +++ b/hw/arm/exynos4210.c | 20 | +++ b/target/arm/internals.h |
63 | @@ -XXX,XX +XXX,XX @@ | 21 | @@ -XXX,XX +XXX,XX @@ static inline void update_spsel(CPUARMState *env, uint32_t imm) |
64 | /* EHCI */ | 22 | * Returns the implementation defined bit-width of physical addresses. |
65 | #define EXYNOS4210_EHCI_BASE_ADDR 0x12580000 | 23 | * The ARMv8 reference manuals refer to this as PAMax(). |
66 | 24 | */ | |
67 | +/* DMA */ | 25 | -static inline unsigned int arm_pamax(ARMCPU *cpu) |
68 | +#define EXYNOS4210_PL330_BASE0_ADDR 0x12680000 | 26 | -{ |
69 | +#define EXYNOS4210_PL330_BASE1_ADDR 0x12690000 | 27 | - static const unsigned int pamax_map[] = { |
70 | +#define EXYNOS4210_PL330_BASE2_ADDR 0x12850000 | 28 | - [0] = 32, |
29 | - [1] = 36, | ||
30 | - [2] = 40, | ||
31 | - [3] = 42, | ||
32 | - [4] = 44, | ||
33 | - [5] = 48, | ||
34 | - }; | ||
35 | - unsigned int parange = | ||
36 | - FIELD_EX64(cpu->isar.id_aa64mmfr0, ID_AA64MMFR0, PARANGE); | ||
37 | - | ||
38 | - /* id_aa64mmfr0 is a read-only register so values outside of the | ||
39 | - * supported mappings can be considered an implementation error. */ | ||
40 | - assert(parange < ARRAY_SIZE(pamax_map)); | ||
41 | - return pamax_map[parange]; | ||
42 | -} | ||
43 | +unsigned int arm_pamax(ARMCPU *cpu); | ||
44 | |||
45 | /* Return true if extended addresses are enabled. | ||
46 | * This is always the case if our translation regime is 64 bit, | ||
47 | diff --git a/target/arm/helper.c b/target/arm/helper.c | ||
48 | index XXXXXXX..XXXXXXX 100644 | ||
49 | --- a/target/arm/helper.c | ||
50 | +++ b/target/arm/helper.c | ||
51 | @@ -XXX,XX +XXX,XX @@ static uint8_t convert_stage2_attrs(CPUARMState *env, uint8_t s2attrs) | ||
52 | } | ||
53 | #endif /* !CONFIG_USER_ONLY */ | ||
54 | |||
55 | +/* The cpu-specific constant value of PAMax; also used by hw/arm/virt. */ | ||
56 | +unsigned int arm_pamax(ARMCPU *cpu) | ||
57 | +{ | ||
58 | + static const unsigned int pamax_map[] = { | ||
59 | + [0] = 32, | ||
60 | + [1] = 36, | ||
61 | + [2] = 40, | ||
62 | + [3] = 42, | ||
63 | + [4] = 44, | ||
64 | + [5] = 48, | ||
65 | + }; | ||
66 | + unsigned int parange = | ||
67 | + FIELD_EX64(cpu->isar.id_aa64mmfr0, ID_AA64MMFR0, PARANGE); | ||
71 | + | 68 | + |
72 | static uint8_t chipid_and_omr[] = { 0x11, 0x02, 0x21, 0x43, | 69 | + /* |
73 | 0x09, 0x00, 0x00, 0x00 }; | 70 | + * id_aa64mmfr0 is a read-only register so values outside of the |
74 | 71 | + * supported mappings can be considered an implementation error. | |
75 | @@ -XXX,XX +XXX,XX @@ static uint64_t exynos4210_calc_affinity(int cpu) | 72 | + */ |
76 | return (0x9 << ARM_AFF1_SHIFT) | cpu; | 73 | + assert(parange < ARRAY_SIZE(pamax_map)); |
77 | } | 74 | + return pamax_map[parange]; |
78 | |||
79 | +static void pl330_create(uint32_t base, qemu_irq irq, int nreq) | ||
80 | +{ | ||
81 | + SysBusDevice *busdev; | ||
82 | + DeviceState *dev; | ||
83 | + | ||
84 | + dev = qdev_create(NULL, "pl330"); | ||
85 | + qdev_prop_set_uint8(dev, "num_periph_req", nreq); | ||
86 | + qdev_init_nofail(dev); | ||
87 | + busdev = SYS_BUS_DEVICE(dev); | ||
88 | + sysbus_mmio_map(busdev, 0, base); | ||
89 | + sysbus_connect_irq(busdev, 0, irq); | ||
90 | +} | 75 | +} |
91 | + | 76 | + |
92 | Exynos4210State *exynos4210_init(MemoryRegion *system_mem) | 77 | static int aa64_va_parameter_tbi(uint64_t tcr, ARMMMUIdx mmu_idx) |
93 | { | 78 | { |
94 | Exynos4210State *s = g_new0(Exynos4210State, 1); | 79 | if (regime_has_2_ranges(mmu_idx)) { |
95 | @@ -XXX,XX +XXX,XX @@ Exynos4210State *exynos4210_init(MemoryRegion *system_mem) | ||
96 | sysbus_create_simple(TYPE_EXYNOS4210_EHCI, EXYNOS4210_EHCI_BASE_ADDR, | ||
97 | s->irq_table[exynos4210_get_irq(28, 3)]); | ||
98 | |||
99 | + /*** DMA controllers ***/ | ||
100 | + pl330_create(EXYNOS4210_PL330_BASE0_ADDR, | ||
101 | + qemu_irq_invert(s->irq_table[exynos4210_get_irq(35, 1)]), 32); | ||
102 | + pl330_create(EXYNOS4210_PL330_BASE1_ADDR, | ||
103 | + qemu_irq_invert(s->irq_table[exynos4210_get_irq(36, 1)]), 32); | ||
104 | + pl330_create(EXYNOS4210_PL330_BASE2_ADDR, | ||
105 | + qemu_irq_invert(s->irq_table[exynos4210_get_irq(34, 1)]), 1); | ||
106 | + | ||
107 | return s; | ||
108 | } | ||
109 | -- | 80 | -- |
110 | 2.20.1 | 81 | 2.25.1 |
111 | 82 | ||
112 | 83 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
1 | 2 | ||
3 | Pass down the width of the output address from translation. | ||
4 | For now this is still just PAMax, but a subsequent patch will | ||
5 | compute the correct value from TCR_ELx.{I}PS. | ||
6 | |||
7 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
8 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
9 | Message-id: 20220301215958.157011-6-richard.henderson@linaro.org | ||
10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
11 | --- | ||
12 | target/arm/helper.c | 21 ++++++++++----------- | ||
13 | 1 file changed, 10 insertions(+), 11 deletions(-) | ||
14 | |||
15 | diff --git a/target/arm/helper.c b/target/arm/helper.c | ||
16 | index XXXXXXX..XXXXXXX 100644 | ||
17 | --- a/target/arm/helper.c | ||
18 | +++ b/target/arm/helper.c | ||
19 | @@ -XXX,XX +XXX,XX @@ do_fault: | ||
20 | * false otherwise. | ||
21 | */ | ||
22 | static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, int level, | ||
23 | - int inputsize, int stride) | ||
24 | + int inputsize, int stride, int outputsize) | ||
25 | { | ||
26 | const int grainsize = stride + 3; | ||
27 | int startsizecheck; | ||
28 | @@ -XXX,XX +XXX,XX @@ static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, int level, | ||
29 | } | ||
30 | |||
31 | if (is_aa64) { | ||
32 | - CPUARMState *env = &cpu->env; | ||
33 | - unsigned int pamax = arm_pamax(cpu); | ||
34 | - | ||
35 | switch (stride) { | ||
36 | case 13: /* 64KB Pages. */ | ||
37 | - if (level == 0 || (level == 1 && pamax <= 42)) { | ||
38 | + if (level == 0 || (level == 1 && outputsize <= 42)) { | ||
39 | return false; | ||
40 | } | ||
41 | break; | ||
42 | case 11: /* 16KB Pages. */ | ||
43 | - if (level == 0 || (level == 1 && pamax <= 40)) { | ||
44 | + if (level == 0 || (level == 1 && outputsize <= 40)) { | ||
45 | return false; | ||
46 | } | ||
47 | break; | ||
48 | case 9: /* 4KB Pages. */ | ||
49 | - if (level == 0 && pamax <= 42) { | ||
50 | + if (level == 0 && outputsize <= 42) { | ||
51 | return false; | ||
52 | } | ||
53 | break; | ||
54 | @@ -XXX,XX +XXX,XX @@ static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, int level, | ||
55 | } | ||
56 | |||
57 | /* Inputsize checks. */ | ||
58 | - if (inputsize > pamax && | ||
59 | - (arm_el_is_aa64(env, 1) || inputsize > 40)) { | ||
60 | + if (inputsize > outputsize && | ||
61 | + (arm_el_is_aa64(&cpu->env, 1) || inputsize > 40)) { | ||
62 | /* This is CONSTRAINED UNPREDICTABLE and we choose to fault. */ | ||
63 | return false; | ||
64 | } | ||
65 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, | ||
66 | target_ulong page_size; | ||
67 | uint32_t attrs; | ||
68 | int32_t stride; | ||
69 | - int addrsize, inputsize; | ||
70 | + int addrsize, inputsize, outputsize; | ||
71 | TCR *tcr = regime_tcr(env, mmu_idx); | ||
72 | int ap, ns, xn, pxn; | ||
73 | uint32_t el = regime_el(env, mmu_idx); | ||
74 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, | ||
75 | |||
76 | addrsize = 64 - 8 * param.tbi; | ||
77 | inputsize = 64 - param.tsz; | ||
78 | + outputsize = arm_pamax(cpu); | ||
79 | } else { | ||
80 | param = aa32_va_parameters(env, address, mmu_idx); | ||
81 | level = 1; | ||
82 | addrsize = (mmu_idx == ARMMMUIdx_Stage2 ? 40 : 32); | ||
83 | inputsize = addrsize - param.tsz; | ||
84 | + outputsize = 40; | ||
85 | } | ||
86 | |||
87 | /* | ||
88 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, | ||
89 | |||
90 | /* Check that the starting level is valid. */ | ||
91 | ok = check_s2_mmu_setup(cpu, aarch64, startlevel, | ||
92 | - inputsize, stride); | ||
93 | + inputsize, stride, outputsize); | ||
94 | if (!ok) { | ||
95 | fault_type = ARMFault_Translation; | ||
96 | goto do_fault; | ||
97 | -- | ||
98 | 2.25.1 | diff view generated by jsdifflib |
1 | From: Alistair Francis <alistair.francis@wdc.com> | 1 | From: Richard Henderson <richard.henderson@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | Commit 89e68b575 "target/arm: Use vector operations for saturation" | 3 | The macro is a bit more readable than the inlined computation. |
4 | causes this abort() when booting QEMU ARM with a Cortex-A15: | ||
5 | 4 | ||
6 | 0 0x00007ffff4c2382f in raise () at /usr/lib/libc.so.6 | 5 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> |
7 | 1 0x00007ffff4c0e672 in abort () at /usr/lib/libc.so.6 | 6 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> |
8 | 2 0x00005555559c1839 in disas_neon_data_insn (insn=<optimized out>, s=<optimized out>) at ./target/arm/translate.c:6673 | 7 | Message-id: 20220301215958.157011-7-richard.henderson@linaro.org |
9 | 3 0x00005555559c1839 in disas_neon_data_insn (s=<optimized out>, insn=<optimized out>) at ./target/arm/translate.c:6386 | ||
10 | 4 0x00005555559cd8a4 in disas_arm_insn (insn=4081107068, s=0x7fffe59a9510) at ./target/arm/translate.c:9289 | ||
11 | 5 0x00005555559cd8a4 in arm_tr_translate_insn (dcbase=0x7fffe59a9510, cpu=<optimized out>) at ./target/arm/translate.c:13612 | ||
12 | 6 0x00005555558d1d39 in translator_loop (ops=0x5555561cc580 <arm_translator_ops>, db=0x7fffe59a9510, cpu=0x55555686a2f0, tb=<optimized out>, max_insns=<optimized out>) at ./accel/tcg/translator.c:96 | ||
13 | 7 0x00005555559d10d4 in gen_intermediate_code (cpu=cpu@entry=0x55555686a2f0, tb=tb@entry=0x7fffd7840080 <code_gen_buffer+126091347>, max_insns=max_insns@entry=512) at ./target/arm/translate.c:13901 | ||
14 | 8 0x00005555558d06b9 in tb_gen_code (cpu=cpu@entry=0x55555686a2f0, pc=3067096216, cs_base=0, flags=192, cflags=-16252928, cflags@entry=524288) at ./accel/tcg/translate-all.c:1736 | ||
15 | 9 0x00005555558ce467 in tb_find (cf_mask=524288, tb_exit=1, last_tb=0x7fffd783e640 <code_gen_buffer+126084627>, cpu=0x1) at ./accel/tcg/cpu-exec.c:407 | ||
16 | 10 0x00005555558ce467 in cpu_exec (cpu=cpu@entry=0x55555686a2f0) at ./accel/tcg/cpu-exec.c:728 | ||
17 | 11 0x000055555588b0cf in tcg_cpu_exec (cpu=0x55555686a2f0) at ./cpus.c:1431 | ||
18 | 12 0x000055555588d223 in qemu_tcg_cpu_thread_fn (arg=0x55555686a2f0) at ./cpus.c:1735 | ||
19 | 13 0x000055555588d223 in qemu_tcg_cpu_thread_fn (arg=arg@entry=0x55555686a2f0) at ./cpus.c:1709 | ||
20 | 14 0x0000555555d2629a in qemu_thread_start (args=<optimized out>) at ./util/qemu-thread-posix.c:502 | ||
21 | 15 0x00007ffff4db8a92 in start_thread () at /usr/lib/libpthread. | ||
22 | |||
23 | This patch ensures that we don't hit the abort() in the second switch | ||
24 | case in disas_neon_data_insn() as we will return from the first case. | ||
25 | |||
26 | Signed-off-by: Alistair Francis <alistair.francis@wdc.com> | ||
27 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | ||
28 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
29 | Reviewed-by: Alex Bennée <alex.bennee@linaro.org> | ||
30 | Tested-by: Alex Bennée <alex.bennee@linaro.org> | ||
31 | Message-id: ad91b397f360b2fc7f4087e476f7df5b04d42ddb.1558021877.git.alistair.francis@wdc.com | ||
32 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
33 | --- | 9 | --- |
34 | target/arm/translate.c | 4 ++-- | 10 | target/arm/helper.c | 4 ++-- |
35 | 1 file changed, 2 insertions(+), 2 deletions(-) | 11 | 1 file changed, 2 insertions(+), 2 deletions(-) |
36 | 12 | ||
37 | diff --git a/target/arm/translate.c b/target/arm/translate.c | 13 | diff --git a/target/arm/helper.c b/target/arm/helper.c |
38 | index XXXXXXX..XXXXXXX 100644 | 14 | index XXXXXXX..XXXXXXX 100644 |
39 | --- a/target/arm/translate.c | 15 | --- a/target/arm/helper.c |
40 | +++ b/target/arm/translate.c | 16 | +++ b/target/arm/helper.c |
41 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | 17 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, |
42 | tcg_gen_gvec_4(rd_ofs, offsetof(CPUARMState, vfp.qc), | 18 | level = startlevel; |
43 | rn_ofs, rm_ofs, vec_size, vec_size, | 19 | } |
44 | (u ? uqadd_op : sqadd_op) + size); | 20 | |
45 | - break; | 21 | - indexmask_grainsize = (1ULL << (stride + 3)) - 1; |
46 | + return 0; | 22 | - indexmask = (1ULL << (inputsize - (stride * (4 - level)))) - 1; |
47 | 23 | + indexmask_grainsize = MAKE_64BIT_MASK(0, stride + 3); | |
48 | case NEON_3R_VQSUB: | 24 | + indexmask = MAKE_64BIT_MASK(0, inputsize - (stride * (4 - level))); |
49 | tcg_gen_gvec_4(rd_ofs, offsetof(CPUARMState, vfp.qc), | 25 | |
50 | rn_ofs, rm_ofs, vec_size, vec_size, | 26 | /* Now we can extract the actual base address from the TTBR */ |
51 | (u ? uqsub_op : sqsub_op) + size); | 27 | descaddr = extract64(ttbr, 0, 48); |
52 | - break; | ||
53 | + return 0; | ||
54 | |||
55 | case NEON_3R_VMUL: /* VMUL */ | ||
56 | if (u) { | ||
57 | -- | 28 | -- |
58 | 2.20.1 | 29 | 2.25.1 |
59 | 30 | ||
60 | 31 | diff view generated by jsdifflib |
1 | From: Philippe Mathieu-Daudé <philmd@redhat.com> | 1 | From: Richard Henderson <richard.henderson@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> | 3 | This field controls the output (intermediate) physical address size |
4 | Reviewed-by: Alistair Francis <alistair.francis@wdc.com> | 4 | of the translation process. V8 requires to raise an AddressSize |
5 | Message-id: 20190520214342.13709-5-philmd@redhat.com | 5 | fault if the page tables are programmed incorrectly, such that any |
6 | intermediate descriptor address, or the final translated address, | ||
7 | is out of range. | ||
8 | |||
9 | Add a PS field to ARMVAParameters, and properly compute outputsize | ||
10 | in get_phys_addr_lpae. Test the descaddr as extracted from TTBR | ||
11 | and from page table entries. | ||
12 | |||
13 | Restrict descaddrmask so that we won't raise the fault for v7. | ||
14 | |||
15 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
16 | Reviewed-by: Alex Bennée <alex.bennee@linaro.org> | ||
17 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
18 | Message-id: 20220301215958.157011-8-richard.henderson@linaro.org | ||
6 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 19 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
7 | --- | 20 | --- |
8 | include/hw/arm/exynos4210.h | 9 +++++++-- | 21 | target/arm/internals.h | 1 + |
9 | hw/arm/exynos4210.c | 28 ++++++++++++++++++++++++---- | 22 | target/arm/helper.c | 72 ++++++++++++++++++++++++++++++++---------- |
10 | hw/arm/exynos4_boards.c | 9 ++++++--- | 23 | 2 files changed, 57 insertions(+), 16 deletions(-) |
11 | 3 files changed, 37 insertions(+), 9 deletions(-) | ||
12 | 24 | ||
13 | diff --git a/include/hw/arm/exynos4210.h b/include/hw/arm/exynos4210.h | 25 | diff --git a/target/arm/internals.h b/target/arm/internals.h |
14 | index XXXXXXX..XXXXXXX 100644 | 26 | index XXXXXXX..XXXXXXX 100644 |
15 | --- a/include/hw/arm/exynos4210.h | 27 | --- a/target/arm/internals.h |
16 | +++ b/include/hw/arm/exynos4210.h | 28 | +++ b/target/arm/internals.h |
17 | @@ -XXX,XX +XXX,XX @@ typedef struct Exynos4210Irq { | 29 | @@ -XXX,XX +XXX,XX @@ static inline uint32_t aarch64_pstate_valid_mask(const ARMISARegisters *id) |
18 | } Exynos4210Irq; | 30 | */ |
19 | 31 | typedef struct ARMVAParameters { | |
20 | typedef struct Exynos4210State { | 32 | unsigned tsz : 8; |
21 | + /*< private >*/ | 33 | + unsigned ps : 3; |
22 | + SysBusDevice parent_obj; | 34 | unsigned select : 1; |
23 | + /*< public >*/ | 35 | bool tbi : 1; |
24 | ARMCPU *cpu[EXYNOS4210_NCPUS]; | 36 | bool epd : 1; |
25 | Exynos4210Irq irqs; | 37 | diff --git a/target/arm/helper.c b/target/arm/helper.c |
26 | qemu_irq *irq_table; | ||
27 | @@ -XXX,XX +XXX,XX @@ typedef struct Exynos4210State { | ||
28 | I2CBus *i2c_if[EXYNOS4210_I2C_NUMBER]; | ||
29 | } Exynos4210State; | ||
30 | |||
31 | +#define TYPE_EXYNOS4210_SOC "exynos4210" | ||
32 | +#define EXYNOS4210_SOC(obj) \ | ||
33 | + OBJECT_CHECK(Exynos4210State, obj, TYPE_EXYNOS4210_SOC) | ||
34 | + | ||
35 | void exynos4210_write_secondary(ARMCPU *cpu, | ||
36 | const struct arm_boot_info *info); | ||
37 | |||
38 | -Exynos4210State *exynos4210_init(MemoryRegion *system_mem); | ||
39 | - | ||
40 | /* Initialize exynos4210 IRQ subsystem stub */ | ||
41 | qemu_irq *exynos4210_init_irq(Exynos4210Irq *env); | ||
42 | |||
43 | diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c | ||
44 | index XXXXXXX..XXXXXXX 100644 | 38 | index XXXXXXX..XXXXXXX 100644 |
45 | --- a/hw/arm/exynos4210.c | 39 | --- a/target/arm/helper.c |
46 | +++ b/hw/arm/exynos4210.c | 40 | +++ b/target/arm/helper.c |
47 | @@ -XXX,XX +XXX,XX @@ static void pl330_create(uint32_t base, qemu_irq irq, int nreq) | 41 | @@ -XXX,XX +XXX,XX @@ static uint8_t convert_stage2_attrs(CPUARMState *env, uint8_t s2attrs) |
48 | sysbus_connect_irq(busdev, 0, irq); | ||
49 | } | 42 | } |
50 | 43 | #endif /* !CONFIG_USER_ONLY */ | |
51 | -Exynos4210State *exynos4210_init(MemoryRegion *system_mem) | 44 | |
52 | +static void exynos4210_realize(DeviceState *socdev, Error **errp) | 45 | +/* This mapping is common between ID_AA64MMFR0.PARANGE and TCR_ELx.{I}PS. */ |
53 | { | 46 | +static const uint8_t pamax_map[] = { |
54 | - Exynos4210State *s = g_new0(Exynos4210State, 1); | 47 | + [0] = 32, |
55 | + Exynos4210State *s = EXYNOS4210_SOC(socdev); | 48 | + [1] = 36, |
56 | + MemoryRegion *system_mem = get_system_memory(); | 49 | + [2] = 40, |
57 | qemu_irq gate_irq[EXYNOS4210_NCPUS][EXYNOS4210_IRQ_GATE_NINPUTS]; | 50 | + [3] = 42, |
58 | SysBusDevice *busdev; | 51 | + [4] = 44, |
59 | DeviceState *dev; | 52 | + [5] = 48, |
60 | @@ -XXX,XX +XXX,XX @@ Exynos4210State *exynos4210_init(MemoryRegion *system_mem) | ||
61 | qemu_irq_invert(s->irq_table[exynos4210_get_irq(36, 1)]), 32); | ||
62 | pl330_create(EXYNOS4210_PL330_BASE2_ADDR, | ||
63 | qemu_irq_invert(s->irq_table[exynos4210_get_irq(34, 1)]), 1); | ||
64 | - | ||
65 | - return s; | ||
66 | } | ||
67 | + | ||
68 | +static void exynos4210_class_init(ObjectClass *klass, void *data) | ||
69 | +{ | ||
70 | + DeviceClass *dc = DEVICE_CLASS(klass); | ||
71 | + | ||
72 | + dc->realize = exynos4210_realize; | ||
73 | +} | ||
74 | + | ||
75 | +static const TypeInfo exynos4210_info = { | ||
76 | + .name = TYPE_EXYNOS4210_SOC, | ||
77 | + .parent = TYPE_SYS_BUS_DEVICE, | ||
78 | + .instance_size = sizeof(Exynos4210State), | ||
79 | + .class_init = exynos4210_class_init, | ||
80 | +}; | 53 | +}; |
81 | + | 54 | + |
82 | +static void exynos4210_register_types(void) | 55 | /* The cpu-specific constant value of PAMax; also used by hw/arm/virt. */ |
83 | +{ | 56 | unsigned int arm_pamax(ARMCPU *cpu) |
84 | + type_register_static(&exynos4210_info); | 57 | { |
85 | +} | 58 | - static const unsigned int pamax_map[] = { |
59 | - [0] = 32, | ||
60 | - [1] = 36, | ||
61 | - [2] = 40, | ||
62 | - [3] = 42, | ||
63 | - [4] = 44, | ||
64 | - [5] = 48, | ||
65 | - }; | ||
66 | unsigned int parange = | ||
67 | FIELD_EX64(cpu->isar.id_aa64mmfr0, ID_AA64MMFR0, PARANGE); | ||
68 | |||
69 | @@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
70 | { | ||
71 | uint64_t tcr = regime_tcr(env, mmu_idx)->raw_tcr; | ||
72 | bool epd, hpd, using16k, using64k, tsz_oob; | ||
73 | - int select, tsz, tbi, max_tsz, min_tsz; | ||
74 | + int select, tsz, tbi, max_tsz, min_tsz, ps; | ||
75 | |||
76 | if (!regime_has_2_ranges(mmu_idx)) { | ||
77 | select = 0; | ||
78 | @@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
79 | hpd = extract32(tcr, 24, 1); | ||
80 | } | ||
81 | epd = false; | ||
82 | + ps = extract32(tcr, 16, 3); | ||
83 | } else { | ||
84 | /* | ||
85 | * Bit 55 is always between the two regions, and is canonical for | ||
86 | @@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
87 | epd = extract32(tcr, 23, 1); | ||
88 | hpd = extract64(tcr, 42, 1); | ||
89 | } | ||
90 | + ps = extract64(tcr, 32, 3); | ||
91 | } | ||
92 | |||
93 | if (cpu_isar_feature(aa64_st, env_archcpu(env))) { | ||
94 | @@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
95 | |||
96 | return (ARMVAParameters) { | ||
97 | .tsz = tsz, | ||
98 | + .ps = ps, | ||
99 | .select = select, | ||
100 | .tbi = tbi, | ||
101 | .epd = epd, | ||
102 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, | ||
103 | |||
104 | /* TODO: This code does not support shareability levels. */ | ||
105 | if (aarch64) { | ||
106 | + int ps; | ||
86 | + | 107 | + |
87 | +type_init(exynos4210_register_types) | 108 | param = aa64_va_parameters(env, address, mmu_idx, |
88 | diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c | 109 | access_type != MMU_INST_FETCH); |
89 | index XXXXXXX..XXXXXXX 100644 | 110 | level = 0; |
90 | --- a/hw/arm/exynos4_boards.c | 111 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, |
91 | +++ b/hw/arm/exynos4_boards.c | 112 | |
92 | @@ -XXX,XX +XXX,XX @@ typedef enum Exynos4BoardType { | 113 | addrsize = 64 - 8 * param.tbi; |
93 | } Exynos4BoardType; | 114 | inputsize = 64 - param.tsz; |
94 | 115 | - outputsize = arm_pamax(cpu); | |
95 | typedef struct Exynos4BoardState { | 116 | + |
96 | - Exynos4210State *soc; | 117 | + /* |
97 | + Exynos4210State soc; | 118 | + * Bound PS by PARANGE to find the effective output address size. |
98 | MemoryRegion dram0_mem; | 119 | + * ID_AA64MMFR0 is a read-only register so values outside of the |
99 | MemoryRegion dram1_mem; | 120 | + * supported mappings can be considered an implementation error. |
100 | } Exynos4BoardState; | 121 | + */ |
101 | @@ -XXX,XX +XXX,XX @@ exynos4_boards_init_common(MachineState *machine, | 122 | + ps = FIELD_EX64(cpu->isar.id_aa64mmfr0, ID_AA64MMFR0, PARANGE); |
102 | exynos4_boards_init_ram(s, get_system_memory(), | 123 | + ps = MIN(ps, param.ps); |
103 | exynos4_board_ram_size[board_type]); | 124 | + assert(ps < ARRAY_SIZE(pamax_map)); |
104 | 125 | + outputsize = pamax_map[ps]; | |
105 | - s->soc = exynos4210_init(get_system_memory()); | 126 | } else { |
106 | + object_initialize(&s->soc, sizeof(s->soc), TYPE_EXYNOS4210_SOC); | 127 | param = aa32_va_parameters(env, address, mmu_idx); |
107 | + qdev_set_parent_bus(DEVICE(&s->soc), sysbus_get_default()); | 128 | level = 1; |
108 | + object_property_set_bool(OBJECT(&s->soc), true, "realized", | 129 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, |
109 | + &error_fatal); | 130 | |
110 | 131 | /* Now we can extract the actual base address from the TTBR */ | |
111 | return s; | 132 | descaddr = extract64(ttbr, 0, 48); |
112 | } | 133 | + |
113 | @@ -XXX,XX +XXX,XX @@ static void smdkc210_init(MachineState *machine) | 134 | + /* |
114 | EXYNOS4_BOARD_SMDKC210); | 135 | + * If the base address is out of range, raise AddressSizeFault. |
115 | 136 | + * In the pseudocode, this is !IsZero(baseregister<47:outputsize>), | |
116 | lan9215_init(SMDK_LAN9118_BASE_ADDR, | 137 | + * but we've just cleared the bits above 47, so simplify the test. |
117 | - qemu_irq_invert(s->soc->irq_table[exynos4210_get_irq(37, 1)])); | 138 | + */ |
118 | + qemu_irq_invert(s->soc.irq_table[exynos4210_get_irq(37, 1)])); | 139 | + if (descaddr >> outputsize) { |
119 | arm_load_kernel(ARM_CPU(first_cpu), &exynos4_board_binfo); | 140 | + level = 0; |
120 | } | 141 | + fault_type = ARMFault_AddressSize; |
121 | 142 | + goto do_fault; | |
143 | + } | ||
144 | + | ||
145 | /* | ||
146 | * We rely on this masking to clear the RES0 bits at the bottom of the TTBR | ||
147 | * and also to mask out CnP (bit 0) which could validly be non-zero. | ||
148 | */ | ||
149 | descaddr &= ~indexmask; | ||
150 | |||
151 | - /* The address field in the descriptor goes up to bit 39 for ARMv7 | ||
152 | - * but up to bit 47 for ARMv8, but we use the descaddrmask | ||
153 | - * up to bit 39 for AArch32, because we don't need other bits in that case | ||
154 | - * to construct next descriptor address (anyway they should be all zeroes). | ||
155 | + /* | ||
156 | + * For AArch32, the address field in the descriptor goes up to bit 39 | ||
157 | + * for both v7 and v8. However, for v8 the SBZ bits [47:40] must be 0 | ||
158 | + * or an AddressSize fault is raised. So for v8 we extract those SBZ | ||
159 | + * bits as part of the address, which will be checked via outputsize. | ||
160 | + * For AArch64, the address field always goes up to bit 47 (with extra | ||
161 | + * bits for FEAT_LPA placed elsewhere). AArch64 implies v8. | ||
162 | */ | ||
163 | - descaddrmask = ((1ull << (aarch64 ? 48 : 40)) - 1) & | ||
164 | - ~indexmask_grainsize; | ||
165 | + if (arm_feature(env, ARM_FEATURE_V8)) { | ||
166 | + descaddrmask = MAKE_64BIT_MASK(0, 48); | ||
167 | + } else { | ||
168 | + descaddrmask = MAKE_64BIT_MASK(0, 40); | ||
169 | + } | ||
170 | + descaddrmask &= ~indexmask_grainsize; | ||
171 | |||
172 | /* Secure accesses start with the page table in secure memory and | ||
173 | * can be downgraded to non-secure at any step. Non-secure accesses | ||
174 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, | ||
175 | /* Invalid, or the Reserved level 3 encoding */ | ||
176 | goto do_fault; | ||
177 | } | ||
178 | + | ||
179 | descaddr = descriptor & descaddrmask; | ||
180 | + if (descaddr >> outputsize) { | ||
181 | + fault_type = ARMFault_AddressSize; | ||
182 | + goto do_fault; | ||
183 | + } | ||
184 | |||
185 | if ((descriptor & 2) && (level < 3)) { | ||
186 | /* Table entry. The top five bits are attributes which may | ||
122 | -- | 187 | -- |
123 | 2.20.1 | 188 | 2.25.1 |
124 | 189 | ||
125 | 190 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
1 | 2 | ||
3 | The original A.a revision of the AArch64 ARM required that we | ||
4 | force-extend the addresses in these registers from 49 bits. | ||
5 | This language has been loosened via a combination of IMPLEMENTATION | ||
6 | DEFINED and CONSTRAINTED UNPREDICTABLE to allow consideration of | ||
7 | the entire aligned address. | ||
8 | |||
9 | This means that we do not have to consider whether or not FEAT_LVA | ||
10 | is enabled, and decide from which bit an address might need to be | ||
11 | extended. | ||
12 | |||
13 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
14 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
15 | Message-id: 20220301215958.157011-9-richard.henderson@linaro.org | ||
16 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
17 | --- | ||
18 | target/arm/helper.c | 32 ++++++++++++++++++++++++-------- | ||
19 | 1 file changed, 24 insertions(+), 8 deletions(-) | ||
20 | |||
21 | diff --git a/target/arm/helper.c b/target/arm/helper.c | ||
22 | index XXXXXXX..XXXXXXX 100644 | ||
23 | --- a/target/arm/helper.c | ||
24 | +++ b/target/arm/helper.c | ||
25 | @@ -XXX,XX +XXX,XX @@ static void dbgwvr_write(CPUARMState *env, const ARMCPRegInfo *ri, | ||
26 | ARMCPU *cpu = env_archcpu(env); | ||
27 | int i = ri->crm; | ||
28 | |||
29 | - /* Bits [63:49] are hardwired to the value of bit [48]; that is, the | ||
30 | - * register reads and behaves as if values written are sign extended. | ||
31 | + /* | ||
32 | * Bits [1:0] are RES0. | ||
33 | + * | ||
34 | + * It is IMPLEMENTATION DEFINED whether [63:49] ([63:53] with FEAT_LVA) | ||
35 | + * are hardwired to the value of bit [48] ([52] with FEAT_LVA), or if | ||
36 | + * they contain the value written. It is CONSTRAINED UNPREDICTABLE | ||
37 | + * whether the RESS bits are ignored when comparing an address. | ||
38 | + * | ||
39 | + * Therefore we are allowed to compare the entire register, which lets | ||
40 | + * us avoid considering whether or not FEAT_LVA is actually enabled. | ||
41 | */ | ||
42 | - value = sextract64(value, 0, 49) & ~3ULL; | ||
43 | + value &= ~3ULL; | ||
44 | |||
45 | raw_write(env, ri, value); | ||
46 | hw_watchpoint_update(cpu, i); | ||
47 | @@ -XXX,XX +XXX,XX @@ void hw_breakpoint_update(ARMCPU *cpu, int n) | ||
48 | case 0: /* unlinked address match */ | ||
49 | case 1: /* linked address match */ | ||
50 | { | ||
51 | - /* Bits [63:49] are hardwired to the value of bit [48]; that is, | ||
52 | - * we behave as if the register was sign extended. Bits [1:0] are | ||
53 | - * RES0. The BAS field is used to allow setting breakpoints on 16 | ||
54 | - * bit wide instructions; it is CONSTRAINED UNPREDICTABLE whether | ||
55 | + /* | ||
56 | + * Bits [1:0] are RES0. | ||
57 | + * | ||
58 | + * It is IMPLEMENTATION DEFINED whether bits [63:49] | ||
59 | + * ([63:53] for FEAT_LVA) are hardwired to a copy of the sign bit | ||
60 | + * of the VA field ([48] or [52] for FEAT_LVA), or whether the | ||
61 | + * value is read as written. It is CONSTRAINED UNPREDICTABLE | ||
62 | + * whether the RESS bits are ignored when comparing an address. | ||
63 | + * Therefore we are allowed to compare the entire register, which | ||
64 | + * lets us avoid considering whether FEAT_LVA is actually enabled. | ||
65 | + * | ||
66 | + * The BAS field is used to allow setting breakpoints on 16-bit | ||
67 | + * wide instructions; it is CONSTRAINED UNPREDICTABLE whether | ||
68 | * a bp will fire if the addresses covered by the bp and the addresses | ||
69 | * covered by the insn overlap but the insn doesn't start at the | ||
70 | * start of the bp address range. We choose to require the insn and | ||
71 | @@ -XXX,XX +XXX,XX @@ void hw_breakpoint_update(ARMCPU *cpu, int n) | ||
72 | * See also figure D2-3 in the v8 ARM ARM (DDI0487A.c). | ||
73 | */ | ||
74 | int bas = extract64(bcr, 5, 4); | ||
75 | - addr = sextract64(bvr, 0, 49) & ~3ULL; | ||
76 | + addr = bvr & ~3ULL; | ||
77 | if (bas == 0) { | ||
78 | return; | ||
79 | } | ||
80 | -- | ||
81 | 2.25.1 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
1 | 2 | ||
3 | This feature is relatively small, as it applies only to | ||
4 | 64k pages and thus requires no additional changes to the | ||
5 | table descriptor walking algorithm, only a change to the | ||
6 | minimum TSZ (which is the inverse of the maximum virtual | ||
7 | address space size). | ||
8 | |||
9 | Note that this feature widens VBAR_ELx, but we already | ||
10 | treat the register as being 64 bits wide. | ||
11 | |||
12 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
13 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
14 | Message-id: 20220301215958.157011-10-richard.henderson@linaro.org | ||
15 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
16 | --- | ||
17 | docs/system/arm/emulation.rst | 1 + | ||
18 | target/arm/cpu-param.h | 2 +- | ||
19 | target/arm/cpu.h | 5 +++++ | ||
20 | target/arm/cpu64.c | 1 + | ||
21 | target/arm/helper.c | 9 ++++++++- | ||
22 | 5 files changed, 16 insertions(+), 2 deletions(-) | ||
23 | |||
24 | diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst | ||
25 | index XXXXXXX..XXXXXXX 100644 | ||
26 | --- a/docs/system/arm/emulation.rst | ||
27 | +++ b/docs/system/arm/emulation.rst | ||
28 | @@ -XXX,XX +XXX,XX @@ the following architecture extensions: | ||
29 | - FEAT_LRCPC (Load-acquire RCpc instructions) | ||
30 | - FEAT_LRCPC2 (Load-acquire RCpc instructions v2) | ||
31 | - FEAT_LSE (Large System Extensions) | ||
32 | +- FEAT_LVA (Large Virtual Address space) | ||
33 | - FEAT_MTE (Memory Tagging Extension) | ||
34 | - FEAT_MTE2 (Memory Tagging Extension) | ||
35 | - FEAT_MTE3 (MTE Asymmetric Fault Handling) | ||
36 | diff --git a/target/arm/cpu-param.h b/target/arm/cpu-param.h | ||
37 | index XXXXXXX..XXXXXXX 100644 | ||
38 | --- a/target/arm/cpu-param.h | ||
39 | +++ b/target/arm/cpu-param.h | ||
40 | @@ -XXX,XX +XXX,XX @@ | ||
41 | #ifdef TARGET_AARCH64 | ||
42 | # define TARGET_LONG_BITS 64 | ||
43 | # define TARGET_PHYS_ADDR_SPACE_BITS 48 | ||
44 | -# define TARGET_VIRT_ADDR_SPACE_BITS 48 | ||
45 | +# define TARGET_VIRT_ADDR_SPACE_BITS 52 | ||
46 | #else | ||
47 | # define TARGET_LONG_BITS 32 | ||
48 | # define TARGET_PHYS_ADDR_SPACE_BITS 40 | ||
49 | diff --git a/target/arm/cpu.h b/target/arm/cpu.h | ||
50 | index XXXXXXX..XXXXXXX 100644 | ||
51 | --- a/target/arm/cpu.h | ||
52 | +++ b/target/arm/cpu.h | ||
53 | @@ -XXX,XX +XXX,XX @@ static inline bool isar_feature_aa64_ccidx(const ARMISARegisters *id) | ||
54 | return FIELD_EX64(id->id_aa64mmfr2, ID_AA64MMFR2, CCIDX) != 0; | ||
55 | } | ||
56 | |||
57 | +static inline bool isar_feature_aa64_lva(const ARMISARegisters *id) | ||
58 | +{ | ||
59 | + return FIELD_EX64(id->id_aa64mmfr2, ID_AA64MMFR2, VARANGE) != 0; | ||
60 | +} | ||
61 | + | ||
62 | static inline bool isar_feature_aa64_tts2uxn(const ARMISARegisters *id) | ||
63 | { | ||
64 | return FIELD_EX64(id->id_aa64mmfr1, ID_AA64MMFR1, XNX) != 0; | ||
65 | diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c | ||
66 | index XXXXXXX..XXXXXXX 100644 | ||
67 | --- a/target/arm/cpu64.c | ||
68 | +++ b/target/arm/cpu64.c | ||
69 | @@ -XXX,XX +XXX,XX @@ static void aarch64_max_initfn(Object *obj) | ||
70 | t = FIELD_DP64(t, ID_AA64MMFR2, UAO, 1); | ||
71 | t = FIELD_DP64(t, ID_AA64MMFR2, CNP, 1); /* TTCNP */ | ||
72 | t = FIELD_DP64(t, ID_AA64MMFR2, ST, 1); /* TTST */ | ||
73 | + t = FIELD_DP64(t, ID_AA64MMFR2, VARANGE, 1); /* FEAT_LVA */ | ||
74 | cpu->isar.id_aa64mmfr2 = t; | ||
75 | |||
76 | t = cpu->isar.id_aa64zfr0; | ||
77 | diff --git a/target/arm/helper.c b/target/arm/helper.c | ||
78 | index XXXXXXX..XXXXXXX 100644 | ||
79 | --- a/target/arm/helper.c | ||
80 | +++ b/target/arm/helper.c | ||
81 | @@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
82 | } else { | ||
83 | max_tsz = 39; | ||
84 | } | ||
85 | - min_tsz = 16; /* TODO: ARMv8.2-LVA */ | ||
86 | + | ||
87 | + min_tsz = 16; | ||
88 | + if (using64k) { | ||
89 | + if (cpu_isar_feature(aa64_lva, env_archcpu(env))) { | ||
90 | + min_tsz = 12; | ||
91 | + } | ||
92 | + } | ||
93 | + /* TODO: FEAT_LPA2 */ | ||
94 | |||
95 | if (tsz > max_tsz) { | ||
96 | tsz = max_tsz; | ||
97 | -- | ||
98 | 2.25.1 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
1 | 2 | ||
3 | This feature widens physical addresses (and intermediate physical | ||
4 | addresses for 2-stage translation) from 48 to 52 bits, when using | ||
5 | 64k pages. The only thing left at this point is to handle the | ||
6 | extra bits in the TTBR and in the table descriptors. | ||
7 | |||
8 | Note that PAR_EL1 and HPFAR_EL2 are nominally extended, but we don't | ||
9 | mask out the high bits when writing to those registers, so no changes | ||
10 | are required there. | ||
11 | |||
12 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
13 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
14 | Message-id: 20220301215958.157011-11-richard.henderson@linaro.org | ||
15 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
16 | --- | ||
17 | docs/system/arm/emulation.rst | 1 + | ||
18 | target/arm/cpu-param.h | 2 +- | ||
19 | target/arm/cpu64.c | 2 +- | ||
20 | target/arm/helper.c | 19 ++++++++++++++++--- | ||
21 | 4 files changed, 19 insertions(+), 5 deletions(-) | ||
22 | |||
23 | diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst | ||
24 | index XXXXXXX..XXXXXXX 100644 | ||
25 | --- a/docs/system/arm/emulation.rst | ||
26 | +++ b/docs/system/arm/emulation.rst | ||
27 | @@ -XXX,XX +XXX,XX @@ the following architecture extensions: | ||
28 | - FEAT_I8MM (AArch64 Int8 matrix multiplication instructions) | ||
29 | - FEAT_JSCVT (JavaScript conversion instructions) | ||
30 | - FEAT_LOR (Limited ordering regions) | ||
31 | +- FEAT_LPA (Large Physical Address space) | ||
32 | - FEAT_LRCPC (Load-acquire RCpc instructions) | ||
33 | - FEAT_LRCPC2 (Load-acquire RCpc instructions v2) | ||
34 | - FEAT_LSE (Large System Extensions) | ||
35 | diff --git a/target/arm/cpu-param.h b/target/arm/cpu-param.h | ||
36 | index XXXXXXX..XXXXXXX 100644 | ||
37 | --- a/target/arm/cpu-param.h | ||
38 | +++ b/target/arm/cpu-param.h | ||
39 | @@ -XXX,XX +XXX,XX @@ | ||
40 | |||
41 | #ifdef TARGET_AARCH64 | ||
42 | # define TARGET_LONG_BITS 64 | ||
43 | -# define TARGET_PHYS_ADDR_SPACE_BITS 48 | ||
44 | +# define TARGET_PHYS_ADDR_SPACE_BITS 52 | ||
45 | # define TARGET_VIRT_ADDR_SPACE_BITS 52 | ||
46 | #else | ||
47 | # define TARGET_LONG_BITS 32 | ||
48 | diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c | ||
49 | index XXXXXXX..XXXXXXX 100644 | ||
50 | --- a/target/arm/cpu64.c | ||
51 | +++ b/target/arm/cpu64.c | ||
52 | @@ -XXX,XX +XXX,XX @@ static void aarch64_max_initfn(Object *obj) | ||
53 | cpu->isar.id_aa64pfr1 = t; | ||
54 | |||
55 | t = cpu->isar.id_aa64mmfr0; | ||
56 | - t = FIELD_DP64(t, ID_AA64MMFR0, PARANGE, 5); /* PARange: 48 bits */ | ||
57 | + t = FIELD_DP64(t, ID_AA64MMFR0, PARANGE, 6); /* FEAT_LPA: 52 bits */ | ||
58 | cpu->isar.id_aa64mmfr0 = t; | ||
59 | |||
60 | t = cpu->isar.id_aa64mmfr1; | ||
61 | diff --git a/target/arm/helper.c b/target/arm/helper.c | ||
62 | index XXXXXXX..XXXXXXX 100644 | ||
63 | --- a/target/arm/helper.c | ||
64 | +++ b/target/arm/helper.c | ||
65 | @@ -XXX,XX +XXX,XX @@ static const uint8_t pamax_map[] = { | ||
66 | [3] = 42, | ||
67 | [4] = 44, | ||
68 | [5] = 48, | ||
69 | + [6] = 52, | ||
70 | }; | ||
71 | |||
72 | /* The cpu-specific constant value of PAMax; also used by hw/arm/virt. */ | ||
73 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, | ||
74 | descaddr = extract64(ttbr, 0, 48); | ||
75 | |||
76 | /* | ||
77 | - * If the base address is out of range, raise AddressSizeFault. | ||
78 | + * For FEAT_LPA and PS=6, bits [51:48] of descaddr are in [5:2] of TTBR. | ||
79 | + * | ||
80 | + * Otherwise, if the base address is out of range, raise AddressSizeFault. | ||
81 | * In the pseudocode, this is !IsZero(baseregister<47:outputsize>), | ||
82 | * but we've just cleared the bits above 47, so simplify the test. | ||
83 | */ | ||
84 | - if (descaddr >> outputsize) { | ||
85 | + if (outputsize > 48) { | ||
86 | + descaddr |= extract64(ttbr, 2, 4) << 48; | ||
87 | + } else if (descaddr >> outputsize) { | ||
88 | level = 0; | ||
89 | fault_type = ARMFault_AddressSize; | ||
90 | goto do_fault; | ||
91 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, | ||
92 | } | ||
93 | |||
94 | descaddr = descriptor & descaddrmask; | ||
95 | - if (descaddr >> outputsize) { | ||
96 | + | ||
97 | + /* | ||
98 | + * For FEAT_LPA and PS=6, bits [51:48] of descaddr are in [15:12] | ||
99 | + * of descriptor. Otherwise, if descaddr is out of range, raise | ||
100 | + * AddressSizeFault. | ||
101 | + */ | ||
102 | + if (outputsize > 48) { | ||
103 | + descaddr |= extract64(descriptor, 12, 4) << 48; | ||
104 | + } else if (descaddr >> outputsize) { | ||
105 | fault_type = ARMFault_AddressSize; | ||
106 | goto do_fault; | ||
107 | } | ||
108 | -- | ||
109 | 2.25.1 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
1 | 2 | ||
3 | With FEAT_LPA2, rather than introducing translation level 4, | ||
4 | we introduce level -1, below the current level 0. Extend | ||
5 | arm_fi_to_lfsc to handle these faults. | ||
6 | |||
7 | Assert that this new translation level does not leak into | ||
8 | fault types for which it is not defined, which allows some | ||
9 | masking of fi->level to be removed. | ||
10 | |||
11 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
12 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
13 | Message-id: 20220301215958.157011-12-richard.henderson@linaro.org | ||
14 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
15 | --- | ||
16 | target/arm/internals.h | 35 +++++++++++++++++++++++++++++------ | ||
17 | 1 file changed, 29 insertions(+), 6 deletions(-) | ||
18 | |||
19 | diff --git a/target/arm/internals.h b/target/arm/internals.h | ||
20 | index XXXXXXX..XXXXXXX 100644 | ||
21 | --- a/target/arm/internals.h | ||
22 | +++ b/target/arm/internals.h | ||
23 | @@ -XXX,XX +XXX,XX @@ static inline uint32_t arm_fi_to_lfsc(ARMMMUFaultInfo *fi) | ||
24 | case ARMFault_None: | ||
25 | return 0; | ||
26 | case ARMFault_AddressSize: | ||
27 | - fsc = fi->level & 3; | ||
28 | + assert(fi->level >= -1 && fi->level <= 3); | ||
29 | + if (fi->level < 0) { | ||
30 | + fsc = 0b101001; | ||
31 | + } else { | ||
32 | + fsc = fi->level; | ||
33 | + } | ||
34 | break; | ||
35 | case ARMFault_AccessFlag: | ||
36 | - fsc = (fi->level & 3) | (0x2 << 2); | ||
37 | + assert(fi->level >= 0 && fi->level <= 3); | ||
38 | + fsc = 0b001000 | fi->level; | ||
39 | break; | ||
40 | case ARMFault_Permission: | ||
41 | - fsc = (fi->level & 3) | (0x3 << 2); | ||
42 | + assert(fi->level >= 0 && fi->level <= 3); | ||
43 | + fsc = 0b001100 | fi->level; | ||
44 | break; | ||
45 | case ARMFault_Translation: | ||
46 | - fsc = (fi->level & 3) | (0x1 << 2); | ||
47 | + assert(fi->level >= -1 && fi->level <= 3); | ||
48 | + if (fi->level < 0) { | ||
49 | + fsc = 0b101011; | ||
50 | + } else { | ||
51 | + fsc = 0b000100 | fi->level; | ||
52 | + } | ||
53 | break; | ||
54 | case ARMFault_SyncExternal: | ||
55 | fsc = 0x10 | (fi->ea << 12); | ||
56 | break; | ||
57 | case ARMFault_SyncExternalOnWalk: | ||
58 | - fsc = (fi->level & 3) | (0x5 << 2) | (fi->ea << 12); | ||
59 | + assert(fi->level >= -1 && fi->level <= 3); | ||
60 | + if (fi->level < 0) { | ||
61 | + fsc = 0b010011; | ||
62 | + } else { | ||
63 | + fsc = 0b010100 | fi->level; | ||
64 | + } | ||
65 | + fsc |= fi->ea << 12; | ||
66 | break; | ||
67 | case ARMFault_SyncParity: | ||
68 | fsc = 0x18; | ||
69 | break; | ||
70 | case ARMFault_SyncParityOnWalk: | ||
71 | - fsc = (fi->level & 3) | (0x7 << 2); | ||
72 | + assert(fi->level >= -1 && fi->level <= 3); | ||
73 | + if (fi->level < 0) { | ||
74 | + fsc = 0b011011; | ||
75 | + } else { | ||
76 | + fsc = 0b011100 | fi->level; | ||
77 | + } | ||
78 | break; | ||
79 | case ARMFault_AsyncParity: | ||
80 | fsc = 0x19; | ||
81 | -- | ||
82 | 2.25.1 | diff view generated by jsdifflib |
1 | From: Philippe Mathieu-Daudé <philmd@redhat.com> | 1 | From: Richard Henderson <richard.henderson@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> | 3 | Merge tlbi_aa64_range_get_length and tlbi_aa64_range_get_base, |
4 | Reviewed-by: Alistair Francis <alistair.francis@wdc.com> | 4 | returning a structure containing both results. Pass in the |
5 | Message-id: 20190520214342.13709-2-philmd@redhat.com | 5 | ARMMMUIdx, rather than the digested two_ranges boolean. |
6 | |||
7 | This is in preparation for FEAT_LPA2, where the interpretation | ||
8 | of 'value' depends on the effective value of DS for the regime. | ||
9 | |||
10 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
11 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
12 | Message-id: 20220301215958.157011-13-richard.henderson@linaro.org | ||
6 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
7 | --- | 14 | --- |
8 | hw/arm/exynos4_boards.c | 24 ------------------------ | 15 | target/arm/helper.c | 58 +++++++++++++++++++-------------------------- |
9 | 1 file changed, 24 deletions(-) | 16 | 1 file changed, 24 insertions(+), 34 deletions(-) |
10 | 17 | ||
11 | diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c | 18 | diff --git a/target/arm/helper.c b/target/arm/helper.c |
12 | index XXXXXXX..XXXXXXX 100644 | 19 | index XXXXXXX..XXXXXXX 100644 |
13 | --- a/hw/arm/exynos4_boards.c | 20 | --- a/target/arm/helper.c |
14 | +++ b/hw/arm/exynos4_boards.c | 21 | +++ b/target/arm/helper.c |
15 | @@ -XXX,XX +XXX,XX @@ | 22 | @@ -XXX,XX +XXX,XX @@ static void tlbi_aa64_vae3is_write(CPUARMState *env, const ARMCPRegInfo *ri, |
16 | #include "hw/net/lan9118.h" | 23 | } |
17 | #include "hw/boards.h" | 24 | |
18 | 25 | #ifdef TARGET_AARCH64 | |
19 | -#undef DEBUG | 26 | -static uint64_t tlbi_aa64_range_get_length(CPUARMState *env, |
27 | - uint64_t value) | ||
28 | -{ | ||
29 | - unsigned int page_shift; | ||
30 | - unsigned int page_size_granule; | ||
31 | - uint64_t num; | ||
32 | - uint64_t scale; | ||
33 | - uint64_t exponent; | ||
34 | +typedef struct { | ||
35 | + uint64_t base; | ||
36 | uint64_t length; | ||
37 | +} TLBIRange; | ||
38 | + | ||
39 | +static TLBIRange tlbi_aa64_get_range(CPUARMState *env, ARMMMUIdx mmuidx, | ||
40 | + uint64_t value) | ||
41 | +{ | ||
42 | + unsigned int page_size_granule, page_shift, num, scale, exponent; | ||
43 | + TLBIRange ret = { }; | ||
44 | |||
45 | - num = extract64(value, 39, 5); | ||
46 | - scale = extract64(value, 44, 2); | ||
47 | page_size_granule = extract64(value, 46, 2); | ||
48 | |||
49 | if (page_size_granule == 0) { | ||
50 | qemu_log_mask(LOG_GUEST_ERROR, "Invalid page size granule %d\n", | ||
51 | page_size_granule); | ||
52 | - return 0; | ||
53 | + return ret; | ||
54 | } | ||
55 | |||
56 | page_shift = (page_size_granule - 1) * 2 + 12; | ||
20 | - | 57 | - |
21 | -//#define DEBUG | 58 | + num = extract64(value, 39, 5); |
59 | + scale = extract64(value, 44, 2); | ||
60 | exponent = (5 * scale) + 1; | ||
61 | - length = (num + 1) << (exponent + page_shift); | ||
62 | |||
63 | - return length; | ||
64 | -} | ||
65 | + ret.length = (num + 1) << (exponent + page_shift); | ||
66 | |||
67 | -static uint64_t tlbi_aa64_range_get_base(CPUARMState *env, uint64_t value, | ||
68 | - bool two_ranges) | ||
69 | -{ | ||
70 | - /* TODO: ARMv8.7 FEAT_LPA2 */ | ||
71 | - uint64_t pageaddr; | ||
22 | - | 72 | - |
23 | -#ifdef DEBUG | 73 | - if (two_ranges) { |
24 | - #undef PRINT_DEBUG | 74 | - pageaddr = sextract64(value, 0, 37) << TARGET_PAGE_BITS; |
25 | - #define PRINT_DEBUG(fmt, args...) \ | 75 | + if (regime_has_2_ranges(mmuidx)) { |
26 | - do { \ | 76 | + ret.base = sextract64(value, 0, 37) << TARGET_PAGE_BITS; |
27 | - fprintf(stderr, " [%s:%d] "fmt, __func__, __LINE__, ##args); \ | 77 | } else { |
28 | - } while (0) | 78 | - pageaddr = extract64(value, 0, 37) << TARGET_PAGE_BITS; |
29 | -#else | 79 | + ret.base = extract64(value, 0, 37) << TARGET_PAGE_BITS; |
30 | - #define PRINT_DEBUG(fmt, args...) do {} while (0) | 80 | } |
31 | -#endif | 81 | |
32 | - | 82 | - return pageaddr; |
33 | #define SMDK_LAN9118_BASE_ADDR 0x05000000 | 83 | + return ret; |
34 | 84 | } | |
35 | typedef enum Exynos4BoardType { | 85 | |
36 | @@ -XXX,XX +XXX,XX @@ exynos4_boards_init_common(MachineState *machine, | 86 | static void do_rvae_write(CPUARMState *env, uint64_t value, |
37 | exynos4_board_binfo.gic_cpu_if_addr = | 87 | int idxmap, bool synced) |
38 | EXYNOS4210_SMP_PRIVATE_BASE_ADDR + 0x100; | 88 | { |
39 | 89 | ARMMMUIdx one_idx = ARM_MMU_IDX_A | ctz32(idxmap); | |
40 | - PRINT_DEBUG("\n ram_size: %luMiB [0x%08lx]\n" | 90 | - bool two_ranges = regime_has_2_ranges(one_idx); |
41 | - " kernel_filename: %s\n" | 91 | - uint64_t baseaddr, length; |
42 | - " kernel_cmdline: %s\n" | 92 | + TLBIRange range; |
43 | - " initrd_filename: %s\n", | 93 | int bits; |
44 | - exynos4_board_ram_size[board_type] / 1048576, | 94 | |
45 | - exynos4_board_ram_size[board_type], | 95 | - baseaddr = tlbi_aa64_range_get_base(env, value, two_ranges); |
46 | - machine->kernel_filename, | 96 | - length = tlbi_aa64_range_get_length(env, value); |
47 | - machine->kernel_cmdline, | 97 | - bits = tlbbits_for_regime(env, one_idx, baseaddr); |
48 | - machine->initrd_filename); | 98 | + range = tlbi_aa64_get_range(env, one_idx, value); |
49 | - | 99 | + bits = tlbbits_for_regime(env, one_idx, range.base); |
50 | exynos4_boards_init_ram(s, get_system_memory(), | 100 | |
51 | exynos4_board_ram_size[board_type]); | 101 | if (synced) { |
102 | tlb_flush_range_by_mmuidx_all_cpus_synced(env_cpu(env), | ||
103 | - baseaddr, | ||
104 | - length, | ||
105 | + range.base, | ||
106 | + range.length, | ||
107 | idxmap, | ||
108 | bits); | ||
109 | } else { | ||
110 | - tlb_flush_range_by_mmuidx(env_cpu(env), baseaddr, | ||
111 | - length, idxmap, bits); | ||
112 | + tlb_flush_range_by_mmuidx(env_cpu(env), range.base, | ||
113 | + range.length, idxmap, bits); | ||
114 | } | ||
115 | } | ||
52 | 116 | ||
53 | -- | 117 | -- |
54 | 2.20.1 | 118 | 2.25.1 |
55 | |||
56 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
1 | 2 | ||
3 | The shift of the BaseADDR field depends on the translation | ||
4 | granule in use. | ||
5 | |||
6 | Fixes: 84940ed8255 ("target/arm: Add support for FEAT_TLBIRANGE") | ||
7 | Reported-by: Peter Maydell <peter.maydell@linaro.org> | ||
8 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
9 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
10 | Message-id: 20220301215958.157011-14-richard.henderson@linaro.org | ||
11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
12 | --- | ||
13 | target/arm/helper.c | 5 +++-- | ||
14 | 1 file changed, 3 insertions(+), 2 deletions(-) | ||
15 | |||
16 | diff --git a/target/arm/helper.c b/target/arm/helper.c | ||
17 | index XXXXXXX..XXXXXXX 100644 | ||
18 | --- a/target/arm/helper.c | ||
19 | +++ b/target/arm/helper.c | ||
20 | @@ -XXX,XX +XXX,XX @@ static TLBIRange tlbi_aa64_get_range(CPUARMState *env, ARMMMUIdx mmuidx, | ||
21 | ret.length = (num + 1) << (exponent + page_shift); | ||
22 | |||
23 | if (regime_has_2_ranges(mmuidx)) { | ||
24 | - ret.base = sextract64(value, 0, 37) << TARGET_PAGE_BITS; | ||
25 | + ret.base = sextract64(value, 0, 37); | ||
26 | } else { | ||
27 | - ret.base = extract64(value, 0, 37) << TARGET_PAGE_BITS; | ||
28 | + ret.base = extract64(value, 0, 37); | ||
29 | } | ||
30 | + ret.base <<= page_shift; | ||
31 | |||
32 | return ret; | ||
33 | } | ||
34 | -- | ||
35 | 2.25.1 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
1 | 2 | ||
3 | For FEAT_LPA2, we will need other ARMVAParameters, which themselves | ||
4 | depend on the translation granule in use. We might as well validate | ||
5 | that the given TG matches; the architecture "does not require that | ||
6 | the instruction invalidates any entries" if this is not true. | ||
7 | |||
8 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
9 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
10 | Message-id: 20220301215958.157011-15-richard.henderson@linaro.org | ||
11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
12 | --- | ||
13 | target/arm/helper.c | 10 +++++++--- | ||
14 | 1 file changed, 7 insertions(+), 3 deletions(-) | ||
15 | |||
16 | diff --git a/target/arm/helper.c b/target/arm/helper.c | ||
17 | index XXXXXXX..XXXXXXX 100644 | ||
18 | --- a/target/arm/helper.c | ||
19 | +++ b/target/arm/helper.c | ||
20 | @@ -XXX,XX +XXX,XX @@ static TLBIRange tlbi_aa64_get_range(CPUARMState *env, ARMMMUIdx mmuidx, | ||
21 | uint64_t value) | ||
22 | { | ||
23 | unsigned int page_size_granule, page_shift, num, scale, exponent; | ||
24 | + /* Extract one bit to represent the va selector in use. */ | ||
25 | + uint64_t select = sextract64(value, 36, 1); | ||
26 | + ARMVAParameters param = aa64_va_parameters(env, select, mmuidx, true); | ||
27 | TLBIRange ret = { }; | ||
28 | |||
29 | page_size_granule = extract64(value, 46, 2); | ||
30 | |||
31 | - if (page_size_granule == 0) { | ||
32 | - qemu_log_mask(LOG_GUEST_ERROR, "Invalid page size granule %d\n", | ||
33 | + /* The granule encoded in value must match the granule in use. */ | ||
34 | + if (page_size_granule != (param.using64k ? 3 : param.using16k ? 2 : 1)) { | ||
35 | + qemu_log_mask(LOG_GUEST_ERROR, "Invalid tlbi page size granule %d\n", | ||
36 | page_size_granule); | ||
37 | return ret; | ||
38 | } | ||
39 | @@ -XXX,XX +XXX,XX @@ static TLBIRange tlbi_aa64_get_range(CPUARMState *env, ARMMMUIdx mmuidx, | ||
40 | |||
41 | ret.length = (num + 1) << (exponent + page_shift); | ||
42 | |||
43 | - if (regime_has_2_ranges(mmuidx)) { | ||
44 | + if (param.select) { | ||
45 | ret.base = sextract64(value, 0, 37); | ||
46 | } else { | ||
47 | ret.base = extract64(value, 0, 37); | ||
48 | -- | ||
49 | 2.25.1 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
1 | 2 | ||
3 | We support 16k pages, but do not advertize that in ID_AA64MMFR0. | ||
4 | |||
5 | The value 0 in the TGRAN*_2 fields indicates that stage2 lookups defer | ||
6 | to the same support as stage1 lookups. This setting is deprecated, so | ||
7 | indicate support for all stage2 page sizes directly. | ||
8 | |||
9 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
10 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
11 | Message-id: 20220301215958.157011-16-richard.henderson@linaro.org | ||
12 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
13 | --- | ||
14 | target/arm/cpu64.c | 4 ++++ | ||
15 | 1 file changed, 4 insertions(+) | ||
16 | |||
17 | diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c | ||
18 | index XXXXXXX..XXXXXXX 100644 | ||
19 | --- a/target/arm/cpu64.c | ||
20 | +++ b/target/arm/cpu64.c | ||
21 | @@ -XXX,XX +XXX,XX @@ static void aarch64_max_initfn(Object *obj) | ||
22 | |||
23 | t = cpu->isar.id_aa64mmfr0; | ||
24 | t = FIELD_DP64(t, ID_AA64MMFR0, PARANGE, 6); /* FEAT_LPA: 52 bits */ | ||
25 | + t = FIELD_DP64(t, ID_AA64MMFR0, TGRAN16, 1); /* 16k pages supported */ | ||
26 | + t = FIELD_DP64(t, ID_AA64MMFR0, TGRAN16_2, 2); /* 16k stage2 supported */ | ||
27 | + t = FIELD_DP64(t, ID_AA64MMFR0, TGRAN64_2, 2); /* 64k stage2 supported */ | ||
28 | + t = FIELD_DP64(t, ID_AA64MMFR0, TGRAN4_2, 2); /* 4k stage2 supported */ | ||
29 | cpu->isar.id_aa64mmfr0 = t; | ||
30 | |||
31 | t = cpu->isar.id_aa64mmfr1; | ||
32 | -- | ||
33 | 2.25.1 | diff view generated by jsdifflib |
1 | From: Richard Henderson <richard.henderson@linaro.org> | 1 | From: Richard Henderson <richard.henderson@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | This is, after all, how we implement extract2 in tcg/aarch64. | 3 | This feature widens physical addresses (and intermediate physical |
4 | addresses for 2-stage translation) from 48 to 52 bits, when using | ||
5 | 4k or 16k pages. | ||
6 | |||
7 | This introduces the DS bit to TCR_ELx, which is RES0 unless the | ||
8 | page size is enabled and supports LPA2, resulting in the effective | ||
9 | value of DS for a given table walk. The DS bit changes the format | ||
10 | of the page table descriptor slightly, moving the PS field out to | ||
11 | TCR so that all pages have the same sharability and repurposing | ||
12 | those bits of the page table descriptor for the highest bits of | ||
13 | the output address. | ||
14 | |||
15 | Do not yet enable FEAT_LPA2; we need extra plumbing to avoid | ||
16 | tickling an old kernel bug. | ||
4 | 17 | ||
5 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 18 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
6 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | 19 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> |
7 | Message-id: 20190514011129.11330-2-richard.henderson@linaro.org | 20 | Message-id: 20220301215958.157011-17-richard.henderson@linaro.org |
8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 21 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
9 | --- | 22 | --- |
10 | target/arm/translate-a64.c | 38 ++++++++++++++++++++------------------ | 23 | docs/system/arm/emulation.rst | 1 + |
11 | 1 file changed, 20 insertions(+), 18 deletions(-) | 24 | target/arm/cpu.h | 22 ++++++++ |
12 | 25 | target/arm/internals.h | 2 + | |
13 | diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c | 26 | target/arm/helper.c | 102 +++++++++++++++++++++++++++++----- |
27 | 4 files changed, 112 insertions(+), 15 deletions(-) | ||
28 | |||
29 | diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst | ||
14 | index XXXXXXX..XXXXXXX 100644 | 30 | index XXXXXXX..XXXXXXX 100644 |
15 | --- a/target/arm/translate-a64.c | 31 | --- a/docs/system/arm/emulation.rst |
16 | +++ b/target/arm/translate-a64.c | 32 | +++ b/docs/system/arm/emulation.rst |
17 | @@ -XXX,XX +XXX,XX @@ static void disas_extract(DisasContext *s, uint32_t insn) | 33 | @@ -XXX,XX +XXX,XX @@ the following architecture extensions: |
18 | } else { | 34 | - FEAT_JSCVT (JavaScript conversion instructions) |
19 | tcg_gen_ext32u_i64(tcg_rd, cpu_reg(s, rm)); | 35 | - FEAT_LOR (Limited ordering regions) |
20 | } | 36 | - FEAT_LPA (Large Physical Address space) |
21 | - } else if (rm == rn) { /* ROR */ | 37 | +- FEAT_LPA2 (Large Physical and virtual Address space v2) |
22 | - tcg_rm = cpu_reg(s, rm); | 38 | - FEAT_LRCPC (Load-acquire RCpc instructions) |
23 | - if (sf) { | 39 | - FEAT_LRCPC2 (Load-acquire RCpc instructions v2) |
24 | - tcg_gen_rotri_i64(tcg_rd, tcg_rm, imm); | 40 | - FEAT_LSE (Large System Extensions) |
25 | - } else { | 41 | diff --git a/target/arm/cpu.h b/target/arm/cpu.h |
26 | - TCGv_i32 tmp = tcg_temp_new_i32(); | 42 | index XXXXXXX..XXXXXXX 100644 |
27 | - tcg_gen_extrl_i64_i32(tmp, tcg_rm); | 43 | --- a/target/arm/cpu.h |
28 | - tcg_gen_rotri_i32(tmp, tmp, imm); | 44 | +++ b/target/arm/cpu.h |
29 | - tcg_gen_extu_i32_i64(tcg_rd, tmp); | 45 | @@ -XXX,XX +XXX,XX @@ static inline bool isar_feature_aa64_i8mm(const ARMISARegisters *id) |
30 | - tcg_temp_free_i32(tmp); | 46 | return FIELD_EX64(id->id_aa64isar1, ID_AA64ISAR1, I8MM) != 0; |
31 | - } | 47 | } |
32 | } else { | 48 | |
33 | - tcg_rm = read_cpu_reg(s, rm, sf); | 49 | +static inline bool isar_feature_aa64_tgran4_lpa2(const ARMISARegisters *id) |
34 | - tcg_rn = read_cpu_reg(s, rn, sf); | 50 | +{ |
35 | - tcg_gen_shri_i64(tcg_rm, tcg_rm, imm); | 51 | + return FIELD_SEX64(id->id_aa64mmfr0, ID_AA64MMFR0, TGRAN4) >= 1; |
36 | - tcg_gen_shli_i64(tcg_rn, tcg_rn, bitsize - imm); | 52 | +} |
37 | - tcg_gen_or_i64(tcg_rd, tcg_rm, tcg_rn); | 53 | + |
38 | - if (!sf) { | 54 | +static inline bool isar_feature_aa64_tgran4_2_lpa2(const ARMISARegisters *id) |
39 | - tcg_gen_ext32u_i64(tcg_rd, tcg_rd); | 55 | +{ |
40 | + tcg_rm = cpu_reg(s, rm); | 56 | + unsigned t = FIELD_EX64(id->id_aa64mmfr0, ID_AA64MMFR0, TGRAN4_2); |
41 | + tcg_rn = cpu_reg(s, rn); | 57 | + return t >= 3 || (t == 0 && isar_feature_aa64_tgran4_lpa2(id)); |
42 | + | 58 | +} |
43 | + if (sf) { | 59 | + |
44 | + /* Specialization to ROR happens in EXTRACT2. */ | 60 | +static inline bool isar_feature_aa64_tgran16_lpa2(const ARMISARegisters *id) |
45 | + tcg_gen_extract2_i64(tcg_rd, tcg_rm, tcg_rn, imm); | 61 | +{ |
62 | + return FIELD_EX64(id->id_aa64mmfr0, ID_AA64MMFR0, TGRAN16) >= 2; | ||
63 | +} | ||
64 | + | ||
65 | +static inline bool isar_feature_aa64_tgran16_2_lpa2(const ARMISARegisters *id) | ||
66 | +{ | ||
67 | + unsigned t = FIELD_EX64(id->id_aa64mmfr0, ID_AA64MMFR0, TGRAN16_2); | ||
68 | + return t >= 3 || (t == 0 && isar_feature_aa64_tgran16_lpa2(id)); | ||
69 | +} | ||
70 | + | ||
71 | static inline bool isar_feature_aa64_ccidx(const ARMISARegisters *id) | ||
72 | { | ||
73 | return FIELD_EX64(id->id_aa64mmfr2, ID_AA64MMFR2, CCIDX) != 0; | ||
74 | diff --git a/target/arm/internals.h b/target/arm/internals.h | ||
75 | index XXXXXXX..XXXXXXX 100644 | ||
76 | --- a/target/arm/internals.h | ||
77 | +++ b/target/arm/internals.h | ||
78 | @@ -XXX,XX +XXX,XX @@ static inline uint32_t aarch64_pstate_valid_mask(const ARMISARegisters *id) | ||
79 | typedef struct ARMVAParameters { | ||
80 | unsigned tsz : 8; | ||
81 | unsigned ps : 3; | ||
82 | + unsigned sh : 2; | ||
83 | unsigned select : 1; | ||
84 | bool tbi : 1; | ||
85 | bool epd : 1; | ||
86 | @@ -XXX,XX +XXX,XX @@ typedef struct ARMVAParameters { | ||
87 | bool using16k : 1; | ||
88 | bool using64k : 1; | ||
89 | bool tsz_oob : 1; /* tsz has been clamped to legal range */ | ||
90 | + bool ds : 1; | ||
91 | } ARMVAParameters; | ||
92 | |||
93 | ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
94 | diff --git a/target/arm/helper.c b/target/arm/helper.c | ||
95 | index XXXXXXX..XXXXXXX 100644 | ||
96 | --- a/target/arm/helper.c | ||
97 | +++ b/target/arm/helper.c | ||
98 | @@ -XXX,XX +XXX,XX @@ static TLBIRange tlbi_aa64_get_range(CPUARMState *env, ARMMMUIdx mmuidx, | ||
99 | } else { | ||
100 | ret.base = extract64(value, 0, 37); | ||
101 | } | ||
102 | + if (param.ds) { | ||
103 | + /* | ||
104 | + * With DS=1, BaseADDR is always shifted 16 so that it is able | ||
105 | + * to address all 52 va bits. The input address is perforce | ||
106 | + * aligned on a 64k boundary regardless of translation granule. | ||
107 | + */ | ||
108 | + page_shift = 16; | ||
109 | + } | ||
110 | ret.base <<= page_shift; | ||
111 | |||
112 | return ret; | ||
113 | @@ -XXX,XX +XXX,XX @@ static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, int level, | ||
114 | const int grainsize = stride + 3; | ||
115 | int startsizecheck; | ||
116 | |||
117 | - /* Negative levels are never allowed. */ | ||
118 | - if (level < 0) { | ||
119 | + /* | ||
120 | + * Negative levels are usually not allowed... | ||
121 | + * Except for FEAT_LPA2, 4k page table, 52-bit address space, which | ||
122 | + * begins with level -1. Note that previous feature tests will have | ||
123 | + * eliminated this combination if it is not enabled. | ||
124 | + */ | ||
125 | + if (level < (inputsize == 52 && stride == 9 ? -1 : 0)) { | ||
126 | return false; | ||
127 | } | ||
128 | |||
129 | @@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
130 | ARMMMUIdx mmu_idx, bool data) | ||
131 | { | ||
132 | uint64_t tcr = regime_tcr(env, mmu_idx)->raw_tcr; | ||
133 | - bool epd, hpd, using16k, using64k, tsz_oob; | ||
134 | - int select, tsz, tbi, max_tsz, min_tsz, ps; | ||
135 | + bool epd, hpd, using16k, using64k, tsz_oob, ds; | ||
136 | + int select, tsz, tbi, max_tsz, min_tsz, ps, sh; | ||
137 | + ARMCPU *cpu = env_archcpu(env); | ||
138 | |||
139 | if (!regime_has_2_ranges(mmu_idx)) { | ||
140 | select = 0; | ||
141 | @@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
142 | hpd = extract32(tcr, 24, 1); | ||
143 | } | ||
144 | epd = false; | ||
145 | + sh = extract32(tcr, 12, 2); | ||
146 | ps = extract32(tcr, 16, 3); | ||
147 | + ds = extract64(tcr, 32, 1); | ||
148 | } else { | ||
149 | /* | ||
150 | * Bit 55 is always between the two regions, and is canonical for | ||
151 | @@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
152 | if (!select) { | ||
153 | tsz = extract32(tcr, 0, 6); | ||
154 | epd = extract32(tcr, 7, 1); | ||
155 | + sh = extract32(tcr, 12, 2); | ||
156 | using64k = extract32(tcr, 14, 1); | ||
157 | using16k = extract32(tcr, 15, 1); | ||
158 | hpd = extract64(tcr, 41, 1); | ||
159 | @@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
160 | using64k = tg == 3; | ||
161 | tsz = extract32(tcr, 16, 6); | ||
162 | epd = extract32(tcr, 23, 1); | ||
163 | + sh = extract32(tcr, 28, 2); | ||
164 | hpd = extract64(tcr, 42, 1); | ||
165 | } | ||
166 | ps = extract64(tcr, 32, 3); | ||
167 | + ds = extract64(tcr, 59, 1); | ||
168 | } | ||
169 | |||
170 | - if (cpu_isar_feature(aa64_st, env_archcpu(env))) { | ||
171 | + if (cpu_isar_feature(aa64_st, cpu)) { | ||
172 | max_tsz = 48 - using64k; | ||
173 | } else { | ||
174 | max_tsz = 39; | ||
175 | } | ||
176 | |||
177 | + /* | ||
178 | + * DS is RES0 unless FEAT_LPA2 is supported for the given page size; | ||
179 | + * adjust the effective value of DS, as documented. | ||
180 | + */ | ||
181 | min_tsz = 16; | ||
182 | if (using64k) { | ||
183 | - if (cpu_isar_feature(aa64_lva, env_archcpu(env))) { | ||
184 | + if (cpu_isar_feature(aa64_lva, cpu)) { | ||
185 | + min_tsz = 12; | ||
186 | + } | ||
187 | + ds = false; | ||
188 | + } else if (ds) { | ||
189 | + switch (mmu_idx) { | ||
190 | + case ARMMMUIdx_Stage2: | ||
191 | + case ARMMMUIdx_Stage2_S: | ||
192 | + if (using16k) { | ||
193 | + ds = cpu_isar_feature(aa64_tgran16_2_lpa2, cpu); | ||
46 | + } else { | 194 | + } else { |
47 | + TCGv_i32 t0 = tcg_temp_new_i32(); | 195 | + ds = cpu_isar_feature(aa64_tgran4_2_lpa2, cpu); |
48 | + | 196 | + } |
49 | + tcg_gen_extrl_i64_i32(t0, tcg_rm); | 197 | + break; |
50 | + if (rm == rn) { | 198 | + default: |
51 | + tcg_gen_rotri_i32(t0, t0, imm); | 199 | + if (using16k) { |
52 | + } else { | 200 | + ds = cpu_isar_feature(aa64_tgran16_lpa2, cpu); |
53 | + TCGv_i32 t1 = tcg_temp_new_i32(); | 201 | + } else { |
54 | + tcg_gen_extrl_i64_i32(t1, tcg_rn); | 202 | + ds = cpu_isar_feature(aa64_tgran4_lpa2, cpu); |
55 | + tcg_gen_extract2_i32(t0, t0, t1, imm); | 203 | + } |
56 | + tcg_temp_free_i32(t1); | 204 | + break; |
57 | + } | 205 | + } |
58 | + tcg_gen_extu_i32_i64(tcg_rd, t0); | 206 | + if (ds) { |
59 | + tcg_temp_free_i32(t0); | 207 | min_tsz = 12; |
60 | } | ||
61 | } | 208 | } |
62 | } | 209 | } |
210 | - /* TODO: FEAT_LPA2 */ | ||
211 | |||
212 | if (tsz > max_tsz) { | ||
213 | tsz = max_tsz; | ||
214 | @@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
215 | return (ARMVAParameters) { | ||
216 | .tsz = tsz, | ||
217 | .ps = ps, | ||
218 | + .sh = sh, | ||
219 | .select = select, | ||
220 | .tbi = tbi, | ||
221 | .epd = epd, | ||
222 | @@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, | ||
223 | .using16k = using16k, | ||
224 | .using64k = using64k, | ||
225 | .tsz_oob = tsz_oob, | ||
226 | + .ds = ds, | ||
227 | }; | ||
228 | } | ||
229 | |||
230 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, | ||
231 | * VTCR_EL2.SL0 field (whose interpretation depends on the page size) | ||
232 | */ | ||
233 | uint32_t sl0 = extract32(tcr->raw_tcr, 6, 2); | ||
234 | + uint32_t sl2 = extract64(tcr->raw_tcr, 33, 1); | ||
235 | uint32_t startlevel; | ||
236 | bool ok; | ||
237 | |||
238 | - if (!aarch64 || stride == 9) { | ||
239 | + /* SL2 is RES0 unless DS=1 & 4kb granule. */ | ||
240 | + if (param.ds && stride == 9 && sl2) { | ||
241 | + if (sl0 != 0) { | ||
242 | + level = 0; | ||
243 | + fault_type = ARMFault_Translation; | ||
244 | + goto do_fault; | ||
245 | + } | ||
246 | + startlevel = -1; | ||
247 | + } else if (!aarch64 || stride == 9) { | ||
248 | /* AArch32 or 4KB pages */ | ||
249 | startlevel = 2 - sl0; | ||
250 | |||
251 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, | ||
252 | * for both v7 and v8. However, for v8 the SBZ bits [47:40] must be 0 | ||
253 | * or an AddressSize fault is raised. So for v8 we extract those SBZ | ||
254 | * bits as part of the address, which will be checked via outputsize. | ||
255 | - * For AArch64, the address field always goes up to bit 47 (with extra | ||
256 | - * bits for FEAT_LPA placed elsewhere). AArch64 implies v8. | ||
257 | + * For AArch64, the address field goes up to bit 47, or 49 with FEAT_LPA2; | ||
258 | + * the highest bits of a 52-bit output are placed elsewhere. | ||
259 | */ | ||
260 | - if (arm_feature(env, ARM_FEATURE_V8)) { | ||
261 | + if (param.ds) { | ||
262 | + descaddrmask = MAKE_64BIT_MASK(0, 50); | ||
263 | + } else if (arm_feature(env, ARM_FEATURE_V8)) { | ||
264 | descaddrmask = MAKE_64BIT_MASK(0, 48); | ||
265 | } else { | ||
266 | descaddrmask = MAKE_64BIT_MASK(0, 40); | ||
267 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, | ||
268 | |||
269 | /* | ||
270 | * For FEAT_LPA and PS=6, bits [51:48] of descaddr are in [15:12] | ||
271 | - * of descriptor. Otherwise, if descaddr is out of range, raise | ||
272 | - * AddressSizeFault. | ||
273 | + * of descriptor. For FEAT_LPA2 and effective DS, bits [51:50] of | ||
274 | + * descaddr are in [9:8]. Otherwise, if descaddr is out of range, | ||
275 | + * raise AddressSizeFault. | ||
276 | */ | ||
277 | if (outputsize > 48) { | ||
278 | - descaddr |= extract64(descriptor, 12, 4) << 48; | ||
279 | + if (param.ds) { | ||
280 | + descaddr |= extract64(descriptor, 8, 2) << 50; | ||
281 | + } else { | ||
282 | + descaddr |= extract64(descriptor, 12, 4) << 48; | ||
283 | + } | ||
284 | } else if (descaddr >> outputsize) { | ||
285 | fault_type = ARMFault_AddressSize; | ||
286 | goto do_fault; | ||
287 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, | ||
288 | assert(attrindx <= 7); | ||
289 | cacheattrs->attrs = extract64(mair, attrindx * 8, 8); | ||
290 | } | ||
291 | - cacheattrs->shareability = extract32(attrs, 6, 2); | ||
292 | + | ||
293 | + /* | ||
294 | + * For FEAT_LPA2 and effective DS, the SH field in the attributes | ||
295 | + * was re-purposed for output address bits. The SH attribute in | ||
296 | + * that case comes from TCR_ELx, which we extracted earlier. | ||
297 | + */ | ||
298 | + if (param.ds) { | ||
299 | + cacheattrs->shareability = param.sh; | ||
300 | + } else { | ||
301 | + cacheattrs->shareability = extract32(attrs, 6, 2); | ||
302 | + } | ||
303 | |||
304 | *phys_ptr = descaddr; | ||
305 | *page_size_ptr = page_size; | ||
63 | -- | 306 | -- |
64 | 2.20.1 | 307 | 2.25.1 |
65 | |||
66 | diff view generated by jsdifflib |
1 | The ICC_CTLR_EL3 register includes some bits which are aliases | 1 | When we're using KVM, the PSCI implementation is provided by the |
---|---|---|---|
2 | of bits in the ICC_CTLR_EL1(S) and (NS) registers. QEMU chooses | 2 | kernel, but QEMU has to tell the guest about it via the device tree. |
3 | to keep those bits in the cs->icc_ctlr_el1[] struct fields. | 3 | Currently we look at the KVM_CAP_ARM_PSCI_0_2 capability to determine |
4 | Unfortunately a missing '~' in the code to update the bits | 4 | if the kernel is providing at least PSCI 0.2, but if the kernel |
5 | in those fields meant that writing to ICC_CTLR_EL3 would corrupt | 5 | provides a newer version than that we will still only tell the guest |
6 | the ICC_CLTR_EL1 register values. | 6 | it has PSCI 0.2. (This is fairly harmless; it just means the guest |
7 | won't use newer parts of the PSCI API.) | ||
8 | |||
9 | The kernel exposes the specific PSCI version it is implementing via | ||
10 | the ONE_REG API; use this to report in the dtb that the PSCI | ||
11 | implementation is 1.0-compatible if appropriate. (The device tree | ||
12 | binding currently only distinguishes "pre-0.2", "0.2-compatible" and | ||
13 | "1.0-compatible".) | ||
7 | 14 | ||
8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 15 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
9 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | 16 | Reviewed-by: Marc Zyngier <maz@kernel.org> |
10 | Message-id: 20190520162809.2677-5-peter.maydell@linaro.org | 17 | Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com> |
18 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | ||
19 | Reviewed-by: Andrew Jones <drjones@redhat.com> | ||
20 | Message-id: 20220224134655.1207865-1-peter.maydell@linaro.org | ||
11 | --- | 21 | --- |
12 | hw/intc/arm_gicv3_cpuif.c | 4 ++-- | 22 | target/arm/kvm-consts.h | 1 + |
13 | 1 file changed, 2 insertions(+), 2 deletions(-) | 23 | hw/arm/boot.c | 5 ++--- |
24 | target/arm/kvm64.c | 12 ++++++++++++ | ||
25 | 3 files changed, 15 insertions(+), 3 deletions(-) | ||
14 | 26 | ||
15 | diff --git a/hw/intc/arm_gicv3_cpuif.c b/hw/intc/arm_gicv3_cpuif.c | 27 | diff --git a/target/arm/kvm-consts.h b/target/arm/kvm-consts.h |
16 | index XXXXXXX..XXXXXXX 100644 | 28 | index XXXXXXX..XXXXXXX 100644 |
17 | --- a/hw/intc/arm_gicv3_cpuif.c | 29 | --- a/target/arm/kvm-consts.h |
18 | +++ b/hw/intc/arm_gicv3_cpuif.c | 30 | +++ b/target/arm/kvm-consts.h |
19 | @@ -XXX,XX +XXX,XX @@ static void icc_ctlr_el3_write(CPUARMState *env, const ARMCPRegInfo *ri, | 31 | @@ -XXX,XX +XXX,XX @@ MISMATCH_CHECK(QEMU_PSCI_1_0_FN_PSCI_FEATURES, PSCI_1_0_FN_PSCI_FEATURES); |
20 | trace_gicv3_icc_ctlr_el3_write(gicv3_redist_affid(cs), value); | 32 | |
21 | 33 | #define QEMU_PSCI_VERSION_0_1 0x00001 | |
22 | /* *_EL1NS and *_EL1S bits are aliases into the ICC_CTLR_EL1 bits. */ | 34 | #define QEMU_PSCI_VERSION_0_2 0x00002 |
23 | - cs->icc_ctlr_el1[GICV3_NS] &= (ICC_CTLR_EL1_CBPR | ICC_CTLR_EL1_EOIMODE); | 35 | +#define QEMU_PSCI_VERSION_1_0 0x10000 |
24 | + cs->icc_ctlr_el1[GICV3_NS] &= ~(ICC_CTLR_EL1_CBPR | ICC_CTLR_EL1_EOIMODE); | 36 | #define QEMU_PSCI_VERSION_1_1 0x10001 |
25 | if (value & ICC_CTLR_EL3_EOIMODE_EL1NS) { | 37 | |
26 | cs->icc_ctlr_el1[GICV3_NS] |= ICC_CTLR_EL1_EOIMODE; | 38 | MISMATCH_CHECK(QEMU_PSCI_0_2_RET_TOS_MIGRATION_NOT_REQUIRED, PSCI_0_2_TOS_MP); |
39 | diff --git a/hw/arm/boot.c b/hw/arm/boot.c | ||
40 | index XXXXXXX..XXXXXXX 100644 | ||
41 | --- a/hw/arm/boot.c | ||
42 | +++ b/hw/arm/boot.c | ||
43 | @@ -XXX,XX +XXX,XX @@ static void fdt_add_psci_node(void *fdt) | ||
27 | } | 44 | } |
28 | @@ -XXX,XX +XXX,XX @@ static void icc_ctlr_el3_write(CPUARMState *env, const ARMCPRegInfo *ri, | 45 | |
29 | cs->icc_ctlr_el1[GICV3_NS] |= ICC_CTLR_EL1_CBPR; | 46 | qemu_fdt_add_subnode(fdt, "/psci"); |
47 | - if (armcpu->psci_version == QEMU_PSCI_VERSION_0_2 || | ||
48 | - armcpu->psci_version == QEMU_PSCI_VERSION_1_1) { | ||
49 | - if (armcpu->psci_version == QEMU_PSCI_VERSION_0_2) { | ||
50 | + if (armcpu->psci_version >= QEMU_PSCI_VERSION_0_2) { | ||
51 | + if (armcpu->psci_version < QEMU_PSCI_VERSION_1_0) { | ||
52 | const char comp[] = "arm,psci-0.2\0arm,psci"; | ||
53 | qemu_fdt_setprop(fdt, "/psci", "compatible", comp, sizeof(comp)); | ||
54 | } else { | ||
55 | diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c | ||
56 | index XXXXXXX..XXXXXXX 100644 | ||
57 | --- a/target/arm/kvm64.c | ||
58 | +++ b/target/arm/kvm64.c | ||
59 | @@ -XXX,XX +XXX,XX @@ int kvm_arch_init_vcpu(CPUState *cs) | ||
60 | uint64_t mpidr; | ||
61 | ARMCPU *cpu = ARM_CPU(cs); | ||
62 | CPUARMState *env = &cpu->env; | ||
63 | + uint64_t psciver; | ||
64 | |||
65 | if (cpu->kvm_target == QEMU_KVM_ARM_TARGET_NONE || | ||
66 | !object_dynamic_cast(OBJECT(cpu), TYPE_AARCH64_CPU)) { | ||
67 | @@ -XXX,XX +XXX,XX @@ int kvm_arch_init_vcpu(CPUState *cs) | ||
68 | } | ||
30 | } | 69 | } |
31 | 70 | ||
32 | - cs->icc_ctlr_el1[GICV3_S] &= (ICC_CTLR_EL1_CBPR | ICC_CTLR_EL1_EOIMODE); | 71 | + /* |
33 | + cs->icc_ctlr_el1[GICV3_S] &= ~(ICC_CTLR_EL1_CBPR | ICC_CTLR_EL1_EOIMODE); | 72 | + * KVM reports the exact PSCI version it is implementing via a |
34 | if (value & ICC_CTLR_EL3_EOIMODE_EL1S) { | 73 | + * special sysreg. If it is present, use its contents to determine |
35 | cs->icc_ctlr_el1[GICV3_S] |= ICC_CTLR_EL1_EOIMODE; | 74 | + * what to report to the guest in the dtb (it is the PSCI version, |
36 | } | 75 | + * in the same 15-bits major 16-bits minor format that PSCI_VERSION |
76 | + * returns). | ||
77 | + */ | ||
78 | + if (!kvm_get_one_reg(cs, KVM_REG_ARM_PSCI_VERSION, &psciver)) { | ||
79 | + cpu->psci_version = psciver; | ||
80 | + } | ||
81 | + | ||
82 | /* | ||
83 | * When KVM is in use, PSCI is emulated in-kernel and not by qemu. | ||
84 | * Currently KVM has its own idea about MPIDR assignment, so we | ||
37 | -- | 85 | -- |
38 | 2.20.1 | 86 | 2.25.1 |
39 | |||
40 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | The updateUIInfo method makes Cocoa API calls. It also calls back | ||
2 | into QEMU functions like dpy_set_ui_info(). To do this safely, we | ||
3 | need to follow two rules: | ||
4 | * Cocoa API calls are made on the Cocoa UI thread | ||
5 | * When calling back into QEMU we must hold the iothread lock | ||
1 | 6 | ||
7 | Fix the places where we got this wrong, by taking the iothread lock | ||
8 | while executing updateUIInfo, and moving the call in cocoa_switch() | ||
9 | inside the dispatch_async block. | ||
10 | |||
11 | Some of the Cocoa UI methods which call updateUIInfo are invoked as | ||
12 | part of the initial application startup, while we're still doing the | ||
13 | little cross-thread dance described in the comment just above | ||
14 | call_qemu_main(). This meant they were calling back into the QEMU UI | ||
15 | layer before we'd actually finished initializing our display and | ||
16 | registered the DisplayChangeListener, which isn't really valid. Once | ||
17 | updateUIInfo takes the iothread lock, we no longer get away with | ||
18 | this, because during this startup phase the iothread lock is held by | ||
19 | the QEMU main-loop thread which is waiting for us to finish our | ||
20 | display initialization. So we must suppress updateUIInfo until | ||
21 | applicationDidFinishLaunching allows the QEMU main-loop thread to | ||
22 | continue. | ||
23 | |||
24 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
25 | Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com> | ||
26 | Tested-by: Akihiko Odaki <akihiko.odaki@gmail.com> | ||
27 | Message-id: 20220224101330.967429-2-peter.maydell@linaro.org | ||
28 | --- | ||
29 | ui/cocoa.m | 25 ++++++++++++++++++++++--- | ||
30 | 1 file changed, 22 insertions(+), 3 deletions(-) | ||
31 | |||
32 | diff --git a/ui/cocoa.m b/ui/cocoa.m | ||
33 | index XXXXXXX..XXXXXXX 100644 | ||
34 | --- a/ui/cocoa.m | ||
35 | +++ b/ui/cocoa.m | ||
36 | @@ -XXX,XX +XXX,XX @@ QemuCocoaView *cocoaView; | ||
37 | } | ||
38 | } | ||
39 | |||
40 | -- (void) updateUIInfo | ||
41 | +- (void) updateUIInfoLocked | ||
42 | { | ||
43 | + /* Must be called with the iothread lock, i.e. via updateUIInfo */ | ||
44 | NSSize frameSize; | ||
45 | QemuUIInfo info; | ||
46 | |||
47 | @@ -XXX,XX +XXX,XX @@ QemuCocoaView *cocoaView; | ||
48 | dpy_set_ui_info(dcl.con, &info, TRUE); | ||
49 | } | ||
50 | |||
51 | +- (void) updateUIInfo | ||
52 | +{ | ||
53 | + if (!allow_events) { | ||
54 | + /* | ||
55 | + * Don't try to tell QEMU about UI information in the application | ||
56 | + * startup phase -- we haven't yet registered dcl with the QEMU UI | ||
57 | + * layer, and also trying to take the iothread lock would deadlock. | ||
58 | + * When cocoa_display_init() does register the dcl, the UI layer | ||
59 | + * will call cocoa_switch(), which will call updateUIInfo, so | ||
60 | + * we don't lose any information here. | ||
61 | + */ | ||
62 | + return; | ||
63 | + } | ||
64 | + | ||
65 | + with_iothread_lock(^{ | ||
66 | + [self updateUIInfoLocked]; | ||
67 | + }); | ||
68 | +} | ||
69 | + | ||
70 | - (void)viewDidMoveToWindow | ||
71 | { | ||
72 | [self updateUIInfo]; | ||
73 | @@ -XXX,XX +XXX,XX @@ static void cocoa_switch(DisplayChangeListener *dcl, | ||
74 | |||
75 | COCOA_DEBUG("qemu_cocoa: cocoa_switch\n"); | ||
76 | |||
77 | - [cocoaView updateUIInfo]; | ||
78 | - | ||
79 | // The DisplaySurface will be freed as soon as this callback returns. | ||
80 | // We take a reference to the underlying pixman image here so it does | ||
81 | // not disappear from under our feet; the switchSurface method will | ||
82 | @@ -XXX,XX +XXX,XX @@ static void cocoa_switch(DisplayChangeListener *dcl, | ||
83 | pixman_image_ref(image); | ||
84 | |||
85 | dispatch_async(dispatch_get_main_queue(), ^{ | ||
86 | + [cocoaView updateUIInfo]; | ||
87 | [cocoaView switchSurface:image]; | ||
88 | }); | ||
89 | [pool release]; | ||
90 | -- | ||
91 | 2.25.1 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | In commit 6e657e64cdc478 in 2013 we added some autorelease pools to | ||
2 | deal with complaints from macOS when we made calls into Cocoa from | ||
3 | threads that didn't have automatically created autorelease pools. | ||
4 | Later on, macOS got stricter about forbidding cross-thread Cocoa | ||
5 | calls, and in commit 5588840ff77800e839d8 we restructured the code to | ||
6 | avoid them. This left the autorelease pool creation in several | ||
7 | functions without any purpose; delete it. | ||
1 | 8 | ||
9 | We still need the pool in cocoa_refresh() for the clipboard related | ||
10 | code which is called directly there. | ||
11 | |||
12 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
13 | Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com> | ||
14 | Tested-by: Akihiko Odaki <akihiko.odaki@gmail.com> | ||
15 | Message-id: 20220224101330.967429-3-peter.maydell@linaro.org | ||
16 | --- | ||
17 | ui/cocoa.m | 6 ------ | ||
18 | 1 file changed, 6 deletions(-) | ||
19 | |||
20 | diff --git a/ui/cocoa.m b/ui/cocoa.m | ||
21 | index XXXXXXX..XXXXXXX 100644 | ||
22 | --- a/ui/cocoa.m | ||
23 | +++ b/ui/cocoa.m | ||
24 | @@ -XXX,XX +XXX,XX @@ int main (int argc, char **argv) { | ||
25 | static void cocoa_update(DisplayChangeListener *dcl, | ||
26 | int x, int y, int w, int h) | ||
27 | { | ||
28 | - NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init]; | ||
29 | - | ||
30 | COCOA_DEBUG("qemu_cocoa: cocoa_update\n"); | ||
31 | |||
32 | dispatch_async(dispatch_get_main_queue(), ^{ | ||
33 | @@ -XXX,XX +XXX,XX @@ static void cocoa_update(DisplayChangeListener *dcl, | ||
34 | } | ||
35 | [cocoaView setNeedsDisplayInRect:rect]; | ||
36 | }); | ||
37 | - | ||
38 | - [pool release]; | ||
39 | } | ||
40 | |||
41 | static void cocoa_switch(DisplayChangeListener *dcl, | ||
42 | DisplaySurface *surface) | ||
43 | { | ||
44 | - NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init]; | ||
45 | pixman_image_t *image = surface->image; | ||
46 | |||
47 | COCOA_DEBUG("qemu_cocoa: cocoa_switch\n"); | ||
48 | @@ -XXX,XX +XXX,XX @@ static void cocoa_switch(DisplayChangeListener *dcl, | ||
49 | [cocoaView updateUIInfo]; | ||
50 | [cocoaView switchSurface:image]; | ||
51 | }); | ||
52 | - [pool release]; | ||
53 | } | ||
54 | |||
55 | static void cocoa_refresh(DisplayChangeListener *dcl) | ||
56 | -- | ||
57 | 2.25.1 | diff view generated by jsdifflib |