[Qemu-devel] [RFC PATCH 0/9] Add support for io_uring

Aarushi Mehta posted 9 patches 4 years, 11 months ago
Test docker-clang@ubuntu passed
Test asan passed
Test checkpatch failed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190521235215.31341-1-mehta.aaru20@gmail.com
Maintainers: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Max Reitz <mreitz@redhat.com>, Eric Blake <eblake@redhat.com>
There is a newer version of this series
block/Makefile.objs     |   2 +
block/file-posix.c      |  63 ++++++-
block/io_uring.c        | 385 ++++++++++++++++++++++++++++++++++++++++
blockdev.c              |   4 +-
configure               |  27 +++
include/block/aio.h     |  16 +-
include/block/block.h   |   1 +
include/block/raw-aio.h |  15 ++
qapi/block-core.json    |   3 +-
stubs/Makefile.objs     |   1 +
stubs/io_uring.c        |  32 ++++
util/async.c            |  32 ++++
12 files changed, 573 insertions(+), 8 deletions(-)
create mode 100644 block/io_uring.c
create mode 100644 stubs/io_uring.c
[Qemu-devel] [RFC PATCH 0/9] Add support for io_uring
Posted by Aarushi Mehta 4 years, 11 months ago
This patch series adds supports for the newly developed io_uring Linux AIO interface. Testing it requires a host kernel with it and the liburing library. Use the option -drive aio=io_uring to enable it.

Aarushi Mehta (9):
  qapi/block-core: add option for io_uring
  block/block: add BDRV flag for io_uring
  include/block: declare interfaces for io_uring
  stubs: add aio interface stubs for io_uring
  util/asyn: add aio interfaces for io_uring
  block/io_uring: implements interfaces for io_uring
  blockdev: accept io_uring as option
  block/file-posix: extends to use with io_uring
  configure: permits use of io_uring with probe

 block/Makefile.objs     |   2 +
 block/file-posix.c      |  63 ++++++-
 block/io_uring.c        | 385 ++++++++++++++++++++++++++++++++++++++++
 blockdev.c              |   4 +-
 configure               |  27 +++
 include/block/aio.h     |  16 +-
 include/block/block.h   |   1 +
 include/block/raw-aio.h |  15 ++
 qapi/block-core.json    |   3 +-
 stubs/Makefile.objs     |   1 +
 stubs/io_uring.c        |  32 ++++
 util/async.c            |  32 ++++
 12 files changed, 573 insertions(+), 8 deletions(-)
 create mode 100644 block/io_uring.c
 create mode 100644 stubs/io_uring.c

--
2.17.1

Re: [Qemu-devel] [RFC PATCH 0/9] Add support for io_uring
Posted by no-reply@patchew.org 4 years, 11 months ago
Patchew URL: https://patchew.org/QEMU/20190521235215.31341-1-mehta.aaru20@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [RFC PATCH 0/9] Add support for io_uring
Message-id: 20190521235215.31341-1-mehta.aaru20@gmail.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190521235215.31341-1-mehta.aaru20@gmail.com -> patchew/20190521235215.31341-1-mehta.aaru20@gmail.com
Switched to a new branch 'test'
678f12be88 configure: permits use of io_uring with probe
e766842048 block/file-posix: extends to use with io_uring
03f080b205 blockdev: accept io_uring as option
7208a09b56 block/io_uring: implements interfaces for io_uring
8d681f052d util/asyn: add aio interfaces for io_uring
27f7b0c951 stubs: add aio interface stubs for io_uring
9c2064f2f5 include/block: declare interfaces for io_uring
54e3c5397c block/block: add BDRV flag for io_uring
25162d6c1f qapi/block-core: add option for io_uring

=== OUTPUT BEGIN ===
1/9 Checking commit 25162d6c1fc9 (qapi/block-core: add option for io_uring)
2/9 Checking commit 54e3c5397cb4 (block/block: add BDRV flag for io_uring)
3/9 Checking commit 9c2064f2f5db (include/block: declare interfaces for io_uring)
4/9 Checking commit 27f7b0c95162 (stubs: add aio interface stubs for io_uring)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

total: 0 errors, 1 warnings, 39 lines checked

Patch 4/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/9 Checking commit 8d681f052d02 (util/asyn: add aio interfaces for io_uring)
6/9 Checking commit 7208a09b5645 (block/io_uring: implements interfaces for io_uring)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

ERROR: else should follow close brace '}'
#240: FILE: block/io_uring.c:206:
+                }
+                else {

total: 1 errors, 1 warnings, 398 lines checked

Patch 6/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/9 Checking commit 03f080b2050b (blockdev: accept io_uring as option)
8/9 Checking commit e766842048eb (block/file-posix: extends to use with io_uring)
9/9 Checking commit 678f12be88a3 (configure: permits use of io_uring with probe)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190521235215.31341-1-mehta.aaru20@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [RFC PATCH 0/9] Add support for io_uring
Posted by Stefan Hajnoczi 4 years, 11 months ago
On Wed, May 22, 2019 at 05:22:06AM +0530, Aarushi Mehta wrote:
> This patch series adds supports for the newly developed io_uring Linux AIO interface. Testing it requires a host kernel with it and the liburing library. Use the option -drive aio=io_uring to enable it.
> 
> Aarushi Mehta (9):
>   qapi/block-core: add option for io_uring
>   block/block: add BDRV flag for io_uring
>   include/block: declare interfaces for io_uring
>   stubs: add aio interface stubs for io_uring
>   util/asyn: add aio interfaces for io_uring
>   block/io_uring: implements interfaces for io_uring
>   blockdev: accept io_uring as option
>   block/file-posix: extends to use with io_uring
>   configure: permits use of io_uring with probe
> 
>  block/Makefile.objs     |   2 +
>  block/file-posix.c      |  63 ++++++-
>  block/io_uring.c        | 385 ++++++++++++++++++++++++++++++++++++++++
>  blockdev.c              |   4 +-
>  configure               |  27 +++
>  include/block/aio.h     |  16 +-
>  include/block/block.h   |   1 +
>  include/block/raw-aio.h |  15 ++
>  qapi/block-core.json    |   3 +-
>  stubs/Makefile.objs     |   1 +
>  stubs/io_uring.c        |  32 ++++
>  util/async.c            |  32 ++++
>  12 files changed, 573 insertions(+), 8 deletions(-)
>  create mode 100644 block/io_uring.c
>  create mode 100644 stubs/io_uring.c

Thanks, I've posted my review feedback!  Looking forward to the next
revision.