[Qemu-devel] [RISU v2 11/11] risu_reginfo_i386: accept named feature sets for --xfeature

Jan Bobek posted 11 patches 6 years, 5 months ago
There is a newer version of this series
[Qemu-devel] [RISU v2 11/11] risu_reginfo_i386: accept named feature sets for --xfeature
Posted by Jan Bobek 6 years, 5 months ago
Have the --xfeature option accept "sse", "avx" and "avx512" in
addition to a plain numerical value, purely for users' convenience.

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Jan Bobek <jan.bobek@gmail.com>
---
 risu_reginfo_i386.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/risu_reginfo_i386.c b/risu_reginfo_i386.c
index aba5ae3..c15fe63 100644
--- a/risu_reginfo_i386.c
+++ b/risu_reginfo_i386.c
@@ -54,7 +54,16 @@ const char * const arch_extra_help
 void process_arch_opt(int opt, const char *arg)
 {
     assert(opt == FIRST_ARCH_OPT);
-    xfeatures = strtoull(arg, 0, 0);
+
+    if (!strcmp(arg, "sse")) {
+        xfeatures = XFEAT_X87 | XFEAT_SSE;
+    } else if (!strcmp(arg, "avx")) {
+        xfeatures = XFEAT_X87 | XFEAT_SSE | XFEAT_AVX;
+    } else if (!strcmp(arg, "avx512")) {
+        xfeatures = XFEAT_X87 | XFEAT_SSE | XFEAT_AVX | XFEAT_AVX512;
+    } else {
+        xfeatures = strtoull(arg, 0, 0);
+    }
 }
 
 const int reginfo_size(void)
-- 
2.20.1


Re: [Qemu-devel] [RISU v2 11/11] risu_reginfo_i386: accept named feature sets for --xfeature
Posted by Richard Henderson 6 years, 5 months ago
On 5/17/19 3:44 PM, Jan Bobek wrote:
> Have the --xfeature option accept "sse", "avx" and "avx512" in
> addition to a plain numerical value, purely for users' convenience.
> 
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Jan Bobek <jan.bobek@gmail.com>
> ---
>  risu_reginfo_i386.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~