[Qemu-devel] [PATCH v14 00/13] RX architecture support

Richard Henderson posted 13 patches 4 years, 11 months ago
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu failed
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190517045136.3509-1-richard.henderson@linaro.org
include/disas/dis-asm.h        |    5 +
include/hw/char/renesas_sci.h  |   45 +
include/hw/intc/rx_icu.h       |   56 +
include/hw/registerfields.h    |   32 +-
include/hw/rx/rx.h             |    7 +
include/hw/rx/rx62n.h          |   94 ++
include/hw/timer/renesas_cmt.h |   38 +
include/hw/timer/renesas_tmr.h |   53 +
include/qemu/bitops.h          |   38 +
include/sysemu/arch_init.h     |    1 +
target/rx/cpu.h                |  227 +++
target/rx/helper.h             |   31 +
arch_init.c                    |    2 +
hw/char/renesas_sci.c          |  340 +++++
hw/intc/rx_icu.c               |  376 +++++
hw/rx/rx-virt.c                |  105 ++
hw/rx/rx62n.c                  |  238 ++++
hw/timer/renesas_cmt.c         |  275 ++++
hw/timer/renesas_tmr.c         |  455 ++++++
target/rx/cpu.c                |  236 ++++
target/rx/disas.c              | 1480 +++++++++++++++++++
target/rx/gdbstub.c            |  112 ++
target/rx/helper.c             |  148 ++
target/rx/monitor.c            |   38 +
target/rx/op_helper.c          |  470 ++++++
target/rx/translate.c          | 2432 ++++++++++++++++++++++++++++++++
MAINTAINERS                    |   19 +
configure                      |    8 +
default-configs/rx-softmmu.mak |    3 +
hw/Kconfig                     |    1 +
hw/char/Kconfig                |    3 +
hw/char/Makefile.objs          |    1 +
hw/intc/Kconfig                |    3 +
hw/intc/Makefile.objs          |    1 +
hw/rx/Kconfig                  |   14 +
hw/rx/Makefile.objs            |    2 +
hw/timer/Kconfig               |    6 +
hw/timer/Makefile.objs         |    3 +
target/rx/Makefile.objs        |   12 +
target/rx/insns.decode         |  621 ++++++++
40 files changed, 8030 insertions(+), 1 deletion(-)
create mode 100644 include/hw/char/renesas_sci.h
create mode 100644 include/hw/intc/rx_icu.h
create mode 100644 include/hw/rx/rx.h
create mode 100644 include/hw/rx/rx62n.h
create mode 100644 include/hw/timer/renesas_cmt.h
create mode 100644 include/hw/timer/renesas_tmr.h
create mode 100644 target/rx/cpu.h
create mode 100644 target/rx/helper.h
create mode 100644 hw/char/renesas_sci.c
create mode 100644 hw/intc/rx_icu.c
create mode 100644 hw/rx/rx-virt.c
create mode 100644 hw/rx/rx62n.c
create mode 100644 hw/timer/renesas_cmt.c
create mode 100644 hw/timer/renesas_tmr.c
create mode 100644 target/rx/cpu.c
create mode 100644 target/rx/disas.c
create mode 100644 target/rx/gdbstub.c
create mode 100644 target/rx/helper.c
create mode 100644 target/rx/monitor.c
create mode 100644 target/rx/op_helper.c
create mode 100644 target/rx/translate.c
create mode 100644 default-configs/rx-softmmu.mak
create mode 100644 hw/rx/Kconfig
create mode 100644 hw/rx/Makefile.objs
create mode 100644 target/rx/Makefile.objs
create mode 100644 target/rx/insns.decode
[Qemu-devel] [PATCH v14 00/13] RX architecture support
Posted by Richard Henderson 4 years, 11 months ago
This is Sato-san's v13, plus the typos that Phil noticed therein,
plus the change to tlb_fill required by

    commit d8276573da58e8ce78dab8c46dd660efd664bcb7
    Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190510'
    Add CPUClass::tlb_fill.
    Improve tlb_vaddr_to_host for use by ARM SVE no-fault loads.


r~


Richard Henderson (1):
  target/rx: Convert to CPUClass::tlb_fill

Yoshinori Sato (12):
  target/rx: TCG translation
  target/rx: TCG helper
  target/rx: CPU definition
  target/rx: RX disassembler
  hw/intc: RX62N interrupt controller (ICUa)
  hw/timer: RX62N internal timer modules
  hw/char: RX62N serial communication interface (SCI)
  hw/rx: RX Target hardware definition
  qemu/bitops.h: Add extract8 and extract16
  hw/registerfields.h: Add 8bit and 16bit register macros
  Add rx-softmmu
  MAINTAINERS: Add RX

 include/disas/dis-asm.h        |    5 +
 include/hw/char/renesas_sci.h  |   45 +
 include/hw/intc/rx_icu.h       |   56 +
 include/hw/registerfields.h    |   32 +-
 include/hw/rx/rx.h             |    7 +
 include/hw/rx/rx62n.h          |   94 ++
 include/hw/timer/renesas_cmt.h |   38 +
 include/hw/timer/renesas_tmr.h |   53 +
 include/qemu/bitops.h          |   38 +
 include/sysemu/arch_init.h     |    1 +
 target/rx/cpu.h                |  227 +++
 target/rx/helper.h             |   31 +
 arch_init.c                    |    2 +
 hw/char/renesas_sci.c          |  340 +++++
 hw/intc/rx_icu.c               |  376 +++++
 hw/rx/rx-virt.c                |  105 ++
 hw/rx/rx62n.c                  |  238 ++++
 hw/timer/renesas_cmt.c         |  275 ++++
 hw/timer/renesas_tmr.c         |  455 ++++++
 target/rx/cpu.c                |  236 ++++
 target/rx/disas.c              | 1480 +++++++++++++++++++
 target/rx/gdbstub.c            |  112 ++
 target/rx/helper.c             |  148 ++
 target/rx/monitor.c            |   38 +
 target/rx/op_helper.c          |  470 ++++++
 target/rx/translate.c          | 2432 ++++++++++++++++++++++++++++++++
 MAINTAINERS                    |   19 +
 configure                      |    8 +
 default-configs/rx-softmmu.mak |    3 +
 hw/Kconfig                     |    1 +
 hw/char/Kconfig                |    3 +
 hw/char/Makefile.objs          |    1 +
 hw/intc/Kconfig                |    3 +
 hw/intc/Makefile.objs          |    1 +
 hw/rx/Kconfig                  |   14 +
 hw/rx/Makefile.objs            |    2 +
 hw/timer/Kconfig               |    6 +
 hw/timer/Makefile.objs         |    3 +
 target/rx/Makefile.objs        |   12 +
 target/rx/insns.decode         |  621 ++++++++
 40 files changed, 8030 insertions(+), 1 deletion(-)
 create mode 100644 include/hw/char/renesas_sci.h
 create mode 100644 include/hw/intc/rx_icu.h
 create mode 100644 include/hw/rx/rx.h
 create mode 100644 include/hw/rx/rx62n.h
 create mode 100644 include/hw/timer/renesas_cmt.h
 create mode 100644 include/hw/timer/renesas_tmr.h
 create mode 100644 target/rx/cpu.h
 create mode 100644 target/rx/helper.h
 create mode 100644 hw/char/renesas_sci.c
 create mode 100644 hw/intc/rx_icu.c
 create mode 100644 hw/rx/rx-virt.c
 create mode 100644 hw/rx/rx62n.c
 create mode 100644 hw/timer/renesas_cmt.c
 create mode 100644 hw/timer/renesas_tmr.c
 create mode 100644 target/rx/cpu.c
 create mode 100644 target/rx/disas.c
 create mode 100644 target/rx/gdbstub.c
 create mode 100644 target/rx/helper.c
 create mode 100644 target/rx/monitor.c
 create mode 100644 target/rx/op_helper.c
 create mode 100644 target/rx/translate.c
 create mode 100644 default-configs/rx-softmmu.mak
 create mode 100644 hw/rx/Kconfig
 create mode 100644 hw/rx/Makefile.objs
 create mode 100644 target/rx/Makefile.objs
 create mode 100644 target/rx/insns.decode

-- 
2.17.1


Re: [Qemu-devel] [PATCH v14 00/13] RX architecture support
Posted by Philippe Mathieu-Daudé 4 years, 11 months ago
On 5/17/19 6:51 AM, Richard Henderson wrote:
> This is Sato-san's v13, plus the typos that Phil noticed therein,
> plus the change to tlb_fill required by
> 
>     commit d8276573da58e8ce78dab8c46dd660efd664bcb7
>     Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190510'
>     Add CPUClass::tlb_fill.
>     Improve tlb_vaddr_to_host for use by ARM SVE no-fault loads.
> 
> 
> r~
> 
> 
> Richard Henderson (1):
>   target/rx: Convert to CPUClass::tlb_fill
> 
> Yoshinori Sato (12):
>   target/rx: TCG translation
>   target/rx: TCG helper
>   target/rx: CPU definition
>   target/rx: RX disassembler
>   hw/intc: RX62N interrupt controller (ICUa)
>   hw/timer: RX62N internal timer modules
>   hw/char: RX62N serial communication interface (SCI)
>   hw/rx: RX Target hardware definition
>   qemu/bitops.h: Add extract8 and extract16
>   hw/registerfields.h: Add 8bit and 16bit register macros
>   Add rx-softmmu
>   MAINTAINERS: Add RX

Series:
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

But please reorder patches before sending the pull request, see:
https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg03671.html

- patch 9 first "Add extract8 and extract16"
- patch 10 then "Add 8bit and 16bit register macros"
- then other patches 1-8, 11-13

This will help if we unlikely have to bisect ;)

Regards,

Phil.

Re: [Qemu-devel] [PATCH v14 00/13] RX architecture support
Posted by Richard Henderson 4 years, 11 months ago
On 5/17/19 1:00 AM, Philippe Mathieu-Daudé wrote:
>>   qemu/bitops.h: Add extract8 and extract16
>>   hw/registerfields.h: Add 8bit and 16bit register macros
>>   Add rx-softmmu
>>   MAINTAINERS: Add RX
> 
> Series:
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks, missed this because patchwork doesn't remember cover letters.

> But please reorder patches before sending the pull request, see:
> https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg03671.html
> 
> - patch 9 first "Add extract8 and extract16"
> - patch 10 then "Add 8bit and 16bit register macros"
> - then other patches 1-8, 11-13

I have reordered extract and register macros properly.

> This will help if we unlikely have to bisect ;)

Bisection is preserved because the rx port is enabled by
patch 12, "Add rx-softmmu".  Eariler than that, the rx
port simply is not built.


r~