[Qemu-devel] [PATCH v12 00/12] Add RX archtecture support

Yoshinori Sato posted 12 patches 10 weeks ago
Test asan passed
Test docker-clang@ubuntu failed
Test checkpatch failed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190514061458.125225-1-ysato@users.sourceforge.jp
Maintainers: Alistair Francis <alistair@alistair23.me>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
configure                      |    8 +
default-configs/rx-softmmu.mak |    3 +
include/disas/dis-asm.h        |    5 +
include/hw/char/renesas_sci.h  |   45 +
include/hw/intc/rx_icu.h       |   57 +
include/hw/registerfields.h    |   32 +-
include/hw/rx/rx.h             |    7 +
include/hw/rx/rx62n.h          |   94 ++
include/hw/timer/renesas_cmt.h |   38 +
include/hw/timer/renesas_tmr.h |   50 +
include/qemu/bitops.h          |   38 +
include/sysemu/arch_init.h     |    1 +
target/rx/cpu.h                |  227 ++++
target/rx/helper.h             |   31 +
arch_init.c                    |    2 +
hw/char/renesas_sci.c          |  340 ++++++
hw/intc/rx_icu.c               |  376 +++++++
hw/rx/rx-virt.c                |  105 ++
hw/rx/rx62n.c                  |  238 ++++
hw/timer/renesas_cmt.c         |  275 +++++
hw/timer/renesas_tmr.c         |  455 ++++++++
target/rx/cpu.c                |  222 ++++
target/rx/disas.c              | 1480 ++++++++++++++++++++++++
target/rx/gdbstub.c            |  112 ++
target/rx/helper.c             |  148 +++
target/rx/monitor.c            |   38 +
target/rx/op_helper.c          |  481 ++++++++
target/rx/translate.c          | 2432 ++++++++++++++++++++++++++++++++++++++++
MAINTAINERS                    |   19 +
hw/Kconfig                     |    1 +
hw/char/Kconfig                |    3 +
hw/char/Makefile.objs          |    1 +
hw/intc/Kconfig                |    3 +
hw/intc/Makefile.objs          |    1 +
hw/rx/Kconfig                  |   14 +
hw/rx/Makefile.objs            |    2 +
hw/timer/Kconfig               |    6 +
hw/timer/Makefile.objs         |    3 +
target/rx/Makefile.objs        |   12 +
target/rx/insns.decode         |  621 ++++++++++
40 files changed, 8025 insertions(+), 1 deletion(-)
create mode 100644 default-configs/rx-softmmu.mak
create mode 100644 include/hw/char/renesas_sci.h
create mode 100644 include/hw/intc/rx_icu.h
create mode 100644 include/hw/rx/rx.h
create mode 100644 include/hw/rx/rx62n.h
create mode 100644 include/hw/timer/renesas_cmt.h
create mode 100644 include/hw/timer/renesas_tmr.h
create mode 100644 target/rx/cpu.h
create mode 100644 target/rx/helper.h
create mode 100644 hw/char/renesas_sci.c
create mode 100644 hw/intc/rx_icu.c
create mode 100644 hw/rx/rx-virt.c
create mode 100644 hw/rx/rx62n.c
create mode 100644 hw/timer/renesas_cmt.c
create mode 100644 hw/timer/renesas_tmr.c
create mode 100644 target/rx/cpu.c
create mode 100644 target/rx/disas.c
create mode 100644 target/rx/gdbstub.c
create mode 100644 target/rx/helper.c
create mode 100644 target/rx/monitor.c
create mode 100644 target/rx/op_helper.c
create mode 100644 target/rx/translate.c
create mode 100644 hw/rx/Kconfig
create mode 100644 hw/rx/Makefile.objs
create mode 100644 target/rx/Makefile.objs
create mode 100644 target/rx/insns.decode

[Qemu-devel] [PATCH v12 00/12] Add RX archtecture support

Posted by Yoshinori Sato 10 weeks ago
Hello.
This patch series is added Renesas RX target emulation.

I fixed the ROM address because v11 was incorrect.

My git repository is bellow.
git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20190514

Testing binaries bellow.
u-boot
Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz

starting
$ gzip -d u-boot.bin.gz
$ qemu-system-rx -bios u-boot.bin

linux and pico-root (only sash)
Download - https://osdn.net/users/ysato/pf/qemu/dl/zImage (kernel)
           https://osdn.net/users/ysato/pf/qemu/dl/rx-qemu.dtb (DeviceTree)

starting
$ qemu-system-rx -kernel zImage -dtb rx-qemu.dtb -append "earlycon"

Changes for v11.
- Fix ROM address.

Yoshinori Sato (12):
  target/rx: TCG translation
  target/rx: TCG helper
  target/rx: CPU definition
  target/rx: RX disassembler
  hw/intc: RX62N interrupt controller (ICUa)
  hw/timer: RX62N internal timer modules
  hw/char: RX62N serial communication interface (SCI)
  hw/rx: RX Target hardware definition
  Add rx-softmmu
  hw/registerfields.h: Add 8bit and 16bit register macros.
  qemu/bitops.h: Add extract8 and extract16
  MAINTAINERS: Add RX

 configure                      |    8 +
 default-configs/rx-softmmu.mak |    3 +
 include/disas/dis-asm.h        |    5 +
 include/hw/char/renesas_sci.h  |   45 +
 include/hw/intc/rx_icu.h       |   57 +
 include/hw/registerfields.h    |   32 +-
 include/hw/rx/rx.h             |    7 +
 include/hw/rx/rx62n.h          |   94 ++
 include/hw/timer/renesas_cmt.h |   38 +
 include/hw/timer/renesas_tmr.h |   50 +
 include/qemu/bitops.h          |   38 +
 include/sysemu/arch_init.h     |    1 +
 target/rx/cpu.h                |  227 ++++
 target/rx/helper.h             |   31 +
 arch_init.c                    |    2 +
 hw/char/renesas_sci.c          |  340 ++++++
 hw/intc/rx_icu.c               |  376 +++++++
 hw/rx/rx-virt.c                |  105 ++
 hw/rx/rx62n.c                  |  238 ++++
 hw/timer/renesas_cmt.c         |  275 +++++
 hw/timer/renesas_tmr.c         |  455 ++++++++
 target/rx/cpu.c                |  222 ++++
 target/rx/disas.c              | 1480 ++++++++++++++++++++++++
 target/rx/gdbstub.c            |  112 ++
 target/rx/helper.c             |  148 +++
 target/rx/monitor.c            |   38 +
 target/rx/op_helper.c          |  481 ++++++++
 target/rx/translate.c          | 2432 ++++++++++++++++++++++++++++++++++++++++
 MAINTAINERS                    |   19 +
 hw/Kconfig                     |    1 +
 hw/char/Kconfig                |    3 +
 hw/char/Makefile.objs          |    1 +
 hw/intc/Kconfig                |    3 +
 hw/intc/Makefile.objs          |    1 +
 hw/rx/Kconfig                  |   14 +
 hw/rx/Makefile.objs            |    2 +
 hw/timer/Kconfig               |    6 +
 hw/timer/Makefile.objs         |    3 +
 target/rx/Makefile.objs        |   12 +
 target/rx/insns.decode         |  621 ++++++++++
 40 files changed, 8025 insertions(+), 1 deletion(-)
 create mode 100644 default-configs/rx-softmmu.mak
 create mode 100644 include/hw/char/renesas_sci.h
 create mode 100644 include/hw/intc/rx_icu.h
 create mode 100644 include/hw/rx/rx.h
 create mode 100644 include/hw/rx/rx62n.h
 create mode 100644 include/hw/timer/renesas_cmt.h
 create mode 100644 include/hw/timer/renesas_tmr.h
 create mode 100644 target/rx/cpu.h
 create mode 100644 target/rx/helper.h
 create mode 100644 hw/char/renesas_sci.c
 create mode 100644 hw/intc/rx_icu.c
 create mode 100644 hw/rx/rx-virt.c
 create mode 100644 hw/rx/rx62n.c
 create mode 100644 hw/timer/renesas_cmt.c
 create mode 100644 hw/timer/renesas_tmr.c
 create mode 100644 target/rx/cpu.c
 create mode 100644 target/rx/disas.c
 create mode 100644 target/rx/gdbstub.c
 create mode 100644 target/rx/helper.c
 create mode 100644 target/rx/monitor.c
 create mode 100644 target/rx/op_helper.c
 create mode 100644 target/rx/translate.c
 create mode 100644 hw/rx/Kconfig
 create mode 100644 hw/rx/Makefile.objs
 create mode 100644 target/rx/Makefile.objs
 create mode 100644 target/rx/insns.decode

-- 
2.11.0


Re: [Qemu-devel] [PATCH v12 00/12] Add RX archtecture support

Posted by Richard Henderson 9 weeks ago
On 5/13/19 11:14 PM, Yoshinori Sato wrote:
> This patch series is added Renesas RX target emulation.
> 
> I fixed the ROM address because v11 was incorrect.
> 
> My git repository is bellow.
> git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20190514
> 
> Testing binaries bellow.
> u-boot
> Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz
> 
> starting
> $ gzip -d u-boot.bin.gz
> $ qemu-system-rx -bios u-boot.bin
> 
> linux and pico-root (only sash)
> Download - https://osdn.net/users/ysato/pf/qemu/dl/zImage (kernel)
>            https://osdn.net/users/ysato/pf/qemu/dl/rx-qemu.dtb (DeviceTree)
> 
> starting
> $ qemu-system-rx -kernel zImage -dtb rx-qemu.dtb -append "earlycon"
> 
> Changes for v11.
> - Fix ROM address.

I think this is ready to be committed, but it is difficult to tell because you
have not retained the Reviewed-by: tags that have been given to previous versions.

Looking at

https://patchwork.ozlabs.org/project/qemu-devel/list/?series=&submitter=7114&state=&q=&archive=&delegate=

	Review	Tested

>From v10:
13/13	-	-
12/13	1	-
11/13	-	-
10/13	2	1
09/13	1	1
08/13	-	1
07/13	-	-
06/13	-	1
05/13	1	-
04/13	1	1
03/13	1	-
02/13	1	-
01/13	1	1

>From v8:
08/12	1	-
07/12	1	-
06/12	1	-

In summary, only the last patch is unreviewed, and it appears that you've fixed
the issue I pointed out in v11.  I have now sent reviews for those.

In future, please retain the tags as you go through the development process.

Rather than having you send out a v13 with only changes to the tags, I will
apply them myself while preparing an initial pull request for this.

Thanks for your patience.


r~

Re: [Qemu-devel] [PATCH v12 00/12] Add RX archtecture support

Posted by Yoshinori Sato 9 weeks ago
On Thu, 16 May 2019 01:48:29 +0900,
Richard Henderson wrote:
> 
> On 5/13/19 11:14 PM, Yoshinori Sato wrote:
> > This patch series is added Renesas RX target emulation.
> > 
> > I fixed the ROM address because v11 was incorrect.
> > 
> > My git repository is bellow.
> > git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20190514
> > 
> > Testing binaries bellow.
> > u-boot
> > Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz
> > 
> > starting
> > $ gzip -d u-boot.bin.gz
> > $ qemu-system-rx -bios u-boot.bin
> > 
> > linux and pico-root (only sash)
> > Download - https://osdn.net/users/ysato/pf/qemu/dl/zImage (kernel)
> >            https://osdn.net/users/ysato/pf/qemu/dl/rx-qemu.dtb (DeviceTree)
> > 
> > starting
> > $ qemu-system-rx -kernel zImage -dtb rx-qemu.dtb -append "earlycon"
> > 
> > Changes for v11.
> > - Fix ROM address.
> 
> I think this is ready to be committed, but it is difficult to tell because you
> have not retained the Reviewed-by: tags that have been given to previous versions.
> 
> Looking at
> 
> https://patchwork.ozlabs.org/project/qemu-devel/list/?series=&submitter=7114&state=&q=&archive=&delegate=
> 
> 	Review	Tested
> 
> >From v10:
> 13/13	-	-
> 12/13	1	-
> 11/13	-	-
> 10/13	2	1
> 09/13	1	1
> 08/13	-	1
> 07/13	-	-
> 06/13	-	1
> 05/13	1	-
> 04/13	1	1
> 03/13	1	-
> 02/13	1	-
> 01/13	1	1
> 
> >From v8:
> 08/12	1	-
> 07/12	1	-
> 06/12	1	-
> 
> In summary, only the last patch is unreviewed, and it appears that you've fixed
> the issue I pointed out in v11.  I have now sent reviews for those.
> 
> In future, please retain the tags as you go through the development process.
> 
> Rather than having you send out a v13 with only changes to the tags, I will
> apply them myself while preparing an initial pull request for this.
> 
> Thanks for your patience.
>

OK.
I prepare v13 which added Reviewed-by.

Thanks.

> 
> r~
> 

-- 
Yosinori Sato

Re: [Qemu-devel] [PATCH v12 00/12] Add RX archtecture support

Posted by Philippe Mathieu-Daudé 9 weeks ago
Hi Yoshinori,

On 5/16/19 6:13 AM, Yoshinori Sato wrote:
> On Thu, 16 May 2019 01:48:29 +0900,
> Richard Henderson wrote:
[...]>> Rather than having you send out a v13 with only changes to the
tags, I will
>> apply them myself while preparing an initial pull request for this.
>>
>> Thanks for your patience.
>>
> 
> OK.
> I prepare v13 which added Reviewed-by.

No need for a v13! Richard already did the work for you :)

Re: [Qemu-devel] [PATCH v12 00/12] Add RX archtecture support

Posted by Yoshinori Sato 9 weeks ago
On Thu, 16 May 2019 19:44:52 +0900,
Philippe Mathieu-Daudé wrote:
> 
> Hi Yoshinori,
> 
> On 5/16/19 6:13 AM, Yoshinori Sato wrote:
> > On Thu, 16 May 2019 01:48:29 +0900,
> > Richard Henderson wrote:
> [...]>> Rather than having you send out a v13 with only changes to the
> tags, I will
> >> apply them myself while preparing an initial pull request for this.
> >>
> >> Thanks for your patience.
> >>
> > 
> > OK.
> > I prepare v13 which added Reviewed-by.
> 
> No need for a v13! Richard already did the work for you :)

Oh. Sorry.
I misunderstood it.

-- 
Yosinori Sato