cadence_gem: Don't define GEM_INT_Q1_MASK twice

[Qemu-devel] [PATCH] cadence_gem: Don't define GEM_INT_Q1_MASK twice

Jonathan Behrens posted 1 patch 4 years, 11 months ago

Download mbox

Test asan passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190513194328.11045-1-jonathan@fintelia.io

Maintainers: Jason Wang <jasowang@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Alistair Francis <alistair@alistair23.me>, Peter Maydell <peter.maydell@linaro.org>

hw/net/cadence_gem.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] cadence_gem: Don't define GEM_INT_Q1_MASK twice

Posted by Jonathan Behrens 4 years, 11 months ago

Signed-off-by: Jonathan Behrens <jonathan@fintelia.io>
---
 hw/net/cadence_gem.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
index 7f63411430..37cb8a4e5c 100644
--- a/hw/net/cadence_gem.c
+++ b/hw/net/cadence_gem.c
@@ -146,7 +146,6 @@
 #define GEM_DESCONF7      (0x00000298/4)
 
 #define GEM_INT_Q1_STATUS               (0x00000400 / 4)
-#define GEM_INT_Q1_MASK                 (0x00000640 / 4)
 
 #define GEM_TRANSMIT_Q1_PTR             (0x00000440 / 4)
 #define GEM_TRANSMIT_Q7_PTR             (GEM_TRANSMIT_Q1_PTR + 6)
-- 
2.20.1

Re: [Qemu-devel] [PATCH] cadence_gem: Don't define GEM_INT_Q1_MASK twice

Posted by Alistair Francis 4 years, 11 months ago

On Mon, May 13, 2019 at 12:57 PM Jonathan Behrens <jonathan@fintelia.io> wrote:
>
> Signed-off-by: Jonathan Behrens <jonathan@fintelia.io>

Good find. Thanks for the patch!

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Can this go via your tree Jason?

Alistair

> ---
>  hw/net/cadence_gem.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
> index 7f63411430..37cb8a4e5c 100644
> --- a/hw/net/cadence_gem.c
> +++ b/hw/net/cadence_gem.c
> @@ -146,7 +146,6 @@
>  #define GEM_DESCONF7      (0x00000298/4)
>
>  #define GEM_INT_Q1_STATUS               (0x00000400 / 4)
> -#define GEM_INT_Q1_MASK                 (0x00000640 / 4)
>
>  #define GEM_TRANSMIT_Q1_PTR             (0x00000440 / 4)
>  #define GEM_TRANSMIT_Q7_PTR             (GEM_TRANSMIT_Q1_PTR + 6)
> --
> 2.20.1
>

Re: [Qemu-devel] [PATCH] cadence_gem: Don't define GEM_INT_Q1_MASK twice

Posted by Philippe Mathieu-Daudé 4 years, 11 months ago

On 5/13/19 9:43 PM, Jonathan Behrens wrote:
> Signed-off-by: Jonathan Behrens <jonathan@fintelia.io>
> ---
>  hw/net/cadence_gem.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
> index 7f63411430..37cb8a4e5c 100644
> --- a/hw/net/cadence_gem.c
> +++ b/hw/net/cadence_gem.c
> @@ -146,7 +146,6 @@
>  #define GEM_DESCONF7      (0x00000298/4)
>  
>  #define GEM_INT_Q1_STATUS               (0x00000400 / 4)
> -#define GEM_INT_Q1_MASK                 (0x00000640 / 4)
>  
>  #define GEM_TRANSMIT_Q1_PTR             (0x00000440 / 4)
>  #define GEM_TRANSMIT_Q7_PTR             (GEM_TRANSMIT_Q1_PTR + 6)
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>