Input 20190510 patches

[Qemu-devel] [PULL 0/8] Input 20190510 patches

Gerd Hoffmann posted 8 patches 4 years, 11 months ago

Download series mbox

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190510140103.3834-1-kraxel@redhat.com

Maintainers: Gerd Hoffmann <kraxel@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>

Makefile                               |  11 +
Makefile.objs                          |   1 +
include/hw/virtio/virtio-input.h       |  14 +
include/sysemu/vhost-user-backend.h    |  57 ++++
backends/vhost-user.c                  | 209 +++++++++++++
contrib/libvhost-user/libvhost-user.c  |  10 +-
contrib/vhost-user-input/main.c        | 393 +++++++++++++++++++++++++
hw/input/vhost-user-input.c            | 129 ++++++++
hw/virtio/vhost-user-input-pci.c       |  50 ++++
hw/virtio/virtio-input-host-pci.c      |   7 +-
util/qemu-sockets.c                    |  18 +-
MAINTAINERS                            |   4 +
backends/Makefile.objs                 |   2 +
contrib/vhost-user-input/Makefile.objs |   1 +
hw/input/Kconfig                       |   7 +-
hw/input/Makefile.objs                 |   5 +-
hw/virtio/Makefile.objs                |   1 +
17 files changed, 891 insertions(+), 28 deletions(-)
create mode 100644 include/sysemu/vhost-user-backend.h
create mode 100644 backends/vhost-user.c
create mode 100644 contrib/vhost-user-input/main.c
create mode 100644 hw/input/vhost-user-input.c
create mode 100644 hw/virtio/vhost-user-input-pci.c
create mode 100644 contrib/vhost-user-input/Makefile.objs

Expand all Fold all

[Qemu-devel] [PULL 0/8] Input 20190510 patches

Posted by Gerd Hoffmann 4 years, 11 months ago

The following changes since commit 812b835fb4d23dd108b2f9802158472d50b73579:

  Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-05-07' into staging (2019-05-09 16:31:12 +0100)

are available in the Git repository at:

  git://git.kraxel.org/qemu tags/input-20190510-pull-request

for you to fetch changes up to 7fb6e5a839bc625fd64c32d167f231ecd6f2b3e2:

  virtio-input: fix Kconfig dependency and Makefile (2019-05-10 14:54:11 +0200)

----------------------------------------------------------------
input: add vhost-user-input, virtio-input fixes.

----------------------------------------------------------------

Gerd Hoffmann (2):
  virtio-input-host-pci: cleanup types
  virtio-input: fix Kconfig dependency and Makefile

Marc-André Lureau (6):
  libvhost-user: fix -Waddress-of-packed-member
  libvhost-user: add PROTOCOL_F_CONFIG if {set, get}_config
  Add vhost-user-backend
  Add vhost-user-input-pci
  util: simplify unix_listen()
  contrib: add vhost-user-input

 Makefile                               |  11 +
 Makefile.objs                          |   1 +
 include/hw/virtio/virtio-input.h       |  14 +
 include/sysemu/vhost-user-backend.h    |  57 ++++
 backends/vhost-user.c                  | 209 +++++++++++++
 contrib/libvhost-user/libvhost-user.c  |  10 +-
 contrib/vhost-user-input/main.c        | 393 +++++++++++++++++++++++++
 hw/input/vhost-user-input.c            | 129 ++++++++
 hw/virtio/vhost-user-input-pci.c       |  50 ++++
 hw/virtio/virtio-input-host-pci.c      |   7 +-
 util/qemu-sockets.c                    |  18 +-
 MAINTAINERS                            |   4 +
 backends/Makefile.objs                 |   2 +
 contrib/vhost-user-input/Makefile.objs |   1 +
 hw/input/Kconfig                       |   7 +-
 hw/input/Makefile.objs                 |   5 +-
 hw/virtio/Makefile.objs                |   1 +
 17 files changed, 891 insertions(+), 28 deletions(-)
 create mode 100644 include/sysemu/vhost-user-backend.h
 create mode 100644 backends/vhost-user.c
 create mode 100644 contrib/vhost-user-input/main.c
 create mode 100644 hw/input/vhost-user-input.c
 create mode 100644 hw/virtio/vhost-user-input-pci.c
 create mode 100644 contrib/vhost-user-input/Makefile.objs

-- 
2.18.1

Re: [Qemu-devel] [PULL 0/8] Input 20190510 patches

Posted by Peter Maydell 4 years, 11 months ago

On Fri, 10 May 2019 at 15:10, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> The following changes since commit 812b835fb4d23dd108b2f9802158472d50b73579:
>
>   Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-05-07' into staging (2019-05-09 16:31:12 +0100)
>
> are available in the Git repository at:
>
>   git://git.kraxel.org/qemu tags/input-20190510-pull-request
>
> for you to fetch changes up to 7fb6e5a839bc625fd64c32d167f231ecd6f2b3e2:
>
>   virtio-input: fix Kconfig dependency and Makefile (2019-05-10 14:54:11 +0200)
>
> ----------------------------------------------------------------
> input: add vhost-user-input, virtio-input fixes.
>
> ----------------------------------------------------------------
>
> Gerd Hoffmann (2):
>   virtio-input-host-pci: cleanup types
>   virtio-input: fix Kconfig dependency and Makefile
>
> Marc-André Lureau (6):
>   libvhost-user: fix -Waddress-of-packed-member
>   libvhost-user: add PROTOCOL_F_CONFIG if {set, get}_config
>   Add vhost-user-backend
>   Add vhost-user-input-pci
>   util: simplify unix_listen()
>   contrib: add vhost-user-input

Hi; there are some compile failures here I'm afraid:

On ppc64:

/home/pm215/qemu/contrib/libvhost-user/libvhost-user.c: In function
‘vu_set_mem_table_exec_postcopy’:
/home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:666:9: error:
format ‘%llx’ expects argument of type ‘long long unsigned int’, but
argument 5 has type ‘__u64’ [-Werror=format=]
         DPRINT("%s: region %d: Registered userfault for %llx + %llx\n",
         ^
/home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:666:9: error:
format ‘%llx’ expects argument of type ‘long long unsigned int’, but
argument 6 has type ‘__u64’ [-Werror=format=]
cc1: all warnings being treated as errors

On arm (and probably any 32-bit host):

/home/peter.maydell/qemu/contrib/libvhost-user/libvhost-user.c: In
function 'vu_set_mem_table_exec_postcopy':
/home/peter.maydell/qemu/contrib/libvhost-user/libvhost-user.c:624:23:
error: cast to pointer from integer of different size
[-Werror=int-to-pointer-cast]
         ret = madvise((void *)dev_region->mmap_addr,
                       ^
/home/peter.maydell/qemu/contrib/libvhost-user/libvhost-user.c:636:23:
error: cast to pointer from integer of different size
[-Werror=int-to-pointer-cast]
         ret = madvise((void *)dev_region->mmap_addr,
                       ^
/home/peter.maydell/qemu/contrib/libvhost-user/libvhost-user.c:669:22:
error: cast to pointer from integer of different size
[-Werror=int-to-pointer-cast]
         if (mprotect((void *)dev_region->mmap_addr,
                      ^

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/8] Input 20190510 patches

Posted by Gerd Hoffmann 4 years, 11 months ago

> Hi; there are some compile failures here I'm afraid:
> 
> On ppc64:
> 
> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c: In function
> ‘vu_set_mem_table_exec_postcopy’:
> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:666:9: error:
> format ‘%llx’ expects argument of type ‘long long unsigned int’, but
> argument 5 has type ‘__u64’ [-Werror=format=]
>          DPRINT("%s: region %d: Registered userfault for %llx + %llx\n",
>          ^
> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:666:9: error:
> format ‘%llx’ expects argument of type ‘long long unsigned int’, but
> argument 6 has type ‘__u64’ [-Werror=format=]
> cc1: all warnings being treated as errors
> 
> On arm (and probably any 32-bit host):
> 
> /home/peter.maydell/qemu/contrib/libvhost-user/libvhost-user.c: In
> function 'vu_set_mem_table_exec_postcopy':
> /home/peter.maydell/qemu/contrib/libvhost-user/libvhost-user.c:624:23:
> error: cast to pointer from integer of different size
> [-Werror=int-to-pointer-cast]
>          ret = madvise((void *)dev_region->mmap_addr,
>                        ^
> /home/peter.maydell/qemu/contrib/libvhost-user/libvhost-user.c:636:23:
> error: cast to pointer from integer of different size
> [-Werror=int-to-pointer-cast]
>          ret = madvise((void *)dev_region->mmap_addr,
>                        ^
> /home/peter.maydell/qemu/contrib/libvhost-user/libvhost-user.c:669:22:
> error: cast to pointer from integer of different size
> [-Werror=int-to-pointer-cast]
>          if (mprotect((void *)dev_region->mmap_addr,
>                       ^

Patch #6 dropped, v2 sent.

cheers,
  Gerd