hw/i386/Kconfig: The Q35 machine requires the ICH9_AHCI device

[Qemu-devel] [PATCH] hw/i386/Kconfig: The Q35 machine requires the ICH9_AHCI device

Philippe Mathieu-Daudé posted 1 patch 4 years, 12 months ago

Download mbox

Test docker-mingw@fedora failed

Test asan failed

Test docker-clang@ubuntu failed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190507122748.18506-1-philmd@redhat.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Richard Henderson <rth@twiddle.net>

hw/i386/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] hw/i386/Kconfig: The Q35 machine requires the ICH9_AHCI device

Posted by Philippe Mathieu-Daudé 4 years, 12 months ago

The Q35 machine uses the ICH9 chipset which is composed of various
sub-devices. There is currently no generic Kconfig selector that
selects all the required devices. Meanwhile, force the Q35 machine
to select the 'ich9-ahci' device.

This fixes:

  $ ./configure --without-default-devices && \
    ./i386-softmmu/qemu-system-i386 -nodefaults -M q35
  qemu-system-i386: Unknown device 'ich9-ahci' for bus 'PCIE'
  Aborted (core dumped)

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/i386/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index a6aed7c1313..98178882169 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -80,7 +80,7 @@ config Q35
     select PC_ACPI
     select PCI_EXPRESS_Q35
     select LPC_ICH9
-    select AHCI
+    select AHCI_ICH9
     select DIMM
     select SMBIOS
     select VMPORT
-- 
2.20.1

Re: [Qemu-devel] [PATCH] hw/i386/Kconfig: The Q35 machine requires the ICH9_AHCI device

Posted by Philippe Mathieu-Daudé 4 years, 12 months ago

On 5/7/19 2:27 PM, Philippe Mathieu-Daudé wrote:
> The Q35 machine uses the ICH9 chipset which is composed of various
> sub-devices. There is currently no generic Kconfig selector that
> selects all the required devices. Meanwhile, force the Q35 machine
> to select the 'ich9-ahci' device.
> 
> This fixes:
> 
>   $ ./configure --without-default-devices && \
>     ./i386-softmmu/qemu-system-i386 -nodefaults -M q35
>   qemu-system-i386: Unknown device 'ich9-ahci' for bus 'PCIE'
>   Aborted (core dumped)
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
I forgot:

Based-on: <20190430071405.16714-3-thuth@redhat.com>
"hw/ide/ahci: Add a Kconfig switch for the AHCI-ICH9 device"

>  hw/i386/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index a6aed7c1313..98178882169 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -80,7 +80,7 @@ config Q35
>      select PC_ACPI
>      select PCI_EXPRESS_Q35
>      select LPC_ICH9
> -    select AHCI
> +    select AHCI_ICH9
>      select DIMM
>      select SMBIOS
>      select VMPORT
>