tests/docker: Test more components on the Fedora default image

[Qemu-devel] [PATCH] tests/docker: Test more components on the Fedora default image

Posted by Philippe Mathieu-Daudé 4 years, 11 months ago

Install optional dependencies of QEMU to get better coverage.

The following components are now enabled:

  $ ./configure
  ...
  Multipath support yes
  VNC SASL support  yes
  RDMA support      yes
  PVRDMA support    yes
  libiscsi support  yes
  seccomp support   yes
  libpmem support   yes
  libudev           yes

Note: The udev-devel package is provided by systemd-devel.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 tests/docker/dockerfiles/fedora.docker | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index 69d4a7f5d75..afbba29adaa 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -8,6 +8,7 @@ ENV PACKAGES \
     bzip2-devel \
     ccache \
     clang \
+    cyrus-sasl-devel \
     device-mapper-multipath-devel \
     findutils \
     flex \
@@ -23,13 +24,17 @@ ENV PACKAGES \
     libaio-devel \
     libasan \
     libattr-devel \
+    libblockdev-mpath-devel \
     libcap-devel \
     libcap-ng-devel \
     libcurl-devel \
     libfdt-devel \
+    libiscsi-devel \
     libjpeg-devel \
+    libpmem-devel \
     libpng-devel \
     librbd-devel \
+    libseccomp-devel \
     libssh2-devel \
     libubsan \
     libusbx-devel \
@@ -74,10 +79,12 @@ ENV PACKAGES \
     pixman-devel \
     python3 \
     PyYAML \
+    rdma-core-devel \
     SDL2-devel \
     snappy-devel \
     sparse \
     spice-server-devel \
+    systemd-devel \
     systemtap-sdt-devel \
     tar \
     usbredir-devel \
-- 
2.20.1

Re: [Qemu-devel] [PATCH] tests/docker: Test more components on the Fedora default image

Posted by Marcel Apfelbaum 4 years, 11 months ago

Hi Philippe,

On 5/4/19 8:54 AM, Philippe Mathieu-Daudé wrote:
> Install optional dependencies of QEMU to get better coverage.
>
> The following components are now enabled:
>
>    $ ./configure
>    ...
>    Multipath support yes
>    VNC SASL support  yes
>    RDMA support      yes
>    PVRDMA support    yes

Appreciated!

Acked-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>

Thanks,
Marcel

>    libiscsi support  yes
>    seccomp support   yes
>    libpmem support   yes
>    libudev           yes
>
> Note: The udev-devel package is provided by systemd-devel.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   tests/docker/dockerfiles/fedora.docker | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 69d4a7f5d75..afbba29adaa 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -8,6 +8,7 @@ ENV PACKAGES \
>       bzip2-devel \
>       ccache \
>       clang \
> +    cyrus-sasl-devel \
>       device-mapper-multipath-devel \
>       findutils \
>       flex \
> @@ -23,13 +24,17 @@ ENV PACKAGES \
>       libaio-devel \
>       libasan \
>       libattr-devel \
> +    libblockdev-mpath-devel \
>       libcap-devel \
>       libcap-ng-devel \
>       libcurl-devel \
>       libfdt-devel \
> +    libiscsi-devel \
>       libjpeg-devel \
> +    libpmem-devel \
>       libpng-devel \
>       librbd-devel \
> +    libseccomp-devel \
>       libssh2-devel \
>       libubsan \
>       libusbx-devel \
> @@ -74,10 +79,12 @@ ENV PACKAGES \
>       pixman-devel \
>       python3 \
>       PyYAML \
> +    rdma-core-devel \
>       SDL2-devel \
>       snappy-devel \
>       sparse \
>       spice-server-devel \
> +    systemd-devel \
>       systemtap-sdt-devel \
>       tar \
>       usbredir-devel \

Re: [Qemu-devel] [PATCH] tests/docker: Test more components on the Fedora default image

Posted by Alex Bennée 4 years, 11 months ago

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> Install optional dependencies of QEMU to get better coverage.
>
> The following components are now enabled:
>
>   $ ./configure
>   ...
>   Multipath support yes
>   VNC SASL support  yes
>   RDMA support      yes
>   PVRDMA support    yes
>   libiscsi support  yes
>   seccomp support   yes
>   libpmem support   yes
>   libudev           yes
>
> Note: The udev-devel package is provided by systemd-devel.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Queued to testing/next, thanks.

> ---
>  tests/docker/dockerfiles/fedora.docker | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 69d4a7f5d75..afbba29adaa 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -8,6 +8,7 @@ ENV PACKAGES \
>      bzip2-devel \
>      ccache \
>      clang \
> +    cyrus-sasl-devel \
>      device-mapper-multipath-devel \
>      findutils \
>      flex \
> @@ -23,13 +24,17 @@ ENV PACKAGES \
>      libaio-devel \
>      libasan \
>      libattr-devel \
> +    libblockdev-mpath-devel \
>      libcap-devel \
>      libcap-ng-devel \
>      libcurl-devel \
>      libfdt-devel \
> +    libiscsi-devel \
>      libjpeg-devel \
> +    libpmem-devel \
>      libpng-devel \
>      librbd-devel \
> +    libseccomp-devel \
>      libssh2-devel \
>      libubsan \
>      libusbx-devel \
> @@ -74,10 +79,12 @@ ENV PACKAGES \
>      pixman-devel \
>      python3 \
>      PyYAML \
> +    rdma-core-devel \
>      SDL2-devel \
>      snappy-devel \
>      sparse \
>      spice-server-devel \
> +    systemd-devel \
>      systemtap-sdt-devel \
>      tar \
>      usbredir-devel \


--
Alex Bennée