[v3] tcg vector improvements

[Qemu-devel] [PATCH v3 25/31] target/cris: Use tcg_gen_abs_tl

Posted by Richard Henderson 6 years, 9 months ago

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/cris/translate.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/target/cris/translate.c b/target/cris/translate.c
index b005a5c20e..31b40a57f9 100644
--- a/target/cris/translate.c
+++ b/target/cris/translate.c
@@ -1686,18 +1686,11 @@ static int dec_cmp_r(CPUCRISState *env, DisasContext *dc)
 
 static int dec_abs_r(CPUCRISState *env, DisasContext *dc)
 {
-    TCGv t0;
-
     LOG_DIS("abs $r%u, $r%u\n",
             dc->op1, dc->op2);
     cris_cc_mask(dc, CC_MASK_NZ);
 
-    t0 = tcg_temp_new();
-    tcg_gen_sari_tl(t0, cpu_R[dc->op1], 31);
-    tcg_gen_xor_tl(cpu_R[dc->op2], cpu_R[dc->op1], t0);
-    tcg_gen_sub_tl(cpu_R[dc->op2], cpu_R[dc->op2], t0);
-    tcg_temp_free(t0);
-
+    tcg_gen_abs_tl(cpu_R[dc->op2], cpu_R[dc->op1]);
     cris_alu(dc, CC_OP_MOVE,
             cpu_R[dc->op2], cpu_R[dc->op2], cpu_R[dc->op2], 4);
     return 2;
-- 
2.17.1

Re: [Qemu-devel] [PATCH v3 25/31] target/cris: Use tcg_gen_abs_tl

Posted by David Hildenbrand 6 years, 9 months ago

On 04.05.19 07:52, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/cris/translate.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/target/cris/translate.c b/target/cris/translate.c
> index b005a5c20e..31b40a57f9 100644
> --- a/target/cris/translate.c
> +++ b/target/cris/translate.c
> @@ -1686,18 +1686,11 @@ static int dec_cmp_r(CPUCRISState *env, DisasContext *dc)
>  
>  static int dec_abs_r(CPUCRISState *env, DisasContext *dc)
>  {
> -    TCGv t0;
> -
>      LOG_DIS("abs $r%u, $r%u\n",
>              dc->op1, dc->op2);
>      cris_cc_mask(dc, CC_MASK_NZ);
>  
> -    t0 = tcg_temp_new();
> -    tcg_gen_sari_tl(t0, cpu_R[dc->op1], 31);
> -    tcg_gen_xor_tl(cpu_R[dc->op2], cpu_R[dc->op1], t0);
> -    tcg_gen_sub_tl(cpu_R[dc->op2], cpu_R[dc->op2], t0);
> -    tcg_temp_free(t0);
> -
> +    tcg_gen_abs_tl(cpu_R[dc->op2], cpu_R[dc->op1]);
>      cris_alu(dc, CC_OP_MOVE,
>              cpu_R[dc->op2], cpu_R[dc->op2], cpu_R[dc->op2], 4);
>      return 2;
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 

Thanks,

David / dhildenb