qemu-ga.texi | 4 ++-- configure | 5 ++--- Makefile | 11 +++++---- hw/display/ati_int.h | 1 - include/exec/cpu-common.h | 3 --- include/hw/cpu/cluster.h | 1 - tests/fp/platform.h | 1 - tests/libqos/qgraph.h | 4 ---- contrib/elf2dmp/main.c | 3 +-- contrib/elf2dmp/pdb.c | 3 +-- hw/display/ati.c | 1 + hw/display/ati_2d.c | 1 + hw/display/ati_dbg.c | 1 + hw/net/pcnet.c | 4 +++- hw/sparc/leon3.c | 4 ++++ net/net.c | 7 +++--- qom/object.c | 2 +- tests/qos-test.c | 2 +- util/qemu-sockets.c | 12 ++++++---- CODING_STYLE | 47 +++++++++++++++++++++++++++++++++++---- 20 files changed, 80 insertions(+), 37 deletions(-)
The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df:
Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-05-02 12:04:51 +0100)
are available in the Git repository at:
git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
for you to fetch changes up to f7c03a68b814254df414977ff299468fbf0fa1c0:
sockets: avoid string truncation warnings when copying UNIX path (2019-05-02 20:50:47 +0200)
----------------------------------------------------------------
Pull request trivial branch 2019-05-02
----------------------------------------------------------------
Aruna Jayasena (1):
Header cleanups
Daniel P. Berrangé (1):
sockets: avoid string truncation warnings when copying UNIX path
Dr. David Alan Gilbert (1):
configure: fix pam test warning
Marc-André Lureau (1):
doc: fix the configuration path
Markus Armbruster (1):
Clean up includes
Philippe Mathieu-Daudé (3):
hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf
Makefile: Let the 'clean' rule remove qemu-ga.exe on Windows hosts
hw/sparc/leon3: Allow load of uImage firmwares
Stefan Weil (1):
Update configure
Thomas Huth (1):
net: Print output of "-net nic, model=help" to stdout instead of
stderr
Wei Yang (3):
CODING_STYLE: specify the indent rule for multiline code
CODING_STYLE: indent example code as all others
qom: use object_new_with_type in object_new_with_propv
qemu-ga.texi | 4 ++--
configure | 5 ++---
Makefile | 11 +++++----
hw/display/ati_int.h | 1 -
include/exec/cpu-common.h | 3 ---
include/hw/cpu/cluster.h | 1 -
tests/fp/platform.h | 1 -
tests/libqos/qgraph.h | 4 ----
contrib/elf2dmp/main.c | 3 +--
contrib/elf2dmp/pdb.c | 3 +--
hw/display/ati.c | 1 +
hw/display/ati_2d.c | 1 +
hw/display/ati_dbg.c | 1 +
hw/net/pcnet.c | 4 +++-
hw/sparc/leon3.c | 4 ++++
net/net.c | 7 +++---
qom/object.c | 2 +-
tests/qos-test.c | 2 +-
util/qemu-sockets.c | 12 ++++++----
CODING_STYLE | 47 +++++++++++++++++++++++++++++++++++----
20 files changed, 80 insertions(+), 37 deletions(-)
--
2.20.1
On Thu, 2 May 2019 at 19:58, Laurent Vivier <laurent@vivier.eu> wrote:
>
> The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df:
>
> Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-05-02 12:04:51 +0100)
>
> are available in the Git repository at:
>
> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>
> for you to fetch changes up to f7c03a68b814254df414977ff299468fbf0fa1c0:
>
> sockets: avoid string truncation warnings when copying UNIX path (2019-05-02 20:50:47 +0200)
>
> ----------------------------------------------------------------
> Pull request trivial branch 2019-05-02
>
> ----------------------------------------------------------------
Markus's "Clean up includes" patch breaks 'make check' on
big-endian hosts:
cd /home/pm215/qemu/build/all/tests/fp && ./fp-test -s -l 1 -r all i32_to_f16 i
64_to_f16 i32_to_f32 i64_to_f32 i32_to_f64 i64_to_f64 i32_to_f128 i64_to_f128 >
int-to-float.out 2>&1 || (cat int-to-float.out && exit 1;)
>> Testing i32_to_f16, rounding near_even
^M372 tests total.
^M372 tests performed.
In 372 tests, no errors found in i32_to_f16, rounding near_even.
>> Testing i32_to_f16, rounding minMag
[...]
^MErrors found in i32_to_f128:
1006FFFF => +0000.000000000000401B006FFFF00000 .....
expected +401B.006FFFF000000000000000000000 .....
^M0001DDEB => +0000.000000000000400FDDEB00000000 .....
expected +400F.DDEB000000000000000000000000 .....
^MFFF6FFFC => +0000.000000000000C012200080000000 .....
expected -4012.2000800000000000000000000000 .....
^MFFFFFFF8 => +0000.000000000000C002000000000000 .....
expected -4002.0000000000000000000000000000 .....
[etc]
(I had to bounce Markus' own pullreq from a week or
so back because it had this patch in too and also failed
for this reason.)
thanks
-- PMM
On 03/05/2019 12:34, Peter Maydell wrote: > On Thu, 2 May 2019 at 19:58, Laurent Vivier <laurent@vivier.eu> wrote: >> >> The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df: >> >> Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-05-02 12:04:51 +0100) >> >> are available in the Git repository at: >> >> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request >> >> for you to fetch changes up to f7c03a68b814254df414977ff299468fbf0fa1c0: >> >> sockets: avoid string truncation warnings when copying UNIX path (2019-05-02 20:50:47 +0200) >> >> ---------------------------------------------------------------- >> Pull request trivial branch 2019-05-02 >> >> ---------------------------------------------------------------- > > Markus's "Clean up includes" patch breaks 'make check' on > big-endian hosts: > cd /home/pm215/qemu/build/all/tests/fp && ./fp-test -s -l 1 -r all i32_to_f16 i > 64_to_f16 i32_to_f32 i64_to_f32 i32_to_f64 i64_to_f64 i32_to_f128 i64_to_f128 > > int-to-float.out 2>&1 || (cat int-to-float.out && exit 1;) >>> Testing i32_to_f16, rounding near_even > ^M372 tests total. > ^M372 tests performed. > In 372 tests, no errors found in i32_to_f16, rounding near_even. >>> Testing i32_to_f16, rounding minMag > [...] > ^MErrors found in i32_to_f128: > 1006FFFF => +0000.000000000000401B006FFFF00000 ..... > expected +401B.006FFFF000000000000000000000 ..... > ^M0001DDEB => +0000.000000000000400FDDEB00000000 ..... > expected +400F.DDEB000000000000000000000000 ..... > ^MFFF6FFFC => +0000.000000000000C012200080000000 ..... > expected -4012.2000800000000000000000000000 ..... > ^MFFFFFFF8 => +0000.000000000000C002000000000000 ..... > expected -4002.0000000000000000000000000000 ..... > [etc] > > (I had to bounce Markus' own pullreq from a week or > so back because it had this patch in too and also failed > for this reason.) ok, I remove it and re-send the PR. Thanks, Laurent
Peter Maydell <peter.maydell@linaro.org> writes:
> On Thu, 2 May 2019 at 19:58, Laurent Vivier <laurent@vivier.eu> wrote:
>>
>> The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df:
>>
>> Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-05-02 12:04:51 +0100)
>>
>> are available in the Git repository at:
>>
>> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>
>> for you to fetch changes up to f7c03a68b814254df414977ff299468fbf0fa1c0:
>>
>> sockets: avoid string truncation warnings when copying UNIX path (2019-05-02 20:50:47 +0200)
>>
>> ----------------------------------------------------------------
>> Pull request trivial branch 2019-05-02
>>
>> ----------------------------------------------------------------
>
> Markus's "Clean up includes" patch breaks 'make check' on
> big-endian hosts:
> cd /home/pm215/qemu/build/all/tests/fp && ./fp-test -s -l 1 -r all i32_to_f16 i
> 64_to_f16 i32_to_f32 i64_to_f32 i32_to_f64 i64_to_f64 i32_to_f128 i64_to_f128 >
> int-to-float.out 2>&1 || (cat int-to-float.out && exit 1;)
>>> Testing i32_to_f16, rounding near_even
> ^M372 tests total.
> ^M372 tests performed.
> In 372 tests, no errors found in i32_to_f16, rounding near_even.
>>> Testing i32_to_f16, rounding minMag
> [...]
> ^MErrors found in i32_to_f128:
> 1006FFFF => +0000.000000000000401B006FFFF00000 .....
> expected +401B.006FFFF000000000000000000000 .....
> ^M0001DDEB => +0000.000000000000400FDDEB00000000 .....
> expected +400F.DDEB000000000000000000000000 .....
> ^MFFF6FFFC => +0000.000000000000C012200080000000 .....
> expected -4012.2000800000000000000000000000 .....
> ^MFFFFFFF8 => +0000.000000000000C002000000000000 .....
> expected -4002.0000000000000000000000000000 .....
> [etc]
Considering the header clean-ups moved bswap related stuff and the
patterns look incorrectly swapped something has gone fishy.
If it's just stuff touching f128 then we have some magic in
softfloat-types:
typedef struct {
#ifdef HOST_WORDS_BIGENDIAN
uint64_t high, low;
#else
uint64_t low, high;
#endif
} float128;
but I would have though HOST_WORDS_BIGENDIAN is in the config. I shall
have a poke once I get onto the s390 machine.
>
> (I had to bounce Markus' own pullreq from a week or
> so back because it had this patch in too and also failed
> for this reason.)
>
> thanks
> -- PMM
--
Alex Bennée
Alex Bennée <alex.bennee@linaro.org> writes:
> Peter Maydell <peter.maydell@linaro.org> writes:
>
>> On Thu, 2 May 2019 at 19:58, Laurent Vivier <laurent@vivier.eu> wrote:
>>>
>>> The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df:
>>>
>>> Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-05-02 12:04:51 +0100)
>>>
>>> are available in the Git repository at:
>>>
>>> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>>
>>> for you to fetch changes up to f7c03a68b814254df414977ff299468fbf0fa1c0:
>>>
>>> sockets: avoid string truncation warnings when copying UNIX path (2019-05-02 20:50:47 +0200)
>>>
>>> ----------------------------------------------------------------
>>> Pull request trivial branch 2019-05-02
>>>
>>> ----------------------------------------------------------------
>>
>> Markus's "Clean up includes" patch breaks 'make check' on
>> big-endian hosts:
>> cd /home/pm215/qemu/build/all/tests/fp && ./fp-test -s -l 1 -r all i32_to_f16 i
>> 64_to_f16 i32_to_f32 i64_to_f32 i32_to_f64 i64_to_f64 i32_to_f128 i64_to_f128 >
>> int-to-float.out 2>&1 || (cat int-to-float.out && exit 1;)
>>>> Testing i32_to_f16, rounding near_even
>> ^M372 tests total.
>> ^M372 tests performed.
>> In 372 tests, no errors found in i32_to_f16, rounding near_even.
>>>> Testing i32_to_f16, rounding minMag
>> [...]
>> ^MErrors found in i32_to_f128:
>> 1006FFFF => +0000.000000000000401B006FFFF00000 .....
>> expected +401B.006FFFF000000000000000000000 .....
>> ^M0001DDEB => +0000.000000000000400FDDEB00000000 .....
>> expected +400F.DDEB000000000000000000000000 .....
>> ^MFFF6FFFC => +0000.000000000000C012200080000000 .....
>> expected -4012.2000800000000000000000000000 .....
>> ^MFFFFFFF8 => +0000.000000000000C002000000000000 .....
>> expected -4002.0000000000000000000000000000 .....
>> [etc]
>
> Considering the header clean-ups moved bswap related stuff and the
> patterns look incorrectly swapped something has gone fishy.
>
> If it's just stuff touching f128 then we have some magic in
> softfloat-types:
>
> typedef struct {
> #ifdef HOST_WORDS_BIGENDIAN
> uint64_t high, low;
> #else
> uint64_t low, high;
> #endif
> } float128;
>
> but I would have though HOST_WORDS_BIGENDIAN is in the config. I shall
> have a poke once I get onto the s390 machine.
Any luck?
In my own poking, I stumbled over
#ifndef HOST_WORDS_BIGENDIAN
#define LITTLEENDIAN 1
/* otherwise do not define it */
#endif
in platform.h. Is LITTLEENDIAN unused, or am I confused?
[...]
Markus Armbruster <armbru@redhat.com> writes:
> Alex Bennée <alex.bennee@linaro.org> writes:
>
>> Peter Maydell <peter.maydell@linaro.org> writes:
>>
>>> On Thu, 2 May 2019 at 19:58, Laurent Vivier <laurent@vivier.eu> wrote:
>>>>
>>>> The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df:
>>>>
>>>> Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-05-02 12:04:51 +0100)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>>>
>>>> for you to fetch changes up to f7c03a68b814254df414977ff299468fbf0fa1c0:
>>>>
>>>> sockets: avoid string truncation warnings when copying UNIX path (2019-05-02 20:50:47 +0200)
>>>>
>>>> ----------------------------------------------------------------
>>>> Pull request trivial branch 2019-05-02
>>>>
>>>> ----------------------------------------------------------------
>>>
>>> Markus's "Clean up includes" patch breaks 'make check' on
>>> big-endian hosts:
>>> cd /home/pm215/qemu/build/all/tests/fp && ./fp-test -s -l 1 -r all i32_to_f16 i
>>> 64_to_f16 i32_to_f32 i64_to_f32 i32_to_f64 i64_to_f64 i32_to_f128 i64_to_f128 >
>>> int-to-float.out 2>&1 || (cat int-to-float.out && exit 1;)
>>>>> Testing i32_to_f16, rounding near_even
>>> ^M372 tests total.
>>> ^M372 tests performed.
>>> In 372 tests, no errors found in i32_to_f16, rounding near_even.
>>>>> Testing i32_to_f16, rounding minMag
>>> [...]
>>> ^MErrors found in i32_to_f128:
>>> 1006FFFF => +0000.000000000000401B006FFFF00000 .....
>>> expected +401B.006FFFF000000000000000000000 .....
>>> ^M0001DDEB => +0000.000000000000400FDDEB00000000 .....
>>> expected +400F.DDEB000000000000000000000000 .....
>>> ^MFFF6FFFC => +0000.000000000000C012200080000000 .....
>>> expected -4012.2000800000000000000000000000 .....
>>> ^MFFFFFFF8 => +0000.000000000000C002000000000000 .....
>>> expected -4002.0000000000000000000000000000 .....
>>> [etc]
>>
>> Considering the header clean-ups moved bswap related stuff and the
>> patterns look incorrectly swapped something has gone fishy.
>>
>> If it's just stuff touching f128 then we have some magic in
>> softfloat-types:
>>
>> typedef struct {
>> #ifdef HOST_WORDS_BIGENDIAN
>> uint64_t high, low;
>> #else
>> uint64_t low, high;
>> #endif
>> } float128;
>>
>> but I would have though HOST_WORDS_BIGENDIAN is in the config. I shall
>> have a poke once I get onto the s390 machine.
>
> Any luck?
>
> In my own poking, I stumbled over
>
> #ifndef HOST_WORDS_BIGENDIAN
> #define LITTLEENDIAN 1
> /* otherwise do not define it */
> #endif
>
> in platform.h. Is LITTLEENDIAN unused, or am I confused?
I couldn't replicate the bug with access to my s390 account so I think
it might be existing build artefact related which is odd.
--
Alex Bennée
Alex Bennée <alex.bennee@linaro.org> writes:
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Alex Bennée <alex.bennee@linaro.org> writes:
>>
>>> Peter Maydell <peter.maydell@linaro.org> writes:
>>>
>>>> On Thu, 2 May 2019 at 19:58, Laurent Vivier <laurent@vivier.eu> wrote:
>>>>>
>>>>> The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df:
>>>>>
>>>>> Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-05-02 12:04:51 +0100)
>>>>>
>>>>> are available in the Git repository at:
>>>>>
>>>>> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>>>>
>>>>> for you to fetch changes up to f7c03a68b814254df414977ff299468fbf0fa1c0:
>>>>>
>>>>> sockets: avoid string truncation warnings when copying UNIX path (2019-05-02 20:50:47 +0200)
>>>>>
>>>>> ----------------------------------------------------------------
>>>>> Pull request trivial branch 2019-05-02
>>>>>
>>>>> ----------------------------------------------------------------
>>>>
>>>> Markus's "Clean up includes" patch breaks 'make check' on
>>>> big-endian hosts:
>>>> cd /home/pm215/qemu/build/all/tests/fp && ./fp-test -s -l 1 -r all i32_to_f16 i
>>>> 64_to_f16 i32_to_f32 i64_to_f32 i32_to_f64 i64_to_f64 i32_to_f128 i64_to_f128 >
>>>> int-to-float.out 2>&1 || (cat int-to-float.out && exit 1;)
>>>>>> Testing i32_to_f16, rounding near_even
>>>> ^M372 tests total.
>>>> ^M372 tests performed.
>>>> In 372 tests, no errors found in i32_to_f16, rounding near_even.
>>>>>> Testing i32_to_f16, rounding minMag
>>>> [...]
>>>> ^MErrors found in i32_to_f128:
>>>> 1006FFFF => +0000.000000000000401B006FFFF00000 .....
>>>> expected +401B.006FFFF000000000000000000000 .....
>>>> ^M0001DDEB => +0000.000000000000400FDDEB00000000 .....
>>>> expected +400F.DDEB000000000000000000000000 .....
>>>> ^MFFF6FFFC => +0000.000000000000C012200080000000 .....
>>>> expected -4012.2000800000000000000000000000 .....
>>>> ^MFFFFFFF8 => +0000.000000000000C002000000000000 .....
>>>> expected -4002.0000000000000000000000000000 .....
>>>> [etc]
>>>
>>> Considering the header clean-ups moved bswap related stuff and the
>>> patterns look incorrectly swapped something has gone fishy.
>>>
>>> If it's just stuff touching f128 then we have some magic in
>>> softfloat-types:
>>>
>>> typedef struct {
>>> #ifdef HOST_WORDS_BIGENDIAN
>>> uint64_t high, low;
>>> #else
>>> uint64_t low, high;
>>> #endif
>>> } float128;
>>>
>>> but I would have though HOST_WORDS_BIGENDIAN is in the config. I shall
>>> have a poke once I get onto the s390 machine.
>>
>> Any luck?
>>
>> In my own poking, I stumbled over
>>
>> #ifndef HOST_WORDS_BIGENDIAN
>> #define LITTLEENDIAN 1
>> /* otherwise do not define it */
>> #endif
>>
>> in platform.h. Is LITTLEENDIAN unused, or am I confused?
>
> I couldn't replicate the bug with access to my s390 account so I think
> it might be existing build artefact related which is odd.
Any ideas on how to debug this further?
On Thu, 9 May 2019 at 09:32, Markus Armbruster <armbru@redhat.com> wrote: > > Alex Bennée <alex.bennee@linaro.org> writes: > > I couldn't replicate the bug with access to my s390 account so I think > > it might be existing build artefact related which is odd. > > Any ideas on how to debug this further? It's consistently failed for me both times I've tried to merge the pullreq, on both s390 and ppc (which is doing a straightforward 'git merge, then do an incremental build out-of-tree'). Alex has access to the s390 box, and there's a ppc box in the gcc compile farm... thanks -- PMM
Peter Maydell <peter.maydell@linaro.org> writes: > On Thu, 9 May 2019 at 09:32, Markus Armbruster <armbru@redhat.com> wrote: >> >> Alex Bennée <alex.bennee@linaro.org> writes: >> > I couldn't replicate the bug with access to my s390 account so I think >> > it might be existing build artefact related which is odd. >> >> Any ideas on how to debug this further? > > It's consistently failed for me both times I've tried > to merge the pullreq, on both s390 and ppc (which is > doing a straightforward 'git merge, then do an incremental > build out-of-tree'). Alex has access to the s390 box, > and there's a ppc box in the gcc compile farm... I tried to reproduce on a ppc64 box in the gcc compile farm, no dice. I double-checked config-host.h has #define HOST_WORDS_BIGENDIAN 1. Clutching at straws... you say you tried "an incremental build out-of-tree". I also built out-of-tree, but it wasn't incremental. Could you try a non-incremental build just to exclude the possibility something wonky in your build tree is breaking "make check" for you?
On Fri, 10 May 2019 at 16:05, Markus Armbruster <armbru@redhat.com> wrote: > I tried to reproduce on a ppc64 box in the gcc compile farm, no dice. I > double-checked config-host.h has #define HOST_WORDS_BIGENDIAN 1. On s390: git clone git://git.qemu.org/qemu.git qemu-tmp cd qemu-tmp mkdir build cd build ../configure make -j3 make -j3 check V=1 # passes wget https://patchew.org/QEMU/20190313162812.8885-1-armbru@redhat.com/mbox git am mbox make -j3 make -j3 check V=1 # fails thanks -- PMM
On Fri, 10 May 2019 at 17:25, Peter Maydell <peter.maydell@linaro.org> wrote: > > On Fri, 10 May 2019 at 16:05, Markus Armbruster <armbru@redhat.com> wrote: > > I tried to reproduce on a ppc64 box in the gcc compile farm, no dice. I > > double-checked config-host.h has #define HOST_WORDS_BIGENDIAN 1. > > On s390: > git clone git://git.qemu.org/qemu.git qemu-tmp > cd qemu-tmp > mkdir build > cd build > ../configure > make -j3 > make -j3 check V=1 # passes > wget https://patchew.org/QEMU/20190313162812.8885-1-armbru@redhat.com/mbox > git am mbox > make -j3 > make -j3 check V=1 # fails For completeness, the commit I got from git clone was efb4f3b62c69383a7308. thanks -- PMM
Peter Maydell <peter.maydell@linaro.org> writes: > On Fri, 10 May 2019 at 16:05, Markus Armbruster <armbru@redhat.com> wrote: >> I tried to reproduce on a ppc64 box in the gcc compile farm, no dice. I >> double-checked config-host.h has #define HOST_WORDS_BIGENDIAN 1. > > On s390: > git clone git://git.qemu.org/qemu.git qemu-tmp > cd qemu-tmp > mkdir build > cd build > ../configure > make -j3 > make -j3 check V=1 # passes > wget https://patchew.org/QEMU/20190313162812.8885-1-armbru@redhat.com/mbox > git am mbox > make -j3 > make -j3 check V=1 # fails > > thanks > -- PMM I double-checked my testing and found where I screwed up. Thanks for your help!
Markus Armbruster <armbru@redhat.com> writes:
> Alex Bennée <alex.bennee@linaro.org> writes:
>
>> Peter Maydell <peter.maydell@linaro.org> writes:
>>
>>> On Thu, 2 May 2019 at 19:58, Laurent Vivier <laurent@vivier.eu> wrote:
>>>>
>>>> The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df:
>>>>
>>>> Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-05-02 12:04:51 +0100)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>>>
>>>> for you to fetch changes up to f7c03a68b814254df414977ff299468fbf0fa1c0:
>>>>
>>>> sockets: avoid string truncation warnings when copying UNIX path (2019-05-02 20:50:47 +0200)
>>>>
>>>> ----------------------------------------------------------------
>>>> Pull request trivial branch 2019-05-02
>>>>
>>>> ----------------------------------------------------------------
>>>
>>> Markus's "Clean up includes" patch breaks 'make check' on
>>> big-endian hosts:
>>> cd /home/pm215/qemu/build/all/tests/fp && ./fp-test -s -l 1 -r all i32_to_f16 i
>>> 64_to_f16 i32_to_f32 i64_to_f32 i32_to_f64 i64_to_f64 i32_to_f128 i64_to_f128 >
>>> int-to-float.out 2>&1 || (cat int-to-float.out && exit 1;)
>>>>> Testing i32_to_f16, rounding near_even
>>> ^M372 tests total.
>>> ^M372 tests performed.
>>> In 372 tests, no errors found in i32_to_f16, rounding near_even.
>>>>> Testing i32_to_f16, rounding minMag
>>> [...]
>>> ^MErrors found in i32_to_f128:
>>> 1006FFFF => +0000.000000000000401B006FFFF00000 .....
>>> expected +401B.006FFFF000000000000000000000 .....
>>> ^M0001DDEB => +0000.000000000000400FDDEB00000000 .....
>>> expected +400F.DDEB000000000000000000000000 .....
>>> ^MFFF6FFFC => +0000.000000000000C012200080000000 .....
>>> expected -4012.2000800000000000000000000000 .....
>>> ^MFFFFFFF8 => +0000.000000000000C002000000000000 .....
>>> expected -4002.0000000000000000000000000000 .....
>>> [etc]
>>
>> Considering the header clean-ups moved bswap related stuff and the
>> patterns look incorrectly swapped something has gone fishy.
>>
>> If it's just stuff touching f128 then we have some magic in
>> softfloat-types:
>>
>> typedef struct {
>> #ifdef HOST_WORDS_BIGENDIAN
>> uint64_t high, low;
>> #else
>> uint64_t low, high;
>> #endif
>> } float128;
>>
>> but I would have though HOST_WORDS_BIGENDIAN is in the config. I shall
Me too; qemu/osdep.h should pull it in.
>> have a poke once I get onto the s390 machine.
>
> Any luck?
>
> In my own poking, I stumbled over
>
> #ifndef HOST_WORDS_BIGENDIAN
> #define LITTLEENDIAN 1
> /* otherwise do not define it */
> #endif
>
> in platform.h. Is LITTLEENDIAN unused, or am I confused?
INLINE appears just as unused.
> [...]
© 2016 - 2024 Red Hat, Inc.