[v7] backup-top: preparing refactoring

[Qemu-devel] [PATCH v7 0/5] backup-top: preparing refactoring

Vladimir Sementsov-Ogievskiy posted 5 patches 5 years ago

Diff against v6
Download series mbox

Test asan passed

Test docker-clang@ubuntu failed

Test docker-mingw@fedora failed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190429090842.57910-1-vsementsov@virtuozzo.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>, Max Reitz <mreitz@redhat.com>

block/backup.c | 243 +++++++++++++++++++++----------------------------
1 file changed, 105 insertions(+), 138 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v7 0/5] backup-top: preparing refactoring

Posted by Vladimir Sementsov-Ogievskiy 5 years ago

Hi all!

Here some refactoring patches, as a first step for backup-top filter
introduction.

v7:
01,03,04: add Max's r-b
05: fix s/return NULL/goto error/ [Max]

v6:
01: - use end_cluster instead of last_cluster and fix bug in
      calculation [Max]
02: only rebased on 01, keep r-b
03, 04: new
05: it's rewritten
    "[PATCH v5 10/11] block/backup: tiny refactor backup_job_create",
    to make it more useful in general than just code movement inside
    one function

Vladimir Sementsov-Ogievskiy (5):
  block/backup: simplify backup_incremental_init_copy_bitmap
  block/backup: move to copy_bitmap with granularity
  block/backup: refactor and tolerate unallocated cluster skipping
  block/backup: unify different modes code path
  block/backup: refactor: split out backup_calculate_cluster_size

 block/backup.c | 243 +++++++++++++++++++++----------------------------
 1 file changed, 105 insertions(+), 138 deletions(-)

-- 
2.18.0

Re: [Qemu-devel] [PATCH v7 0/5] backup-top: preparing refactoring

Posted by Max Reitz 4 years, 11 months ago

On 29.04.19 11:08, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> Here some refactoring patches, as a first step for backup-top filter
> introduction.
> 
> v7:
> 01,03,04: add Max's r-b
> 05: fix s/return NULL/goto error/ [Max]
> 
> v6:
> 01: - use end_cluster instead of last_cluster and fix bug in
>       calculation [Max]
> 02: only rebased on 01, keep r-b
> 03, 04: new
> 05: it's rewritten
>     "[PATCH v5 10/11] block/backup: tiny refactor backup_job_create",
>     to make it more useful in general than just code movement inside
>     one function
> 
> Vladimir Sementsov-Ogievskiy (5):
>   block/backup: simplify backup_incremental_init_copy_bitmap
>   block/backup: move to copy_bitmap with granularity
>   block/backup: refactor and tolerate unallocated cluster skipping
>   block/backup: unify different modes code path
>   block/backup: refactor: split out backup_calculate_cluster_size
> 
>  block/backup.c | 243 +++++++++++++++++++++----------------------------
>  1 file changed, 105 insertions(+), 138 deletions(-)

Thanks, I’ve fixed patch 5’s commit message and applied the series to my
block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max