hw/dma: Compile the bcm2835_dma device as common object

[Qemu-devel] [PATCH] hw/dma: Compile the bcm2835_dma device as common object

Philippe Mathieu-Daudé posted 1 patch 5 years ago

Download mbox

Test checkpatch passed

Test asan passed

Test docker-clang@ubuntu passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190427133028.12874-1-philmd@redhat.com

hw/dma/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] hw/dma: Compile the bcm2835_dma device as common object

Posted by Philippe Mathieu-Daudé 5 years ago

This device is used by both ARM (BCM2836, for raspi2) and AArch64
(BCM2837, for raspi3) targets, and is not CPU-specific.
Move it to common object, so we build it once for all targets.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/dma/Makefile.objs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/dma/Makefile.objs b/hw/dma/Makefile.objs
index 79affecc390..8b39f9c6004 100644
--- a/hw/dma/Makefile.objs
+++ b/hw/dma/Makefile.objs
@@ -14,4 +14,4 @@ common-obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx-zdma.o
 
 obj-$(CONFIG_OMAP) += omap_dma.o soc_dma.o
 obj-$(CONFIG_PXA2XX) += pxa2xx_dma.o
-obj-$(CONFIG_RASPI) += bcm2835_dma.o
+common-obj-$(CONFIG_RASPI) += bcm2835_dma.o
-- 
2.20.1

Re: [Qemu-devel] [PATCH] hw/dma: Compile the bcm2835_dma device as common object

Posted by Peter Maydell 5 years ago

On Sat, 27 Apr 2019 at 14:30, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> This device is used by both ARM (BCM2836, for raspi2) and AArch64
> (BCM2837, for raspi3) targets, and is not CPU-specific.
> Move it to common object, so we build it once for all targets.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/dma/Makefile.objs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/dma/Makefile.objs b/hw/dma/Makefile.objs
> index 79affecc390..8b39f9c6004 100644
> --- a/hw/dma/Makefile.objs
> +++ b/hw/dma/Makefile.objs
> @@ -14,4 +14,4 @@ common-obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx-zdma.o
>
>  obj-$(CONFIG_OMAP) += omap_dma.o soc_dma.o
>  obj-$(CONFIG_PXA2XX) += pxa2xx_dma.o
> -obj-$(CONFIG_RASPI) += bcm2835_dma.o
> +common-obj-$(CONFIG_RASPI) += bcm2835_dma.o




Applied to target-arm.next, thanks.

-- PMM