trace: fix runstate tracing

[Qemu-devel] [PATCH] trace: fix runstate tracing

Yury Kotov posted 1 patch 5 years ago

Download mbox

Test checkpatch passed

Test asan passed

Test docker-clang@ubuntu passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190426102115.30002-1-yury-kotov@yandex-team.ru

Maintainers: Paolo Bonzini <pbonzini@redhat.com>

vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] trace: fix runstate tracing

Posted by Yury Kotov 5 years ago

Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>
---
 vl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vl.c b/vl.c
index ff5dfb6fbc..ad9b181e57 100644
--- a/vl.c
+++ b/vl.c
@@ -725,7 +725,7 @@ void runstate_set(RunState new_state)
     assert(new_state < RUN_STATE__MAX);
 
     trace_runstate_set(current_run_state, RunState_str(current_run_state),
-                       new_state, RunState_str(current_run_state));
+                       new_state, RunState_str(new_state));
 
     if (current_run_state == new_state) {
         return;
-- 
2.21.0

Re: [Qemu-devel] [PATCH] trace: fix runstate tracing

Posted by Vladimir Sementsov-Ogievskiy 5 years ago

Oops, my fault, sorry:( Thank you for fixing!

May be added, that it is broken since ff12e3ae3d0.

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

26.04.2019 13:21, Yury Kotov wrote:
> Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>
> ---
>   vl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/vl.c b/vl.c
> index ff5dfb6fbc..ad9b181e57 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -725,7 +725,7 @@ void runstate_set(RunState new_state)
>       assert(new_state < RUN_STATE__MAX);
>   
>       trace_runstate_set(current_run_state, RunState_str(current_run_state),
> -                       new_state, RunState_str(current_run_state));
> +                       new_state, RunState_str(new_state));
>   
>       if (current_run_state == new_state) {
>           return;
> 


-- 
Best regards,
Vladimir

Re: [Qemu-devel] [PATCH] trace: fix runstate tracing

Posted by Stefan Hajnoczi 5 years ago

On Fri, Apr 26, 2019 at 01:21:15PM +0300, Yury Kotov wrote:
> Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>
> ---
>  vl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan