[Qemu-devel] [PATCH] memory: correct the comment to DIRTY_MEMORY_MIGRATION

Wei Yang posted 1 patch 5 years ago
Test checkpatch passed
Test asan passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190426020927.25470-1-richardw.yang@linux.intel.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>
memory.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[Qemu-devel] [PATCH] memory: correct the comment to DIRTY_MEMORY_MIGRATION
Posted by Wei Yang 5 years ago
The dirty bit is DIRTY_MEMORY_MIGRATION. Correct the comment.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 memory.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/memory.c b/memory.c
index e49369d85d..9d015bfe4c 100644
--- a/memory.c
+++ b/memory.c
@@ -2576,7 +2576,7 @@ void memory_global_dirty_log_start(void)
 
     MEMORY_LISTENER_CALL_GLOBAL(log_global_start, Forward);
 
-    /* Refresh DIRTY_LOG_MIGRATION bit.  */
+    /* Refresh DIRTY_MEMORY_MIGRATION bit.  */
     memory_region_transaction_begin();
     memory_region_update_pending = true;
     memory_region_transaction_commit();
@@ -2586,7 +2586,7 @@ static void memory_global_dirty_log_do_stop(void)
 {
     global_dirty_log = false;
 
-    /* Refresh DIRTY_LOG_MIGRATION bit.  */
+    /* Refresh DIRTY_MEMORY_MIGRATION bit.  */
     memory_region_transaction_begin();
     memory_region_update_pending = true;
     memory_region_transaction_commit();
-- 
2.19.1


Re: [Qemu-devel] [PATCH] memory: correct the comment to DIRTY_MEMORY_MIGRATION
Posted by Paolo Bonzini 5 years ago
On 26/04/19 04:09, Wei Yang wrote:
> The dirty bit is DIRTY_MEMORY_MIGRATION. Correct the comment.
> 
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
>  memory.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/memory.c b/memory.c
> index e49369d85d..9d015bfe4c 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -2576,7 +2576,7 @@ void memory_global_dirty_log_start(void)
>  
>      MEMORY_LISTENER_CALL_GLOBAL(log_global_start, Forward);
>  
> -    /* Refresh DIRTY_LOG_MIGRATION bit.  */
> +    /* Refresh DIRTY_MEMORY_MIGRATION bit.  */
>      memory_region_transaction_begin();
>      memory_region_update_pending = true;
>      memory_region_transaction_commit();
> @@ -2586,7 +2586,7 @@ static void memory_global_dirty_log_do_stop(void)
>  {
>      global_dirty_log = false;
>  
> -    /* Refresh DIRTY_LOG_MIGRATION bit.  */
> +    /* Refresh DIRTY_MEMORY_MIGRATION bit.  */
>      memory_region_transaction_begin();
>      memory_region_update_pending = true;
>      memory_region_transaction_commit();
> 

Queued, thanks.

Paolo