[Qemu-devel] [PATCH] gitmodules: use qemu.org git mirrors

Stefan Hajnoczi posted 1 patch 6 years, 6 months ago
Test checkpatch passed
Test asan passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190425125650.28846-1-stefanha@redhat.com
There is a newer version of this series
.gitmodules | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
[Qemu-devel] [PATCH] gitmodules: use qemu.org git mirrors
Posted by Stefan Hajnoczi 6 years, 6 months ago
qemu.org hosts git repository mirrors of all submodules.  Update
.gitmodules to use the mirrors and not the upstream repositories.

Mirroring upstream repositories ensures that QEMU continues to build
even when upstream repositories are deleted or temporarily offline.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
Based-on: <20190424110041.8175-1-marcandre.lureau@redhat.com>
          "[PATCH v2 0/2] slirp: move slirp as git submodule project"

Peter: Please apply Marc-André's series.  I have set up the necessary
mirrors and this patch will fix up the libsirp URL as well as the
other URLs.

 .gitmodules | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/.gitmodules b/.gitmodules
index aa77ce6f50..84b260031c 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -39,19 +39,19 @@
 	url = https://git.qemu.org/git/capstone.git
 [submodule "roms/seabios-hppa"]
 	path = roms/seabios-hppa
-	url = https://github.com/hdeller/seabios-hppa.git
+	url = https://git.qemu.org/git/seabios-hppa.git
 [submodule "roms/u-boot-sam460ex"]
 	path = roms/u-boot-sam460ex
 	url = https://git.qemu.org/git/u-boot-sam460ex.git
 [submodule "tests/fp/berkeley-testfloat-3"]
 	path = tests/fp/berkeley-testfloat-3
-	url = https://github.com/cota/berkeley-testfloat-3
+	url = https://git.qemu.org/git/berkeley-testfloat-3.git
 [submodule "tests/fp/berkeley-softfloat-3"]
 	path = tests/fp/berkeley-softfloat-3
-	url = https://github.com/cota/berkeley-softfloat-3
+	url = https://git.qemu.org/git/berkeley-softfloat-3.git
 [submodule "roms/edk2"]
 	path = roms/edk2
-	url = https://github.com/tianocore/edk2.git
+	url = https://git.qemu.org/git/tianocore/edk2.git
 [submodule "slirp"]
 	path = slirp
-	url = https://gitlab.freedesktop.org/slirp/libslirp.git
+	url = https://git.qemu.org/git/libslirp.git
-- 
2.20.1


Re: [Qemu-devel] [PATCH] gitmodules: use qemu.org git mirrors
Posted by Philippe Mathieu-Daudé 6 years, 6 months ago
Hi Stefan,

On 4/25/19 2:56 PM, Stefan Hajnoczi wrote:
> qemu.org hosts git repository mirrors of all submodules.  Update
> .gitmodules to use the mirrors and not the upstream repositories.
> 
> Mirroring upstream repositories ensures that QEMU continues to build
> even when upstream repositories are deleted or temporarily offline.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> Based-on: <20190424110041.8175-1-marcandre.lureau@redhat.com>
>           "[PATCH v2 0/2] slirp: move slirp as git submodule project"
> 
> Peter: Please apply Marc-André's series.  I have set up the necessary
> mirrors and this patch will fix up the libsirp URL as well as the
> other URLs.
> 
>  .gitmodules | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/.gitmodules b/.gitmodules
> index aa77ce6f50..84b260031c 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -39,19 +39,19 @@
>  	url = https://git.qemu.org/git/capstone.git
>  [submodule "roms/seabios-hppa"]
>  	path = roms/seabios-hppa
> -	url = https://github.com/hdeller/seabios-hppa.git
> +	url = https://git.qemu.org/git/seabios-hppa.git
>  [submodule "roms/u-boot-sam460ex"]
>  	path = roms/u-boot-sam460ex
>  	url = https://git.qemu.org/git/u-boot-sam460ex.git
>  [submodule "tests/fp/berkeley-testfloat-3"]
>  	path = tests/fp/berkeley-testfloat-3
> -	url = https://github.com/cota/berkeley-testfloat-3
> +	url = https://git.qemu.org/git/berkeley-testfloat-3.git
>  [submodule "tests/fp/berkeley-softfloat-3"]
>  	path = tests/fp/berkeley-softfloat-3
> -	url = https://github.com/cota/berkeley-softfloat-3
> +	url = https://git.qemu.org/git/berkeley-softfloat-3.git
>  [submodule "roms/edk2"]
>  	path = roms/edk2
> -	url = https://github.com/tianocore/edk2.git
> +	url = https://git.qemu.org/git/tianocore/edk2.git

I'm getting:

Entering 'roms/edk2'
fatal: repository 'https://git.qemu.org/git/tianocore/edk2.git/' not found

OK, got it, the correct URL is https://git.qemu.org/git/edk2.git
(without 'tianocore')

With the URL or the path locally updated:

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

>  [submodule "slirp"]
>  	path = slirp
> -	url = https://gitlab.freedesktop.org/slirp/libslirp.git
> +	url = https://git.qemu.org/git/libslirp.git
> 

Re: [Qemu-devel] [PATCH] gitmodules: use qemu.org git mirrors
Posted by Stefan Hajnoczi 6 years, 6 months ago
On Thu, Apr 25, 2019 at 03:14:29PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Stefan,
> 
> On 4/25/19 2:56 PM, Stefan Hajnoczi wrote:
> > qemu.org hosts git repository mirrors of all submodules.  Update
> > .gitmodules to use the mirrors and not the upstream repositories.
> > 
> > Mirroring upstream repositories ensures that QEMU continues to build
> > even when upstream repositories are deleted or temporarily offline.
> > 
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > Based-on: <20190424110041.8175-1-marcandre.lureau@redhat.com>
> >           "[PATCH v2 0/2] slirp: move slirp as git submodule project"
> > 
> > Peter: Please apply Marc-André's series.  I have set up the necessary
> > mirrors and this patch will fix up the libsirp URL as well as the
> > other URLs.
> > 
> >  .gitmodules | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/.gitmodules b/.gitmodules
> > index aa77ce6f50..84b260031c 100644
> > --- a/.gitmodules
> > +++ b/.gitmodules
> > @@ -39,19 +39,19 @@
> >  	url = https://git.qemu.org/git/capstone.git
> >  [submodule "roms/seabios-hppa"]
> >  	path = roms/seabios-hppa
> > -	url = https://github.com/hdeller/seabios-hppa.git
> > +	url = https://git.qemu.org/git/seabios-hppa.git
> >  [submodule "roms/u-boot-sam460ex"]
> >  	path = roms/u-boot-sam460ex
> >  	url = https://git.qemu.org/git/u-boot-sam460ex.git
> >  [submodule "tests/fp/berkeley-testfloat-3"]
> >  	path = tests/fp/berkeley-testfloat-3
> > -	url = https://github.com/cota/berkeley-testfloat-3
> > +	url = https://git.qemu.org/git/berkeley-testfloat-3.git
> >  [submodule "tests/fp/berkeley-softfloat-3"]
> >  	path = tests/fp/berkeley-softfloat-3
> > -	url = https://github.com/cota/berkeley-softfloat-3
> > +	url = https://git.qemu.org/git/berkeley-softfloat-3.git
> >  [submodule "roms/edk2"]
> >  	path = roms/edk2
> > -	url = https://github.com/tianocore/edk2.git
> > +	url = https://git.qemu.org/git/tianocore/edk2.git
> 
> I'm getting:
> 
> Entering 'roms/edk2'
> fatal: repository 'https://git.qemu.org/git/tianocore/edk2.git/' not found
> 
> OK, got it, the correct URL is https://git.qemu.org/git/edk2.git
> (without 'tianocore')
> 
> With the URL or the path locally updated:
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Doh, I should have run "git submodule update --init" in addition to
./configure && make.

Will fix in v2.

Stefan