fw_cfg: Improve tracing

[Qemu-devel] [PATCH v3 0/7] fw_cfg: Improve tracing

Philippe Mathieu-Daudé posted 7 patches 4 years, 12 months ago

Download series mbox

Test checkpatch passed

Test asan passed

Test docker-clang@ubuntu passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190422195020.1494-1-philmd@redhat.com

Maintainers: Laszlo Ersek <lersek@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Artyom Tarasenko <atar4qemu@gmail.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Richard Henderson <rth@twiddle.net>, Gerd Hoffmann <kraxel@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

MAINTAINERS               |  1 +
hw/i386/Makefile.objs     |  2 +-
hw/i386/fw_cfg.c          | 38 +++++++++++++++++++++++
hw/i386/fw_cfg.h          | 20 +++++++++++++
hw/i386/pc.c              |  7 +----
hw/nvram/fw_cfg.c         | 63 ++++++++++++++++++++++++++++++++++++++-
hw/nvram/trace-events     |  7 ++++-
hw/ppc/Makefile.objs      |  2 +-
hw/ppc/fw_cfg.c           | 45 ++++++++++++++++++++++++++++
hw/sparc/sun4m.c          | 19 ++++++++++++
hw/sparc64/sun4u.c        | 19 ++++++++++++
include/hw/nvram/fw_cfg.h | 11 +++++++
stubs/Makefile.objs       |  1 +
stubs/fw_cfg.c            | 21 +++++++++++++
14 files changed, 246 insertions(+), 10 deletions(-)
create mode 100644 hw/i386/fw_cfg.c
create mode 100644 hw/i386/fw_cfg.h
create mode 100644 hw/ppc/fw_cfg.c
create mode 100644 stubs/fw_cfg.c

Expand all Fold all

[Qemu-devel] [PATCH v3 0/7] fw_cfg: Improve tracing

Posted by Philippe Mathieu-Daudé 4 years, 12 months ago

Trivial series to improve fw_cfg tracing.

Regards,

Phil.

Since v2: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02522.html
- Split arch-specific code (1 patch per arch) (requested by Laszlo)

Since v1: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01598.html
- Added arch-specific keys

Philippe Mathieu-Daudé (7):
  hw/nvram/fw_cfg: Add trace events
  hw/nvram/fw_cfg: Add fw_cfg_arch_key_name()
  hw/i386: Extract fw_cfg definitions to local "fw_cfg.h"
  hw/i386: Implement fw_cfg_arch_key_name()
  hw/ppc: Implement fw_cfg_arch_key_name()
  hw/sparc: Implement fw_cfg_arch_key_name()
  hw/sparc64: Implement fw_cfg_arch_key_name()

 MAINTAINERS               |  1 +
 hw/i386/Makefile.objs     |  2 +-
 hw/i386/fw_cfg.c          | 38 +++++++++++++++++++++++
 hw/i386/fw_cfg.h          | 20 +++++++++++++
 hw/i386/pc.c              |  7 +----
 hw/nvram/fw_cfg.c         | 63 ++++++++++++++++++++++++++++++++++++++-
 hw/nvram/trace-events     |  7 ++++-
 hw/ppc/Makefile.objs      |  2 +-
 hw/ppc/fw_cfg.c           | 45 ++++++++++++++++++++++++++++
 hw/sparc/sun4m.c          | 19 ++++++++++++
 hw/sparc64/sun4u.c        | 19 ++++++++++++
 include/hw/nvram/fw_cfg.h | 11 +++++++
 stubs/Makefile.objs       |  1 +
 stubs/fw_cfg.c            | 21 +++++++++++++
 14 files changed, 246 insertions(+), 10 deletions(-)
 create mode 100644 hw/i386/fw_cfg.c
 create mode 100644 hw/i386/fw_cfg.h
 create mode 100644 hw/ppc/fw_cfg.c
 create mode 100644 stubs/fw_cfg.c

-- 
2.20.1

Re: [Qemu-devel] [PATCH v3 0/7] fw_cfg: Improve tracing

Posted by Philippe Mathieu-Daudé 4 years, 11 months ago

On 4/22/19 9:50 PM, Philippe Mathieu-Daudé wrote:
> Trivial series to improve fw_cfg tracing.
> 
> Regards,
> 
> Phil.
> 
> Since v2: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02522.html
> - Split arch-specific code (1 patch per arch) (requested by Laszlo)
> 
> Since v1: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01598.html
> - Added arch-specific keys
> 
> Philippe Mathieu-Daudé (7):
>   hw/nvram/fw_cfg: Add trace events
>   hw/nvram/fw_cfg: Add fw_cfg_arch_key_name()
>   hw/i386: Extract fw_cfg definitions to local "fw_cfg.h"
>   hw/i386: Implement fw_cfg_arch_key_name()
>   hw/ppc: Implement fw_cfg_arch_key_name()
>   hw/sparc: Implement fw_cfg_arch_key_name()
>   hw/sparc64: Implement fw_cfg_arch_key_name()

Queued, fixing the typo reported by Laszlo, documenting the PPC uses.