[v2] HPPA fixes for NetBSD/hppa emulation

[Qemu-devel] [PATCH v2 0/2] HPPA fixes for NetBSD/hppa emulation

Nick Hudson posted 2 patches 4 years, 12 months ago

Diff against v1 v3
Download series mbox

Test checkpatch failed

Test asan passed

Test docker-clang@ubuntu passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190422123411.5178-1-nick.hudson@gmx.co.uk

Maintainers: Richard Henderson <rth@twiddle.net>

There is a newer version of this series

target/hppa/insns.decode |  3 +++
target/hppa/mem_helper.c |  3 +--
target/hppa/translate.c  | 52 ++++++++++++++++++++++++++++++++++++++++
3 files changed, 56 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/2] HPPA fixes for NetBSD/hppa emulation

Posted by Nick Hudson 4 years, 12 months ago

From: Nick Hudson <skrll@netbsd.org>

Here are the required changes to allow qemu to emulate NetBSD/hppa.

v2 changes:
 - remove old debug code

Nick Hudson (2):
  Implement the pcxl and pcxl2 Fast TLB Insert instructions as used by
    NetBSD (and OpenBSD)
  Always return EXCP_DMAR for protection id trap as EXCP_DMP is
    considered legacy.

 target/hppa/insns.decode |  3 +++
 target/hppa/mem_helper.c |  3 +--
 target/hppa/translate.c  | 52 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 56 insertions(+), 2 deletions(-)

--
2.17.1

Re: [Qemu-devel] [PATCH v2 0/2] HPPA fixes for NetBSD/hppa emulation

Posted by no-reply@patchew.org 4 years, 12 months ago

Patchew URL: https://patchew.org/QEMU/20190422123411.5178-1-nick.hudson@gmx.co.uk/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190422123411.5178-1-nick.hudson@gmx.co.uk
Subject: [Qemu-devel] [PATCH v2 0/2] HPPA fixes for NetBSD/hppa emulation

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190422123411.5178-1-nick.hudson@gmx.co.uk -> patchew/20190422123411.5178-1-nick.hudson@gmx.co.uk
Switched to a new branch 'test'
a6b41a65f4 Always return EXCP_DMAR for protection id trap as EXCP_DMP is considered legacy.
5894d61641 Implement the pcxl and pcxl2 Fast TLB Insert instructions as used by NetBSD (and OpenBSD)

=== OUTPUT BEGIN ===
1/2 Checking commit 5894d6164109 (Implement the pcxl and pcxl2 Fast TLB Insert instructions as used by NetBSD (and OpenBSD))
WARNING: Block comments use a leading /* on a separate line
#36: FILE: target/hppa/translate.c:2521:
+/* Implement the pcxl and pcxl2 Fast TLB Insert instructions.

WARNING: Block comments use a trailing */ on a separate line
#39: FILE: target/hppa/translate.c:2524:
+ *     page 13-9 (195/206) */

ERROR: do not use C99 // comments
#51: FILE: target/hppa/translate.c:2536:
+//    if (not (pcx or pcxl2))

ERROR: do not use C99 // comments
#52: FILE: target/hppa/translate.c:2537:
+//        return gen_illegal(ctx);

total: 2 errors, 2 warnings, 67 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit a6b41a65f4d3 (Always return EXCP_DMAR for protection id trap as EXCP_DMP is considered legacy.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190422123411.5178-1-nick.hudson@gmx.co.uk/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com