[v2] Fix overflow bug in qcow2 discard

[Qemu-devel] [PATCH v2 0/3] Fix overflow bug in qcow2 discard

Vladimir Sementsov-Ogievskiy posted 3 patches 5 years ago

Diff against v1 v3 v4 v5
Download series mbox

Test checkpatch passed

Test asan passed

Test docker-clang@ubuntu passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190419135142.91810-1-vsementsov@virtuozzo.com

Maintainers: Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>

There is a newer version of this series

include/block/block.h      |  4 +--
block/io.c                 | 16 ++++-----
block/qcow2-refcount.c     |  7 +++-
block/trace-events         |  3 ++
tests/qemu-iotests/250     | 72 ++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/250.out | 21 +++++++++++
tests/qemu-iotests/group   |  1 +
7 files changed, 113 insertions(+), 11 deletions(-)
create mode 100755 tests/qemu-iotests/250
create mode 100644 tests/qemu-iotests/250.out

Expand all Fold all

[Qemu-devel] [PATCH v2 0/3] Fix overflow bug in qcow2 discard

Posted by Vladimir Sementsov-Ogievskiy 5 years ago

v2: [mostly by Eric's review]
01: new
02: point to bug introducing commit in cover letter [Eric]
     [but I failed to compile it, to check]
    drop s/INT_MAX/BDRV_REQUEST_MAX_BYTES/ chunk
03: - improve wording
    - cheating with preallocation=metadata and discards
      to make test quick and not eating disk space
    - use new trace-point
    - move it to be 250 iotest
    - filter out extra qemu-img info output

Vladimir Sementsov-Ogievskiy (3):
  block/qcow2-refcount: add trace-point to qcow2_process_discards
  block/io: bdrv_pdiscard: support int64_t bytes parameter
  iotests: test big qcow2 shrink

 include/block/block.h      |  4 +--
 block/io.c                 | 16 ++++-----
 block/qcow2-refcount.c     |  7 +++-
 block/trace-events         |  3 ++
 tests/qemu-iotests/250     | 72 ++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/250.out | 21 +++++++++++
 tests/qemu-iotests/group   |  1 +
 7 files changed, 113 insertions(+), 11 deletions(-)
 create mode 100755 tests/qemu-iotests/250
 create mode 100644 tests/qemu-iotests/250.out

-- 
2.18.0