Memory fixes for slirp tcp_emu()

[Qemu-devel] [PATCH 0/2] Memory fixes for slirp tcp_emu()

Posted by Marc-André Lureau 5 years ago

Hi,

See the following 2 patches fixing some memory issues in
tcp_emu(). Those are not regressions, consider it for 4.1.

Marc-André Lureau (2):
  slirp: ensure there is enough space in mbuf to null-terminate
  slirp: don't manipulate so_rcv in tcp_emu()

 slirp/src/tcp_subr.c | 27 +++++++--------------------
 1 file changed, 7 insertions(+), 20 deletions(-)

-- 
2.21.0.313.ge35b8cb8e2

Re: [Qemu-devel] [PATCH 0/2] Memory fixes for slirp tcp_emu()

Posted by no-reply@patchew.org 5 years ago

Patchew URL: https://patchew.org/QEMU/20190418125908.11928-1-marcandre.lureau@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/2] Memory fixes for slirp tcp_emu()
Type: series
Message-id: 20190418125908.11928-1-marcandre.lureau@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
7c6d6d0 slirp: don't manipulate so_rcv in tcp_emu()
84d8e3e slirp: ensure there is enough space in mbuf to null-terminate

=== OUTPUT BEGIN ===
1/2 Checking commit 84d8e3ea687d (slirp: ensure there is enough space in mbuf to null-terminate)
ERROR: code indent should never use tabs
#22: FILE: slirp/src/tcp_subr.c:647:
+^I^I^Im_inc(m, m->m_len + 1);$

ERROR: code indent should never use tabs
#38: FILE: slirp/src/tcp_subr.c:779:
+^I^Im_inc(m, m->m_len + 1);$

total: 2 errors, 0 warnings, 21 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit 7c6d6d0e8c68 (slirp: don't manipulate so_rcv in tcp_emu())
ERROR: code indent should never use tabs
#47: FILE: slirp/src/tcp_subr.c:638:
+^I^I^Iif (g_strstr_len(m->m_data, m->m_len, "\r\n")$

WARNING: line over 80 characters
#48: FILE: slirp/src/tcp_subr.c:639:
+                               && sscanf(m->m_data, "%u%*[ ,]%u\r\n", &n1, &n2) == 2) {

ERROR: code indent should never use tabs
#48: FILE: slirp/src/tcp_subr.c:639:
+^I^I^I^I&& sscanf(m->m_data, "%u%*[ ,]%u\r\n", &n1, &n2) == 2) {$

WARNING: line over 80 characters
#61: FILE: slirp/src/tcp_subr.c:658:
+                                       m->m_len = snprintf(m->m_data, m->m_size,

ERROR: code indent should never use tabs
#61: FILE: slirp/src/tcp_subr.c:658:
+^I^I^I^I^Im->m_len = snprintf(m->m_data, m->m_size,$

ERROR: line over 90 characters
#62: FILE: slirp/src/tcp_subr.c:659:
+                                                                               "%d,%d\r\n", n1, n2);

ERROR: code indent should never use tabs
#62: FILE: slirp/src/tcp_subr.c:659:
+^I^I^I^I^I^I^I^I^I^I"%d,%d\r\n", n1, n2);$

ERROR: code indent should never use tabs
#67: FILE: slirp/src/tcp_subr.c:661:
+^I^I^Ireturn 1;$

total: 6 errors, 2 warnings, 40 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190418125908.11928-1-marcandre.lureau@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com