1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function

Markus Armbruster posted 17 patches 5 years ago
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test checkpatch failed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190417191805.28198-1-armbru@redhat.com
Maintainers: David Hildenbrand <david@redhat.com>, Aleksandar Markovic <amarkovic@wavecomp.com>, Stefan Weil <sw@weilnetz.de>, Laurent Vivier <laurent@vivier.eu>, Kevin Wolf <kwolf@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Markus Armbruster <armbru@redhat.com>, Aleksandar Rikalo <arikalo@wavecomp.com>, Palmer Dabbelt <palmer@sifive.com>, Max Reitz <mreitz@redhat.com>, Riku Voipio <riku.voipio@iki.fi>, Eduardo Habkost <ehabkost@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Paolo Bonzini <pbonzini@redhat.com>, Anthony Green <green@moxielogic.com>, David Gibson <david@gibson.dropbear.id.au>, Cornelia Huck <cohuck@redhat.com>, Stafford Horne <shorne@gmail.com>, Richard Henderson <rth@twiddle.net>, Sagar Karandikar <sagark@eecs.berkeley.edu>, Peter Maydell <peter.maydell@linaro.org>, Chris Wulff <crwulff@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, Michael Walle <michael@walle.cc>, Claudio Fontana <claudio.fontana@huawei.com>, Marek Vasut <marex@denx.de>, Stefan Hajnoczi <stefanha@redhat.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Alistair Francis <Alistair.Francis@wdc.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Aurelien Jarno <aurelien@aurel32.net>, Artyom Tarasenko <atar4qemu@gmail.com>, Andrzej Zaborowski <balrogg@gmail.com>
accel/kvm/kvm-all.c                |   4 +-
accel/tcg/translate-all.c          |  49 ++--
block/qapi.c                       | 120 +++++-----
bsd-user/main.c                    |   4 +-
cpus.c                             |  21 +-
disas.c                            |   5 +-
disas/alpha.c                      |   2 +-
disas/arm-a64.cc                   |   2 +-
disas/arm.c                        |   2 +-
disas/cris.c                       |   2 +-
disas/hppa.c                       |   2 +-
disas/i386.c                       |   2 +-
disas/lm32.c                       |   2 +-
disas/m68k.c                       |   2 +-
disas/microblaze.c                 |   2 +-
disas/mips.c                       |   2 +-
disas/moxie.c                      |   2 +-
disas/nanomips.cpp                 |   2 +-
disas/nios2.c                      |   2 +-
disas/ppc.c                        |   2 +-
disas/riscv.c                      |   2 +-
disas/s390.c                       |   2 +-
disas/sh4.c                        |   2 +-
disas/sparc.c                      |   2 +-
disas/tci.c                        |   2 +-
disas/xtensa.c                     |   2 +-
exec.c                             |  42 ++--
hmp.c                              |  12 +-
include/block/qapi.h               |   9 +-
include/disas/{bfd.h => dis-asm.h} |   5 +-
include/exec/cpu-all.h             |   4 +-
include/exec/cpu-common.h          |  13 --
include/exec/log.h                 |   2 +-
include/exec/memory-internal.h     |   3 +-
include/exec/memory.h              |   3 +-
include/monitor/monitor.h          |   1 -
include/qemu-common.h              |   2 -
include/qemu/cutils.h              |   2 -
include/qemu/fprintf-fn.h          |  14 --
include/qemu/qemu-print.h          |   4 +
include/qemu/qsp.h                 |   6 +-
include/qom/cpu.h                  |  24 +-
include/sysemu/cpus.h              |   4 +-
linux-user/alpha/cpu_loop.c        |   2 +-
linux-user/cpu_loop-common.h       |   2 +-
linux-user/cris/cpu_loop.c         |   2 +-
linux-user/main.c                  |   2 +-
linux-user/microblaze/cpu_loop.c   |   4 +-
linux-user/s390x/cpu_loop.c        |   4 +-
linux-user/sh4/cpu_loop.c          |   2 +-
linux-user/sparc/cpu_loop.c        |   2 +-
memory.c                           | 156 ++++++-------
monitor.c                          |  30 +--
qemu-img.c                         |   6 +-
qemu-io-cmds.c                     |   2 +-
qom/cpu.c                          |  11 +-
target/alpha/cpu.c                 |  15 +-
target/alpha/cpu.h                 |   5 +-
target/alpha/helper.c              |  24 +-
target/arm/arm-semi.c              |   2 +-
target/arm/cpu.c                   |   1 -
target/arm/cpu.h                   |   5 +-
target/arm/helper.c                |  15 +-
target/arm/translate-a64.c         |  82 +++----
target/arm/translate.c             |  58 ++---
target/arm/translate.h             |   7 +-
target/cris/cpu.c                  |  14 +-
target/cris/cpu.h                  |   5 +-
target/cris/helper.c               |   2 +-
target/cris/translate.c            |  36 +--
target/hppa/cpu.c                  |  14 +-
target/hppa/cpu.h                  |   4 +-
target/hppa/helper.c               |  24 +-
target/i386/cpu.c                  |  29 +--
target/i386/cpu.h                  |   8 +-
target/i386/hax-all.c              |   4 +-
target/i386/helper.c               | 356 ++++++++++++++---------------
target/i386/monitor.c              |   3 +-
target/lm32/cpu.c                  |  14 +-
target/lm32/cpu.h                  |   5 +-
target/lm32/translate.c            |  36 +--
target/m68k/cpu.h                  |   8 +-
target/m68k/helper.c               | 129 +++++------
target/m68k/monitor.c              |   2 +-
target/m68k/translate.c            |  86 +++----
target/microblaze/cpu.h            |   3 +-
target/microblaze/helper.c         |   2 +-
target/microblaze/translate.c      |  39 ++--
target/mips/cpu.h                  |   2 +-
target/mips/internal.h             |   3 +-
target/mips/translate.c            |  77 ++++---
target/mips/translate_init.inc.c   |   5 +-
target/moxie/cpu.h                 |   3 +-
target/moxie/helper.c              |   2 +-
target/moxie/translate.c           |  22 +-
target/nios2/cpu.h                 |   5 +-
target/nios2/helper.c              |   2 +-
target/nios2/mmu.c                 |   7 +-
target/nios2/monitor.c             |   2 +-
target/nios2/translate.c           |  24 +-
target/openrisc/cpu.c              |  15 +-
target/openrisc/cpu.h              |   5 +-
target/openrisc/disas.c            |   2 +-
target/openrisc/translate.c        |  11 +-
target/ppc/cpu.h                   |  10 +-
target/ppc/mmu-hash64.c            |   7 +-
target/ppc/mmu-hash64.h            |   2 +-
target/ppc/mmu_helper.c            |  70 +++---
target/ppc/monitor.c               |   2 +-
target/ppc/translate.c             | 170 +++++++-------
target/ppc/translate_init.inc.c    |  28 +--
target/riscv/cpu.c                 |  54 ++---
target/riscv/cpu.h                 |   2 +-
target/s390x/cpu.h                 |   2 +-
target/s390x/cpu_models.c          |  21 +-
target/s390x/helper.c              |  42 ++--
target/s390x/internal.h            |   3 +-
target/sh4/cpu.c                   |  17 +-
target/sh4/cpu.h                   |   5 +-
target/sh4/translate.c             |  27 +--
target/sparc/cpu.c                 | 133 ++++++-----
target/sparc/cpu.h                 |   7 +-
target/sparc/ldst_helper.c         |  18 +-
target/sparc/mmu_helper.c          |  97 ++++----
target/sparc/monitor.c             |   2 +-
target/tilegx/cpu.c                |  14 +-
target/tricore/cpu.h               |   5 +-
target/tricore/helper.c            |  15 +-
target/tricore/translate.c         |  26 +--
target/unicore32/cpu.h             |   3 +-
target/unicore32/translate.c       |  39 ++--
target/xtensa/cpu.h                |   7 +-
target/xtensa/helper.c             |   7 +-
target/xtensa/mmu_helper.c         |  24 +-
target/xtensa/monitor.c            |   2 +-
target/xtensa/translate.c          |  40 ++--
tcg/tcg.c                          |  50 ++--
tcg/tcg.h                          |   4 +-
trace/simple.c                     |   7 +-
trace/simple.h                     |   2 +-
util/qemu-print.c                  |  27 +++
util/qsp.c                         |  21 +-
vl.c                               |   2 +-
143 files changed, 1353 insertions(+), 1503 deletions(-)
rename include/disas/{bfd.h => dis-asm.h} (99%)
delete mode 100644 include/qemu/fprintf-fn.h
[Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Posted by Markus Armbruster 5 years ago 
We pass around fprintf_function callbacks together a FILE * argument.
Three cases:

* We pass fprintf() and stdout, stderr or qemu_log_file.  Okay.

* We pass monitor_fprintf() together with the current monitor cast to
  FILE *.  The type-punning is ugly.

* We pass monitor_printf() cast to fprintf_function together with the
  current monitor cast to FILE *.  Even uglier.

All but two instances can be replaced by using qemu_printf() directly
instead of printing through a callback.

One more can be replace by using new qemu_fprintf() directly.

The last one can use qemu_fprintf() to at least avoid the
type-punning.

Based-on: <20190417190641.26814-1-armbru@redhat.com>

v2:
* PATCH 08: Commit message pasto [Dave]
* PATCH 09: Commit message typo [Dave]
* PATCH 14: Drop spurious change to x86_cpu_dump_local_apic_state()
  [Dave]

Markus Armbruster (17):
  include: Include fprintf-fn.h only where needed
  trace: Simplify how st_print_trace_file_status() prints
  tcg: Simplify how dump_opcount_info() prints
  tcg: Simplify how dump_exec_info() prints
  tcg: Simplify how dump_drift_info() prints
  qsp: Simplify how qsp_report() prints
  block/qapi: Clean up how we print to monitor or stdout
  memory: Clean up how mtree_info() prints
  target: Simplify how the TARGET_cpu_list() print
  target: Clean up how the dump_mmu() print
  target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
  qom/cpu: Simplify how CPUClass::dump_statistics() prints
  qemu-print: New qemu_fprintf(), qemu_vfprintf()
  qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
  monitor: Clean up how monitor_disas() funnels output to monitor
  disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
  include: Move fprintf_function to disas/

 accel/kvm/kvm-all.c                |   4 +-
 accel/tcg/translate-all.c          |  49 ++--
 block/qapi.c                       | 120 +++++-----
 bsd-user/main.c                    |   4 +-
 cpus.c                             |  21 +-
 disas.c                            |   5 +-
 disas/alpha.c                      |   2 +-
 disas/arm-a64.cc                   |   2 +-
 disas/arm.c                        |   2 +-
 disas/cris.c                       |   2 +-
 disas/hppa.c                       |   2 +-
 disas/i386.c                       |   2 +-
 disas/lm32.c                       |   2 +-
 disas/m68k.c                       |   2 +-
 disas/microblaze.c                 |   2 +-
 disas/mips.c                       |   2 +-
 disas/moxie.c                      |   2 +-
 disas/nanomips.cpp                 |   2 +-
 disas/nios2.c                      |   2 +-
 disas/ppc.c                        |   2 +-
 disas/riscv.c                      |   2 +-
 disas/s390.c                       |   2 +-
 disas/sh4.c                        |   2 +-
 disas/sparc.c                      |   2 +-
 disas/tci.c                        |   2 +-
 disas/xtensa.c                     |   2 +-
 exec.c                             |  42 ++--
 hmp.c                              |  12 +-
 include/block/qapi.h               |   9 +-
 include/disas/{bfd.h => dis-asm.h} |   5 +-
 include/exec/cpu-all.h             |   4 +-
 include/exec/cpu-common.h          |  13 --
 include/exec/log.h                 |   2 +-
 include/exec/memory-internal.h     |   3 +-
 include/exec/memory.h              |   3 +-
 include/monitor/monitor.h          |   1 -
 include/qemu-common.h              |   2 -
 include/qemu/cutils.h              |   2 -
 include/qemu/fprintf-fn.h          |  14 --
 include/qemu/qemu-print.h          |   4 +
 include/qemu/qsp.h                 |   6 +-
 include/qom/cpu.h                  |  24 +-
 include/sysemu/cpus.h              |   4 +-
 linux-user/alpha/cpu_loop.c        |   2 +-
 linux-user/cpu_loop-common.h       |   2 +-
 linux-user/cris/cpu_loop.c         |   2 +-
 linux-user/main.c                  |   2 +-
 linux-user/microblaze/cpu_loop.c   |   4 +-
 linux-user/s390x/cpu_loop.c        |   4 +-
 linux-user/sh4/cpu_loop.c          |   2 +-
 linux-user/sparc/cpu_loop.c        |   2 +-
 memory.c                           | 156 ++++++-------
 monitor.c                          |  30 +--
 qemu-img.c                         |   6 +-
 qemu-io-cmds.c                     |   2 +-
 qom/cpu.c                          |  11 +-
 target/alpha/cpu.c                 |  15 +-
 target/alpha/cpu.h                 |   5 +-
 target/alpha/helper.c              |  24 +-
 target/arm/arm-semi.c              |   2 +-
 target/arm/cpu.c                   |   1 -
 target/arm/cpu.h                   |   5 +-
 target/arm/helper.c                |  15 +-
 target/arm/translate-a64.c         |  82 +++----
 target/arm/translate.c             |  58 ++---
 target/arm/translate.h             |   7 +-
 target/cris/cpu.c                  |  14 +-
 target/cris/cpu.h                  |   5 +-
 target/cris/helper.c               |   2 +-
 target/cris/translate.c            |  36 +--
 target/hppa/cpu.c                  |  14 +-
 target/hppa/cpu.h                  |   4 +-
 target/hppa/helper.c               |  24 +-
 target/i386/cpu.c                  |  29 +--
 target/i386/cpu.h                  |   8 +-
 target/i386/hax-all.c              |   4 +-
 target/i386/helper.c               | 356 ++++++++++++++---------------
 target/i386/monitor.c              |   3 +-
 target/lm32/cpu.c                  |  14 +-
 target/lm32/cpu.h                  |   5 +-
 target/lm32/translate.c            |  36 +--
 target/m68k/cpu.h                  |   8 +-
 target/m68k/helper.c               | 129 +++++------
 target/m68k/monitor.c              |   2 +-
 target/m68k/translate.c            |  86 +++----
 target/microblaze/cpu.h            |   3 +-
 target/microblaze/helper.c         |   2 +-
 target/microblaze/translate.c      |  39 ++--
 target/mips/cpu.h                  |   2 +-
 target/mips/internal.h             |   3 +-
 target/mips/translate.c            |  77 ++++---
 target/mips/translate_init.inc.c   |   5 +-
 target/moxie/cpu.h                 |   3 +-
 target/moxie/helper.c              |   2 +-
 target/moxie/translate.c           |  22 +-
 target/nios2/cpu.h                 |   5 +-
 target/nios2/helper.c              |   2 +-
 target/nios2/mmu.c                 |   7 +-
 target/nios2/monitor.c             |   2 +-
 target/nios2/translate.c           |  24 +-
 target/openrisc/cpu.c              |  15 +-
 target/openrisc/cpu.h              |   5 +-
 target/openrisc/disas.c            |   2 +-
 target/openrisc/translate.c        |  11 +-
 target/ppc/cpu.h                   |  10 +-
 target/ppc/mmu-hash64.c            |   7 +-
 target/ppc/mmu-hash64.h            |   2 +-
 target/ppc/mmu_helper.c            |  70 +++---
 target/ppc/monitor.c               |   2 +-
 target/ppc/translate.c             | 170 +++++++-------
 target/ppc/translate_init.inc.c    |  28 +--
 target/riscv/cpu.c                 |  54 ++---
 target/riscv/cpu.h                 |   2 +-
 target/s390x/cpu.h                 |   2 +-
 target/s390x/cpu_models.c          |  21 +-
 target/s390x/helper.c              |  42 ++--
 target/s390x/internal.h            |   3 +-
 target/sh4/cpu.c                   |  17 +-
 target/sh4/cpu.h                   |   5 +-
 target/sh4/translate.c             |  27 +--
 target/sparc/cpu.c                 | 133 ++++++-----
 target/sparc/cpu.h                 |   7 +-
 target/sparc/ldst_helper.c         |  18 +-
 target/sparc/mmu_helper.c          |  97 ++++----
 target/sparc/monitor.c             |   2 +-
 target/tilegx/cpu.c                |  14 +-
 target/tricore/cpu.h               |   5 +-
 target/tricore/helper.c            |  15 +-
 target/tricore/translate.c         |  26 +--
 target/unicore32/cpu.h             |   3 +-
 target/unicore32/translate.c       |  39 ++--
 target/xtensa/cpu.h                |   7 +-
 target/xtensa/helper.c             |   7 +-
 target/xtensa/mmu_helper.c         |  24 +-
 target/xtensa/monitor.c            |   2 +-
 target/xtensa/translate.c          |  40 ++--
 tcg/tcg.c                          |  50 ++--
 tcg/tcg.h                          |   4 +-
 trace/simple.c                     |   7 +-
 trace/simple.h                     |   2 +-
 util/qemu-print.c                  |  27 +++
 util/qsp.c                         |  21 +-
 vl.c                               |   2 +-
 143 files changed, 1353 insertions(+), 1503 deletions(-)
 rename include/disas/{bfd.h => dis-asm.h} (99%)
 delete mode 100644 include/qemu/fprintf-fn.h

-- 
2.17.2
Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Posted by no-reply@patchew.org 5 years ago 
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190417191805.28198-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190417191805.28198-1-armbru@redhat.com -> patchew/20190417191805.28198-1-armbru@redhat.com
Switched to a new branch 'test'
d406c1d4cd include: Move fprintf_function to disas/
16ce7b0844 disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
f8e6976645 monitor: Clean up how monitor_disas() funnels output to monitor
f79afa9517 qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
e1bbc178e1 qemu-print: New qemu_fprintf(), qemu_vfprintf()
7d392f9f86 qom/cpu: Simplify how CPUClass::dump_statistics() prints
090bb102c7 target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
56219b4319 target: Clean up how the dump_mmu() print
4e158b35c2 target: Simplify how the TARGET_cpu_list() print
567d521da5 memory: Clean up how mtree_info() prints
48a4f4d6da block/qapi: Clean up how we print to monitor or stdout
f680529453 qsp: Simplify how qsp_report() prints
8112185742 tcg: Simplify how dump_drift_info() prints
852634721a tcg: Simplify how dump_exec_info() prints
c85405d1e6 tcg: Simplify how dump_opcount_info() prints
21ecaf197a trace: Simplify how st_print_trace_file_status() prints
092f2c47ed include: Include fprintf-fn.h only where needed

=== OUTPUT BEGIN ===
1/17 Checking commit 092f2c47eda6 (include: Include fprintf-fn.h only where needed)
2/17 Checking commit 21ecaf197ac6 (trace: Simplify how st_print_trace_file_status() prints)
3/17 Checking commit c85405d1e6e5 (tcg: Simplify how dump_opcount_info() prints)
4/17 Checking commit 852634721a33 (tcg: Simplify how dump_exec_info() prints)
5/17 Checking commit 8112185742a2 (tcg: Simplify how dump_drift_info() prints)
6/17 Checking commit f6805294530b (qsp: Simplify how qsp_report() prints)
7/17 Checking commit 48a4f4d6da8d (block/qapi: Clean up how we print to monitor or stdout)
8/17 Checking commit 567d521da590 (memory: Clean up how mtree_info() prints)
9/17 Checking commit 4e158b35c234 (target: Simplify how the TARGET_cpu_list() print)
10/17 Checking commit 56219b431925 (target: Clean up how the dump_mmu() print)
WARNING: line over 80 characters
#950: FILE: target/xtensa/mmu_helper.c:784:
+                    qemu_printf("\tVaddr       Paddr       ASID  Attr RWX Cache\n"

total: 0 errors, 1 warnings, 848 lines checked

Patch 10/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/17 Checking commit 090bb102c765 (target/i386: Simplify how x86_cpu_dump_local_apic_state() prints)
12/17 Checking commit 7d392f9f86d6 (qom/cpu: Simplify how CPUClass::dump_statistics() prints)
13/17 Checking commit e1bbc178e114 (qemu-print: New qemu_fprintf(), qemu_vfprintf())
14/17 Checking commit f79afa951759 (qom/cpu: Simplify how CPUClass:cpu_dump_state() prints)
ERROR: line over 90 characters
#1051: FILE: target/i386/helper.c:419:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1052: FILE: target/i386/helper.c:420:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1053: FILE: target/i386/helper.c:421:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1054: FILE: target/i386/helper.c:422:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1055: FILE: target/i386/helper.c:423:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n",

WARNING: line over 80 characters
#1163: FILE: target/i386/helper.c:494:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n",

WARNING: line over 80 characters
#1751: FILE: target/mips/translate.c:29791:
+    qemu_fprintf(f, "CP0 Status  0x%08x Cause   0x%08x EPC    0x" TARGET_FMT_lx "\n",

total: 5 errors, 2 warnings, 2551 lines checked

Patch 14/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/17 Checking commit f8e6976645da (monitor: Clean up how monitor_disas() funnels output to monitor)
16/17 Checking commit 16ce7b0844dd (disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#296: 
rename from include/disas/bfd.h

total: 0 errors, 1 warnings, 192 lines checked

Patch 16/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/17 Checking commit d406c1d4cd3e (include: Move fprintf_function to disas/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 17 lines checked

Patch 17/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190417191805.28198-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Posted by no-reply@patchew.org 5 years ago 
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190417191805.28198-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190417191805.28198-1-armbru@redhat.com -> patchew/20190417191805.28198-1-armbru@redhat.com
Switched to a new branch 'test'
db19e834f8 include: Move fprintf_function to disas/
4413299b4d disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
4daa71b4be monitor: Clean up how monitor_disas() funnels output to monitor
8db320f550 qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
b71147d0c2 qemu-print: New qemu_fprintf(), qemu_vfprintf()
27a5a25b67 qom/cpu: Simplify how CPUClass::dump_statistics() prints
a83cbb831d target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
245613cc1b target: Clean up how the dump_mmu() print
10998140d5 target: Simplify how the TARGET_cpu_list() print
2e76bc9d7c memory: Clean up how mtree_info() prints
fef413a9bc block/qapi: Clean up how we print to monitor or stdout
72de8879b2 qsp: Simplify how qsp_report() prints
89b234381a tcg: Simplify how dump_drift_info() prints
511085a3f7 tcg: Simplify how dump_exec_info() prints
8a89bb3a52 tcg: Simplify how dump_opcount_info() prints
d8a29469b3 trace: Simplify how st_print_trace_file_status() prints
d1ffc558ad include: Include fprintf-fn.h only where needed

=== OUTPUT BEGIN ===
1/17 Checking commit d1ffc558ada9 (include: Include fprintf-fn.h only where needed)
2/17 Checking commit d8a29469b38b (trace: Simplify how st_print_trace_file_status() prints)
3/17 Checking commit 8a89bb3a523a (tcg: Simplify how dump_opcount_info() prints)
4/17 Checking commit 511085a3f704 (tcg: Simplify how dump_exec_info() prints)
5/17 Checking commit 89b234381aef (tcg: Simplify how dump_drift_info() prints)
6/17 Checking commit 72de8879b2a5 (qsp: Simplify how qsp_report() prints)
7/17 Checking commit fef413a9bc34 (block/qapi: Clean up how we print to monitor or stdout)
8/17 Checking commit 2e76bc9d7c92 (memory: Clean up how mtree_info() prints)
9/17 Checking commit 10998140d529 (target: Simplify how the TARGET_cpu_list() print)
10/17 Checking commit 245613cc1b1e (target: Clean up how the dump_mmu() print)
WARNING: line over 80 characters
#950: FILE: target/xtensa/mmu_helper.c:784:
+                    qemu_printf("\tVaddr       Paddr       ASID  Attr RWX Cache\n"

total: 0 errors, 1 warnings, 848 lines checked

Patch 10/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/17 Checking commit a83cbb831dfb (target/i386: Simplify how x86_cpu_dump_local_apic_state() prints)
12/17 Checking commit 27a5a25b6773 (qom/cpu: Simplify how CPUClass::dump_statistics() prints)
13/17 Checking commit b71147d0c208 (qemu-print: New qemu_fprintf(), qemu_vfprintf())
14/17 Checking commit 8db320f55011 (qom/cpu: Simplify how CPUClass:cpu_dump_state() prints)
ERROR: line over 90 characters
#1051: FILE: target/i386/helper.c:419:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1052: FILE: target/i386/helper.c:420:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1053: FILE: target/i386/helper.c:421:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1054: FILE: target/i386/helper.c:422:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1055: FILE: target/i386/helper.c:423:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n",

WARNING: line over 80 characters
#1163: FILE: target/i386/helper.c:494:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n",

WARNING: line over 80 characters
#1751: FILE: target/mips/translate.c:29791:
+    qemu_fprintf(f, "CP0 Status  0x%08x Cause   0x%08x EPC    0x" TARGET_FMT_lx "\n",

total: 5 errors, 2 warnings, 2551 lines checked

Patch 14/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/17 Checking commit 4daa71b4bee9 (monitor: Clean up how monitor_disas() funnels output to monitor)
16/17 Checking commit 4413299b4d9a (disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#296: 
rename from include/disas/bfd.h

total: 0 errors, 1 warnings, 192 lines checked

Patch 16/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/17 Checking commit db19e834f826 (include: Move fprintf_function to disas/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 17 lines checked

Patch 17/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190417191805.28198-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Posted by no-reply@patchew.org 5 years ago 
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190417191805.28198-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190417191805.28198-1-armbru@redhat.com -> patchew/20190417191805.28198-1-armbru@redhat.com
Switched to a new branch 'test'
90107e0ecd include: Move fprintf_function to disas/
08c75e94b5 disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
b35d73a420 monitor: Clean up how monitor_disas() funnels output to monitor
4f0c3493f6 qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
68f63bc7a9 qemu-print: New qemu_fprintf(), qemu_vfprintf()
d41d47ee91 qom/cpu: Simplify how CPUClass::dump_statistics() prints
df73a8c8e6 target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
edc6b2832c target: Clean up how the dump_mmu() print
482f38cd69 target: Simplify how the TARGET_cpu_list() print
18b22c842c memory: Clean up how mtree_info() prints
2dfb27eebe block/qapi: Clean up how we print to monitor or stdout
10b6b38b8a qsp: Simplify how qsp_report() prints
3a161a6792 tcg: Simplify how dump_drift_info() prints
e340f7a5c0 tcg: Simplify how dump_exec_info() prints
bdd8aea085 tcg: Simplify how dump_opcount_info() prints
0cb2f55550 trace: Simplify how st_print_trace_file_status() prints
dcae6b30f1 include: Include fprintf-fn.h only where needed

=== OUTPUT BEGIN ===
1/17 Checking commit dcae6b30f156 (include: Include fprintf-fn.h only where needed)
2/17 Checking commit 0cb2f5555029 (trace: Simplify how st_print_trace_file_status() prints)
3/17 Checking commit bdd8aea085c0 (tcg: Simplify how dump_opcount_info() prints)
4/17 Checking commit e340f7a5c047 (tcg: Simplify how dump_exec_info() prints)
5/17 Checking commit 3a161a679275 (tcg: Simplify how dump_drift_info() prints)
6/17 Checking commit 10b6b38b8ae9 (qsp: Simplify how qsp_report() prints)
7/17 Checking commit 2dfb27eebe4e (block/qapi: Clean up how we print to monitor or stdout)
8/17 Checking commit 18b22c842ccb (memory: Clean up how mtree_info() prints)
9/17 Checking commit 482f38cd6965 (target: Simplify how the TARGET_cpu_list() print)
10/17 Checking commit edc6b2832c82 (target: Clean up how the dump_mmu() print)
WARNING: line over 80 characters
#950: FILE: target/xtensa/mmu_helper.c:784:
+                    qemu_printf("\tVaddr       Paddr       ASID  Attr RWX Cache\n"

total: 0 errors, 1 warnings, 848 lines checked

Patch 10/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/17 Checking commit df73a8c8e645 (target/i386: Simplify how x86_cpu_dump_local_apic_state() prints)
12/17 Checking commit d41d47ee915e (qom/cpu: Simplify how CPUClass::dump_statistics() prints)
13/17 Checking commit 68f63bc7a914 (qemu-print: New qemu_fprintf(), qemu_vfprintf())
14/17 Checking commit 4f0c3493f69b (qom/cpu: Simplify how CPUClass:cpu_dump_state() prints)
ERROR: line over 90 characters
#1051: FILE: target/i386/helper.c:419:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1052: FILE: target/i386/helper.c:420:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1053: FILE: target/i386/helper.c:421:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1054: FILE: target/i386/helper.c:422:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1055: FILE: target/i386/helper.c:423:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n",

WARNING: line over 80 characters
#1163: FILE: target/i386/helper.c:494:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n",

WARNING: line over 80 characters
#1751: FILE: target/mips/translate.c:29791:
+    qemu_fprintf(f, "CP0 Status  0x%08x Cause   0x%08x EPC    0x" TARGET_FMT_lx "\n",

total: 5 errors, 2 warnings, 2551 lines checked

Patch 14/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/17 Checking commit b35d73a42067 (monitor: Clean up how monitor_disas() funnels output to monitor)
16/17 Checking commit 08c75e94b574 (disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#296: 
rename from include/disas/bfd.h

total: 0 errors, 1 warnings, 192 lines checked

Patch 16/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/17 Checking commit 90107e0ecdfa (include: Move fprintf_function to disas/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 17 lines checked

Patch 17/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190417191805.28198-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Posted by no-reply@patchew.org 5 years ago 
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190417191805.28198-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190417191805.28198-1-armbru@redhat.com -> patchew/20190417191805.28198-1-armbru@redhat.com
Switched to a new branch 'test'
dbad74bf63 include: Move fprintf_function to disas/
8056ad6cd3 disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
90edbaf518 monitor: Clean up how monitor_disas() funnels output to monitor
9dacaf5ef7 qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
5e6905625e qemu-print: New qemu_fprintf(), qemu_vfprintf()
149609b2ad qom/cpu: Simplify how CPUClass::dump_statistics() prints
64fad59c2e target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
d0d676884c target: Clean up how the dump_mmu() print
e62415eb3c target: Simplify how the TARGET_cpu_list() print
6b93fa5e80 memory: Clean up how mtree_info() prints
e55e74cdf1 block/qapi: Clean up how we print to monitor or stdout
922dc9a331 qsp: Simplify how qsp_report() prints
a319820a6d tcg: Simplify how dump_drift_info() prints
7e213bdc95 tcg: Simplify how dump_exec_info() prints
a8dbca91a2 tcg: Simplify how dump_opcount_info() prints
8f9d9b1b12 trace: Simplify how st_print_trace_file_status() prints
7bf430b203 include: Include fprintf-fn.h only where needed

=== OUTPUT BEGIN ===
1/17 Checking commit 7bf430b2033a (include: Include fprintf-fn.h only where needed)
2/17 Checking commit 8f9d9b1b1263 (trace: Simplify how st_print_trace_file_status() prints)
3/17 Checking commit a8dbca91a2fb (tcg: Simplify how dump_opcount_info() prints)
4/17 Checking commit 7e213bdc9596 (tcg: Simplify how dump_exec_info() prints)
5/17 Checking commit a319820a6d62 (tcg: Simplify how dump_drift_info() prints)
6/17 Checking commit 922dc9a33160 (qsp: Simplify how qsp_report() prints)
7/17 Checking commit e55e74cdf1f9 (block/qapi: Clean up how we print to monitor or stdout)
8/17 Checking commit 6b93fa5e8004 (memory: Clean up how mtree_info() prints)
9/17 Checking commit e62415eb3c51 (target: Simplify how the TARGET_cpu_list() print)
10/17 Checking commit d0d676884c52 (target: Clean up how the dump_mmu() print)
WARNING: line over 80 characters
#950: FILE: target/xtensa/mmu_helper.c:784:
+                    qemu_printf("\tVaddr       Paddr       ASID  Attr RWX Cache\n"

total: 0 errors, 1 warnings, 848 lines checked

Patch 10/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/17 Checking commit 64fad59c2e43 (target/i386: Simplify how x86_cpu_dump_local_apic_state() prints)
12/17 Checking commit 149609b2ad9b (qom/cpu: Simplify how CPUClass::dump_statistics() prints)
13/17 Checking commit 5e6905625eeb (qemu-print: New qemu_fprintf(), qemu_vfprintf())
14/17 Checking commit 9dacaf5ef718 (qom/cpu: Simplify how CPUClass:cpu_dump_state() prints)
ERROR: line over 90 characters
#1051: FILE: target/i386/helper.c:419:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1052: FILE: target/i386/helper.c:420:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1053: FILE: target/i386/helper.c:421:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1054: FILE: target/i386/helper.c:422:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1055: FILE: target/i386/helper.c:423:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n",

WARNING: line over 80 characters
#1163: FILE: target/i386/helper.c:494:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n",

WARNING: line over 80 characters
#1751: FILE: target/mips/translate.c:29791:
+    qemu_fprintf(f, "CP0 Status  0x%08x Cause   0x%08x EPC    0x" TARGET_FMT_lx "\n",

total: 5 errors, 2 warnings, 2551 lines checked

Patch 14/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/17 Checking commit 90edbaf518e3 (monitor: Clean up how monitor_disas() funnels output to monitor)
16/17 Checking commit 8056ad6cd3d8 (disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#296: 
rename from include/disas/bfd.h

total: 0 errors, 1 warnings, 192 lines checked

Patch 16/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/17 Checking commit dbad74bf63f2 (include: Move fprintf_function to disas/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 17 lines checked

Patch 17/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190417191805.28198-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Posted by no-reply@patchew.org 5 years ago 
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190417191805.28198-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190417191805.28198-1-armbru@redhat.com -> patchew/20190417191805.28198-1-armbru@redhat.com
Switched to a new branch 'test'
dfb284c449 include: Move fprintf_function to disas/
dbc3e8039f disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
71f572cab2 monitor: Clean up how monitor_disas() funnels output to monitor
67cdf8cf8b qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
6a1d72f66f qemu-print: New qemu_fprintf(), qemu_vfprintf()
b6e8226b5c qom/cpu: Simplify how CPUClass::dump_statistics() prints
fea77047bb target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
f850e6e38b target: Clean up how the dump_mmu() print
f36f9982d5 target: Simplify how the TARGET_cpu_list() print
97472bedb7 memory: Clean up how mtree_info() prints
09a19b6e63 block/qapi: Clean up how we print to monitor or stdout
68ff1d89f6 qsp: Simplify how qsp_report() prints
6777d9cdfd tcg: Simplify how dump_drift_info() prints
dc643ac146 tcg: Simplify how dump_exec_info() prints
9801855090 tcg: Simplify how dump_opcount_info() prints
7530ac3e60 trace: Simplify how st_print_trace_file_status() prints
8d5be4b138 include: Include fprintf-fn.h only where needed

=== OUTPUT BEGIN ===
1/17 Checking commit 8d5be4b13878 (include: Include fprintf-fn.h only where needed)
2/17 Checking commit 7530ac3e60b5 (trace: Simplify how st_print_trace_file_status() prints)
3/17 Checking commit 980185509054 (tcg: Simplify how dump_opcount_info() prints)
4/17 Checking commit dc643ac146c5 (tcg: Simplify how dump_exec_info() prints)
5/17 Checking commit 6777d9cdfd98 (tcg: Simplify how dump_drift_info() prints)
6/17 Checking commit 68ff1d89f658 (qsp: Simplify how qsp_report() prints)
7/17 Checking commit 09a19b6e63c7 (block/qapi: Clean up how we print to monitor or stdout)
8/17 Checking commit 97472bedb71b (memory: Clean up how mtree_info() prints)
9/17 Checking commit f36f9982d564 (target: Simplify how the TARGET_cpu_list() print)
10/17 Checking commit f850e6e38bf3 (target: Clean up how the dump_mmu() print)
WARNING: line over 80 characters
#950: FILE: target/xtensa/mmu_helper.c:784:
+                    qemu_printf("\tVaddr       Paddr       ASID  Attr RWX Cache\n"

total: 0 errors, 1 warnings, 848 lines checked

Patch 10/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/17 Checking commit fea77047bbff (target/i386: Simplify how x86_cpu_dump_local_apic_state() prints)
12/17 Checking commit b6e8226b5c46 (qom/cpu: Simplify how CPUClass::dump_statistics() prints)
13/17 Checking commit 6a1d72f66f1b (qemu-print: New qemu_fprintf(), qemu_vfprintf())
14/17 Checking commit 67cdf8cf8b1f (qom/cpu: Simplify how CPUClass:cpu_dump_state() prints)
ERROR: line over 90 characters
#1051: FILE: target/i386/helper.c:419:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1052: FILE: target/i386/helper.c:420:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1053: FILE: target/i386/helper.c:421:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1054: FILE: target/i386/helper.c:422:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1055: FILE: target/i386/helper.c:423:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n",

WARNING: line over 80 characters
#1163: FILE: target/i386/helper.c:494:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n",

WARNING: line over 80 characters
#1751: FILE: target/mips/translate.c:29791:
+    qemu_fprintf(f, "CP0 Status  0x%08x Cause   0x%08x EPC    0x" TARGET_FMT_lx "\n",

total: 5 errors, 2 warnings, 2551 lines checked

Patch 14/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/17 Checking commit 71f572cab24d (monitor: Clean up how monitor_disas() funnels output to monitor)
16/17 Checking commit dbc3e8039f78 (disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#296: 
rename from include/disas/bfd.h

total: 0 errors, 1 warnings, 192 lines checked

Patch 16/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/17 Checking commit dfb284c44975 (include: Move fprintf_function to disas/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 17 lines checked

Patch 17/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190417191805.28198-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Posted by no-reply@patchew.org 5 years ago 
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190417191805.28198-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190417191805.28198-1-armbru@redhat.com -> patchew/20190417191805.28198-1-armbru@redhat.com
Switched to a new branch 'test'
c8c93e61d1 include: Move fprintf_function to disas/
f5674f82b2 disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
08e5c5c637 monitor: Clean up how monitor_disas() funnels output to monitor
5758566368 qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
263852f63a qemu-print: New qemu_fprintf(), qemu_vfprintf()
005251581b qom/cpu: Simplify how CPUClass::dump_statistics() prints
207d3db725 target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
d9cc902329 target: Clean up how the dump_mmu() print
827021bdb4 target: Simplify how the TARGET_cpu_list() print
f5dfd1ae06 memory: Clean up how mtree_info() prints
ea4b4273ed block/qapi: Clean up how we print to monitor or stdout
cf6447c2ca qsp: Simplify how qsp_report() prints
66120f6a1e tcg: Simplify how dump_drift_info() prints
872e71e6a3 tcg: Simplify how dump_exec_info() prints
49dadefa20 tcg: Simplify how dump_opcount_info() prints
ce1a847509 trace: Simplify how st_print_trace_file_status() prints
20ac898544 include: Include fprintf-fn.h only where needed

=== OUTPUT BEGIN ===
1/17 Checking commit 20ac898544d2 (include: Include fprintf-fn.h only where needed)
2/17 Checking commit ce1a8475095a (trace: Simplify how st_print_trace_file_status() prints)
3/17 Checking commit 49dadefa2093 (tcg: Simplify how dump_opcount_info() prints)
4/17 Checking commit 872e71e6a30d (tcg: Simplify how dump_exec_info() prints)
5/17 Checking commit 66120f6a1e65 (tcg: Simplify how dump_drift_info() prints)
6/17 Checking commit cf6447c2ca7d (qsp: Simplify how qsp_report() prints)
7/17 Checking commit ea4b4273ed42 (block/qapi: Clean up how we print to monitor or stdout)
8/17 Checking commit f5dfd1ae06f7 (memory: Clean up how mtree_info() prints)
9/17 Checking commit 827021bdb479 (target: Simplify how the TARGET_cpu_list() print)
10/17 Checking commit d9cc9023295d (target: Clean up how the dump_mmu() print)
WARNING: line over 80 characters
#950: FILE: target/xtensa/mmu_helper.c:784:
+                    qemu_printf("\tVaddr       Paddr       ASID  Attr RWX Cache\n"

total: 0 errors, 1 warnings, 848 lines checked

Patch 10/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/17 Checking commit 207d3db72502 (target/i386: Simplify how x86_cpu_dump_local_apic_state() prints)
12/17 Checking commit 005251581b3b (qom/cpu: Simplify how CPUClass::dump_statistics() prints)
13/17 Checking commit 263852f63aa4 (qemu-print: New qemu_fprintf(), qemu_vfprintf())
14/17 Checking commit 5758566368d1 (qom/cpu: Simplify how CPUClass:cpu_dump_state() prints)
ERROR: line over 90 characters
#1051: FILE: target/i386/helper.c:419:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1052: FILE: target/i386/helper.c:420:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1053: FILE: target/i386/helper.c:421:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1054: FILE: target/i386/helper.c:422:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1055: FILE: target/i386/helper.c:423:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n",

WARNING: line over 80 characters
#1163: FILE: target/i386/helper.c:494:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n",

WARNING: line over 80 characters
#1751: FILE: target/mips/translate.c:29791:
+    qemu_fprintf(f, "CP0 Status  0x%08x Cause   0x%08x EPC    0x" TARGET_FMT_lx "\n",

total: 5 errors, 2 warnings, 2551 lines checked

Patch 14/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/17 Checking commit 08e5c5c637d7 (monitor: Clean up how monitor_disas() funnels output to monitor)
16/17 Checking commit f5674f82b2d3 (disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#296: 
rename from include/disas/bfd.h

total: 0 errors, 1 warnings, 192 lines checked

Patch 16/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/17 Checking commit c8c93e61d132 (include: Move fprintf_function to disas/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 17 lines checked

Patch 17/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190417191805.28198-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Posted by no-reply@patchew.org 5 years ago 
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190417191805.28198-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190417191805.28198-1-armbru@redhat.com -> patchew/20190417191805.28198-1-armbru@redhat.com
Switched to a new branch 'test'
4efc614089 include: Move fprintf_function to disas/
609b068e91 disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
b60826bdec monitor: Clean up how monitor_disas() funnels output to monitor
7e0a83951c qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
0310913eaf qemu-print: New qemu_fprintf(), qemu_vfprintf()
de8e759927 qom/cpu: Simplify how CPUClass::dump_statistics() prints
21575fb486 target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
5e14da45f9 target: Clean up how the dump_mmu() print
d38f591f4a target: Simplify how the TARGET_cpu_list() print
f6d226a80d memory: Clean up how mtree_info() prints
dea28d5474 block/qapi: Clean up how we print to monitor or stdout
18cc598399 qsp: Simplify how qsp_report() prints
a2acbfe35b tcg: Simplify how dump_drift_info() prints
746793c924 tcg: Simplify how dump_exec_info() prints
48e5796804 tcg: Simplify how dump_opcount_info() prints
2788f8a6c8 trace: Simplify how st_print_trace_file_status() prints
b667f124bf include: Include fprintf-fn.h only where needed

=== OUTPUT BEGIN ===
1/17 Checking commit b667f124bfd4 (include: Include fprintf-fn.h only where needed)
2/17 Checking commit 2788f8a6c887 (trace: Simplify how st_print_trace_file_status() prints)
3/17 Checking commit 48e579680473 (tcg: Simplify how dump_opcount_info() prints)
4/17 Checking commit 746793c92494 (tcg: Simplify how dump_exec_info() prints)
5/17 Checking commit a2acbfe35b3f (tcg: Simplify how dump_drift_info() prints)
6/17 Checking commit 18cc59839940 (qsp: Simplify how qsp_report() prints)
7/17 Checking commit dea28d5474ce (block/qapi: Clean up how we print to monitor or stdout)
8/17 Checking commit f6d226a80d57 (memory: Clean up how mtree_info() prints)
9/17 Checking commit d38f591f4af4 (target: Simplify how the TARGET_cpu_list() print)
10/17 Checking commit 5e14da45f92c (target: Clean up how the dump_mmu() print)
WARNING: line over 80 characters
#950: FILE: target/xtensa/mmu_helper.c:784:
+                    qemu_printf("\tVaddr       Paddr       ASID  Attr RWX Cache\n"

total: 0 errors, 1 warnings, 848 lines checked

Patch 10/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/17 Checking commit 21575fb486ef (target/i386: Simplify how x86_cpu_dump_local_apic_state() prints)
12/17 Checking commit de8e75992712 (qom/cpu: Simplify how CPUClass::dump_statistics() prints)
13/17 Checking commit 0310913eaf37 (qemu-print: New qemu_fprintf(), qemu_vfprintf())
14/17 Checking commit 7e0a83951c37 (qom/cpu: Simplify how CPUClass:cpu_dump_state() prints)
ERROR: line over 90 characters
#1051: FILE: target/i386/helper.c:419:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1052: FILE: target/i386/helper.c:420:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1053: FILE: target/i386/helper.c:421:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1054: FILE: target/i386/helper.c:422:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1055: FILE: target/i386/helper.c:423:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n",

WARNING: line over 80 characters
#1163: FILE: target/i386/helper.c:494:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n",

WARNING: line over 80 characters
#1751: FILE: target/mips/translate.c:29791:
+    qemu_fprintf(f, "CP0 Status  0x%08x Cause   0x%08x EPC    0x" TARGET_FMT_lx "\n",

total: 5 errors, 2 warnings, 2551 lines checked

Patch 14/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/17 Checking commit b60826bdec60 (monitor: Clean up how monitor_disas() funnels output to monitor)
16/17 Checking commit 609b068e9185 (disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#296: 
rename from include/disas/bfd.h

total: 0 errors, 1 warnings, 192 lines checked

Patch 16/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/17 Checking commit 4efc61408903 (include: Move fprintf_function to disas/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 17 lines checked

Patch 17/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190417191805.28198-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Posted by no-reply@patchew.org 5 years ago 
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190417191805.28198-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190417191805.28198-1-armbru@redhat.com -> patchew/20190417191805.28198-1-armbru@redhat.com
Switched to a new branch 'test'
587c26c24e include: Move fprintf_function to disas/
416f563f47 disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
0a17831a3d monitor: Clean up how monitor_disas() funnels output to monitor
7552bb783c qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
f8829004b6 qemu-print: New qemu_fprintf(), qemu_vfprintf()
6e17d7886f qom/cpu: Simplify how CPUClass::dump_statistics() prints
b9e7cc19f9 target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
d0235ec2aa target: Clean up how the dump_mmu() print
5ac5266b18 target: Simplify how the TARGET_cpu_list() print
537efe83e7 memory: Clean up how mtree_info() prints
d8c0a5610f block/qapi: Clean up how we print to monitor or stdout
1f2593e991 qsp: Simplify how qsp_report() prints
8ddded1f2c tcg: Simplify how dump_drift_info() prints
50a002becd tcg: Simplify how dump_exec_info() prints
eb737a179a tcg: Simplify how dump_opcount_info() prints
298229bbdd trace: Simplify how st_print_trace_file_status() prints
8a2715b3db include: Include fprintf-fn.h only where needed

=== OUTPUT BEGIN ===
1/17 Checking commit 8a2715b3db01 (include: Include fprintf-fn.h only where needed)
2/17 Checking commit 298229bbddd0 (trace: Simplify how st_print_trace_file_status() prints)
3/17 Checking commit eb737a179ad4 (tcg: Simplify how dump_opcount_info() prints)
4/17 Checking commit 50a002becdd9 (tcg: Simplify how dump_exec_info() prints)
5/17 Checking commit 8ddded1f2ce1 (tcg: Simplify how dump_drift_info() prints)
6/17 Checking commit 1f2593e99199 (qsp: Simplify how qsp_report() prints)
7/17 Checking commit d8c0a5610f9d (block/qapi: Clean up how we print to monitor or stdout)
8/17 Checking commit 537efe83e7af (memory: Clean up how mtree_info() prints)
9/17 Checking commit 5ac5266b18f3 (target: Simplify how the TARGET_cpu_list() print)
10/17 Checking commit d0235ec2aa72 (target: Clean up how the dump_mmu() print)
WARNING: line over 80 characters
#950: FILE: target/xtensa/mmu_helper.c:784:
+                    qemu_printf("\tVaddr       Paddr       ASID  Attr RWX Cache\n"

total: 0 errors, 1 warnings, 848 lines checked

Patch 10/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/17 Checking commit b9e7cc19f90d (target/i386: Simplify how x86_cpu_dump_local_apic_state() prints)
12/17 Checking commit 6e17d7886f80 (qom/cpu: Simplify how CPUClass::dump_statistics() prints)
13/17 Checking commit f8829004b621 (qemu-print: New qemu_fprintf(), qemu_vfprintf())
14/17 Checking commit 7552bb783c08 (qom/cpu: Simplify how CPUClass:cpu_dump_state() prints)
ERROR: line over 90 characters
#1051: FILE: target/i386/helper.c:419:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1052: FILE: target/i386/helper.c:420:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1053: FILE: target/i386/helper.c:421:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1054: FILE: target/i386/helper.c:422:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1055: FILE: target/i386/helper.c:423:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n",

WARNING: line over 80 characters
#1163: FILE: target/i386/helper.c:494:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n",

WARNING: line over 80 characters
#1751: FILE: target/mips/translate.c:29791:
+    qemu_fprintf(f, "CP0 Status  0x%08x Cause   0x%08x EPC    0x" TARGET_FMT_lx "\n",

total: 5 errors, 2 warnings, 2551 lines checked

Patch 14/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/17 Checking commit 0a17831a3dbe (monitor: Clean up how monitor_disas() funnels output to monitor)
16/17 Checking commit 416f563f47e7 (disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#296: 
rename from include/disas/bfd.h

total: 0 errors, 1 warnings, 192 lines checked

Patch 16/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/17 Checking commit 587c26c24e65 (include: Move fprintf_function to disas/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 17 lines checked

Patch 17/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190417191805.28198-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Posted by no-reply@patchew.org 5 years ago 
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190417191805.28198-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190417191805.28198-1-armbru@redhat.com -> patchew/20190417191805.28198-1-armbru@redhat.com
Switched to a new branch 'test'
66669b6bcf include: Move fprintf_function to disas/
5f3c81a6c0 disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
b1ae46c343 monitor: Clean up how monitor_disas() funnels output to monitor
a00c28ab5f qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
0f55321ae1 qemu-print: New qemu_fprintf(), qemu_vfprintf()
f2dbd0673c qom/cpu: Simplify how CPUClass::dump_statistics() prints
5b67d37795 target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
dc40ad0d34 target: Clean up how the dump_mmu() print
8df164790b target: Simplify how the TARGET_cpu_list() print
17406d3cf6 memory: Clean up how mtree_info() prints
53875f811b block/qapi: Clean up how we print to monitor or stdout
d2f6642515 qsp: Simplify how qsp_report() prints
e380a5d2ef tcg: Simplify how dump_drift_info() prints
aa6873e448 tcg: Simplify how dump_exec_info() prints
f8a56f8a9e tcg: Simplify how dump_opcount_info() prints
5beb1ec556 trace: Simplify how st_print_trace_file_status() prints
5f69e0108f include: Include fprintf-fn.h only where needed

=== OUTPUT BEGIN ===
1/17 Checking commit 5f69e0108f3a (include: Include fprintf-fn.h only where needed)
2/17 Checking commit 5beb1ec556b3 (trace: Simplify how st_print_trace_file_status() prints)
3/17 Checking commit f8a56f8a9e7a (tcg: Simplify how dump_opcount_info() prints)
4/17 Checking commit aa6873e4485d (tcg: Simplify how dump_exec_info() prints)
5/17 Checking commit e380a5d2ef1f (tcg: Simplify how dump_drift_info() prints)
6/17 Checking commit d2f6642515d9 (qsp: Simplify how qsp_report() prints)
7/17 Checking commit 53875f811b38 (block/qapi: Clean up how we print to monitor or stdout)
8/17 Checking commit 17406d3cf6af (memory: Clean up how mtree_info() prints)
9/17 Checking commit 8df164790bf4 (target: Simplify how the TARGET_cpu_list() print)
10/17 Checking commit dc40ad0d3487 (target: Clean up how the dump_mmu() print)
WARNING: line over 80 characters
#950: FILE: target/xtensa/mmu_helper.c:784:
+                    qemu_printf("\tVaddr       Paddr       ASID  Attr RWX Cache\n"

total: 0 errors, 1 warnings, 848 lines checked

Patch 10/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/17 Checking commit 5b67d377956e (target/i386: Simplify how x86_cpu_dump_local_apic_state() prints)
12/17 Checking commit f2dbd0673ce7 (qom/cpu: Simplify how CPUClass::dump_statistics() prints)
13/17 Checking commit 0f55321ae1d6 (qemu-print: New qemu_fprintf(), qemu_vfprintf())
14/17 Checking commit a00c28ab5fe0 (qom/cpu: Simplify how CPUClass:cpu_dump_state() prints)
ERROR: line over 90 characters
#1051: FILE: target/i386/helper.c:419:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1052: FILE: target/i386/helper.c:420:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1053: FILE: target/i386/helper.c:421:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1054: FILE: target/i386/helper.c:422:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1055: FILE: target/i386/helper.c:423:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n",

WARNING: line over 80 characters
#1163: FILE: target/i386/helper.c:494:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n",

WARNING: line over 80 characters
#1751: FILE: target/mips/translate.c:29791:
+    qemu_fprintf(f, "CP0 Status  0x%08x Cause   0x%08x EPC    0x" TARGET_FMT_lx "\n",

total: 5 errors, 2 warnings, 2551 lines checked

Patch 14/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/17 Checking commit b1ae46c3432c (monitor: Clean up how monitor_disas() funnels output to monitor)
16/17 Checking commit 5f3c81a6c07d (disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#296: 
rename from include/disas/bfd.h

total: 0 errors, 1 warnings, 192 lines checked

Patch 16/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/17 Checking commit 66669b6bcf6b (include: Move fprintf_function to disas/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 17 lines checked

Patch 17/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190417191805.28198-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Posted by no-reply@patchew.org 5 years ago 
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190417191805.28198-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190417191805.28198-1-armbru@redhat.com -> patchew/20190417191805.28198-1-armbru@redhat.com
Switched to a new branch 'test'
d04838b7b7 include: Move fprintf_function to disas/
319ed76db2 disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
feff1f1103 monitor: Clean up how monitor_disas() funnels output to monitor
c9c4a984c5 qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
f7def015ea qemu-print: New qemu_fprintf(), qemu_vfprintf()
286643ea44 qom/cpu: Simplify how CPUClass::dump_statistics() prints
3d846546c8 target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
f2b3c9abee target: Clean up how the dump_mmu() print
1394894623 target: Simplify how the TARGET_cpu_list() print
1c6016aa83 memory: Clean up how mtree_info() prints
8f6c6a9fe3 block/qapi: Clean up how we print to monitor or stdout
782d9eb94e qsp: Simplify how qsp_report() prints
e6de5c5911 tcg: Simplify how dump_drift_info() prints
9e1aa6472d tcg: Simplify how dump_exec_info() prints
21dba78baa tcg: Simplify how dump_opcount_info() prints
c6d722b62c trace: Simplify how st_print_trace_file_status() prints
ded6f95b0e include: Include fprintf-fn.h only where needed

=== OUTPUT BEGIN ===
1/17 Checking commit ded6f95b0e1b (include: Include fprintf-fn.h only where needed)
2/17 Checking commit c6d722b62cc2 (trace: Simplify how st_print_trace_file_status() prints)
3/17 Checking commit 21dba78baad3 (tcg: Simplify how dump_opcount_info() prints)
4/17 Checking commit 9e1aa6472d45 (tcg: Simplify how dump_exec_info() prints)
5/17 Checking commit e6de5c591115 (tcg: Simplify how dump_drift_info() prints)
6/17 Checking commit 782d9eb94e8a (qsp: Simplify how qsp_report() prints)
7/17 Checking commit 8f6c6a9fe333 (block/qapi: Clean up how we print to monitor or stdout)
8/17 Checking commit 1c6016aa83ad (memory: Clean up how mtree_info() prints)
9/17 Checking commit 139489462353 (target: Simplify how the TARGET_cpu_list() print)
10/17 Checking commit f2b3c9abeec5 (target: Clean up how the dump_mmu() print)
WARNING: line over 80 characters
#950: FILE: target/xtensa/mmu_helper.c:784:
+                    qemu_printf("\tVaddr       Paddr       ASID  Attr RWX Cache\n"

total: 0 errors, 1 warnings, 848 lines checked

Patch 10/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/17 Checking commit 3d846546c8e2 (target/i386: Simplify how x86_cpu_dump_local_apic_state() prints)
12/17 Checking commit 286643ea442b (qom/cpu: Simplify how CPUClass::dump_statistics() prints)
13/17 Checking commit f7def015ea17 (qemu-print: New qemu_fprintf(), qemu_vfprintf())
14/17 Checking commit c9c4a984c53d (qom/cpu: Simplify how CPUClass:cpu_dump_state() prints)
ERROR: line over 90 characters
#1051: FILE: target/i386/helper.c:419:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1052: FILE: target/i386/helper.c:420:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1053: FILE: target/i386/helper.c:421:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1054: FILE: target/i386/helper.c:422:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1055: FILE: target/i386/helper.c:423:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n",

WARNING: line over 80 characters
#1163: FILE: target/i386/helper.c:494:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n",

WARNING: line over 80 characters
#1751: FILE: target/mips/translate.c:29791:
+    qemu_fprintf(f, "CP0 Status  0x%08x Cause   0x%08x EPC    0x" TARGET_FMT_lx "\n",

total: 5 errors, 2 warnings, 2551 lines checked

Patch 14/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/17 Checking commit feff1f11032c (monitor: Clean up how monitor_disas() funnels output to monitor)
16/17 Checking commit 319ed76db21e (disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#296: 
rename from include/disas/bfd.h

total: 0 errors, 1 warnings, 192 lines checked

Patch 16/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/17 Checking commit d04838b7b77a (include: Move fprintf_function to disas/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 17 lines checked

Patch 17/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190417191805.28198-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Posted by no-reply@patchew.org 5 years ago 
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190417191805.28198-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190417191805.28198-1-armbru@redhat.com -> patchew/20190417191805.28198-1-armbru@redhat.com
Switched to a new branch 'test'
8b142fc767 include: Move fprintf_function to disas/
d69f01b1b3 disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
473a1c8779 monitor: Clean up how monitor_disas() funnels output to monitor
363a8f9258 qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
a2be3c05f9 qemu-print: New qemu_fprintf(), qemu_vfprintf()
1f6386c655 qom/cpu: Simplify how CPUClass::dump_statistics() prints
fc33835b61 target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
bea3b777db target: Clean up how the dump_mmu() print
0cf22bb8f4 target: Simplify how the TARGET_cpu_list() print
edae5f9c36 memory: Clean up how mtree_info() prints
409b0a9ef6 block/qapi: Clean up how we print to monitor or stdout
a2db2c108d qsp: Simplify how qsp_report() prints
eeef382c8b tcg: Simplify how dump_drift_info() prints
26f0941f15 tcg: Simplify how dump_exec_info() prints
1befd4787a tcg: Simplify how dump_opcount_info() prints
ca597f2d8e trace: Simplify how st_print_trace_file_status() prints
1c6d436697 include: Include fprintf-fn.h only where needed

=== OUTPUT BEGIN ===
1/17 Checking commit 1c6d43669789 (include: Include fprintf-fn.h only where needed)
2/17 Checking commit ca597f2d8e95 (trace: Simplify how st_print_trace_file_status() prints)
3/17 Checking commit 1befd4787a61 (tcg: Simplify how dump_opcount_info() prints)
4/17 Checking commit 26f0941f15dc (tcg: Simplify how dump_exec_info() prints)
5/17 Checking commit eeef382c8bdb (tcg: Simplify how dump_drift_info() prints)
6/17 Checking commit a2db2c108d25 (qsp: Simplify how qsp_report() prints)
7/17 Checking commit 409b0a9ef641 (block/qapi: Clean up how we print to monitor or stdout)
8/17 Checking commit edae5f9c360a (memory: Clean up how mtree_info() prints)
9/17 Checking commit 0cf22bb8f42e (target: Simplify how the TARGET_cpu_list() print)
10/17 Checking commit bea3b777dbfa (target: Clean up how the dump_mmu() print)
WARNING: line over 80 characters
#950: FILE: target/xtensa/mmu_helper.c:784:
+                    qemu_printf("\tVaddr       Paddr       ASID  Attr RWX Cache\n"

total: 0 errors, 1 warnings, 848 lines checked

Patch 10/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/17 Checking commit fc33835b6178 (target/i386: Simplify how x86_cpu_dump_local_apic_state() prints)
12/17 Checking commit 1f6386c655a5 (qom/cpu: Simplify how CPUClass::dump_statistics() prints)
13/17 Checking commit a2be3c05f9fc (qemu-print: New qemu_fprintf(), qemu_vfprintf())
14/17 Checking commit 363a8f9258a4 (qom/cpu: Simplify how CPUClass:cpu_dump_state() prints)
ERROR: line over 90 characters
#1051: FILE: target/i386/helper.c:419:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1052: FILE: target/i386/helper.c:420:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1053: FILE: target/i386/helper.c:421:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1054: FILE: target/i386/helper.c:422:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1055: FILE: target/i386/helper.c:423:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n",

WARNING: line over 80 characters
#1163: FILE: target/i386/helper.c:494:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n",

WARNING: line over 80 characters
#1751: FILE: target/mips/translate.c:29791:
+    qemu_fprintf(f, "CP0 Status  0x%08x Cause   0x%08x EPC    0x" TARGET_FMT_lx "\n",

total: 5 errors, 2 warnings, 2551 lines checked

Patch 14/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/17 Checking commit 473a1c877930 (monitor: Clean up how monitor_disas() funnels output to monitor)
16/17 Checking commit d69f01b1b315 (disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#296: 
rename from include/disas/bfd.h

total: 0 errors, 1 warnings, 192 lines checked

Patch 16/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/17 Checking commit 8b142fc76760 (include: Move fprintf_function to disas/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 17 lines checked

Patch 17/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190417191805.28198-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.