Hi, This patch series aims to add supprot to migrate a VM with a vhost-scsi device. The 1st patch fixes a bug of mistakenly not stopping vhost-scsi backend when a VM is stopped (As happens on migratino pre-copy completion). The 2nd patch adds ability to save/load vhost-scsi device state in VMState. The 3rd and final paqtch adds a flag to vhost-scsi which allows admin to specify it's setup supports vhost-scsi migratino. For more detailed information on why this is valid, see commit message of specific patch. Regards, -Liran
On Tue, Apr 16, 2019 at 03:59:09PM +0300, Liran Alon wrote: > Hi, > > This patch series aims to add supprot to migrate a VM with a vhost-scsi device. > > The 1st patch fixes a bug of mistakenly not stopping vhost-scsi backend when a > VM is stopped (As happens on migratino pre-copy completion). > > The 2nd patch adds ability to save/load vhost-scsi device state in VMState. > > The 3rd and final paqtch adds a flag to vhost-scsi which allows admin to specify > it's setup supports vhost-scsi migratino. For more detailed information on why > this is valid, see commit message of specific patch. > > Regards, > -Liran Looks fine for vhost_scsi.ko. I have not checked how this interacts with vhost-user-scsi. Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> On 18 Apr 2019, at 12:41, Stefan Hajnoczi <stefanha@gmail.com> wrote: > > On Tue, Apr 16, 2019 at 03:59:09PM +0300, Liran Alon wrote: >> Hi, >> >> This patch series aims to add supprot to migrate a VM with a vhost-scsi device. >> >> The 1st patch fixes a bug of mistakenly not stopping vhost-scsi backend when a >> VM is stopped (As happens on migratino pre-copy completion). >> >> The 2nd patch adds ability to save/load vhost-scsi device state in VMState. >> >> The 3rd and final paqtch adds a flag to vhost-scsi which allows admin to specify >> it's setup supports vhost-scsi migratino. For more detailed information on why >> this is valid, see commit message of specific patch. >> >> Regards, >> -Liran > > Looks fine for vhost_scsi.ko. I have not checked how this interacts > with vhost-user-scsi. > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Gentle Ping. -Liran
On Wed, Apr 24, 2019 at 07:38:57PM +0300, Liran Alon wrote: > > > > On 18 Apr 2019, at 12:41, Stefan Hajnoczi <stefanha@gmail.com> wrote: > > > > On Tue, Apr 16, 2019 at 03:59:09PM +0300, Liran Alon wrote: > >> Hi, > >> > >> This patch series aims to add supprot to migrate a VM with a vhost-scsi device. > >> > >> The 1st patch fixes a bug of mistakenly not stopping vhost-scsi backend when a > >> VM is stopped (As happens on migratino pre-copy completion). > >> > >> The 2nd patch adds ability to save/load vhost-scsi device state in VMState. > >> > >> The 3rd and final paqtch adds a flag to vhost-scsi which allows admin to specify > >> it's setup supports vhost-scsi migratino. For more detailed information on why > >> this is valid, see commit message of specific patch. > >> > >> Regards, > >> -Liran > > > > Looks fine for vhost_scsi.ko. I have not checked how this interacts > > with vhost-user-scsi. > > > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> > > Gentle Ping. This should go either through Michael's virtio/vhost tree or Paolo's SCSI tree. Stefan
On Thu, Apr 25, 2019 at 09:38:19AM +0100, Stefan Hajnoczi wrote: > On Wed, Apr 24, 2019 at 07:38:57PM +0300, Liran Alon wrote: > > > > > > > On 18 Apr 2019, at 12:41, Stefan Hajnoczi <stefanha@gmail.com> wrote: > > > > > > On Tue, Apr 16, 2019 at 03:59:09PM +0300, Liran Alon wrote: > > >> Hi, > > >> > > >> This patch series aims to add supprot to migrate a VM with a vhost-scsi device. > > >> > > >> The 1st patch fixes a bug of mistakenly not stopping vhost-scsi backend when a > > >> VM is stopped (As happens on migratino pre-copy completion). > > >> > > >> The 2nd patch adds ability to save/load vhost-scsi device state in VMState. > > >> > > >> The 3rd and final paqtch adds a flag to vhost-scsi which allows admin to specify > > >> it's setup supports vhost-scsi migratino. For more detailed information on why > > >> this is valid, see commit message of specific patch. > > >> > > >> Regards, > > >> -Liran > > > > > > Looks fine for vhost_scsi.ko. I have not checked how this interacts > > > with vhost-user-scsi. > > > > > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> > > > > Gentle Ping. > > This should go either through Michael's virtio/vhost tree or Paolo's > SCSI tree. > > Stefan OK I'll queue it.
> On 25 Apr 2019, at 20:53, Michael S. Tsirkin <mst@redhat.com> wrote: > > On Thu, Apr 25, 2019 at 09:38:19AM +0100, Stefan Hajnoczi wrote: >> On Wed, Apr 24, 2019 at 07:38:57PM +0300, Liran Alon wrote: >>> >>> >>>> On 18 Apr 2019, at 12:41, Stefan Hajnoczi <stefanha@gmail.com> wrote: >>>> >>>> On Tue, Apr 16, 2019 at 03:59:09PM +0300, Liran Alon wrote: >>>>> Hi, >>>>> >>>>> This patch series aims to add supprot to migrate a VM with a vhost-scsi device. >>>>> >>>>> The 1st patch fixes a bug of mistakenly not stopping vhost-scsi backend when a >>>>> VM is stopped (As happens on migratino pre-copy completion). >>>>> >>>>> The 2nd patch adds ability to save/load vhost-scsi device state in VMState. >>>>> >>>>> The 3rd and final paqtch adds a flag to vhost-scsi which allows admin to specify >>>>> it's setup supports vhost-scsi migratino. For more detailed information on why >>>>> this is valid, see commit message of specific patch. >>>>> >>>>> Regards, >>>>> -Liran >>>> >>>> Looks fine for vhost_scsi.ko. I have not checked how this interacts >>>> with vhost-user-scsi. >>>> >>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> >>> >>> Gentle Ping. >> >> This should go either through Michael's virtio/vhost tree or Paolo's >> SCSI tree. >> >> Stefan > > OK I'll queue it. Thanks. When is this expected to be merged to QEMU’s master? -Liran
Any news on when this patch-series is expected to be merged to upstream QEMU? It was accepted 2 months ago. Thanks, -Liran > On 25 Apr 2019, at 20:53, Michael S. Tsirkin <mst@redhat.com> wrote: > > On Thu, Apr 25, 2019 at 09:38:19AM +0100, Stefan Hajnoczi wrote: >> On Wed, Apr 24, 2019 at 07:38:57PM +0300, Liran Alon wrote: >>> >>> >>>> On 18 Apr 2019, at 12:41, Stefan Hajnoczi <stefanha@gmail.com> wrote: >>>> >>>> On Tue, Apr 16, 2019 at 03:59:09PM +0300, Liran Alon wrote: >>>>> Hi, >>>>> >>>>> This patch series aims to add supprot to migrate a VM with a vhost-scsi device. >>>>> >>>>> The 1st patch fixes a bug of mistakenly not stopping vhost-scsi backend when a >>>>> VM is stopped (As happens on migratino pre-copy completion). >>>>> >>>>> The 2nd patch adds ability to save/load vhost-scsi device state in VMState. >>>>> >>>>> The 3rd and final paqtch adds a flag to vhost-scsi which allows admin to specify >>>>> it's setup supports vhost-scsi migratino. For more detailed information on why >>>>> this is valid, see commit message of specific patch. >>>>> >>>>> Regards, >>>>> -Liran >>>> >>>> Looks fine for vhost_scsi.ko. I have not checked how this interacts >>>> with vhost-user-scsi. >>>> >>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> >>> >>> Gentle Ping. >> >> This should go either through Michael's virtio/vhost tree or Paolo's >> SCSI tree. >> >> Stefan > > OK I'll queue it.
On Mon, Jun 03, 2019 at 02:40:04AM +0300, Liran Alon wrote: > Any news on when this patch-series is expected to be merged to upstream QEMU? > It was accepted 2 months ago. > > Thanks, > -Liran > > > On 25 Apr 2019, at 20:53, Michael S. Tsirkin <mst@redhat.com> wrote: > > > > On Thu, Apr 25, 2019 at 09:38:19AM +0100, Stefan Hajnoczi wrote: > >> On Wed, Apr 24, 2019 at 07:38:57PM +0300, Liran Alon wrote: > >>> > >>> > >>>> On 18 Apr 2019, at 12:41, Stefan Hajnoczi <stefanha@gmail.com> wrote: > >>>> > >>>> On Tue, Apr 16, 2019 at 03:59:09PM +0300, Liran Alon wrote: > >>>>> Hi, > >>>>> > >>>>> This patch series aims to add supprot to migrate a VM with a vhost-scsi device. > >>>>> > >>>>> The 1st patch fixes a bug of mistakenly not stopping vhost-scsi backend when a > >>>>> VM is stopped (As happens on migratino pre-copy completion). > >>>>> > >>>>> The 2nd patch adds ability to save/load vhost-scsi device state in VMState. > >>>>> > >>>>> The 3rd and final paqtch adds a flag to vhost-scsi which allows admin to specify > >>>>> it's setup supports vhost-scsi migratino. For more detailed information on why > >>>>> this is valid, see commit message of specific patch. > >>>>> > >>>>> Regards, > >>>>> -Liran > >>>> > >>>> Looks fine for vhost_scsi.ko. I have not checked how this interacts > >>>> with vhost-user-scsi. > >>>> > >>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> > >>> > >>> Gentle Ping. > >> > >> This should go either through Michael's virtio/vhost tree or Paolo's > >> SCSI tree. > >> > >> Stefan > > > > OK I'll queue it. Sorry dropped it by mistake after queueing and was not cc'd so forgot to reapply. Queued now. -- MST
© 2016 - 2024 Red Hat, Inc.