[v2] hw/arm/virt: Support firmware configuration with -blockdev

[Qemu-devel] [PATCH v2 0/3] hw/arm/virt: Support firmware configuration with -blockdev

Markus Armbruster posted 3 patches 5 years ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190416091348.26075-1-armbru@redhat.com

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Maintainers: Richard Henderson <rth@twiddle.net>, Peter Maydell <peter.maydell@linaro.org>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Kevin Wolf <kwolf@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Max Reitz <mreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>

hw/arm/virt.c            | 198 +++++++++++++++++++++++++--------------
hw/block/pflash_cfi01.c  |  28 ++++++
hw/i386/pc_sysfw.c       |  18 +---
include/hw/arm/virt.h    |   2 +
include/hw/block/flash.h |   1 +
5 files changed, 161 insertions(+), 86 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/3] hw/arm/virt: Support firmware configuration with -blockdev

Posted by Markus Armbruster 5 years ago

László asked for feature parity with the PC machine types.

v2:
* PATCH 1: Split off PATCH 2 [László]
* PATCH 2: Factor out the loop body, not the whole loop
* PATCH 3: Rebase on previous change
           More detailed commit message [László]

Markus Armbruster (3):
  pc: Rearrange pc_system_firmware_init()'s legacy -drive loop
  pflash_cfi01: New pflash_cfi01_legacy_drive()
  hw/arm/virt: Support firmware configuration with -blockdev

 hw/arm/virt.c            | 198 +++++++++++++++++++++++++--------------
 hw/block/pflash_cfi01.c  |  28 ++++++
 hw/i386/pc_sysfw.c       |  18 +---
 include/hw/arm/virt.h    |   2 +
 include/hw/block/flash.h |   1 +
 5 files changed, 161 insertions(+), 86 deletions(-)

-- 
2.17.2

Re: [Qemu-devel] [PATCH v2 0/3] hw/arm/virt: Support firmware configuration with -blockdev

Posted by Peter Maydell 4 years, 12 months ago

On Tue, 16 Apr 2019 at 10:13, Markus Armbruster <armbru@redhat.com> wrote:
>
> László asked for feature parity with the PC machine types.
>
> v2:
> * PATCH 1: Split off PATCH 2 [László]
> * PATCH 2: Factor out the loop body, not the whole loop
> * PATCH 3: Rebase on previous change
>            More detailed commit message [László]
>
> Markus Armbruster (3):
>   pc: Rearrange pc_system_firmware_init()'s legacy -drive loop
>   pflash_cfi01: New pflash_cfi01_legacy_drive()
>   hw/arm/virt: Support firmware configuration with -blockdev

I appreciated the commit message on patch 3, it was very helpful.
Applied to target-arm.next, thanks.

-- PMM