[Qemu-devel] [PULL 0/1] slirp gcc9 build fix

Samuel Thibault posted 1 patch 9 weeks ago
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test checkpatch failed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190415180618.1450-1-samuel.thibault@ens-lyon.org
Maintainers: Samuel Thibault <samuel.thibault@ens-lyon.org>, Jan Kiszka <jan.kiszka@siemens.com>
slirp/src/socket.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL 0/1] slirp gcc9 build fix

Posted by Samuel Thibault 9 weeks ago
The following changes since commit afccfc0c4c6134a7bc9da6375996b3b91d291de4:

  Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-04-12 17:06:49 +0100)

are available in the Git repository at:

  https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault

for you to fetch changes up to 6fabae61a9393fd2bc703837e464b9c34ec5ef25:

  slirp: Gcc 9 -O3 fix (2019-04-15 20:01:18 +0200)

----------------------------------------------------------------
Slirp updates

Dr. David Alan Gilbert (1):
  slirp: Gcc 9 -O3 fix

----------------------------------------------------------------
Dr. David Alan Gilbert (1):
      slirp: Gcc 9 -O3 fix

 slirp/src/socket.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PULL 0/1] slirp gcc9 build fix

Posted by Peter Maydell 8 weeks ago
On Mon, 15 Apr 2019 at 19:06, Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
>
> The following changes since commit afccfc0c4c6134a7bc9da6375996b3b91d291de4:
>
>   Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-04-12 17:06:49 +0100)
>
> are available in the Git repository at:
>
>   https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
>
> for you to fetch changes up to 6fabae61a9393fd2bc703837e464b9c34ec5ef25:
>
>   slirp: Gcc 9 -O3 fix (2019-04-15 20:01:18 +0200)
>
> ----------------------------------------------------------------
> Slirp updates
>
> Dr. David Alan Gilbert (1):
>   slirp: Gcc 9 -O3 fix
>
> ----------------------------------------------------------------
> Dr. David Alan Gilbert (1):
>       slirp: Gcc 9 -O3 fix
>
>  slirp/src/socket.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes.

-- PMM

Re: [Qemu-devel] [PULL 0/1] slirp gcc9 build fix

Posted by no-reply@patchew.org 9 weeks ago
Patchew URL: https://patchew.org/QEMU/20190415180618.1450-1-samuel.thibault@ens-lyon.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190415180618.1450-1-samuel.thibault@ens-lyon.org
Subject: [Qemu-devel] [PULL 0/1] slirp gcc9 build fix
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190411152520.10061-1-armbru@redhat.com -> patchew/20190411152520.10061-1-armbru@redhat.com
 * [new tag]               patchew/20190415180618.1450-1-samuel.thibault@ens-lyon.org -> patchew/20190415180618.1450-1-samuel.thibault@ens-lyon.org
Switched to a new branch 'test'
7e45fd0bf6 slirp: Gcc 9 -O3 fix

=== OUTPUT BEGIN ===
ERROR: code indent should never use tabs
#24: FILE: slirp/src/socket.c:174:
+^Isize_t buf_len;$

ERROR: code indent should never use tabs
#33: FILE: slirp/src/socket.c:185:
+^Ibuf_len = sopreprbuf(so, iov, &n);$

ERROR: code indent should never use tabs
#34: FILE: slirp/src/socket.c:186:
+^Iassert(buf_len != 0);$

ERROR: code indent should never use tabs
#42: FILE: slirp/src/socket.c:262:
+^Iassert(size > 0);$

total: 4 errors, 0 warnings, 23 lines checked

Commit 7e45fd0bf690 (slirp: Gcc 9 -O3 fix) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190415180618.1450-1-samuel.thibault@ens-lyon.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com