qemu-img: Make create hint at protocol options

[Qemu-devel] [PATCH for-next 0/2] qemu-img: Make create hint at protocol options

Max Reitz posted 2 patches 5 years ago

Download series mbox

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190413152037.6817-1-mreitz@redhat.com

Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>

qemu-img.c                 | 13 ++++++++++++-
tests/qemu-iotests/082     |  5 ++++-
tests/qemu-iotests/082.out | 25 ++++++++++++++++++-------
3 files changed, 34 insertions(+), 9 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH for-next 0/2] qemu-img: Make create hint at protocol options

Posted by Max Reitz 5 years ago

https://bugzilla.redhat.com/show_bug.cgi?id=1698863 reports that while
"qemu-img create -f raw" supports the "preallocation" option, it is not
listed under "-o help".

It turns out it is, but only if you specify a target filename.  Users
may not realize this, but a note should help.


Max Reitz (2):
  iotests: Perform the correct test in 082
  qemu-img: Make create hint at protocol options

 qemu-img.c                 | 13 ++++++++++++-
 tests/qemu-iotests/082     |  5 ++++-
 tests/qemu-iotests/082.out | 25 ++++++++++++++++++-------
 3 files changed, 34 insertions(+), 9 deletions(-)

-- 
2.20.1

Re: [Qemu-devel] [Qemu-block] [PATCH for-next 0/2] qemu-img: Make create hint at protocol options

Posted by John Snow 5 years ago


On 4/13/19 11:20 AM, Max Reitz wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1698863 reports that while
> "qemu-img create -f raw" supports the "preallocation" option, it is not
> listed under "-o help".
> 
> It turns out it is, but only if you specify a target filename.  Users
> may not realize this, but a note should help.
> 
> 
> Max Reitz (2):
>   iotests: Perform the correct test in 082
>   qemu-img: Make create hint at protocol options
> 
>  qemu-img.c                 | 13 ++++++++++++-
>  tests/qemu-iotests/082     |  5 ++++-
>  tests/qemu-iotests/082.out | 25 ++++++++++++++++++-------
>  3 files changed, 34 insertions(+), 9 deletions(-)
> 

Seems like an improvement to me.

Reviewed-by: John Snow <jsnow@redhat.com>

Re: [Qemu-devel] [PATCH for-next 0/2] qemu-img: Make create hint at protocol options

Posted by Kevin Wolf 4 years, 12 months ago

Am 13.04.2019 um 17:20 hat Max Reitz geschrieben:
> https://bugzilla.redhat.com/show_bug.cgi?id=1698863 reports that while
> "qemu-img create -f raw" supports the "preallocation" option, it is not
> listed under "-o help".
> 
> It turns out it is, but only if you specify a target filename.  Users
> may not realize this, but a note should help.

Thanks, applied to the block branch.

Kevin