vl: Add missing descriptions to the VGA adapters list

[Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list

Posted by Philippe Mathieu-Daudé 6 years, 10 months ago

Some VGA adapters do not contain an helpful description,
this can be confusing:

  $ qemu-system-arm -M virt -vga help
  none
  std                  standard VGA
  cirrus               Cirrus VGA (default)
  vmware               VMWare SVGA
  xenfb

Add a description to the missing adapters:

  $ qemu-system-arm -M virt -vga help
  none                 no graphic card
  std                  standard VGA
  cirrus               Cirrus VGA (default)
  vmware               VMWare SVGA
  xenfb                Xen paravirtualized framebuffer

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Based-on: <20190412152713.16018-1-marcandre.lureau@redhat.com>
---
 vl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/vl.c b/vl.c
index 840c45c00fa..dfeda8bd7fc 100644
--- a/vl.c
+++ b/vl.c
@@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
 static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
     [VGA_NONE] = {
         .opt_name = "none",
+        .name = "no graphic card",
     },
     [VGA_STD] = {
         .opt_name = "std",
@@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
     },
     [VGA_XENFB] = {
         .opt_name = "xenfb",
+        .name = "Xen paravirtualized framebuffer",
     },
 };
 
-- 
2.20.1

Re: [Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list

Posted by Paul Durrant 6 years, 10 months ago

> -----Original Message-----
> From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com]
> Sent: 12 April 2019 17:37
> To: Marc-André Lureau <marcandre.lureau@redhat.com>; qemu-devel@nongnu.org
> Cc: Markus Armbruster <armbru@redhat.com>; Anthony Perard <anthony.perard@citrix.com>; Paul Durrant
> <Paul.Durrant@citrix.com>; Stefano Stabellini <sstabellini@kernel.org>; Gerd Hoffmann
> <kraxel@redhat.com>; Paolo Bonzini <pbonzini@redhat.com>; Philippe Mathieu-Daudé <philmd@redhat.com>
> Subject: [PATCH] vl: Add missing descriptions to the VGA adapters list
> 
> Some VGA adapters do not contain an helpful description,
> this can be confusing:
> 
>   $ qemu-system-arm -M virt -vga help
>   none
>   std                  standard VGA
>   cirrus               Cirrus VGA (default)
>   vmware               VMWare SVGA
>   xenfb
> 
> Add a description to the missing adapters:
> 
>   $ qemu-system-arm -M virt -vga help
>   none                 no graphic card
>   std                  standard VGA
>   cirrus               Cirrus VGA (default)
>   vmware               VMWare SVGA
>   xenfb                Xen paravirtualized framebuffer
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20190412152713.16018-1-marcandre.lureau@redhat.com>

Reviewed-by: Paul Durrant <paul.durrant@citrix.com>

> ---
>  vl.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/vl.c b/vl.c
> index 840c45c00fa..dfeda8bd7fc 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
>  static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
>      [VGA_NONE] = {
>          .opt_name = "none",
> +        .name = "no graphic card",
>      },
>      [VGA_STD] = {
>          .opt_name = "std",
> @@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
>      },
>      [VGA_XENFB] = {
>          .opt_name = "xenfb",
> +        .name = "Xen paravirtualized framebuffer",
>      },
>  };
> 
> --
> 2.20.1

Re: [Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list

Posted by Paolo Bonzini 6 years, 9 months ago

On 12/04/19 18:37, Philippe Mathieu-Daudé wrote:
> Some VGA adapters do not contain an helpful description,
> this can be confusing:
> 
>   $ qemu-system-arm -M virt -vga help
>   none
>   std                  standard VGA
>   cirrus               Cirrus VGA (default)
>   vmware               VMWare SVGA
>   xenfb
> 
> Add a description to the missing adapters:
> 
>   $ qemu-system-arm -M virt -vga help
>   none                 no graphic card
>   std                  standard VGA
>   cirrus               Cirrus VGA (default)
>   vmware               VMWare SVGA
>   xenfb                Xen paravirtualized framebuffer
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20190412152713.16018-1-marcandre.lureau@redhat.com>
> ---
>  vl.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/vl.c b/vl.c
> index 840c45c00fa..dfeda8bd7fc 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
>  static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
>      [VGA_NONE] = {
>          .opt_name = "none",
> +        .name = "no graphic card",
>      },
>      [VGA_STD] = {
>          .opt_name = "std",
> @@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
>      },
>      [VGA_XENFB] = {
>          .opt_name = "xenfb",
> +        .name = "Xen paravirtualized framebuffer",
>      },
>  };
>  
> 

Queued, thanks.

Paolo

Re: [Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list

Posted by Marc-André Lureau 6 years, 10 months ago

Hi

On Fri, Apr 12, 2019 at 6:37 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Some VGA adapters do not contain an helpful description,
> this can be confusing:
>
>   $ qemu-system-arm -M virt -vga help
>   none
>   std                  standard VGA
>   cirrus               Cirrus VGA (default)
>   vmware               VMWare SVGA
>   xenfb
>
> Add a description to the missing adapters:
>
>   $ qemu-system-arm -M virt -vga help
>   none                 no graphic card
>   std                  standard VGA
>   cirrus               Cirrus VGA (default)
>   vmware               VMWare SVGA
>   xenfb                Xen paravirtualized framebuffer
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20190412152713.16018-1-marcandre.lureau@redhat.com>

nice follow up, thanks
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  vl.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 840c45c00fa..dfeda8bd7fc 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
>  static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
>      [VGA_NONE] = {
>          .opt_name = "none",
> +        .name = "no graphic card",
>      },
>      [VGA_STD] = {
>          .opt_name = "std",
> @@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
>      },
>      [VGA_XENFB] = {
>          .opt_name = "xenfb",
> +        .name = "Xen paravirtualized framebuffer",
>      },
>  };
>
> --
> 2.20.1
>
>


-- 
Marc-André Lureau