[libvirt] [PATCH for-4.1] hw/arm/nseries: Deprecate the n800 and n810 machines

Thomas Huth posted 1 patch 1 week ago
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190412152619.23542-1-thuth@redhat.com
hw/arm/nseries.c     | 3 +++
qemu-deprecated.texi | 6 ++++++
2 files changed, 9 insertions(+)

[libvirt] [PATCH for-4.1] hw/arm/nseries: Deprecate the n800 and n810 machines

Posted by Thomas Huth 1 week ago
These machines depend on the deprecated bluetooth subsystem. In case we
finally decide to remove the bluetooth subsystem, we likely need to
remove the n800 and n810 machines, too, so mark them now as deprecated.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/arm/nseries.c     | 3 +++
 qemu-deprecated.texi | 6 ++++++
 2 files changed, 9 insertions(+)

diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
index 906b7ca22d..66e50b850c 100644
--- a/hw/arm/nseries.c
+++ b/hw/arm/nseries.c
@@ -1309,6 +1309,9 @@ static void n8x0_init(MachineState *machine,
     struct n800_s *s = (struct n800_s *) g_malloc0(sizeof(*s));
     int sdram_size = binfo->ram_size;
 
+    warn_report("The n800 and n810 machines are deprecated. Please use a "
+                "different Arm machine instead.");
+
     s->mpu = omap2420_mpu_init(sysmem, sdram_size, machine->cpu_type);
 
     /* Setup peripherals
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 2219386769..4de7452fac 100644
--- a/qemu-deprecated.texi
+++ b/qemu-deprecated.texi
@@ -145,6 +145,12 @@ This machine type uses an unmaintained firmware, broken in lots of ways,
 and unable to start post-2004 operating systems. 40p machine type should be
 used instead.
 
+@subsection n800 and n810 (Arm) (since 4.1)
+
+These machines depend on the deprecated bluetooth subsystem. When the
+bluetooth subsystem will be removed, the n800 and n810 machines will be
+deleted, too. If possible, use a different Arm board instead.
+
 @section Device options
 
 @subsection Block device options
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Qemu-devel] [PATCH for-4.1] hw/arm/nseries: Deprecate the n800 and n810 machines

Posted by Philippe Mathieu-Daudé 1 week ago
On 4/12/19 5:26 PM, Thomas Huth wrote:
> These machines depend on the deprecated bluetooth subsystem. In case we
> finally decide to remove the bluetooth subsystem, we likely need to
> remove the n800 and n810 machines, too, so mark them now as deprecated.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  hw/arm/nseries.c     | 3 +++
>  qemu-deprecated.texi | 6 ++++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
> index 906b7ca22d..66e50b850c 100644
> --- a/hw/arm/nseries.c
> +++ b/hw/arm/nseries.c
> @@ -1309,6 +1309,9 @@ static void n8x0_init(MachineState *machine,
>      struct n800_s *s = (struct n800_s *) g_malloc0(sizeof(*s));
>      int sdram_size = binfo->ram_size;
>  
> +    warn_report("The n800 and n810 machines are deprecated. Please use a "
> +                "different Arm machine instead.");
> +

Unrelated to this patch, but can you add a similar warning in
uart_hci_init() to make obvious that the bluetooth subsystem is now
deprecated?

>      s->mpu = omap2420_mpu_init(sysmem, sdram_size, machine->cpu_type);
>  
>      /* Setup peripherals
> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> index 2219386769..4de7452fac 100644
> --- a/qemu-deprecated.texi
> +++ b/qemu-deprecated.texi
> @@ -145,6 +145,12 @@ This machine type uses an unmaintained firmware, broken in lots of ways,
>  and unable to start post-2004 operating systems. 40p machine type should be
>  used instead.
>  
> +@subsection n800 and n810 (Arm) (since 4.1)
> +
> +These machines depend on the deprecated bluetooth subsystem. When the
> +bluetooth subsystem will be removed, the n800 and n810 machines will be
> +deleted, too. If possible, use a different Arm board instead.
> +
>  @section Device options
>  
>  @subsection Block device options
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Qemu-devel] [PATCH for-4.1] hw/arm/nseries: Deprecate the n800 and n810 machines

Posted by Thomas Huth 1 week ago
On 12/04/2019 18.21, Philippe Mathieu-Daudé wrote:
> On 4/12/19 5:26 PM, Thomas Huth wrote:
>> These machines depend on the deprecated bluetooth subsystem. In case we
>> finally decide to remove the bluetooth subsystem, we likely need to
>> remove the n800 and n810 machines, too, so mark them now as deprecated.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  hw/arm/nseries.c     | 3 +++
>>  qemu-deprecated.texi | 6 ++++++
>>  2 files changed, 9 insertions(+)
>>
>> diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
>> index 906b7ca22d..66e50b850c 100644
>> --- a/hw/arm/nseries.c
>> +++ b/hw/arm/nseries.c
>> @@ -1309,6 +1309,9 @@ static void n8x0_init(MachineState *machine,
>>      struct n800_s *s = (struct n800_s *) g_malloc0(sizeof(*s));
>>      int sdram_size = binfo->ram_size;
>>  
>> +    warn_report("The n800 and n810 machines are deprecated. Please use a "
>> +                "different Arm machine instead.");
>> +
> 
> Unrelated to this patch, but can you add a similar warning in
> uart_hci_init() to make obvious that the bluetooth subsystem is now
> deprecated?

It's already there, in vl.c, case QEMU_OPTION_bt.

 Thomas

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH for-4.1] hw/arm/nseries: Deprecate the n800 and n810 machines

Posted by Peter Maydell 1 week ago
On Fri, 12 Apr 2019 at 16:26, Thomas Huth <thuth@redhat.com> wrote:
>
> These machines depend on the deprecated bluetooth subsystem. In case we
> finally decide to remove the bluetooth subsystem, we likely need to
> remove the n800 and n810 machines, too, so mark them now as deprecated.

...we could just remove the bluetooth devices from the boards?

thanks
-- PMM

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [Qemu-devel] [PATCH for-4.1] hw/arm/nseries: Deprecate the n800 and n810 machines

Posted by Thomas Huth 1 week ago
On 12/04/2019 18.02, Peter Maydell wrote:
> On Fri, 12 Apr 2019 at 16:26, Thomas Huth <thuth@redhat.com> wrote:
>>
>> These machines depend on the deprecated bluetooth subsystem. In case we
>> finally decide to remove the bluetooth subsystem, we likely need to
>> remove the n800 and n810 machines, too, so mark them now as deprecated.
> 
> ...we could just remove the bluetooth devices from the boards?

Maybe we could. But do we really want to spent time to work on boards
that likely nobody uses anymore? Or do you know anybody using it?
(at least Guenter does not seem to use it, according to his list, see
https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg06125.html )

 Thomas

Re: [Qemu-devel] [PATCH for-4.1] hw/arm/nseries: Deprecate the n800 and n810 machines

Posted by Markus Armbruster 1 week ago
Thomas Huth <thuth@redhat.com> writes:

> On 12/04/2019 18.02, Peter Maydell wrote:
>> On Fri, 12 Apr 2019 at 16:26, Thomas Huth <thuth@redhat.com> wrote:
>>>
>>> These machines depend on the deprecated bluetooth subsystem. In case we
>>> finally decide to remove the bluetooth subsystem, we likely need to
>>> remove the n800 and n810 machines, too, so mark them now as deprecated.
>> 
>> ...we could just remove the bluetooth devices from the boards?
>
> Maybe we could. But do we really want to spent time to work on boards
> that likely nobody uses anymore? Or do you know anybody using it?
> (at least Guenter does not seem to use it, according to his list, see
> https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg06125.html )

I think we're far too willing to drag along code of dubious utility.

Deprecation is not a death sentence.  It's a formal notice to users "we
intend to drop this, and now is the time to argue for keeping it".