[Qemu-devel] [PATCH 0/3] aspeed: cleanups and extenstions

Cédric Le Goater posted 3 patches 5 years ago
Test docker-mingw@fedora passed
Test docker-clang@ubuntu failed
Test checkpatch passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190411161013.4514-1-clg@kaod.org
Maintainers: Joel Stanley <joel@jms.id.au>, Peter Maydell <peter.maydell@linaro.org>, Andrew Jeffery <andrew@aj.id.au>, "Cédric Le Goater" <clg@kaod.org>
include/hw/arm/aspeed_soc.h |   3 +-
hw/arm/aspeed_soc.c         | 266 ++++++++++++++++++++++++------------
2 files changed, 184 insertions(+), 85 deletions(-)
[Qemu-devel] [PATCH 0/3] aspeed: cleanups and extenstions
Posted by Cédric Le Goater 5 years ago
Hello,

Here is a series adding a couple of cleanups to the Aspeed SoCs to
prepare ground for extensions and new SoCs.

Thanks,

C.

Cédric Le Goater (3):
  aspeed: add a per SoC mapping for the interrupt space
  aspeed: add a per SoC mapping for the memory space
  aspeed: use sysbus_init_child_obj() to initialize children

 include/hw/arm/aspeed_soc.h |   3 +-
 hw/arm/aspeed_soc.c         | 266 ++++++++++++++++++++++++------------
 2 files changed, 184 insertions(+), 85 deletions(-)

-- 
2.20.1


Re: [Qemu-devel] [PATCH 0/3] aspeed: cleanups and extenstions
Posted by Peter Maydell 5 years ago
On Thu, 11 Apr 2019 at 17:10, Cédric Le Goater <clg@kaod.org> wrote:
>
> Hello,
>
> Here is a series adding a couple of cleanups to the Aspeed SoCs to
> prepare ground for extensions and new SoCs.
>
> Thanks,
>
> C.
>
> Cédric Le Goater (3):
>   aspeed: add a per SoC mapping for the interrupt space
>   aspeed: add a per SoC mapping for the memory space
>   aspeed: use sysbus_init_child_obj() to initialize children
>



Applied to target-arm.next, thanks.

-- PMM

Re: [Qemu-devel] [PATCH 0/3] aspeed: cleanups and extenstions
Posted by Peter Maydell 5 years ago
On Mon, 29 Apr 2019 at 13:07, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Thu, 11 Apr 2019 at 17:10, Cédric Le Goater <clg@kaod.org> wrote:
> >
> > Hello,
> >
> > Here is a series adding a couple of cleanups to the Aspeed SoCs to
> > prepare ground for extensions and new SoCs.
> >
> > Thanks,
> >
> > C.
> >
> > Cédric Le Goater (3):
> >   aspeed: add a per SoC mapping for the interrupt space
> >   aspeed: add a per SoC mapping for the memory space
> >   aspeed: use sysbus_init_child_obj() to initialize children
> >
>
>
>
> Applied to target-arm.next, thanks.

...spoke too soon. Clang doesn't like this:

/home/petmay01/linaro/qemu-from-laptop/qemu/hw/arm/aspeed_soc.c:155:25:
error: initializer element is not a
      compile-time constant
        .sdram_base   = aspeed_soc_ast2400_memmap[ASPEED_SDRAM],
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
/home/petmay01/linaro/qemu-from-laptop/qemu/rules.mak:69: recipe for
target 'hw/arm/aspeed_soc.o' failed

thanks
-- PMM