This series adds optional feature lists to struct definitions in the
QAPI schema and makes use of them to advertise the new behaviour of
auto-read-only=on in file-posix.

Kevin Wolf (4):
  qapi: Support features for structs
  tests/qapi-schema: Test for good feature lists in structs
  tests/qapi-schema: Error case tests for features in structs
  file-posix: Add dynamic-auto-read-only QAPI feature

 qapi/block-core.json                          | 11 ++++-
 qapi/introspect.json                          |  8 ++-
 tests/qapi-schema/features-bad-type.json      |  3 ++
 tests/qapi-schema/features-missing-name.json  |  3 ++
 tests/qapi-schema/features-name-bad-type.json |  3 ++
 tests/qapi-schema/features-no-list.json       |  3 ++
 tests/qapi-schema/features-unknown-key.json   |  3 ++
 tests/qapi-schema/qapi-schema-test.json       | 27 ++++++++++
 docs/devel/qapi-code-gen.txt                  | 38 ++++++++++++++
 scripts/qapi/common.py                        | 49 +++++++++++++++----
 scripts/qapi/doc.py                           |  3 +-
 scripts/qapi/introspect.py                    |  6 ++-
 scripts/qapi/types.py                         |  3 +-
 scripts/qapi/visit.py                         |  3 +-
 tests/Makefile.include                        |  5 ++
 tests/qapi-schema/double-type.err             |  2 +-
 tests/qapi-schema/features-bad-type.err       |  1 +
 tests/qapi-schema/features-bad-type.exit      |  1 +
 tests/qapi-schema/features-bad-type.out       |  0
 tests/qapi-schema/features-missing-name.err   |  1 +
 tests/qapi-schema/features-missing-name.exit  |  1 +
 tests/qapi-schema/features-missing-name.out   |  0
 tests/qapi-schema/features-name-bad-type.err  |  1 +
 tests/qapi-schema/features-name-bad-type.exit |  1 +
 tests/qapi-schema/features-name-bad-type.out  |  0
 tests/qapi-schema/features-no-list.err        |  1 +
 tests/qapi-schema/features-no-list.exit       |  1 +
 tests/qapi-schema/features-no-list.out        |  0
 tests/qapi-schema/features-unknown-key.err    |  2 +
 tests/qapi-schema/features-unknown-key.exit   |  1 +
 tests/qapi-schema/features-unknown-key.out    |  0
 tests/qapi-schema/qapi-schema-test.out        | 26 ++++++++++
 tests/qapi-schema/test-qapi.py                |  7 ++-
 tests/qapi-schema/unknown-expr-key.err        |  2 +-
 34 files changed, 197 insertions(+), 19 deletions(-)
 create mode 100644 tests/qapi-schema/features-bad-type.json
 create mode 100644 tests/qapi-schema/features-missing-name.json
 create mode 100644 tests/qapi-schema/features-name-bad-type.json
 create mode 100644 tests/qapi-schema/features-no-list.json
 create mode 100644 tests/qapi-schema/features-unknown-key.json
 create mode 100644 tests/qapi-schema/features-bad-type.err
 create mode 100644 tests/qapi-schema/features-bad-type.exit
 create mode 100644 tests/qapi-schema/features-bad-type.out
 create mode 100644 tests/qapi-schema/features-missing-name.err
 create mode 100644 tests/qapi-schema/features-missing-name.exit
 create mode 100644 tests/qapi-schema/features-missing-name.out
 create mode 100644 tests/qapi-schema/features-name-bad-type.err
 create mode 100644 tests/qapi-schema/features-name-bad-type.exit
 create mode 100644 tests/qapi-schema/features-name-bad-type.out
 create mode 100644 tests/qapi-schema/features-no-list.err
 create mode 100644 tests/qapi-schema/features-no-list.exit
 create mode 100644 tests/qapi-schema/features-no-list.out
 create mode 100644 tests/qapi-schema/features-unknown-key.err
 create mode 100644 tests/qapi-schema/features-unknown-key.exit
 create mode 100644 tests/qapi-schema/features-unknown-key.out

-- 
2.20.1

On Mon, Apr 08, 2019 at 16:35:39 +0200, Kevin Wolf wrote:
> This series adds optional feature lists to struct definitions in the
> QAPI schema and makes use of them to advertise the new behaviour of
> auto-read-only=on in file-posix.
> 
> Kevin Wolf (4):
>   qapi: Support features for structs
>   tests/qapi-schema: Test for good feature lists in structs
>   tests/qapi-schema: Error case tests for features in structs
>   file-posix: Add dynamic-auto-read-only QAPI feature

I was able to implement this in libvirt fairly easy. My work-in-progress
(needs some docs and polishing) patches can be found at:

https://github.com/pipo/libvirt/commits/qapi-features-introspect

Am 08.04.2019 um 16:35 hat Kevin Wolf geschrieben:
> This series adds optional feature lists to struct definitions in the
> QAPI schema and makes use of them to advertise the new behaviour of
> auto-read-only=on in file-posix.

Ping?

Kevin Wolf <kwolf@redhat.com> writes:

> This series adds optional feature lists to struct definitions in the
> QAPI schema and makes use of them to advertise the new behaviour of
> auto-read-only=on in file-posix.

General approach looks good to me.  It's just a first step, however.
One that is already useful.