[v2] cleanup select_machine

[Qemu-devel] [PATCH v2 0/4] cleanup select_machine

Wei Yang posted 4 patches 5 years, 1 month ago

Diff against v1
Download series mbox

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190405064121.23662-1-richardw.yang@linux.intel.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>

include/hw/boards.h |  1 -
vl.c                | 69 ++++++++++++++++++---------------------------
2 files changed, 28 insertions(+), 42 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/4] cleanup select_machine

Posted by Wei Yang 5 years, 1 month ago

Here is two simple change related to select_machine()

[1]: make find_default_machine() local since no one outside file use it
[2]: allocate TYPE_MACHINE list only once to select machine type
[3]: cleanup after previous commit
[4]: Simplify machine_parse()

---
v2:
  * adjust changelog in [1]
  * Markus provides [3-4]

Markus Armbruster (2):
  vl: Clean up after previous commit
  vl: Simplify machine_parse()

Wei Yang (2):
  vl.c: make find_default_machine() local
  vl.c: allocate TYPE_MACHINE list once during bootup

 include/hw/boards.h |  1 -
 vl.c                | 69 ++++++++++++++++++---------------------------
 2 files changed, 28 insertions(+), 42 deletions(-)

-- 
2.19.1

Re: [Qemu-devel] [PATCH v2 0/4] cleanup select_machine

Posted by Eduardo Habkost 5 years, 1 month ago

On Fri, Apr 05, 2019 at 02:41:17PM +0800, Wei Yang wrote:
> Here is two simple change related to select_machine()
> 
> [1]: make find_default_machine() local since no one outside file use it
> [2]: allocate TYPE_MACHINE list only once to select machine type
> [3]: cleanup after previous commit
> [4]: Simplify machine_parse()

Thanks!  Queued on machine-next, for 4.1.

> 
> ---
> v2:
>   * adjust changelog in [1]
>   * Markus provides [3-4]
> 
> Markus Armbruster (2):
>   vl: Clean up after previous commit
>   vl: Simplify machine_parse()
> 
> Wei Yang (2):
>   vl.c: make find_default_machine() local
>   vl.c: allocate TYPE_MACHINE list once during bootup
> 
>  include/hw/boards.h |  1 -
>  vl.c                | 69 ++++++++++++++++++---------------------------
>  2 files changed, 28 insertions(+), 42 deletions(-)
> 
> -- 
> 2.19.1
> 
> 

-- 
Eduardo