[Qemu-devel] [PATCH for-4.0? 8/7] nbd/client: Fix error message for server with unusable sizing

Eric Blake posted 7 patches 6 years, 10 months ago
Maintainers: Eric Blake <eblake@redhat.com>, Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>, Stefan Hajnoczi <stefanha@redhat.com>
[Qemu-devel] [PATCH for-4.0? 8/7] nbd/client: Fix error message for server with unusable sizing
Posted by Eric Blake 6 years, 10 months ago
Add a missing space to the error message used when giving up on a
server that insists on an alignment which renders the last few bytes
of the export unreadable.

Fixes: 3add3ab78
Signed-off-by: Eric Blake <eblake@redhat.com>
---

We've already concluded that 5-7 are too risky for 4.0 (so qemu 4.0
NBD servers will have non-compliance issues in alignment corner cases,
although in fewer places than where 3.1 had similar bugs; and the 4.0
client is able to work around those non-compliance cases).  But I'd
still like a review on 1-3 and this patch 8, as trivial improvements
worth having in 4.0. I'm borderline on whether having patch 4 in 4.0
adds any value.

 nbd/client.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nbd/client.c b/nbd/client.c
index 427980bdd22..4de30630c73 100644
--- a/nbd/client.c
+++ b/nbd/client.c
@@ -428,7 +428,7 @@ static int nbd_opt_info_or_go(QIOChannel *ioc, uint32_t opt,
             }
             if (info->min_block &&
                 !QEMU_IS_ALIGNED(info->size, info->min_block)) {
-                error_setg(errp, "export size %" PRIu64 "is not multiple of "
+                error_setg(errp, "export size %" PRIu64 " is not multiple of "
                            "minimum block size %" PRIu32, info->size,
                            info->min_block);
                 nbd_send_opt_abort(ioc);
-- 
2.20.1


Re: [Qemu-devel] [Qemu-block] [PATCH for-4.0? 8/7] nbd/client: Fix error message for server with unusable sizing
Posted by Kevin Wolf 6 years, 10 months ago
Am 04.04.2019 um 16:52 hat Eric Blake geschrieben:
> Add a missing space to the error message used when giving up on a
> server that insists on an alignment which renders the last few bytes
> of the export unreadable.
> 
> Fixes: 3add3ab78
> Signed-off-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>